[INFO] updating cached repository jackwickham/rust-webserver
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/jackwickham/rust-webserver
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/jackwickham/rust-webserver" "work/ex/clippy-test-run/sources/stable/gh/jackwickham/rust-webserver"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/jackwickham/rust-webserver'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/jackwickham/rust-webserver" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jackwickham/rust-webserver"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jackwickham/rust-webserver'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 8ceba4e9cb6da89fcb40fb4ee133c581ea88bd7b
[INFO] sha for GitHub repo jackwickham/rust-webserver: 8ceba4e9cb6da89fcb40fb4ee133c581ea88bd7b
[INFO] validating manifest of jackwickham/rust-webserver on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of jackwickham/rust-webserver on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing jackwickham/rust-webserver
[INFO] finished frobbing jackwickham/rust-webserver
[INFO] frobbed toml for jackwickham/rust-webserver written to work/ex/clippy-test-run/sources/stable/gh/jackwickham/rust-webserver/Cargo.toml
[INFO] started frobbing jackwickham/rust-webserver
[INFO] finished frobbing jackwickham/rust-webserver
[INFO] frobbed toml for jackwickham/rust-webserver written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jackwickham/rust-webserver/Cargo.toml
[INFO] crate jackwickham/rust-webserver has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting jackwickham/rust-webserver against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jackwickham/rust-webserver:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 9b1e1e6701bfaa670191ca662bd140187697c3b89cc398ab7d223b0bd6a09486
[INFO] running `"docker" "start" "-a" "9b1e1e6701bfaa670191ca662bd140187697c3b89cc398ab7d223b0bd6a09486"`
[INFO] [stderr]     Checking webserver v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/http/request/util.rs:20:13
[INFO] [stderr]    |
[INFO] [stderr] 20 |             stream: stream,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^ help: replace it with: `stream`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/http/request/mod.rs:222:66
[INFO] [stderr]     |
[INFO] [stderr] 222 |                             state = ParserState::ValueLeadingWS {name: name};
[INFO] [stderr]     |                                                                  ^^^^^^^^^^ help: replace it with: `name`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/http/request/util.rs:20:13
[INFO] [stderr]    |
[INFO] [stderr] 20 |             stream: stream,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^ help: replace it with: `stream`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/http/request/mod.rs:222:66
[INFO] [stderr]     |
[INFO] [stderr] 222 |                             state = ParserState::ValueLeadingWS {name: name};
[INFO] [stderr]     |                                                                  ^^^^^^^^^^ help: replace it with: `name`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/http/request/mod.rs:330:9
[INFO] [stderr]     |
[INFO] [stderr] 330 |         return Custom(Arc::from(name));
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Custom(Arc::from(name))`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/http/request/mod.rs:330:9
[INFO] [stderr]     |
[INFO] [stderr] 330 |         return Custom(Arc::from(name));
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Custom(Arc::from(name))`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `builder`
[INFO] [stderr]    --> src/http/request/mod.rs:277:28
[INFO] [stderr]     |
[INFO] [stderr] 277 |     fn parse_body<T: Read>(builder: &mut RequestBuilder, it: &mut StreamReader<T>) -> Result<(), ParseError> {
[INFO] [stderr]     |                            ^^^^^^^ help: consider using `_builder` instead
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_variables)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `it`
[INFO] [stderr]    --> src/http/request/mod.rs:277:58
[INFO] [stderr]     |
[INFO] [stderr] 277 |     fn parse_body<T: Read>(builder: &mut RequestBuilder, it: &mut StreamReader<T>) -> Result<(), ParseError> {
[INFO] [stderr]     |                                                          ^^ help: consider using `_it` instead
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `step_back`
[INFO] [stderr]   --> src/http/request/util.rs:55:5
[INFO] [stderr]    |
[INFO] [stderr] 55 |     pub fn step_back(&mut self) -> Option<()> {
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `get_inner`
[INFO] [stderr]   --> src/http/request/util.rs:65:5
[INFO] [stderr]    |
[INFO] [stderr] 65 |     pub fn get_inner(&mut self) -> &mut T {
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `get_body`
[INFO] [stderr]    --> src/http/request/mod.rs:375:5
[INFO] [stderr]     |
[INFO] [stderr] 375 |     pub fn get_body(&mut self) -> &mut Vec<u8> {
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `get_headers`
[INFO] [stderr]    --> src/http/request/mod.rs:384:5
[INFO] [stderr]     |
[INFO] [stderr] 384 |     pub fn get_headers(&self) -> &HashMap<String, String> {
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/http/request/util.rs:137:9
[INFO] [stderr]     |
[INFO] [stderr] 137 | /         match self {
[INFO] [stderr] 138 | |             &ParseError::EOF => None,
[INFO] [stderr] 139 | |             &ParseError::IllegalCharacter => Some(400),
[INFO] [stderr] 140 | |             &ParseError::MissingRequiredHeader (_) => Some(400),
[INFO] [stderr] 141 | |             &ParseError::ServerError(_) => Some(500),
[INFO] [stderr] 142 | |             &ParseError::Generic {http_response: r, ..} => Some(r),
[INFO] [stderr] 143 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 137 |         match *self {
[INFO] [stderr] 138 |             ParseError::EOF => None,
[INFO] [stderr] 139 |             ParseError::IllegalCharacter => Some(400),
[INFO] [stderr] 140 |             ParseError::MissingRequiredHeader (_) => Some(400),
[INFO] [stderr] 141 |             ParseError::ServerError(_) => Some(500),
[INFO] [stderr] 142 |             ParseError::Generic {http_response: r, ..} => Some(r),
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/http/request/util.rs:158:9
[INFO] [stderr]     |
[INFO] [stderr] 158 | /         match self {
[INFO] [stderr] 159 | |             &ParseError::EOF => "End of file reached while parsing headers",
[INFO] [stderr] 160 | |             &ParseError::IllegalCharacter => "Illegal character encountered while parsing headers",
[INFO] [stderr] 161 | |             &ParseError::MissingRequiredHeader (_h) => "Missing required header",
[INFO] [stderr] 162 | |             &ParseError::ServerError(ref e) => e.description(),
[INFO] [stderr] 163 | |             &ParseError::Generic {ref err, ..} => err.description(),
[INFO] [stderr] 164 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 158 |         match *self {
[INFO] [stderr] 159 |             ParseError::EOF => "End of file reached while parsing headers",
[INFO] [stderr] 160 |             ParseError::IllegalCharacter => "Illegal character encountered while parsing headers",
[INFO] [stderr] 161 |             ParseError::MissingRequiredHeader (_h) => "Missing required header",
[INFO] [stderr] 162 |             ParseError::ServerError(ref e) => e.description(),
[INFO] [stderr] 163 |             ParseError::Generic {ref err, ..} => err.description(),
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead
[INFO] [stderr]   --> src/main.rs:38:5
[INFO] [stderr]    |
[INFO] [stderr] 38 |     stream.write(response.as_bytes()).unwrap();
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[deny(clippy::unused_io_amount)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount
[INFO] [stderr] 
[INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead
[INFO] [stderr]   --> src/main.rs:49:5
[INFO] [stderr]    |
[INFO] [stderr] 49 |     stream.write(response.as_bytes()).unwrap();
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to 2 previous errors
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `webserver`.
[INFO] [stderr] warning: build failed, waiting for other jobs to finish...
[INFO] [stderr] warning: unused variable: `builder`
[INFO] [stderr]    --> src/http/request/mod.rs:277:28
[INFO] [stderr]     |
[INFO] [stderr] 277 |     fn parse_body<T: Read>(builder: &mut RequestBuilder, it: &mut StreamReader<T>) -> Result<(), ParseError> {
[INFO] [stderr]     |                            ^^^^^^^ help: consider using `_builder` instead
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_variables)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `it`
[INFO] [stderr]    --> src/http/request/mod.rs:277:58
[INFO] [stderr]     |
[INFO] [stderr] 277 |     fn parse_body<T: Read>(builder: &mut RequestBuilder, it: &mut StreamReader<T>) -> Result<(), ParseError> {
[INFO] [stderr]     |                                                          ^^ help: consider using `_it` instead
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `step_back`
[INFO] [stderr]   --> src/http/request/util.rs:55:5
[INFO] [stderr]    |
[INFO] [stderr] 55 |     pub fn step_back(&mut self) -> Option<()> {
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `get_inner`
[INFO] [stderr]   --> src/http/request/util.rs:65:5
[INFO] [stderr]    |
[INFO] [stderr] 65 |     pub fn get_inner(&mut self) -> &mut T {
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `get_body`
[INFO] [stderr]    --> src/http/request/mod.rs:375:5
[INFO] [stderr]     |
[INFO] [stderr] 375 |     pub fn get_body(&mut self) -> &mut Vec<u8> {
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `get_headers`
[INFO] [stderr]    --> src/http/request/mod.rs:384:5
[INFO] [stderr]     |
[INFO] [stderr] 384 |     pub fn get_headers(&self) -> &HashMap<String, String> {
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/http/request/util.rs:137:9
[INFO] [stderr]     |
[INFO] [stderr] 137 | /         match self {
[INFO] [stderr] 138 | |             &ParseError::EOF => None,
[INFO] [stderr] 139 | |             &ParseError::IllegalCharacter => Some(400),
[INFO] [stderr] 140 | |             &ParseError::MissingRequiredHeader (_) => Some(400),
[INFO] [stderr] 141 | |             &ParseError::ServerError(_) => Some(500),
[INFO] [stderr] 142 | |             &ParseError::Generic {http_response: r, ..} => Some(r),
[INFO] [stderr] 143 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 137 |         match *self {
[INFO] [stderr] 138 |             ParseError::EOF => None,
[INFO] [stderr] 139 |             ParseError::IllegalCharacter => Some(400),
[INFO] [stderr] 140 |             ParseError::MissingRequiredHeader (_) => Some(400),
[INFO] [stderr] 141 |             ParseError::ServerError(_) => Some(500),
[INFO] [stderr] 142 |             ParseError::Generic {http_response: r, ..} => Some(r),
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/http/request/util.rs:158:9
[INFO] [stderr]     |
[INFO] [stderr] 158 | /         match self {
[INFO] [stderr] 159 | |             &ParseError::EOF => "End of file reached while parsing headers",
[INFO] [stderr] 160 | |             &ParseError::IllegalCharacter => "Illegal character encountered while parsing headers",
[INFO] [stderr] 161 | |             &ParseError::MissingRequiredHeader (_h) => "Missing required header",
[INFO] [stderr] 162 | |             &ParseError::ServerError(ref e) => e.description(),
[INFO] [stderr] 163 | |             &ParseError::Generic {ref err, ..} => err.description(),
[INFO] [stderr] 164 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 158 |         match *self {
[INFO] [stderr] 159 |             ParseError::EOF => "End of file reached while parsing headers",
[INFO] [stderr] 160 |             ParseError::IllegalCharacter => "Illegal character encountered while parsing headers",
[INFO] [stderr] 161 |             ParseError::MissingRequiredHeader (_h) => "Missing required header",
[INFO] [stderr] 162 |             ParseError::ServerError(ref e) => e.description(),
[INFO] [stderr] 163 |             ParseError::Generic {ref err, ..} => err.description(),
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead
[INFO] [stderr]   --> src/main.rs:38:5
[INFO] [stderr]    |
[INFO] [stderr] 38 |     stream.write(response.as_bytes()).unwrap();
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[deny(clippy::unused_io_amount)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount
[INFO] [stderr] 
[INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead
[INFO] [stderr]   --> src/main.rs:49:5
[INFO] [stderr]    |
[INFO] [stderr] 49 |     stream.write(response.as_bytes()).unwrap();
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to 2 previous errors
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `webserver`.
[INFO] [stderr] 
[INFO] [stderr] To learn more, run the command again with --verbose.
[INFO] running `"docker" "inspect" "9b1e1e6701bfaa670191ca662bd140187697c3b89cc398ab7d223b0bd6a09486"`
[INFO] running `"docker" "rm" "-f" "9b1e1e6701bfaa670191ca662bd140187697c3b89cc398ab7d223b0bd6a09486"`
[INFO] [stdout] 9b1e1e6701bfaa670191ca662bd140187697c3b89cc398ab7d223b0bd6a09486