[INFO] updating cached repository iveltondequeiroz/port-sniffer-rust [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/iveltondequeiroz/port-sniffer-rust [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/iveltondequeiroz/port-sniffer-rust" "work/ex/clippy-test-run/sources/stable/gh/iveltondequeiroz/port-sniffer-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/iveltondequeiroz/port-sniffer-rust'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/iveltondequeiroz/port-sniffer-rust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/iveltondequeiroz/port-sniffer-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/iveltondequeiroz/port-sniffer-rust'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] fb8c0ebbd04512774660291694cf19e54d01ad5f [INFO] sha for GitHub repo iveltondequeiroz/port-sniffer-rust: fb8c0ebbd04512774660291694cf19e54d01ad5f [INFO] validating manifest of iveltondequeiroz/port-sniffer-rust on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of iveltondequeiroz/port-sniffer-rust on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing iveltondequeiroz/port-sniffer-rust [INFO] finished frobbing iveltondequeiroz/port-sniffer-rust [INFO] frobbed toml for iveltondequeiroz/port-sniffer-rust written to work/ex/clippy-test-run/sources/stable/gh/iveltondequeiroz/port-sniffer-rust/Cargo.toml [INFO] started frobbing iveltondequeiroz/port-sniffer-rust [INFO] finished frobbing iveltondequeiroz/port-sniffer-rust [INFO] frobbed toml for iveltondequeiroz/port-sniffer-rust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/iveltondequeiroz/port-sniffer-rust/Cargo.toml [INFO] crate iveltondequeiroz/port-sniffer-rust has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting iveltondequeiroz/port-sniffer-rust against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/iveltondequeiroz/port-sniffer-rust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] c4952eb330e23a33561c904551aab62b63a3d22573a9f4437776510f0d172b57 [INFO] running `"docker" "start" "-a" "c4952eb330e23a33561c904551aab62b63a3d22573a9f4437776510f0d172b57"` [INFO] [stderr] Checking ip_sniffer v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:107:5 [INFO] [stderr] | [INFO] [stderr] 107 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:107:5 [INFO] [stderr] | [INFO] [stderr] 107 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: field is never used: `flag` [INFO] [stderr] --> src/main.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | flag: String, [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: field is never used: `flag` [INFO] [stderr] --> src/main.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | flag: String, [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:34:37 [INFO] [stderr] | [INFO] [stderr] 34 | } else if flag.contains("h") || flag.contains("-help") { [INFO] [stderr] | ^^^ help: try using a char instead: `'h'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:58:9 [INFO] [stderr] | [INFO] [stderr] 58 | / match TcpStream::connect((addr, port)) { [INFO] [stderr] 59 | | Ok(_) => { [INFO] [stderr] 60 | | print!("."); [INFO] [stderr] 61 | | io::stdout().flush().unwrap(); [INFO] [stderr] ... | [INFO] [stderr] 64 | | Err(_) => {} [INFO] [stderr] 65 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 58 | if let Ok(_) = TcpStream::connect((addr, port)) { [INFO] [stderr] 59 | print!("."); [INFO] [stderr] 60 | io::stdout().flush().unwrap(); [INFO] [stderr] 61 | tx.send(port).unwrap(); [INFO] [stderr] 62 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:34:37 [INFO] [stderr] | [INFO] [stderr] 34 | } else if flag.contains("h") || flag.contains("-help") { [INFO] [stderr] | ^^^ help: try using a char instead: `'h'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:58:9 [INFO] [stderr] | [INFO] [stderr] 58 | / match TcpStream::connect((addr, port)) { [INFO] [stderr] 59 | | Ok(_) => { [INFO] [stderr] 60 | | print!("."); [INFO] [stderr] 61 | | io::stdout().flush().unwrap(); [INFO] [stderr] ... | [INFO] [stderr] 64 | | Err(_) => {} [INFO] [stderr] 65 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 58 | if let Ok(_) = TcpStream::connect((addr, port)) { [INFO] [stderr] 59 | print!("."); [INFO] [stderr] 60 | io::stdout().flush().unwrap(); [INFO] [stderr] 61 | tx.send(port).unwrap(); [INFO] [stderr] 62 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.89s [INFO] running `"docker" "inspect" "c4952eb330e23a33561c904551aab62b63a3d22573a9f4437776510f0d172b57"` [INFO] running `"docker" "rm" "-f" "c4952eb330e23a33561c904551aab62b63a3d22573a9f4437776510f0d172b57"` [INFO] [stdout] c4952eb330e23a33561c904551aab62b63a3d22573a9f4437776510f0d172b57