[INFO] updating cached repository it6/tic-tac-toe [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/it6/tic-tac-toe [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/it6/tic-tac-toe" "work/ex/clippy-test-run/sources/stable/gh/it6/tic-tac-toe"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/it6/tic-tac-toe'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/it6/tic-tac-toe" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/it6/tic-tac-toe"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/it6/tic-tac-toe'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] e834d85c47d420ad9e3059cea2356edc04898c1a [INFO] sha for GitHub repo it6/tic-tac-toe: e834d85c47d420ad9e3059cea2356edc04898c1a [INFO] validating manifest of it6/tic-tac-toe on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of it6/tic-tac-toe on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing it6/tic-tac-toe [INFO] finished frobbing it6/tic-tac-toe [INFO] frobbed toml for it6/tic-tac-toe written to work/ex/clippy-test-run/sources/stable/gh/it6/tic-tac-toe/Cargo.toml [INFO] started frobbing it6/tic-tac-toe [INFO] finished frobbing it6/tic-tac-toe [INFO] frobbed toml for it6/tic-tac-toe written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/it6/tic-tac-toe/Cargo.toml [INFO] crate it6/tic-tac-toe has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting it6/tic-tac-toe against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/it6/tic-tac-toe:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 1d1b16e47e52ad7e0830c766fb1a9efaa497d418a8605481f9514d452f4aad9f [INFO] running `"docker" "start" "-a" "1d1b16e47e52ad7e0830c766fb1a9efaa497d418a8605481f9514d452f4aad9f"` [INFO] [stderr] Checking tic-tac-toe v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:62:5 [INFO] [stderr] | [INFO] [stderr] 62 | return ans; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `ans` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/main.rs:13:9 [INFO] [stderr] | [INFO] [stderr] 13 | / io::stdin() [INFO] [stderr] 14 | | .read_line(&mut num) [INFO] [stderr] 15 | | .ok() [INFO] [stderr] 16 | | .expect("Couldn't read line"); [INFO] [stderr] | |_________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ok_expect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:62:5 [INFO] [stderr] | [INFO] [stderr] 62 | return ans; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `ans` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/main.rs:13:9 [INFO] [stderr] | [INFO] [stderr] 13 | / io::stdin() [INFO] [stderr] 14 | | .read_line(&mut num) [INFO] [stderr] 15 | | .ok() [INFO] [stderr] 16 | | .expect("Couldn't read line"); [INFO] [stderr] | |_________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ok_expect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.74s [INFO] running `"docker" "inspect" "1d1b16e47e52ad7e0830c766fb1a9efaa497d418a8605481f9514d452f4aad9f"` [INFO] running `"docker" "rm" "-f" "1d1b16e47e52ad7e0830c766fb1a9efaa497d418a8605481f9514d452f4aad9f"` [INFO] [stdout] 1d1b16e47e52ad7e0830c766fb1a9efaa497d418a8605481f9514d452f4aad9f