[INFO] updating cached repository iosmanthus/minigrep [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/iosmanthus/minigrep [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/iosmanthus/minigrep" "work/ex/clippy-test-run/sources/stable/gh/iosmanthus/minigrep"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/iosmanthus/minigrep'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/iosmanthus/minigrep" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/iosmanthus/minigrep"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/iosmanthus/minigrep'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 0fc7ee1dc05f6dc51038d5969903f0b26b418cef [INFO] sha for GitHub repo iosmanthus/minigrep: 0fc7ee1dc05f6dc51038d5969903f0b26b418cef [INFO] validating manifest of iosmanthus/minigrep on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of iosmanthus/minigrep on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing iosmanthus/minigrep [INFO] finished frobbing iosmanthus/minigrep [INFO] frobbed toml for iosmanthus/minigrep written to work/ex/clippy-test-run/sources/stable/gh/iosmanthus/minigrep/Cargo.toml [INFO] started frobbing iosmanthus/minigrep [INFO] finished frobbing iosmanthus/minigrep [INFO] frobbed toml for iosmanthus/minigrep written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/iosmanthus/minigrep/Cargo.toml [INFO] crate iosmanthus/minigrep has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting iosmanthus/minigrep against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/iosmanthus/minigrep:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 013ffcc6aa23fff2aab36dcb9b3825d71eebea09b9e9b8722f3099317bc7ba55 [INFO] running `"docker" "start" "-a" "013ffcc6aa23fff2aab36dcb9b3825d71eebea09b9e9b8722f3099317bc7ba55"` [INFO] [stderr] Checking minigrep v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/lib.rs:17:17 [INFO] [stderr] | [INFO] [stderr] 17 | / if val.parse::().unwrap() == 0 { [INFO] [stderr] 18 | | false [INFO] [stderr] 19 | | } else { [INFO] [stderr] 20 | | true [INFO] [stderr] 21 | | } [INFO] [stderr] | |_________________^ help: you can reduce it to: `!(val.parse::().unwrap() == 0)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/lib.rs:17:17 [INFO] [stderr] | [INFO] [stderr] 17 | / if val.parse::().unwrap() == 0 { [INFO] [stderr] 18 | | false [INFO] [stderr] 19 | | } else { [INFO] [stderr] 20 | | true [INFO] [stderr] 21 | | } [INFO] [stderr] | |_________________^ help: you can reduce it to: `!(val.parse::().unwrap() == 0)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.31s [INFO] running `"docker" "inspect" "013ffcc6aa23fff2aab36dcb9b3825d71eebea09b9e9b8722f3099317bc7ba55"` [INFO] running `"docker" "rm" "-f" "013ffcc6aa23fff2aab36dcb9b3825d71eebea09b9e9b8722f3099317bc7ba55"` [INFO] [stdout] 013ffcc6aa23fff2aab36dcb9b3825d71eebea09b9e9b8722f3099317bc7ba55