[INFO] updating cached repository ioncodes/snesutilities [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/ioncodes/snesutilities [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/ioncodes/snesutilities" "work/ex/clippy-test-run/sources/stable/gh/ioncodes/snesutilities"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/ioncodes/snesutilities'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/ioncodes/snesutilities" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ioncodes/snesutilities"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ioncodes/snesutilities'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 749d358f7d614e4ffb38d2625588aafe70ef12c0 [INFO] sha for GitHub repo ioncodes/snesutilities: 749d358f7d614e4ffb38d2625588aafe70ef12c0 [INFO] validating manifest of ioncodes/snesutilities on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ioncodes/snesutilities on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ioncodes/snesutilities [INFO] finished frobbing ioncodes/snesutilities [INFO] frobbed toml for ioncodes/snesutilities written to work/ex/clippy-test-run/sources/stable/gh/ioncodes/snesutilities/Cargo.toml [INFO] started frobbing ioncodes/snesutilities [INFO] finished frobbing ioncodes/snesutilities [INFO] frobbed toml for ioncodes/snesutilities written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ioncodes/snesutilities/Cargo.toml [INFO] crate ioncodes/snesutilities has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ioncodes/snesutilities against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ioncodes/snesutilities:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 1a48445581462afdb9f6475ac6f709a4f1a29ed83a6b601b0d66d3c6f14b8533 [INFO] running `"docker" "start" "-a" "1a48445581462afdb9f6475ac6f709a4f1a29ed83a6b601b0d66d3c6f14b8533"` [INFO] [stderr] Checking snesutils v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/snesutilities.rs:61:13 [INFO] [stderr] | [INFO] [stderr] 61 | internal_name: internal_name, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `internal_name` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/snesutilities.rs:62:13 [INFO] [stderr] | [INFO] [stderr] 62 | rom_makeup_type: rom_makeup_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `rom_makeup_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/snesutilities.rs:63:13 [INFO] [stderr] | [INFO] [stderr] 63 | rom_type: rom_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `rom_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/snesutilities.rs:64:13 [INFO] [stderr] | [INFO] [stderr] 64 | rom_size: rom_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `rom_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/snesutilities.rs:65:13 [INFO] [stderr] | [INFO] [stderr] 65 | sram_size: sram_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `sram_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/snesutilities.rs:66:13 [INFO] [stderr] | [INFO] [stderr] 66 | video_mode: video_mode, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `video_mode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/snesutilities.rs:67:13 [INFO] [stderr] | [INFO] [stderr] 67 | license: license, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `license` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/snesutilities.rs:61:13 [INFO] [stderr] | [INFO] [stderr] 61 | internal_name: internal_name, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `internal_name` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/snesutilities.rs:62:13 [INFO] [stderr] | [INFO] [stderr] 62 | rom_makeup_type: rom_makeup_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `rom_makeup_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/snesutilities.rs:63:13 [INFO] [stderr] | [INFO] [stderr] 63 | rom_type: rom_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `rom_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/snesutilities.rs:64:13 [INFO] [stderr] | [INFO] [stderr] 64 | rom_size: rom_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `rom_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/snesutilities.rs:65:13 [INFO] [stderr] | [INFO] [stderr] 65 | sram_size: sram_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `sram_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/snesutilities.rs:66:13 [INFO] [stderr] | [INFO] [stderr] 66 | video_mode: video_mode, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `video_mode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/snesutilities.rs:67:13 [INFO] [stderr] | [INFO] [stderr] 67 | license: license, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `license` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/snesutilities.rs:89:5 [INFO] [stderr] | [INFO] [stderr] 89 | return str::from_utf8(&vec).unwrap().to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `str::from_utf8(&vec).unwrap().to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/snesutilities.rs:123:5 [INFO] [stderr] | [INFO] [stderr] 123 | / return match buffer { [INFO] [stderr] 124 | | buffer if buffer[0] == 0 as u8 => { [INFO] [stderr] 125 | | VideoMode { [INFO] [stderr] 126 | | country: "Japan".to_string(), [INFO] [stderr] ... | [INFO] [stderr] 213 | | } [INFO] [stderr] 214 | | }; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 123 | match buffer { [INFO] [stderr] 124 | buffer if buffer[0] == 0 as u8 => { [INFO] [stderr] 125 | VideoMode { [INFO] [stderr] 126 | country: "Japan".to_string(), [INFO] [stderr] 127 | mode: "NTSC".to_string(), [INFO] [stderr] 128 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/snesutilities.rs:217:18 [INFO] [stderr] | [INFO] [stderr] 217 | const LICENSES: &'static [&'static str] = &["Invalid", [INFO] [stderr] | -^^^^^^^--------------- help: consider removing `'static`: `&[&'static str]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/snesutilities.rs:217:28 [INFO] [stderr] | [INFO] [stderr] 217 | const LICENSES: &'static [&'static str] = &["Invalid", [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/snesutilities.rs:89:5 [INFO] [stderr] | [INFO] [stderr] 89 | return str::from_utf8(&vec).unwrap().to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `str::from_utf8(&vec).unwrap().to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/snesutilities.rs:123:5 [INFO] [stderr] | [INFO] [stderr] 123 | / return match buffer { [INFO] [stderr] 124 | | buffer if buffer[0] == 0 as u8 => { [INFO] [stderr] 125 | | VideoMode { [INFO] [stderr] 126 | | country: "Japan".to_string(), [INFO] [stderr] ... | [INFO] [stderr] 213 | | } [INFO] [stderr] 214 | | }; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 123 | match buffer { [INFO] [stderr] 124 | buffer if buffer[0] == 0 as u8 => { [INFO] [stderr] 125 | VideoMode { [INFO] [stderr] 126 | country: "Japan".to_string(), [INFO] [stderr] 127 | mode: "NTSC".to_string(), [INFO] [stderr] 128 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/snesutilities.rs:217:18 [INFO] [stderr] | [INFO] [stderr] 217 | const LICENSES: &'static [&'static str] = &["Invalid", [INFO] [stderr] | -^^^^^^^--------------- help: consider removing `'static`: `&[&'static str]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/snesutilities.rs:217:28 [INFO] [stderr] | [INFO] [stderr] 217 | const LICENSES: &'static [&'static str] = &["Invalid", [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead [INFO] [stderr] --> src/snesutilities.rs:76:5 [INFO] [stderr] | [INFO] [stderr] 76 | file.read(vec.as_mut_slice()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead [INFO] [stderr] --> src/snesutilities.rs:87:9 [INFO] [stderr] | [INFO] [stderr] 87 | file.read(vec.as_mut_slice()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 28 [INFO] [stderr] --> src/snesutilities.rs:122:1 [INFO] [stderr] | [INFO] [stderr] 122 | / fn get_location(buffer: [u8; 1]) -> VideoMode { [INFO] [stderr] 123 | | return match buffer { [INFO] [stderr] 124 | | buffer if buffer[0] == 0 as u8 => { [INFO] [stderr] 125 | | VideoMode { [INFO] [stderr] ... | [INFO] [stderr] 214 | | }; [INFO] [stderr] 215 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `snesutils`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead [INFO] [stderr] --> src/snesutilities.rs:76:5 [INFO] [stderr] | [INFO] [stderr] 76 | file.read(vec.as_mut_slice()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead [INFO] [stderr] --> src/snesutilities.rs:87:9 [INFO] [stderr] | [INFO] [stderr] 87 | file.read(vec.as_mut_slice()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 28 [INFO] [stderr] --> src/snesutilities.rs:122:1 [INFO] [stderr] | [INFO] [stderr] 122 | / fn get_location(buffer: [u8; 1]) -> VideoMode { [INFO] [stderr] 123 | | return match buffer { [INFO] [stderr] 124 | | buffer if buffer[0] == 0 as u8 => { [INFO] [stderr] 125 | | VideoMode { [INFO] [stderr] ... | [INFO] [stderr] 214 | | }; [INFO] [stderr] 215 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `snesutils`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "1a48445581462afdb9f6475ac6f709a4f1a29ed83a6b601b0d66d3c6f14b8533"` [INFO] running `"docker" "rm" "-f" "1a48445581462afdb9f6475ac6f709a4f1a29ed83a6b601b0d66d3c6f14b8533"` [INFO] [stdout] 1a48445581462afdb9f6475ac6f709a4f1a29ed83a6b601b0d66d3c6f14b8533