[INFO] updating cached repository ioncodes/rec8 [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/ioncodes/rec8 [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/ioncodes/rec8" "work/ex/clippy-test-run/sources/stable/gh/ioncodes/rec8"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/ioncodes/rec8'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/ioncodes/rec8" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ioncodes/rec8"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ioncodes/rec8'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 10eb6bcd97a639c396fdc141262657ce536409b2 [INFO] sha for GitHub repo ioncodes/rec8: 10eb6bcd97a639c396fdc141262657ce536409b2 [INFO] validating manifest of ioncodes/rec8 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ioncodes/rec8 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ioncodes/rec8 [INFO] finished frobbing ioncodes/rec8 [INFO] frobbed toml for ioncodes/rec8 written to work/ex/clippy-test-run/sources/stable/gh/ioncodes/rec8/Cargo.toml [INFO] started frobbing ioncodes/rec8 [INFO] finished frobbing ioncodes/rec8 [INFO] frobbed toml for ioncodes/rec8 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ioncodes/rec8/Cargo.toml [INFO] crate ioncodes/rec8 has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ioncodes/rec8 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ioncodes/rec8:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 97360e66bdd3c5d24cde2ec956831a886dd71fe62a94569f3aa997997153c72c [INFO] running `"docker" "start" "-a" "97360e66bdd3c5d24cde2ec956831a886dd71fe62a94569f3aa997997153c72c"` [INFO] [stderr] Checking rec8 v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/core/translator.rs:243:17 [INFO] [stderr] | [INFO] [stderr] 243 | let mut k: usize = 0; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/core/translator.rs:243:17 [INFO] [stderr] | [INFO] [stderr] 243 | let mut k: usize = 0; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/core/translator.rs:65:11 [INFO] [stderr] | [INFO] [stderr] 65 | ((bytes >> 8 * position) & 0xFF) as u8 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `bytes >> (8 * position)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::precedence)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/core/translator.rs:65:11 [INFO] [stderr] | [INFO] [stderr] 65 | ((bytes >> 8 * position) & 0xFF) as u8 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `bytes >> (8 * position)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::precedence)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/core/translator.rs:61:11 [INFO] [stderr] | [INFO] [stderr] 61 | (((n1 as u16) << 8) | ((n2 << 4) | n3) as u16) as u16 [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(n1)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/core/translator.rs:61:31 [INFO] [stderr] | [INFO] [stderr] 61 | (((n1 as u16) << 8) | ((n2 << 4) | n3) as u16) as u16 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from((n2 << 4) | n3)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/core/translator.rs:61:11 [INFO] [stderr] | [INFO] [stderr] 61 | (((n1 as u16) << 8) | ((n2 << 4) | n3) as u16) as u16 [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(n1)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/core/translator.rs:61:31 [INFO] [stderr] | [INFO] [stderr] 61 | (((n1 as u16) << 8) | ((n2 << 4) | n3) as u16) as u16 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from((n2 << 4) | n3)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.78s [INFO] running `"docker" "inspect" "97360e66bdd3c5d24cde2ec956831a886dd71fe62a94569f3aa997997153c72c"` [INFO] running `"docker" "rm" "-f" "97360e66bdd3c5d24cde2ec956831a886dd71fe62a94569f3aa997997153c72c"` [INFO] [stdout] 97360e66bdd3c5d24cde2ec956831a886dd71fe62a94569f3aa997997153c72c