[INFO] updating cached repository ioncodes/bytereader
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/ioncodes/bytereader
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/ioncodes/bytereader" "work/ex/clippy-test-run/sources/stable/gh/ioncodes/bytereader"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/ioncodes/bytereader'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/ioncodes/bytereader" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ioncodes/bytereader"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ioncodes/bytereader'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] fcff20a2c2b9db0a5fcd165f4df1876fc9989ea7
[INFO] sha for GitHub repo ioncodes/bytereader: fcff20a2c2b9db0a5fcd165f4df1876fc9989ea7
[INFO] validating manifest of ioncodes/bytereader on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of ioncodes/bytereader on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing ioncodes/bytereader
[INFO] finished frobbing ioncodes/bytereader
[INFO] frobbed toml for ioncodes/bytereader written to work/ex/clippy-test-run/sources/stable/gh/ioncodes/bytereader/Cargo.toml
[INFO] started frobbing ioncodes/bytereader
[INFO] finished frobbing ioncodes/bytereader
[INFO] frobbed toml for ioncodes/bytereader written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ioncodes/bytereader/Cargo.toml
[INFO] crate ioncodes/bytereader has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting ioncodes/bytereader against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ioncodes/bytereader:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 6a5620ef4979c1b04881c299568bed42ec1233732fde01f64c91e6b43140983f
[INFO] running `"docker" "start" "-a" "6a5620ef4979c1b04881c299568bed42ec1233732fde01f64c91e6b43140983f"`
[INFO] [stderr]     Checking bytereader v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/hex.rs:20:9
[INFO] [stderr]    |
[INFO] [stderr] 20 |         return s;
[INFO] [stderr]    |         ^^^^^^^^^ help: remove `return` as shown: `s`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/hex.rs:20:9
[INFO] [stderr]    |
[INFO] [stderr] 20 |         return s;
[INFO] [stderr]    |         ^^^^^^^^^ help: remove `return` as shown: `s`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]   --> src/byte.rs:29:9
[INFO] [stderr]    |
[INFO] [stderr] 29 | /         let pos;
[INFO] [stderr] 30 | |         if position > self.position {
[INFO] [stderr] 31 | |             pos = -1 * (position - self.position + buf.len() as u64 - 1) as i64;
[INFO] [stderr] 32 | |         } else {
[INFO] [stderr] 33 | |             pos = (self.position - position - buf.len() as u64 + 1) as i64;
[INFO] [stderr] 34 | |         }
[INFO] [stderr]    | |_________^ help: it is more idiomatic to write: `let pos = if position > self.position { -1 * (position - self.position + buf.len() as u64 - 1) as i64 } else { (self.position - position - buf.len() as u64 + 1) as i64 };`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::useless_let_if_seq)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: Negation by multiplying with -1
[INFO] [stderr]   --> src/byte.rs:31:19
[INFO] [stderr]    |
[INFO] [stderr] 31 |             pos = -1 * (position - self.position + buf.len() as u64 - 1) as i64;
[INFO] [stderr]    |                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::neg_multiply)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_multiply
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]   --> src/byte.rs:29:9
[INFO] [stderr]    |
[INFO] [stderr] 29 | /         let pos;
[INFO] [stderr] 30 | |         if position > self.position {
[INFO] [stderr] 31 | |             pos = -1 * (position - self.position + buf.len() as u64 - 1) as i64;
[INFO] [stderr] 32 | |         } else {
[INFO] [stderr] 33 | |             pos = (self.position - position - buf.len() as u64 + 1) as i64;
[INFO] [stderr] 34 | |         }
[INFO] [stderr]    | |_________^ help: it is more idiomatic to write: `let pos = if position > self.position { -1 * (position - self.position + buf.len() as u64 - 1) as i64 } else { (self.position - position - buf.len() as u64 + 1) as i64 };`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::useless_let_if_seq)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: Negation by multiplying with -1
[INFO] [stderr]   --> src/byte.rs:31:19
[INFO] [stderr]    |
[INFO] [stderr] 31 |             pos = -1 * (position - self.position + buf.len() as u64 - 1) as i64;
[INFO] [stderr]    |                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::neg_multiply)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_multiply
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 0.82s
[INFO] running `"docker" "inspect" "6a5620ef4979c1b04881c299568bed42ec1233732fde01f64c91e6b43140983f"`
[INFO] running `"docker" "rm" "-f" "6a5620ef4979c1b04881c299568bed42ec1233732fde01f64c91e6b43140983f"`
[INFO] [stdout] 6a5620ef4979c1b04881c299568bed42ec1233732fde01f64c91e6b43140983f