[INFO] updating cached repository inter-action/super_tiny_compiler [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/inter-action/super_tiny_compiler [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/inter-action/super_tiny_compiler" "work/ex/clippy-test-run/sources/stable/gh/inter-action/super_tiny_compiler"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/inter-action/super_tiny_compiler'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/inter-action/super_tiny_compiler" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/inter-action/super_tiny_compiler"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/inter-action/super_tiny_compiler'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] c30343f3138166adeeef62e509bb6d99ce071c7d [INFO] sha for GitHub repo inter-action/super_tiny_compiler: c30343f3138166adeeef62e509bb6d99ce071c7d [INFO] validating manifest of inter-action/super_tiny_compiler on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of inter-action/super_tiny_compiler on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing inter-action/super_tiny_compiler [INFO] finished frobbing inter-action/super_tiny_compiler [INFO] frobbed toml for inter-action/super_tiny_compiler written to work/ex/clippy-test-run/sources/stable/gh/inter-action/super_tiny_compiler/Cargo.toml [INFO] started frobbing inter-action/super_tiny_compiler [INFO] finished frobbing inter-action/super_tiny_compiler [INFO] frobbed toml for inter-action/super_tiny_compiler written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/inter-action/super_tiny_compiler/Cargo.toml [INFO] crate inter-action/super_tiny_compiler has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting inter-action/super_tiny_compiler against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/inter-action/super_tiny_compiler:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] eb5d60e1ac782a574073c6ea7b52a7d1ac33e6387bd8aa070f1226a63287ff41 [INFO] running `"docker" "start" "-a" "eb5d60e1ac782a574073c6ea7b52a7d1ac33e6387bd8aa070f1226a63287ff41"` [INFO] [stderr] Checking thread-id v3.0.0 [INFO] [stderr] Checking thread_local v0.3.3 [INFO] [stderr] Checking regex v0.2.1 [INFO] [stderr] Checking env_logger v0.4.2 [INFO] [stderr] Checking super_tiny_compiler v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:110:17 [INFO] [stderr] | [INFO] [stderr] 110 | value: value, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] --> src/main.rs:110:17 [INFO] [stderr] | [INFO] [stderr] 110 | value: value, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:196:25 [INFO] [stderr] | [INFO] [stderr] 196 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:196:25 [INFO] [stderr] | [INFO] [stderr] 196 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:197:25 [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] | [INFO] [stderr] --> src/main.rs:197:25 [INFO] [stderr] 197 | params: params [INFO] [stderr] | [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `params` [INFO] [stderr] 197 | params: params [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `params` [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:216:9 [INFO] [stderr] | [INFO] [stderr] 216 | body: body [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `body` [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:216:9 [INFO] [stderr] | [INFO] [stderr] 216 | body: body [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `body` [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:275:25 [INFO] [stderr] | [INFO] [stderr] 275 | VistorContainer{data: data} [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:275:25 [INFO] [stderr] | [INFO] [stderr] 275 | VistorContainer{data: data} [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:284:9 [INFO] [stderr] | [INFO] [stderr] 284 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/main.rs:301:76 [INFO] [stderr] | [INFO] [stderr] 301 | fn traverse_node(env: &Env, node: &AstNode, parent: &Option<&AstNode>) -> (){ [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:284:9 [INFO] [stderr] | [INFO] [stderr] 284 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/main.rs:301:76 [INFO] [stderr] | [INFO] [stderr] 301 | fn traverse_node(env: &Env, node: &AstNode, parent: &Option<&AstNode>) -> (){ [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:164:41 [INFO] [stderr] | [INFO] [stderr] 164 | fn walk(counter: &mut usize, input: &Vec)->AstNode{ [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Token]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/main.rs:165:17 [INFO] [stderr] | [INFO] [stderr] 165 | assert!(counter < &mut input.len()); [INFO] [stderr] | ^^^^^^^^^^---------------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `input.len()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/main.rs:253:12 [INFO] [stderr] | [INFO] [stderr] 253 | enter: Option)>>, // trait is unsized, has to be boxed here [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/main.rs:254:11 [INFO] [stderr] | [INFO] [stderr] 254 | exit: Option)>>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:295:41 [INFO] [stderr] | [INFO] [stderr] 295 | fn traverse_array(env: &Env, array: &Vec, parent: &Option<&AstNode>) { [INFO] [stderr] | ^^^^^^^^^^^^^ help: change this to: `&[AstNode]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:295:64 [INFO] [stderr] | [INFO] [stderr] 295 | fn traverse_array(env: &Env, array: &Vec, parent: &Option<&AstNode>) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider passing by value instead: `Option<&AstNode>` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:296:13 [INFO] [stderr] | [INFO] [stderr] 296 | for ref node in array { [INFO] [stderr] | ^^^^^^^^ ----- help: try: `let node = &array;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:301:57 [INFO] [stderr] | [INFO] [stderr] 301 | fn traverse_node(env: &Env, node: &AstNode, parent: &Option<&AstNode>) -> (){ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider passing by value instead: `Option<&AstNode>` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/main.rs:304:13 [INFO] [stderr] | [INFO] [stderr] 304 | vi.enter.as_ref().map(|f| f(node, parent)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(f) = vi.enter.as_ref() { f(node, parent) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:307:9 [INFO] [stderr] | [INFO] [stderr] 307 | / match node { [INFO] [stderr] 308 | | &AstNode::Program{ref body} => traverse_array(env, body, &Some(node)), [INFO] [stderr] 309 | | &AstNode::CallExpression{ref params, ..} => traverse_array(env, params, &Some(node)), [INFO] [stderr] 310 | | &AstNode::NumberLiteral{..} => (), [INFO] [stderr] 311 | | &AstNode::StringLiteral{..} => (), [INFO] [stderr] 312 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 307 | match *node { [INFO] [stderr] 308 | AstNode::Program{ref body} => traverse_array(env, body, &Some(node)), [INFO] [stderr] 309 | AstNode::CallExpression{ref params, ..} => traverse_array(env, params, &Some(node)), [INFO] [stderr] 310 | AstNode::NumberLiteral{..} => (), [INFO] [stderr] 311 | AstNode::StringLiteral{..} => (), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/main.rs:315:12 [INFO] [stderr] | [INFO] [stderr] 315 | vi.exit.as_ref().map(|f| f(node, parent)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(f) = vi.exit.as_ref() { f(node, parent) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:164:41 [INFO] [stderr] | [INFO] [stderr] 164 | fn walk(counter: &mut usize, input: &Vec)->AstNode{ [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Token]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/main.rs:165:17 [INFO] [stderr] | [INFO] [stderr] 165 | assert!(counter < &mut input.len()); [INFO] [stderr] | ^^^^^^^^^^---------------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `input.len()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/main.rs:253:12 [INFO] [stderr] | [INFO] [stderr] 253 | enter: Option)>>, // trait is unsized, has to be boxed here [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/main.rs:254:11 [INFO] [stderr] | [INFO] [stderr] 254 | exit: Option)>>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:295:41 [INFO] [stderr] | [INFO] [stderr] 295 | fn traverse_array(env: &Env, array: &Vec, parent: &Option<&AstNode>) { [INFO] [stderr] | ^^^^^^^^^^^^^ help: change this to: `&[AstNode]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:295:64 [INFO] [stderr] | [INFO] [stderr] 295 | fn traverse_array(env: &Env, array: &Vec, parent: &Option<&AstNode>) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider passing by value instead: `Option<&AstNode>` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:296:13 [INFO] [stderr] | [INFO] [stderr] 296 | for ref node in array { [INFO] [stderr] | ^^^^^^^^ ----- help: try: `let node = &array;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:301:57 [INFO] [stderr] | [INFO] [stderr] 301 | fn traverse_node(env: &Env, node: &AstNode, parent: &Option<&AstNode>) -> (){ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider passing by value instead: `Option<&AstNode>` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/main.rs:304:13 [INFO] [stderr] | [INFO] [stderr] 304 | vi.enter.as_ref().map(|f| f(node, parent)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(f) = vi.enter.as_ref() { f(node, parent) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:307:9 [INFO] [stderr] | [INFO] [stderr] 307 | / match node { [INFO] [stderr] 308 | | &AstNode::Program{ref body} => traverse_array(env, body, &Some(node)), [INFO] [stderr] 309 | | &AstNode::CallExpression{ref params, ..} => traverse_array(env, params, &Some(node)), [INFO] [stderr] 310 | | &AstNode::NumberLiteral{..} => (), [INFO] [stderr] 311 | | &AstNode::StringLiteral{..} => (), [INFO] [stderr] 312 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 307 | match *node { [INFO] [stderr] 308 | AstNode::Program{ref body} => traverse_array(env, body, &Some(node)), [INFO] [stderr] 309 | AstNode::CallExpression{ref params, ..} => traverse_array(env, params, &Some(node)), [INFO] [stderr] 310 | AstNode::NumberLiteral{..} => (), [INFO] [stderr] 311 | AstNode::StringLiteral{..} => (), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/main.rs:315:12 [INFO] [stderr] | [INFO] [stderr] 315 | vi.exit.as_ref().map(|f| f(node, parent)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(f) = vi.exit.as_ref() { f(node, parent) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.91s [INFO] running `"docker" "inspect" "eb5d60e1ac782a574073c6ea7b52a7d1ac33e6387bd8aa070f1226a63287ff41"` [INFO] running `"docker" "rm" "-f" "eb5d60e1ac782a574073c6ea7b52a7d1ac33e6387bd8aa070f1226a63287ff41"` [INFO] [stdout] eb5d60e1ac782a574073c6ea7b52a7d1ac33e6387bd8aa070f1226a63287ff41