[INFO] updating cached repository intdxdt/two_product [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/intdxdt/two_product [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/intdxdt/two_product" "work/ex/clippy-test-run/sources/stable/gh/intdxdt/two_product"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/intdxdt/two_product'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/intdxdt/two_product" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/intdxdt/two_product"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/intdxdt/two_product'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] f407ca7312906fe76dc7d873c87f228f785eaf11 [INFO] sha for GitHub repo intdxdt/two_product: f407ca7312906fe76dc7d873c87f228f785eaf11 [INFO] validating manifest of intdxdt/two_product on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of intdxdt/two_product on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing intdxdt/two_product [INFO] finished frobbing intdxdt/two_product [INFO] frobbed toml for intdxdt/two_product written to work/ex/clippy-test-run/sources/stable/gh/intdxdt/two_product/Cargo.toml [INFO] started frobbing intdxdt/two_product [INFO] finished frobbing intdxdt/two_product [INFO] frobbed toml for intdxdt/two_product written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/intdxdt/two_product/Cargo.toml [INFO] crate intdxdt/two_product has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting intdxdt/two_product against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/intdxdt/two_product:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 90b49401ca60377503f7721f9ec3d70592a01221ea0bd320e60a788e2969c988 [INFO] running `"docker" "start" "-a" "90b49401ca60377503f7721f9ec3d70592a01221ea0bd320e60a788e2969c988"` [INFO] [stderr] Checking two_product v0.1.0 (/opt/crater/workdir) [INFO] [stderr] Checking rand v0.3.15 [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/lib.rs:12:9 [INFO] [stderr] | [INFO] [stderr] 12 | let d = SPLITTER * b; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/lib.rs:21:9 [INFO] [stderr] | [INFO] [stderr] 21 | let y = alo * blo - err3; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:1:23 [INFO] [stderr] | [INFO] [stderr] 1 | const SPLITTER: f64 = 134217729.0;//math.Pow(2, 27) + 1.0 [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `134_217_729.0` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/lib.rs:12:9 [INFO] [stderr] | [INFO] [stderr] 12 | let d = SPLITTER * b; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/lib.rs:21:9 [INFO] [stderr] | [INFO] [stderr] 21 | let y = alo * blo - err3; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:1:23 [INFO] [stderr] | [INFO] [stderr] 1 | const SPLITTER: f64 = 134217729.0;//math.Pow(2, 27) + 1.0 [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `134_217_729.0` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: the loop variable `j` is only used to index `test_values`. [INFO] [stderr] --> src/lib.rs:68:18 [INFO] [stderr] | [INFO] [stderr] 68 | for j in 0..test_values.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 68 | for in &test_values { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.65s [INFO] running `"docker" "inspect" "90b49401ca60377503f7721f9ec3d70592a01221ea0bd320e60a788e2969c988"` [INFO] running `"docker" "rm" "-f" "90b49401ca60377503f7721f9ec3d70592a01221ea0bd320e60a788e2969c988"` [INFO] [stdout] 90b49401ca60377503f7721f9ec3d70592a01221ea0bd320e60a788e2969c988