[INFO] updating cached repository increpare/rust_solitaire_game [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/increpare/rust_solitaire_game [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/increpare/rust_solitaire_game" "work/ex/clippy-test-run/sources/stable/gh/increpare/rust_solitaire_game"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/increpare/rust_solitaire_game'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/increpare/rust_solitaire_game" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/increpare/rust_solitaire_game"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/increpare/rust_solitaire_game'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 415189c6f2a672eaee435b23783eb0b7df3622b5 [INFO] sha for GitHub repo increpare/rust_solitaire_game: 415189c6f2a672eaee435b23783eb0b7df3622b5 [INFO] validating manifest of increpare/rust_solitaire_game on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of increpare/rust_solitaire_game on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing increpare/rust_solitaire_game [INFO] finished frobbing increpare/rust_solitaire_game [INFO] frobbed toml for increpare/rust_solitaire_game written to work/ex/clippy-test-run/sources/stable/gh/increpare/rust_solitaire_game/Cargo.toml [INFO] started frobbing increpare/rust_solitaire_game [INFO] finished frobbing increpare/rust_solitaire_game [INFO] frobbed toml for increpare/rust_solitaire_game written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/increpare/rust_solitaire_game/Cargo.toml [INFO] crate increpare/rust_solitaire_game has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting increpare/rust_solitaire_game against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/increpare/rust_solitaire_game:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 53089230f06222ff655c56f16b54d0c7c6fc879c6bd57206f79c951300c0b7ac [INFO] running `"docker" "start" "-a" "53089230f06222ff655c56f16b54d0c7c6fc879c6bd57206f79c951300c0b7ac"` [INFO] [stderr] Checking hello_world v0.0.1 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:21:2 [INFO] [stderr] | [INFO] [stderr] 21 | return [INFO] [stderr] | _____^ [INFO] [stderr] 22 | | (x[0]>=y[0] && x[1]>=y[1]&&x[2]>=y[2]&&x[3]>=y[3]) || [INFO] [stderr] 23 | | (x[0]<=y[0] && x[1]<=y[1]&&x[2]<=y[2]&&x[3]<=y[3]); [INFO] [stderr] | |___________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 21 | (x[0]>=y[0] && x[1]>=y[1]&&x[2]>=y[2]&&x[3]>=y[3]) || [INFO] [stderr] 22 | (x[0]<=y[0] && x[1]<=y[1]&&x[2]<=y[2]&&x[3]<=y[3]) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:48:2 [INFO] [stderr] | [INFO] [stderr] 48 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:77:2 [INFO] [stderr] | [INFO] [stderr] 77 | return (result,states_used); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(result,states_used)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this looks like you are trying to use `.. -= ..`, but you really are doing `.. = (- ..)` [INFO] [stderr] --> src/main.rs:68:27 [INFO] [stderr] | [INFO] [stderr] 68 | r.playable[CARDCOUNT-2]=-1; [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::suspicious_assignment_formatting)] on by default [INFO] [stderr] = note: to remove this lint, use either `-=` or `= -` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_assignment_formatting [INFO] [stderr] [INFO] [stderr] warning: this looks like you are trying to use `.. -= ..`, but you really are doing `.. = (- ..)` [INFO] [stderr] --> src/main.rs:69:27 [INFO] [stderr] | [INFO] [stderr] 69 | r.playable[CARDCOUNT-1]=-1; [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: to remove this lint, use either `-=` or `= -` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_assignment_formatting [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:118:2 [INFO] [stderr] | [INFO] [stderr] 118 | return (result,s.playable_count); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(result,s.playable_count)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:131:3 [INFO] [stderr] | [INFO] [stderr] 131 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:133:3 [INFO] [stderr] | [INFO] [stderr] 133 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:148:3 [INFO] [stderr] | [INFO] [stderr] 148 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:150:3 [INFO] [stderr] | [INFO] [stderr] 150 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:162:2 [INFO] [stderr] | [INFO] [stderr] 162 | return t; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `t` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:173:2 [INFO] [stderr] | [INFO] [stderr] 173 | return t; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `t` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:204:3 [INFO] [stderr] | [INFO] [stderr] 204 | return left_score; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `left_score` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:206:3 [INFO] [stderr] | [INFO] [stderr] 206 | return right_score; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `right_score` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:222:2 [INFO] [stderr] | [INFO] [stderr] 222 | return compatibility; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `compatibility` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:21:2 [INFO] [stderr] | [INFO] [stderr] 21 | return [INFO] [stderr] | _____^ [INFO] [stderr] 22 | | (x[0]>=y[0] && x[1]>=y[1]&&x[2]>=y[2]&&x[3]>=y[3]) || [INFO] [stderr] 23 | | (x[0]<=y[0] && x[1]<=y[1]&&x[2]<=y[2]&&x[3]<=y[3]); [INFO] [stderr] | |___________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 21 | (x[0]>=y[0] && x[1]>=y[1]&&x[2]>=y[2]&&x[3]>=y[3]) || [INFO] [stderr] 22 | (x[0]<=y[0] && x[1]<=y[1]&&x[2]<=y[2]&&x[3]<=y[3]) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:48:2 [INFO] [stderr] | [INFO] [stderr] 48 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:77:2 [INFO] [stderr] | [INFO] [stderr] 77 | return (result,states_used); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(result,states_used)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this looks like you are trying to use `.. -= ..`, but you really are doing `.. = (- ..)` [INFO] [stderr] --> src/main.rs:68:27 [INFO] [stderr] | [INFO] [stderr] 68 | r.playable[CARDCOUNT-2]=-1; [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::suspicious_assignment_formatting)] on by default [INFO] [stderr] = note: to remove this lint, use either `-=` or `= -` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_assignment_formatting [INFO] [stderr] [INFO] [stderr] warning: this looks like you are trying to use `.. -= ..`, but you really are doing `.. = (- ..)` [INFO] [stderr] --> src/main.rs:69:27 [INFO] [stderr] | [INFO] [stderr] 69 | r.playable[CARDCOUNT-1]=-1; [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: to remove this lint, use either `-=` or `= -` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_assignment_formatting [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:118:2 [INFO] [stderr] | [INFO] [stderr] 118 | return (result,s.playable_count); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(result,s.playable_count)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:131:3 [INFO] [stderr] | [INFO] [stderr] 131 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:133:3 [INFO] [stderr] | [INFO] [stderr] 133 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:148:3 [INFO] [stderr] | [INFO] [stderr] 148 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:150:3 [INFO] [stderr] | [INFO] [stderr] 150 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:162:2 [INFO] [stderr] | [INFO] [stderr] 162 | return t; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `t` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:173:2 [INFO] [stderr] | [INFO] [stderr] 173 | return t; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `t` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:204:3 [INFO] [stderr] | [INFO] [stderr] 204 | return left_score; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `left_score` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:206:3 [INFO] [stderr] | [INFO] [stderr] 206 | return right_score; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `right_score` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:222:2 [INFO] [stderr] | [INFO] [stderr] 222 | return compatibility; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `compatibility` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `result` [INFO] [stderr] --> src/main.rs:93:11 [INFO] [stderr] | [INFO] [stderr] 93 | for i in 0..s.playable_count { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 93 | for (i, ) in result.iter_mut().enumerate().take(s.playable_count) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/main.rs:102:12 [INFO] [stderr] | [INFO] [stderr] 102 | for j in 0..i { [INFO] [stderr] | ^^^^ help: try replacing the loop by: `t.playable[..i].clone_from_slice(&s.playable[..i])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::manual_memcpy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/main.rs:105:12 [INFO] [stderr] | [INFO] [stderr] 105 | for j in (i+1)..s.playable_count { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try replacing the loop by: `t.playable[((i+1) - 1)..(s.playable_count - 1)].clone_from_slice(&s.playable[(i+1)..s.playable_count])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/main.rs:130:2 [INFO] [stderr] | [INFO] [stderr] 130 | if compatibility[s.left as usize][s.top as usize] == 1 { [INFO] [stderr] | _____^ [INFO] [stderr] 131 | | return true; [INFO] [stderr] 132 | | } else { [INFO] [stderr] 133 | | return false; [INFO] [stderr] 134 | | } [INFO] [stderr] | |_____^ help: you can reduce it to: `return compatibility[s.left as usize][s.top as usize] == 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/main.rs:147:2 [INFO] [stderr] | [INFO] [stderr] 147 | if compatibility[s.right as usize][s.top as usize] == 1 { [INFO] [stderr] | _____^ [INFO] [stderr] 148 | | return true; [INFO] [stderr] 149 | | } else { [INFO] [stderr] 150 | | return false; [INFO] [stderr] 151 | | } [INFO] [stderr] | |_____^ help: you can reduce it to: `return compatibility[s.right as usize][s.top as usize] == 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:159:13 [INFO] [stderr] | [INFO] [stderr] 159 | playable: s.playable.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `s.playable` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:170:13 [INFO] [stderr] | [INFO] [stderr] 170 | playable: s.playable.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `s.playable` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:179:10 [INFO] [stderr] | [INFO] [stderr] 179 | return 1 as f64; [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(1)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:182:29 [INFO] [stderr] | [INFO] [stderr] 182 | let mut left_score : f64 = 0 as f64; [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `possibilities`. [INFO] [stderr] --> src/main.rs:187:13 [INFO] [stderr] | [INFO] [stderr] 187 | for i in 0..l { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 187 | for in possibilities.iter().take(l) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:193:30 [INFO] [stderr] | [INFO] [stderr] 193 | let mut right_score : f64 = 0 as f64; [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `possibilities`. [INFO] [stderr] --> src/main.rs:198:12 [INFO] [stderr] | [INFO] [stderr] 198 | for i in 0..l { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 198 | for in possibilities.iter().take(l) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:230:47 [INFO] [stderr] | [INFO] [stderr] 230 | let mut probs : [f64;CARDCOUNT*CARDCOUNT] = [0 as f64;CARDCOUNT*CARDCOUNT]; [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:239:26 [INFO] [stderr] | [INFO] [stderr] 239 | let mut average : f64 = 0 as f64; [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `probs`. [INFO] [stderr] --> src/main.rs:240:12 [INFO] [stderr] | [INFO] [stderr] 240 | for i in 0..states_used { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 240 | for in probs.iter().take(states_used) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `result` [INFO] [stderr] --> src/main.rs:93:11 [INFO] [stderr] | [INFO] [stderr] 93 | for i in 0..s.playable_count { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 93 | for (i, ) in result.iter_mut().enumerate().take(s.playable_count) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/main.rs:102:12 [INFO] [stderr] | [INFO] [stderr] 102 | for j in 0..i { [INFO] [stderr] | ^^^^ help: try replacing the loop by: `t.playable[..i].clone_from_slice(&s.playable[..i])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::manual_memcpy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/main.rs:105:12 [INFO] [stderr] | [INFO] [stderr] 105 | for j in (i+1)..s.playable_count { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try replacing the loop by: `t.playable[((i+1) - 1)..(s.playable_count - 1)].clone_from_slice(&s.playable[(i+1)..s.playable_count])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/main.rs:130:2 [INFO] [stderr] | [INFO] [stderr] 130 | if compatibility[s.left as usize][s.top as usize] == 1 { [INFO] [stderr] | _____^ [INFO] [stderr] 131 | | return true; [INFO] [stderr] 132 | | } else { [INFO] [stderr] 133 | | return false; [INFO] [stderr] 134 | | } [INFO] [stderr] | |_____^ help: you can reduce it to: `return compatibility[s.left as usize][s.top as usize] == 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/main.rs:147:2 [INFO] [stderr] | [INFO] [stderr] 147 | if compatibility[s.right as usize][s.top as usize] == 1 { [INFO] [stderr] | _____^ [INFO] [stderr] 148 | | return true; [INFO] [stderr] 149 | | } else { [INFO] [stderr] 150 | | return false; [INFO] [stderr] 151 | | } [INFO] [stderr] | |_____^ help: you can reduce it to: `return compatibility[s.right as usize][s.top as usize] == 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:159:13 [INFO] [stderr] | [INFO] [stderr] 159 | playable: s.playable.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `s.playable` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:170:13 [INFO] [stderr] | [INFO] [stderr] 170 | playable: s.playable.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `s.playable` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:179:10 [INFO] [stderr] | [INFO] [stderr] 179 | return 1 as f64; [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(1)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:182:29 [INFO] [stderr] | [INFO] [stderr] 182 | let mut left_score : f64 = 0 as f64; [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `possibilities`. [INFO] [stderr] --> src/main.rs:187:13 [INFO] [stderr] | [INFO] [stderr] 187 | for i in 0..l { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 187 | for in possibilities.iter().take(l) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:193:30 [INFO] [stderr] | [INFO] [stderr] 193 | let mut right_score : f64 = 0 as f64; [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `possibilities`. [INFO] [stderr] --> src/main.rs:198:12 [INFO] [stderr] | [INFO] [stderr] 198 | for i in 0..l { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 198 | for in possibilities.iter().take(l) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:230:47 [INFO] [stderr] | [INFO] [stderr] 230 | let mut probs : [f64;CARDCOUNT*CARDCOUNT] = [0 as f64;CARDCOUNT*CARDCOUNT]; [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:239:26 [INFO] [stderr] | [INFO] [stderr] 239 | let mut average : f64 = 0 as f64; [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `probs`. [INFO] [stderr] --> src/main.rs:240:12 [INFO] [stderr] | [INFO] [stderr] 240 | for i in 0..states_used { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 240 | for in probs.iter().take(states_used) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.72s [INFO] running `"docker" "inspect" "53089230f06222ff655c56f16b54d0c7c6fc879c6bd57206f79c951300c0b7ac"` [INFO] running `"docker" "rm" "-f" "53089230f06222ff655c56f16b54d0c7c6fc879c6bd57206f79c951300c0b7ac"` [INFO] [stdout] 53089230f06222ff655c56f16b54d0c7c6fc879c6bd57206f79c951300c0b7ac