[INFO] updating cached repository imnotbad/adventofcode [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/imnotbad/adventofcode [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/imnotbad/adventofcode" "work/ex/clippy-test-run/sources/stable/gh/imnotbad/adventofcode"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/imnotbad/adventofcode'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/imnotbad/adventofcode" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/imnotbad/adventofcode"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/imnotbad/adventofcode'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 075c0534fe7dbab584f463eda20441360bc1948e [INFO] sha for GitHub repo imnotbad/adventofcode: 075c0534fe7dbab584f463eda20441360bc1948e [INFO] validating manifest of imnotbad/adventofcode on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of imnotbad/adventofcode on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing imnotbad/adventofcode [INFO] finished frobbing imnotbad/adventofcode [INFO] frobbed toml for imnotbad/adventofcode written to work/ex/clippy-test-run/sources/stable/gh/imnotbad/adventofcode/Cargo.toml [INFO] started frobbing imnotbad/adventofcode [INFO] finished frobbing imnotbad/adventofcode [INFO] frobbed toml for imnotbad/adventofcode written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/imnotbad/adventofcode/Cargo.toml [INFO] crate imnotbad/adventofcode has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting imnotbad/adventofcode against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/imnotbad/adventofcode:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] fb2f675be14b3763030073ca0f5b09f06582dbbea476a5f20cd028a56cf3ae58 [INFO] running `"docker" "start" "-a" "fb2f675be14b3763030073ca0f5b09f06582dbbea476a5f20cd028a56cf3ae58"` [INFO] [stderr] Checking advent_of_code v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/days/day_five.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | / loop { [INFO] [stderr] 11 | | if let Some(instruction) = input.clone().get(current_index as usize) { [INFO] [stderr] 12 | | steps += 1; [INFO] [stderr] 13 | | input[current_index as usize] += 1; [INFO] [stderr] ... | [INFO] [stderr] 17 | | } [INFO] [stderr] 18 | | } [INFO] [stderr] | |_____^ help: try: `while let Some(instruction) = input.clone().get(current_index as usize) { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/days/day_five.rs:29:5 [INFO] [stderr] | [INFO] [stderr] 29 | / loop { [INFO] [stderr] 30 | | if let Some(instruction) = input.clone().get(current_index as usize) { [INFO] [stderr] 31 | | steps += 1; [INFO] [stderr] 32 | | if *instruction >= 3 { [INFO] [stderr] ... | [INFO] [stderr] 40 | | } [INFO] [stderr] 41 | | } [INFO] [stderr] | |_____^ help: try: `while let Some(instruction) = input.clone().get(current_index as usize) { .. }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/days/day_five.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | / loop { [INFO] [stderr] 11 | | if let Some(instruction) = input.clone().get(current_index as usize) { [INFO] [stderr] 12 | | steps += 1; [INFO] [stderr] 13 | | input[current_index as usize] += 1; [INFO] [stderr] ... | [INFO] [stderr] 17 | | } [INFO] [stderr] 18 | | } [INFO] [stderr] | |_____^ help: try: `while let Some(instruction) = input.clone().get(current_index as usize) { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/days/day_five.rs:29:5 [INFO] [stderr] | [INFO] [stderr] 29 | / loop { [INFO] [stderr] 30 | | if let Some(instruction) = input.clone().get(current_index as usize) { [INFO] [stderr] 31 | | steps += 1; [INFO] [stderr] 32 | | if *instruction >= 3 { [INFO] [stderr] ... | [INFO] [stderr] 40 | | } [INFO] [stderr] 41 | | } [INFO] [stderr] | |_____^ help: try: `while let Some(instruction) = input.clone().get(current_index as usize) { .. }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.77s [INFO] running `"docker" "inspect" "fb2f675be14b3763030073ca0f5b09f06582dbbea476a5f20cd028a56cf3ae58"` [INFO] running `"docker" "rm" "-f" "fb2f675be14b3763030073ca0f5b09f06582dbbea476a5f20cd028a56cf3ae58"` [INFO] [stdout] fb2f675be14b3763030073ca0f5b09f06582dbbea476a5f20cd028a56cf3ae58