[INFO] updating cached repository illustrious-you/tic-tac-toe-ecs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/illustrious-you/tic-tac-toe-ecs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/illustrious-you/tic-tac-toe-ecs" "work/ex/clippy-test-run/sources/stable/gh/illustrious-you/tic-tac-toe-ecs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/illustrious-you/tic-tac-toe-ecs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/illustrious-you/tic-tac-toe-ecs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/illustrious-you/tic-tac-toe-ecs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/illustrious-you/tic-tac-toe-ecs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 2368a23bcc234dbfe89fb8a4975b61b90c1c874f [INFO] sha for GitHub repo illustrious-you/tic-tac-toe-ecs: 2368a23bcc234dbfe89fb8a4975b61b90c1c874f [INFO] validating manifest of illustrious-you/tic-tac-toe-ecs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of illustrious-you/tic-tac-toe-ecs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing illustrious-you/tic-tac-toe-ecs [INFO] finished frobbing illustrious-you/tic-tac-toe-ecs [INFO] frobbed toml for illustrious-you/tic-tac-toe-ecs written to work/ex/clippy-test-run/sources/stable/gh/illustrious-you/tic-tac-toe-ecs/Cargo.toml [INFO] started frobbing illustrious-you/tic-tac-toe-ecs [INFO] finished frobbing illustrious-you/tic-tac-toe-ecs [INFO] frobbed toml for illustrious-you/tic-tac-toe-ecs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/illustrious-you/tic-tac-toe-ecs/Cargo.toml [INFO] crate illustrious-you/tic-tac-toe-ecs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting illustrious-you/tic-tac-toe-ecs against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/illustrious-you/tic-tac-toe-ecs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 4b3f0bee149d6ceed4426ce97136aa7fc10872a8507d41bbc70a0fe47d1019b2 [INFO] running `"docker" "start" "-a" "4b3f0bee149d6ceed4426ce97136aa7fc10872a8507d41bbc70a0fe47d1019b2"` [INFO] [stderr] Checking tic-tac-toe-ecs v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/input.rs:14:16 [INFO] [stderr] | [INFO] [stderr] 14 | if let Err(_) = input.read_line(&mut buffer) { [INFO] [stderr] | _________- ^^^^^^ [INFO] [stderr] 15 | | println!("Cannot read from stdin!"); [INFO] [stderr] 16 | | continue; [INFO] [stderr] 17 | | }; [INFO] [stderr] | |_________- help: try this: `if input.read_line(&mut buffer).is_err()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/input.rs:19:75 [INFO] [stderr] | [INFO] [stderr] 19 | let items : Vec<_> = buffer.split(char::is_whitespace).filter(|s| s.len() > 0).collect(); [INFO] [stderr] | ^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!s.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/win.rs:10:54 [INFO] [stderr] | [INFO] [stderr] 10 | fn check_win_pattern<'a>(pattern: [usize;3], claims: &Vec>) -> WinPatternState<'a> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: change this to: `&[CellState<'a>]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: The function/method `render_system` doesn't need a mutable reference [INFO] [stderr] --> src/main.rs:11:23 [INFO] [stderr] | [INFO] [stderr] 11 | render_system(&mut game); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/main.rs:218:9 [INFO] [stderr] | [INFO] [stderr] 218 | self.board().iter().flatten().map(|&s| s).collect() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.board().iter().flatten().cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/input.rs:14:16 [INFO] [stderr] | [INFO] [stderr] 14 | if let Err(_) = input.read_line(&mut buffer) { [INFO] [stderr] | _________- ^^^^^^ [INFO] [stderr] 15 | | println!("Cannot read from stdin!"); [INFO] [stderr] 16 | | continue; [INFO] [stderr] 17 | | }; [INFO] [stderr] | |_________- help: try this: `if input.read_line(&mut buffer).is_err()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/input.rs:19:75 [INFO] [stderr] | [INFO] [stderr] 19 | let items : Vec<_> = buffer.split(char::is_whitespace).filter(|s| s.len() > 0).collect(); [INFO] [stderr] | ^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!s.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/win.rs:10:54 [INFO] [stderr] | [INFO] [stderr] 10 | fn check_win_pattern<'a>(pattern: [usize;3], claims: &Vec>) -> WinPatternState<'a> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: change this to: `&[CellState<'a>]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: The function/method `render_system` doesn't need a mutable reference [INFO] [stderr] --> src/main.rs:11:23 [INFO] [stderr] | [INFO] [stderr] 11 | render_system(&mut game); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/main.rs:218:9 [INFO] [stderr] | [INFO] [stderr] 218 | self.board().iter().flatten().map(|&s| s).collect() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.board().iter().flatten().cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.16s [INFO] running `"docker" "inspect" "4b3f0bee149d6ceed4426ce97136aa7fc10872a8507d41bbc70a0fe47d1019b2"` [INFO] running `"docker" "rm" "-f" "4b3f0bee149d6ceed4426ce97136aa7fc10872a8507d41bbc70a0fe47d1019b2"` [INFO] [stdout] 4b3f0bee149d6ceed4426ce97136aa7fc10872a8507d41bbc70a0fe47d1019b2