[INFO] updating cached repository igorharden/CFG
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/igorharden/CFG
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/igorharden/CFG" "work/ex/clippy-test-run/sources/stable/gh/igorharden/CFG"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/igorharden/CFG'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/igorharden/CFG" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/igorharden/CFG"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/igorharden/CFG'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 72de827a771bdb6ef6b799618a98a3a6deddcda6
[INFO] sha for GitHub repo igorharden/CFG: 72de827a771bdb6ef6b799618a98a3a6deddcda6
[INFO] validating manifest of igorharden/CFG on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of igorharden/CFG on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing igorharden/CFG
[INFO] finished frobbing igorharden/CFG
[INFO] frobbed toml for igorharden/CFG written to work/ex/clippy-test-run/sources/stable/gh/igorharden/CFG/Cargo.toml
[INFO] started frobbing igorharden/CFG
[INFO] finished frobbing igorharden/CFG
[INFO] frobbed toml for igorharden/CFG written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/igorharden/CFG/Cargo.toml
[INFO] crate igorharden/CFG has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting igorharden/CFG against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/igorharden/CFG:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 5685b143781313949124e266d06e0529c76c61d55619cde70a34dd8d7237b211
[INFO] running `"docker" "start" "-a" "5685b143781313949124e266d06e0529c76c61d55619cde70a34dd8d7237b211"`
[INFO] [stderr]     Checking cfg v1.0.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/cfg.rs:430:39
[INFO] [stderr]     |
[INFO] [stderr] 430 |                 let symbol = Symbol { terminal: terminal, start: false, label: word };
[INFO] [stderr]     |                                       ^^^^^^^^^^^^^^^^^^ help: replace it with: `terminal`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/cfg.rs:446:13
[INFO] [stderr]     |
[INFO] [stderr] 446 |             outcomes:   outcomes,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `outcomes`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: using `println!("")`
[INFO] [stderr]   --> src/main.rs:43:22
[INFO] [stderr]    |
[INFO] [stderr] 43 |         if spacing { println!(""); }
[INFO] [stderr]    |                      ^^^^^^^^^^^^ help: replace it with: `println!()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::println_empty_string)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/cfg.rs:430:39
[INFO] [stderr]     |
[INFO] [stderr] 430 |                 let symbol = Symbol { terminal: terminal, start: false, label: word };
[INFO] [stderr]     |                                       ^^^^^^^^^^^^^^^^^^ help: replace it with: `terminal`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/cfg.rs:446:13
[INFO] [stderr]     |
[INFO] [stderr] 446 |             outcomes:   outcomes,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `outcomes`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: using `println!("")`
[INFO] [stderr]   --> src/main.rs:43:22
[INFO] [stderr]    |
[INFO] [stderr] 43 |         if spacing { println!(""); }
[INFO] [stderr]    |                      ^^^^^^^^^^^^ help: replace it with: `println!()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::println_empty_string)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/cfg.rs:51:40
[INFO] [stderr]    |
[INFO] [stderr] 51 |         Order::ASCENDING{count: c}  => return c % n,
[INFO] [stderr]    |                                        ^^^^^^^^^^^^ help: remove `return` as shown: `c % n`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/cfg.rs:52:40
[INFO] [stderr]    |
[INFO] [stderr] 52 |         _                           => return rand::thread_rng().gen_range(0, n),
[INFO] [stderr]    |                                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `rand::thread_rng().gen_range(0, n)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/cfg.rs:60:13
[INFO] [stderr]    |
[INFO] [stderr] 60 |             return Order::ASCENDING { count: new };
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Order::ASCENDING { count: new }`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/cfg.rs:62:14
[INFO] [stderr]    |
[INFO] [stderr] 62 |         _ => return order,
[INFO] [stderr]    |              ^^^^^^^^^^^^ help: remove `return` as shown: `order`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: this if statement can be collapsed
[INFO] [stderr]   --> src/main.rs:23:9
[INFO] [stderr]    |
[INFO] [stderr] 23 | /         if args.len() > 2 {
[INFO] [stderr] 24 | |             if args[2] == "-s".to_string() {
[INFO] [stderr] 25 | |                 spacing = true;
[INFO] [stderr] 26 | |             }
[INFO] [stderr] 27 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 23 |         if args.len() > 2 && args[2] == "-s".to_string() {
[INFO] [stderr] 24 |     spacing = true;
[INFO] [stderr] 25 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/cfg.rs:51:40
[INFO] [stderr]    |
[INFO] [stderr] 51 |         Order::ASCENDING{count: c}  => return c % n,
[INFO] [stderr]    |                                        ^^^^^^^^^^^^ help: remove `return` as shown: `c % n`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/cfg.rs:52:40
[INFO] [stderr]    |
[INFO] [stderr] 52 |         _                           => return rand::thread_rng().gen_range(0, n),
[INFO] [stderr]    |                                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `rand::thread_rng().gen_range(0, n)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/cfg.rs:60:13
[INFO] [stderr]    |
[INFO] [stderr] 60 |             return Order::ASCENDING { count: new };
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Order::ASCENDING { count: new }`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/cfg.rs:62:14
[INFO] [stderr]    |
[INFO] [stderr] 62 |         _ => return order,
[INFO] [stderr]    |              ^^^^^^^^^^^^ help: remove `return` as shown: `order`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: this if statement can be collapsed
[INFO] [stderr]   --> src/main.rs:23:9
[INFO] [stderr]    |
[INFO] [stderr] 23 | /         if args.len() > 2 {
[INFO] [stderr] 24 | |             if args[2] == "-s".to_string() {
[INFO] [stderr] 25 | |                 spacing = true;
[INFO] [stderr] 26 | |             }
[INFO] [stderr] 27 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 23 |         if args.len() > 2 && args[2] == "-s".to_string() {
[INFO] [stderr] 24 |     spacing = true;
[INFO] [stderr] 25 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/cfg.rs:87:29
[INFO] [stderr]    |
[INFO] [stderr] 87 |         if self.num == 0 || self.rules.len() == 0 { return false; }
[INFO] [stderr]    |                             ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.rules.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is only used to index `rules`.
[INFO] [stderr]    --> src/cfg.rs:159:18
[INFO] [stderr]     |
[INFO] [stderr] 159 |         for i in 0..rules.len() {
[INFO] [stderr]     |                  ^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]     |
[INFO] [stderr] 159 |         for <item> in &rules {
[INFO] [stderr]     |             ^^^^^^    ^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]    --> src/cfg.rs:170:22
[INFO] [stderr]     |
[INFO] [stderr] 170 |     fn parse_line(l: &String, data: &mut CfgData) {
[INFO] [stderr]     |                      ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/cfg.rs:180:36
[INFO] [stderr]     |
[INFO] [stderr] 180 |         if line.trim().starts_with("#") { return; } // comment
[INFO] [stderr]     |                                    ^^^ help: try using a char instead: `'#'`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/cfg.rs:183:49
[INFO] [stderr]     |
[INFO] [stderr] 183 |             let parts: Vec<String> = line.split("=")
[INFO] [stderr]     |                                                 ^^^ help: try using a char instead: `'='`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/cfg.rs:200:49
[INFO] [stderr]     |
[INFO] [stderr] 200 |             let parts: Vec<String> = line.split("=")
[INFO] [stderr]     |                                                 ^^^ help: try using a char instead: `'='`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/cfg.rs:209:49
[INFO] [stderr]     |
[INFO] [stderr] 209 |             let parts: Vec<String> = line.split("=")
[INFO] [stderr]     |                                                 ^^^ help: try using a char instead: `'='`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/cfg.rs:225:49
[INFO] [stderr]     |
[INFO] [stderr] 225 |             let parts: Vec<String> = line.split("=")
[INFO] [stderr]     |                                                 ^^^ help: try using a char instead: `'='`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: this creates an owned instance just for comparison
[INFO] [stderr]    --> src/cfg.rs:393:29
[INFO] [stderr]     |
[INFO] [stderr] 393 |         if sym_separator == "|".to_string() ||
[INFO] [stderr]     |                             ^^^^^^^^^^^^^^^ help: try: `"|"`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cmp_owned)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned
[INFO] [stderr] 
[INFO] [stderr] warning: this creates an owned instance just for comparison
[INFO] [stderr]    --> src/cfg.rs:394:38
[INFO] [stderr]     |
[INFO] [stderr] 394 |                     sym_separator == "->".to_string() {
[INFO] [stderr]     |                                      ^^^^^^^^^^^^^^^^ help: try: `"->"`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/cfg.rs:407:53
[INFO] [stderr]     |
[INFO] [stderr] 407 |         let raw_outcomes: Vec<String> = right.split("|")
[INFO] [stderr]     |                                                     ^^^ help: try using a char instead: `'|'`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is only used to index `raw_outcomes`.
[INFO] [stderr]    --> src/cfg.rs:410:18
[INFO] [stderr]     |
[INFO] [stderr] 410 |         for i in 0..raw_outcomes.len() {
[INFO] [stderr]     |                  ^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]     |
[INFO] [stderr] 410 |         for <item> in &raw_outcomes {
[INFO] [stderr]     |             ^^^^^^    ^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/cfg.rs:411:16
[INFO] [stderr]     |
[INFO] [stderr] 411 |             if raw_outcomes[i].len() == 0 {
[INFO] [stderr]     |                ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `raw_outcomes[i].is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `n` is only used to index `words`.
[INFO] [stderr]    --> src/cfg.rs:421:22
[INFO] [stderr]     |
[INFO] [stderr] 421 |             for n in 0..words.len() {
[INFO] [stderr]     |                      ^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]     |
[INFO] [stderr] 421 |             for <item> in &words {
[INFO] [stderr]     |                 ^^^^^^    ^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]    --> src/cfg.rs:424:17
[INFO] [stderr]     |
[INFO] [stderr] 424 | /                 let mut terminal = true;
[INFO] [stderr] 425 | |                 if word.starts_with("!") {
[INFO] [stderr] 426 | |                     word = word.replace("!", "");
[INFO] [stderr] 427 | |                     terminal = false;
[INFO] [stderr] 428 | |                 }
[INFO] [stderr]     | |_________________^ help: it is more idiomatic to write: `let <mut> terminal = if word.starts_with("!") { ..; false } else { true };`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::useless_let_if_seq)] on by default
[INFO] [stderr]     = note: you might not need `mut` at all
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/cfg.rs:423:20
[INFO] [stderr]     |
[INFO] [stderr] 423 |                 if word.len() == 0 { return None; }
[INFO] [stderr]     |                    ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `word.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/cfg.rs:425:37
[INFO] [stderr]     |
[INFO] [stderr] 425 |                 if word.starts_with("!") {
[INFO] [stderr]     |                                     ^^^ help: try using a char instead: `'!'`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: this creates an owned instance just for comparison
[INFO] [stderr]   --> src/main.rs:15:23
[INFO] [stderr]    |
[INFO] [stderr] 15 |         if args[1] == "-h".to_string() ||
[INFO] [stderr]    |                       ^^^^^^^^^^^^^^^^ help: try: `"-h"`
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/cfg.rs:87:29
[INFO] [stderr]    |
[INFO] [stderr] 87 |         if self.num == 0 || self.rules.len() == 0 { return false; }
[INFO] [stderr]    |                             ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.rules.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned
[INFO] [stderr] 
[INFO] [stderr] warning: this creates an owned instance just for comparison
[INFO] [stderr]   --> src/main.rs:16:23
[INFO] [stderr]    |
[INFO] [stderr] 16 |            args[1] == "--help".to_string() {
[INFO] [stderr]    |                       ^^^^^^^^^^^^^^^^^^^^ help: try: `"--help"`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned
[INFO] [stderr] 
[INFO] [stderr] warning: this creates an owned instance just for comparison
[INFO] [stderr]   --> src/main.rs:24:27
[INFO] [stderr]    |
[INFO] [stderr] 24 |             if args[2] == "-s".to_string() {
[INFO] [stderr]    |                           ^^^^^^^^^^^^^^^^ help: try: `"-s"`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is only used to index `rules`.
[INFO] [stderr]    --> src/cfg.rs:159:18
[INFO] [stderr]     |
[INFO] [stderr] 159 |         for i in 0..rules.len() {
[INFO] [stderr]     |                  ^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]     |
[INFO] [stderr] 159 |         for <item> in &rules {
[INFO] [stderr]     |             ^^^^^^    ^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]    --> src/cfg.rs:170:22
[INFO] [stderr]     |
[INFO] [stderr] 170 |     fn parse_line(l: &String, data: &mut CfgData) {
[INFO] [stderr]     |                      ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/cfg.rs:180:36
[INFO] [stderr]     |
[INFO] [stderr] 180 |         if line.trim().starts_with("#") { return; } // comment
[INFO] [stderr]     |                                    ^^^ help: try using a char instead: `'#'`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/cfg.rs:183:49
[INFO] [stderr]     |
[INFO] [stderr] 183 |             let parts: Vec<String> = line.split("=")
[INFO] [stderr]     |                                                 ^^^ help: try using a char instead: `'='`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/cfg.rs:200:49
[INFO] [stderr]     |
[INFO] [stderr] 200 |             let parts: Vec<String> = line.split("=")
[INFO] [stderr]     |                                                 ^^^ help: try using a char instead: `'='`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/cfg.rs:209:49
[INFO] [stderr]     |
[INFO] [stderr] 209 |             let parts: Vec<String> = line.split("=")
[INFO] [stderr]     |                                                 ^^^ help: try using a char instead: `'='`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/cfg.rs:225:49
[INFO] [stderr]     |
[INFO] [stderr] 225 |             let parts: Vec<String> = line.split("=")
[INFO] [stderr]     |                                                 ^^^ help: try using a char instead: `'='`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: this creates an owned instance just for comparison
[INFO] [stderr]    --> src/cfg.rs:393:29
[INFO] [stderr]     |
[INFO] [stderr] 393 |         if sym_separator == "|".to_string() ||
[INFO] [stderr]     |                             ^^^^^^^^^^^^^^^ help: try: `"|"`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cmp_owned)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned
[INFO] [stderr] 
[INFO] [stderr] warning: this creates an owned instance just for comparison
[INFO] [stderr]    --> src/cfg.rs:394:38
[INFO] [stderr]     |
[INFO] [stderr] 394 |                     sym_separator == "->".to_string() {
[INFO] [stderr]     |                                      ^^^^^^^^^^^^^^^^ help: try: `"->"`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/cfg.rs:407:53
[INFO] [stderr]     |
[INFO] [stderr] 407 |         let raw_outcomes: Vec<String> = right.split("|")
[INFO] [stderr]     |                                                     ^^^ help: try using a char instead: `'|'`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is only used to index `raw_outcomes`.
[INFO] [stderr]    --> src/cfg.rs:410:18
[INFO] [stderr]     |
[INFO] [stderr] 410 |         for i in 0..raw_outcomes.len() {
[INFO] [stderr]     |                  ^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]     |
[INFO] [stderr] 410 |         for <item> in &raw_outcomes {
[INFO] [stderr]     |             ^^^^^^    ^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/cfg.rs:411:16
[INFO] [stderr]     |
[INFO] [stderr] 411 |             if raw_outcomes[i].len() == 0 {
[INFO] [stderr]     |                ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `raw_outcomes[i].is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `n` is only used to index `words`.
[INFO] [stderr]    --> src/cfg.rs:421:22
[INFO] [stderr]     |
[INFO] [stderr] 421 |             for n in 0..words.len() {
[INFO] [stderr]     |                      ^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]     |
[INFO] [stderr] 421 |             for <item> in &words {
[INFO] [stderr]     |                 ^^^^^^    ^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]    --> src/cfg.rs:424:17
[INFO] [stderr]     |
[INFO] [stderr] 424 | /                 let mut terminal = true;
[INFO] [stderr] 425 | |                 if word.starts_with("!") {
[INFO] [stderr] 426 | |                     word = word.replace("!", "");
[INFO] [stderr] 427 | |                     terminal = false;
[INFO] [stderr] 428 | |                 }
[INFO] [stderr]     | |_________________^ help: it is more idiomatic to write: `let <mut> terminal = if word.starts_with("!") { ..; false } else { true };`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::useless_let_if_seq)] on by default
[INFO] [stderr]     = note: you might not need `mut` at all
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/cfg.rs:423:20
[INFO] [stderr]     |
[INFO] [stderr] 423 |                 if word.len() == 0 { return None; }
[INFO] [stderr]     |                    ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `word.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/cfg.rs:425:37
[INFO] [stderr]     |
[INFO] [stderr] 425 |                 if word.starts_with("!") {
[INFO] [stderr]     |                                     ^^^ help: try using a char instead: `'!'`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: this creates an owned instance just for comparison
[INFO] [stderr]   --> src/main.rs:15:23
[INFO] [stderr]    |
[INFO] [stderr] 15 |         if args[1] == "-h".to_string() ||
[INFO] [stderr]    |                       ^^^^^^^^^^^^^^^^ help: try: `"-h"`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned
[INFO] [stderr] 
[INFO] [stderr] warning: this creates an owned instance just for comparison
[INFO] [stderr]   --> src/main.rs:16:23
[INFO] [stderr]    |
[INFO] [stderr] 16 |            args[1] == "--help".to_string() {
[INFO] [stderr]    |                       ^^^^^^^^^^^^^^^^^^^^ help: try: `"--help"`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned
[INFO] [stderr] 
[INFO] [stderr] warning: this creates an owned instance just for comparison
[INFO] [stderr]   --> src/main.rs:24:27
[INFO] [stderr]    |
[INFO] [stderr] 24 |             if args[2] == "-s".to_string() {
[INFO] [stderr]    |                           ^^^^^^^^^^^^^^^^ help: try: `"-s"`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 1.02s
[INFO] running `"docker" "inspect" "5685b143781313949124e266d06e0529c76c61d55619cde70a34dd8d7237b211"`
[INFO] running `"docker" "rm" "-f" "5685b143781313949124e266d06e0529c76c61d55619cde70a34dd8d7237b211"`
[INFO] [stdout] 5685b143781313949124e266d06e0529c76c61d55619cde70a34dd8d7237b211