[INFO] updating cached repository idunn-network/idunn-dht [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/idunn-network/idunn-dht [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/idunn-network/idunn-dht" "work/ex/clippy-test-run/sources/stable/gh/idunn-network/idunn-dht"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/idunn-network/idunn-dht'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/idunn-network/idunn-dht" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/idunn-network/idunn-dht"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/idunn-network/idunn-dht'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] ef61829f981319280043c11f6390a731b55516c3 [INFO] sha for GitHub repo idunn-network/idunn-dht: ef61829f981319280043c11f6390a731b55516c3 [INFO] validating manifest of idunn-network/idunn-dht on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of idunn-network/idunn-dht on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing idunn-network/idunn-dht [INFO] finished frobbing idunn-network/idunn-dht [INFO] frobbed toml for idunn-network/idunn-dht written to work/ex/clippy-test-run/sources/stable/gh/idunn-network/idunn-dht/Cargo.toml [INFO] started frobbing idunn-network/idunn-dht [INFO] finished frobbing idunn-network/idunn-dht [INFO] frobbed toml for idunn-network/idunn-dht written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/idunn-network/idunn-dht/Cargo.toml [INFO] crate idunn-network/idunn-dht has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting idunn-network/idunn-dht against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/idunn-network/idunn-dht:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 8cd4002a4f4956e21f3d29888a724a37e8ac29b64766b35993134f7c1005adb2 [INFO] running `"docker" "start" "-a" "8cd4002a4f4956e21f3d29888a724a37e8ac29b64766b35993134f7c1005adb2"` [INFO] [stderr] Checking idunn-dht v0.0.1 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/nodeid.rs:36:9 [INFO] [stderr] | [INFO] [stderr] 36 | return Ordering::Equal [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ordering::Equal` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `for` head expression [INFO] [stderr] --> src/nodeid.rs:31:18 [INFO] [stderr] | [INFO] [stderr] 31 | for i in (0..NODE_ID_SIZE) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/nodeid.rs:46:9 [INFO] [stderr] | [INFO] [stderr] 46 | return bucket; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `bucket` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `for` head expression [INFO] [stderr] --> src/nodeid.rs:41:18 [INFO] [stderr] | [INFO] [stderr] 41 | for i in (0..NODE_ID_SIZE) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/util.rs:20:25 [INFO] [stderr] | [INFO] [stderr] 20 | assert_eq!(Some(912559), parse_hex_bytes("decaf".as_bytes())); [INFO] [stderr] | ^^^^^^ help: consider: `912_559` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/nodeid.rs:36:9 [INFO] [stderr] | [INFO] [stderr] 36 | return Ordering::Equal [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ordering::Equal` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `for` head expression [INFO] [stderr] --> src/nodeid.rs:31:18 [INFO] [stderr] | [INFO] [stderr] 31 | for i in (0..NODE_ID_SIZE) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/nodeid.rs:46:9 [INFO] [stderr] | [INFO] [stderr] 46 | return bucket; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `bucket` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `for` head expression [INFO] [stderr] --> src/nodeid.rs:41:18 [INFO] [stderr] | [INFO] [stderr] 41 | for i in (0..NODE_ID_SIZE) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] error: equal expressions as operands to `==` [INFO] [stderr] --> src/nodeid.rs:89:17 [INFO] [stderr] | [INFO] [stderr] 89 | assert!(nid1 == nid1); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::eq_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eq_op [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/kbucket.rs:56:46 [INFO] [stderr] | [INFO] [stderr] 56 | let ninfo = NodeInfo{nodeid: node.clone(), [INFO] [stderr] | ^^^^^^^^^^^^ help: try removing the `clone` call: `node` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/kbucket.rs:63:42 [INFO] [stderr] | [INFO] [stderr] 63 | let ninfo = NodeInfo{nodeid: node.clone(), [INFO] [stderr] | ^^^^^^^^^^^^ help: try removing the `clone` call: `node` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/kbucket.rs:82:17 [INFO] [stderr] | [INFO] [stderr] 82 | let ref me = self.tree.get(&node).as_ref().unwrap().borrow(); [INFO] [stderr] | ----^^^^^^--------------------------------------------------- help: try: `let me = &self.tree.get(&node).as_ref().unwrap().borrow();` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/kbucket.rs:83:17 [INFO] [stderr] | [INFO] [stderr] 83 | let ref p = me.prev; [INFO] [stderr] | ----^^^^^----------- help: try: `let p = &me.prev;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/kbucket.rs:84:17 [INFO] [stderr] | [INFO] [stderr] 84 | let ref n = me.next; [INFO] [stderr] | ----^^^^^----------- help: try: `let n = &me.next;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/kbucket.rs:85:40 [INFO] [stderr] | [INFO] [stderr] 85 | if me.next.is_some() { let ref mut x = me.next.as_ref().unwrap().borrow_mut(); x.prev = p.clone(); }; [INFO] [stderr] | ----^^^^^^^^^------------------------------------------ help: try: `let x = &mut me.next.as_ref().unwrap().borrow_mut();` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/kbucket.rs:86:40 [INFO] [stderr] | [INFO] [stderr] 86 | if me.prev.is_some() { let ref mut x = me.prev.as_ref().unwrap().borrow_mut(); x.next = n.clone(); }; [INFO] [stderr] | ----^^^^^^^^^------------------------------------------ help: try: `let x = &mut me.prev.as_ref().unwrap().borrow_mut();` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/kbucket.rs:89:17 [INFO] [stderr] | [INFO] [stderr] 89 | let ref me_opt = self.tree.get(&node); [INFO] [stderr] | ----^^^^^^^^^^------------------------ help: try: `let me_opt = &self.tree.get(&node);` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/kbucket.rs:90:17 [INFO] [stderr] | [INFO] [stderr] 90 | let ref mut me = me_opt.as_ref().unwrap().borrow_mut(); [INFO] [stderr] | ----^^^^^^^^^^----------------------------------------- help: try: `let me = &mut me_opt.as_ref().unwrap().borrow_mut();` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/kbucket.rs:99:17 [INFO] [stderr] | [INFO] [stderr] 99 | let ref mut me_opt = self.tree.get(&node); [INFO] [stderr] | ----^^^^^^^^^^^^^^------------------------ help: try: `let me_opt = &mut self.tree.get(&node);` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/kbucket.rs:106:17 [INFO] [stderr] | [INFO] [stderr] 106 | let ref node = self.tail.as_ref().unwrap().clone(); [INFO] [stderr] | ----^^^^^^^^--------------------------------------- help: try: `let node = &self.tail.as_ref().unwrap().clone();` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/kbucket.rs:107:17 [INFO] [stderr] | [INFO] [stderr] 107 | let ref id = node.borrow().nodeid.clone(); [INFO] [stderr] | ----^^^^^^-------------------------------- help: try: `let id = &node.borrow().nodeid.clone();` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/kbucket.rs:107:26 [INFO] [stderr] | [INFO] [stderr] 107 | let ref id = node.borrow().nodeid.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `node.borrow().nodeid` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/kbucket.rs:113:12 [INFO] [stderr] | [INFO] [stderr] 113 | if self.tree.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.tree.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/kbucket.rs:130:13 [INFO] [stderr] | [INFO] [stderr] 130 | c = c + 1; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `c += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/kbucket.rs:56:46 [INFO] [stderr] | [INFO] [stderr] 56 | let ninfo = NodeInfo{nodeid: node.clone(), [INFO] [stderr] | ^^^^^^^^^^^^ help: try removing the `clone` call: `node` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/kbucket.rs:63:42 [INFO] [stderr] | [INFO] [stderr] 63 | let ninfo = NodeInfo{nodeid: node.clone(), [INFO] [stderr] | ^^^^^^^^^^^^ help: try removing the `clone` call: `node` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/kbucket.rs:82:17 [INFO] [stderr] | [INFO] [stderr] 82 | let ref me = self.tree.get(&node).as_ref().unwrap().borrow(); [INFO] [stderr] | ----^^^^^^--------------------------------------------------- help: try: `let me = &self.tree.get(&node).as_ref().unwrap().borrow();` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/kbucket.rs:83:17 [INFO] [stderr] | [INFO] [stderr] 83 | let ref p = me.prev; [INFO] [stderr] | ----^^^^^----------- help: try: `let p = &me.prev;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/kbucket.rs:84:17 [INFO] [stderr] | [INFO] [stderr] 84 | let ref n = me.next; [INFO] [stderr] | ----^^^^^----------- help: try: `let n = &me.next;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/kbucket.rs:85:40 [INFO] [stderr] | [INFO] [stderr] 85 | if me.next.is_some() { let ref mut x = me.next.as_ref().unwrap().borrow_mut(); x.prev = p.clone(); }; [INFO] [stderr] | ----^^^^^^^^^------------------------------------------ help: try: `let x = &mut me.next.as_ref().unwrap().borrow_mut();` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/kbucket.rs:86:40 [INFO] [stderr] | [INFO] [stderr] 86 | if me.prev.is_some() { let ref mut x = me.prev.as_ref().unwrap().borrow_mut(); x.next = n.clone(); }; [INFO] [stderr] | ----^^^^^^^^^------------------------------------------ help: try: `let x = &mut me.prev.as_ref().unwrap().borrow_mut();` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/kbucket.rs:89:17 [INFO] [stderr] | [INFO] [stderr] 89 | let ref me_opt = self.tree.get(&node); [INFO] [stderr] | ----^^^^^^^^^^------------------------ help: try: `let me_opt = &self.tree.get(&node);` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/kbucket.rs:90:17 [INFO] [stderr] | [INFO] [stderr] 90 | let ref mut me = me_opt.as_ref().unwrap().borrow_mut(); [INFO] [stderr] | ----^^^^^^^^^^----------------------------------------- help: try: `let me = &mut me_opt.as_ref().unwrap().borrow_mut();` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/kbucket.rs:99:17 [INFO] [stderr] | [INFO] [stderr] 99 | let ref mut me_opt = self.tree.get(&node); [INFO] [stderr] | ----^^^^^^^^^^^^^^------------------------ help: try: `let me_opt = &mut self.tree.get(&node);` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/kbucket.rs:106:17 [INFO] [stderr] | [INFO] [stderr] 106 | let ref node = self.tail.as_ref().unwrap().clone(); [INFO] [stderr] | ----^^^^^^^^--------------------------------------- help: try: `let node = &self.tail.as_ref().unwrap().clone();` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/kbucket.rs:107:17 [INFO] [stderr] | [INFO] [stderr] 107 | let ref id = node.borrow().nodeid.clone(); [INFO] [stderr] | ----^^^^^^-------------------------------- help: try: `let id = &node.borrow().nodeid.clone();` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/kbucket.rs:107:26 [INFO] [stderr] | [INFO] [stderr] 107 | let ref id = node.borrow().nodeid.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `node.borrow().nodeid` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/kbucket.rs:113:12 [INFO] [stderr] | [INFO] [stderr] 113 | if self.tree.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.tree.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/kbucket.rs:130:13 [INFO] [stderr] | [INFO] [stderr] 130 | c = c + 1; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `c += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/util.rs:19:47 [INFO] [stderr] | [INFO] [stderr] 19 | assert_eq!(Some(164), parse_hex_bytes("a4".as_bytes())); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"a4"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::string_lit_as_bytes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/util.rs:20:50 [INFO] [stderr] | [INFO] [stderr] 20 | assert_eq!(Some(912559), parse_hex_bytes("decaf".as_bytes())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"decaf"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/util.rs:21:42 [INFO] [stderr] | [INFO] [stderr] 21 | assert_eq!(None, parse_hex_bytes("fudge".as_bytes())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"fudge"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `idunn-dht`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "8cd4002a4f4956e21f3d29888a724a37e8ac29b64766b35993134f7c1005adb2"` [INFO] running `"docker" "rm" "-f" "8cd4002a4f4956e21f3d29888a724a37e8ac29b64766b35993134f7c1005adb2"` [INFO] [stdout] 8cd4002a4f4956e21f3d29888a724a37e8ac29b64766b35993134f7c1005adb2