[INFO] updating cached repository ickshonpe/noughts-and-crosses
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/ickshonpe/noughts-and-crosses
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/ickshonpe/noughts-and-crosses" "work/ex/clippy-test-run/sources/stable/gh/ickshonpe/noughts-and-crosses"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/ickshonpe/noughts-and-crosses'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/ickshonpe/noughts-and-crosses" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ickshonpe/noughts-and-crosses"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ickshonpe/noughts-and-crosses'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] d558e05bbc26bf105e0702e6b775c8ac28293b79
[INFO] sha for GitHub repo ickshonpe/noughts-and-crosses: d558e05bbc26bf105e0702e6b775c8ac28293b79
[INFO] validating manifest of ickshonpe/noughts-and-crosses on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of ickshonpe/noughts-and-crosses on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing ickshonpe/noughts-and-crosses
[INFO] finished frobbing ickshonpe/noughts-and-crosses
[INFO] frobbed toml for ickshonpe/noughts-and-crosses written to work/ex/clippy-test-run/sources/stable/gh/ickshonpe/noughts-and-crosses/Cargo.toml
[INFO] started frobbing ickshonpe/noughts-and-crosses
[INFO] finished frobbing ickshonpe/noughts-and-crosses
[INFO] frobbed toml for ickshonpe/noughts-and-crosses written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ickshonpe/noughts-and-crosses/Cargo.toml
[INFO] crate ickshonpe/noughts-and-crosses has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting ickshonpe/noughts-and-crosses against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ickshonpe/noughts-and-crosses:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 937bd985322f78675ee9b432a1bd93e62854ed6a6f474b53182354023afc9a66
[INFO] running `"docker" "start" "-a" "937bd985322f78675ee9b432a1bd93e62854ed6a6f474b53182354023afc9a66"`
[INFO] [stderr]     Checking noughts-and-crosses v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/main.rs:11:28
[INFO] [stderr]    |
[INFO] [stderr] 11 | fn evaluate_square(square: &Option<Piece>) -> i64 {
[INFO] [stderr]    |                            ^^^^^^^^^^^^^^ help: consider passing by value instead: `Option<Piece>`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `x` is only used to index `board`.
[INFO] [stderr]   --> src/main.rs:34:18
[INFO] [stderr]    |
[INFO] [stderr] 34 |         for x in 0..3 {
[INFO] [stderr]    |                  ^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 34 |         for <item> in &board {
[INFO] [stderr]    |             ^^^^^^    ^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/main.rs:11:28
[INFO] [stderr]    |
[INFO] [stderr] 11 | fn evaluate_square(square: &Option<Piece>) -> i64 {
[INFO] [stderr]    |                            ^^^^^^^^^^^^^^ help: consider passing by value instead: `Option<Piece>`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `x` is only used to index `board`.
[INFO] [stderr]   --> src/main.rs:34:18
[INFO] [stderr]    |
[INFO] [stderr] 34 |         for x in 0..3 {
[INFO] [stderr]    |                  ^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 34 |         for <item> in &board {
[INFO] [stderr]    |             ^^^^^^    ^^^^^^
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 0.95s
[INFO] running `"docker" "inspect" "937bd985322f78675ee9b432a1bd93e62854ed6a6f474b53182354023afc9a66"`
[INFO] running `"docker" "rm" "-f" "937bd985322f78675ee9b432a1bd93e62854ed6a6f474b53182354023afc9a66"`
[INFO] [stdout] 937bd985322f78675ee9b432a1bd93e62854ed6a6f474b53182354023afc9a66