[INFO] updating cached repository icasdri/acslasmc [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/icasdri/acslasmc [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/icasdri/acslasmc" "work/ex/clippy-test-run/sources/stable/gh/icasdri/acslasmc"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/icasdri/acslasmc'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/icasdri/acslasmc" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/icasdri/acslasmc"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/icasdri/acslasmc'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] e579a4de7378f7faaa6968814535560c99f51b1e [INFO] sha for GitHub repo icasdri/acslasmc: e579a4de7378f7faaa6968814535560c99f51b1e [INFO] validating manifest of icasdri/acslasmc on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of icasdri/acslasmc on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing icasdri/acslasmc [INFO] finished frobbing icasdri/acslasmc [INFO] frobbed toml for icasdri/acslasmc written to work/ex/clippy-test-run/sources/stable/gh/icasdri/acslasmc/Cargo.toml [INFO] started frobbing icasdri/acslasmc [INFO] finished frobbing icasdri/acslasmc [INFO] frobbed toml for icasdri/acslasmc written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/icasdri/acslasmc/Cargo.toml [INFO] crate icasdri/acslasmc has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting icasdri/acslasmc against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/icasdri/acslasmc:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 25db8914b2b03c75f241b3f751502e4919a01334eb36a1cadc17506af8f125c8 [INFO] running `"docker" "start" "-a" "25db8914b2b03c75f241b3f751502e4919a01334eb36a1cadc17506af8f125c8"` [INFO] [stderr] Checking acslasmc v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:126:5 [INFO] [stderr] | [INFO] [stderr] 126 | return 0; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `0` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:134:36 [INFO] [stderr] | [INFO] [stderr] 134 | OpcodeType::LocRequired => return trans(var_map, counter, "", comps[0], match comps.get(1) { [INFO] [stderr] | ____________________________________^ [INFO] [stderr] 135 | | None => return Err(format!("missing loc: loc is required for opcode {}", comps[0])), [INFO] [stderr] 136 | | Some(x) => x [INFO] [stderr] 137 | | }), [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 134 | OpcodeType::LocRequired => trans(var_map, counter, "", comps[0], match comps.get(1) { [INFO] [stderr] 135 | None => return Err(format!("missing loc: loc is required for opcode {}", comps[0])), [INFO] [stderr] 136 | Some(x) => x [INFO] [stderr] 137 | }), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:138:40 [INFO] [stderr] | [INFO] [stderr] 138 | OpcodeType::NothingRequired => return trans(var_map, counter, "", comps[0], ""), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `trans(var_map, counter, "", comps[0], "")` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:139:43 [INFO] [stderr] | [INFO] [stderr] 139 | OpcodeType::LocAndLabelRequred => return Err(format!("missing label: label is required for opcode {}", comps[0])), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(format!("missing label: label is required for opcode {}", comps[0]))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:144:73 [INFO] [stderr] | [INFO] [stderr] 144 | OpcodeType::LocRequired | OpcodeType::LocAndLabelRequred => return trans(var_map, counter, comps[0], comps[1], match comps.get(2) { [INFO] [stderr] | _________________________________________________________________________^ [INFO] [stderr] 145 | | Some(x) => x, [INFO] [stderr] 146 | | None => return Err(format!("missing loc: loc is required for opcode {}", comps[1])) [INFO] [stderr] 147 | | }), [INFO] [stderr] | |______________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 144 | OpcodeType::LocRequired | OpcodeType::LocAndLabelRequred => trans(var_map, counter, comps[0], comps[1], match comps.get(2) { [INFO] [stderr] 145 | Some(x) => x, [INFO] [stderr] 146 | None => return Err(format!("missing loc: loc is required for opcode {}", comps[1])) [INFO] [stderr] 147 | }), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:148:44 [INFO] [stderr] | [INFO] [stderr] 148 | OpcodeType::NothingRequired => return trans(var_map, counter, comps[0], comps[1], ""), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `trans(var_map, counter, comps[0], comps[1], "")` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:149:40 [INFO] [stderr] | [INFO] [stderr] 149 | OpcodeType::NotAnOpcode => return Err(format!("invalid opcode: {}", comps[1])) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(format!("invalid opcode: {}", comps[1]))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:126:5 [INFO] [stderr] | [INFO] [stderr] 126 | return 0; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `0` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:134:36 [INFO] [stderr] | [INFO] [stderr] 134 | OpcodeType::LocRequired => return trans(var_map, counter, "", comps[0], match comps.get(1) { [INFO] [stderr] | ____________________________________^ [INFO] [stderr] 135 | | None => return Err(format!("missing loc: loc is required for opcode {}", comps[0])), [INFO] [stderr] 136 | | Some(x) => x [INFO] [stderr] 137 | | }), [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 134 | OpcodeType::LocRequired => trans(var_map, counter, "", comps[0], match comps.get(1) { [INFO] [stderr] 135 | None => return Err(format!("missing loc: loc is required for opcode {}", comps[0])), [INFO] [stderr] 136 | Some(x) => x [INFO] [stderr] 137 | }), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:138:40 [INFO] [stderr] | [INFO] [stderr] 138 | OpcodeType::NothingRequired => return trans(var_map, counter, "", comps[0], ""), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `trans(var_map, counter, "", comps[0], "")` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:139:43 [INFO] [stderr] | [INFO] [stderr] 139 | OpcodeType::LocAndLabelRequred => return Err(format!("missing label: label is required for opcode {}", comps[0])), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(format!("missing label: label is required for opcode {}", comps[0]))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:144:73 [INFO] [stderr] | [INFO] [stderr] 144 | OpcodeType::LocRequired | OpcodeType::LocAndLabelRequred => return trans(var_map, counter, comps[0], comps[1], match comps.get(2) { [INFO] [stderr] | _________________________________________________________________________^ [INFO] [stderr] 145 | | Some(x) => x, [INFO] [stderr] 146 | | None => return Err(format!("missing loc: loc is required for opcode {}", comps[1])) [INFO] [stderr] 147 | | }), [INFO] [stderr] | |______________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 144 | OpcodeType::LocRequired | OpcodeType::LocAndLabelRequred => trans(var_map, counter, comps[0], comps[1], match comps.get(2) { [INFO] [stderr] 145 | Some(x) => x, [INFO] [stderr] 146 | None => return Err(format!("missing loc: loc is required for opcode {}", comps[1])) [INFO] [stderr] 147 | }), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:148:44 [INFO] [stderr] | [INFO] [stderr] 148 | OpcodeType::NothingRequired => return trans(var_map, counter, comps[0], comps[1], ""), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `trans(var_map, counter, comps[0], comps[1], "")` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:149:40 [INFO] [stderr] | [INFO] [stderr] 149 | OpcodeType::NotAnOpcode => return Err(format!("invalid opcode: {}", comps[1])) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(format!("invalid opcode: {}", comps[1]))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/main.rs:102:13 [INFO] [stderr] | [INFO] [stderr] 102 | Err(_) => panic!("Failed to read line!") [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_wild_err_arm)] on by default [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false [INFO] [stderr] --> src/main.rs:98:20 [INFO] [stderr] | [INFO] [stderr] 98 | if bytes_read <= 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::absurd_extreme_comparisons)] on by default [INFO] [stderr] = help: because 0 is the minimum value for this type, the case where the two sides are not equal never occurs, consider using bytes_read == 0 instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#absurd_extreme_comparisons [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:129:25 [INFO] [stderr] | [INFO] [stderr] 129 | fn process_comps(comps: &Vec<&str>, var_map: &mut HashMap, counter: &mut u32) -> Result { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[&str]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:142:32 [INFO] [stderr] | [INFO] [stderr] 142 | None => return Err(format!("missing opcode, only label provided")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"missing opcode, only label provided".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:198:5 [INFO] [stderr] | [INFO] [stderr] 198 | / match var_map.get(&owned_loc) { [INFO] [stderr] 199 | | Some(x) => return *x, [INFO] [stderr] 200 | | None => () [INFO] [stderr] 201 | | } [INFO] [stderr] | |_____^ help: try this: `if let Some(x) = var_map.get(&owned_loc) { return *x }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `acslasmc`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/main.rs:102:13 [INFO] [stderr] | [INFO] [stderr] 102 | Err(_) => panic!("Failed to read line!") [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_wild_err_arm)] on by default [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false [INFO] [stderr] --> src/main.rs:98:20 [INFO] [stderr] | [INFO] [stderr] 98 | if bytes_read <= 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::absurd_extreme_comparisons)] on by default [INFO] [stderr] = help: because 0 is the minimum value for this type, the case where the two sides are not equal never occurs, consider using bytes_read == 0 instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#absurd_extreme_comparisons [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:129:25 [INFO] [stderr] | [INFO] [stderr] 129 | fn process_comps(comps: &Vec<&str>, var_map: &mut HashMap, counter: &mut u32) -> Result { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[&str]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:142:32 [INFO] [stderr] | [INFO] [stderr] 142 | None => return Err(format!("missing opcode, only label provided")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"missing opcode, only label provided".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:198:5 [INFO] [stderr] | [INFO] [stderr] 198 | / match var_map.get(&owned_loc) { [INFO] [stderr] 199 | | Some(x) => return *x, [INFO] [stderr] 200 | | None => () [INFO] [stderr] 201 | | } [INFO] [stderr] | |_____^ help: try this: `if let Some(x) = var_map.get(&owned_loc) { return *x }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `acslasmc`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "25db8914b2b03c75f241b3f751502e4919a01334eb36a1cadc17506af8f125c8"` [INFO] running `"docker" "rm" "-f" "25db8914b2b03c75f241b3f751502e4919a01334eb36a1cadc17506af8f125c8"` [INFO] [stdout] 25db8914b2b03c75f241b3f751502e4919a01334eb36a1cadc17506af8f125c8