[INFO] updating cached repository ianbrault/crisp [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/ianbrault/crisp [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/ianbrault/crisp" "work/ex/clippy-test-run/sources/stable/gh/ianbrault/crisp"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/ianbrault/crisp'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/ianbrault/crisp" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ianbrault/crisp"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ianbrault/crisp'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 73e3b7deb12f5ccb194dfb064907771f4e4a6df3 [INFO] sha for GitHub repo ianbrault/crisp: 73e3b7deb12f5ccb194dfb064907771f4e4a6df3 [INFO] validating manifest of ianbrault/crisp on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ianbrault/crisp on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ianbrault/crisp [INFO] finished frobbing ianbrault/crisp [INFO] frobbed toml for ianbrault/crisp written to work/ex/clippy-test-run/sources/stable/gh/ianbrault/crisp/Cargo.toml [INFO] started frobbing ianbrault/crisp [INFO] finished frobbing ianbrault/crisp [INFO] frobbed toml for ianbrault/crisp written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ianbrault/crisp/Cargo.toml [INFO] crate ianbrault/crisp has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ianbrault/crisp against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ianbrault/crisp:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 3a8d79f162914ec6b6a83d7078dc63ac4e5f1536091e84d669f7825bb7077ad0 [INFO] running `"docker" "start" "-a" "3a8d79f162914ec6b6a83d7078dc63ac4e5f1536091e84d669f7825bb7077ad0"` [INFO] [stderr] Checking crisp v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parse/dfa.rs:119:13 [INFO] [stderr] | [INFO] [stderr] 119 | states: states [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `states` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parse/dfa.rs:119:13 [INFO] [stderr] | [INFO] [stderr] 119 | states: states [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `states` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Int` [INFO] [stderr] --> src/eval.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 21 | Int(i32), [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Float` [INFO] [stderr] --> src/eval.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | Float(f64), [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/parse/dfa.rs:39:32 [INFO] [stderr] | [INFO] [stderr] 39 | pub fn contains(&self, ch: &char) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `char` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `parse::dfa::State` [INFO] [stderr] --> src/parse/dfa.rs:71:5 [INFO] [stderr] | [INFO] [stderr] 71 | / pub fn new() -> State { [INFO] [stderr] 72 | | State { [INFO] [stderr] 73 | | input_groups: vec![], [INFO] [stderr] 74 | | } [INFO] [stderr] 75 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 65 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/parse/dfa.rs:141:31 [INFO] [stderr] | [INFO] [stderr] 141 | pub fn eval(&self, input: &String) -> bool { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/parse/dfa.rs:151:9 [INFO] [stderr] | [INFO] [stderr] 151 | / if self.acc_states.contains(&(curr_state as usize)) { [INFO] [stderr] 152 | | true [INFO] [stderr] 153 | | } else { [INFO] [stderr] 154 | | false [INFO] [stderr] 155 | | } [INFO] [stderr] | |_________^ help: you can reduce it to: `self.acc_states.contains(&(curr_state as usize))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/parse/token.rs:85:24 [INFO] [stderr] | [INFO] [stderr] 85 | pub fn tokenize(input: &String) -> Vec { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/parse/token.rs:92:25 [INFO] [stderr] | [INFO] [stderr] 92 | let ch = &input[curr..curr+1]; [INFO] [stderr] | ^^^^^^^^^^^^ help: use: `curr..=curr` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/parse/type_parser.rs:43:32 [INFO] [stderr] | [INFO] [stderr] 43 | pub fn parse(&self, input: &String) -> TypeID { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/parse/mod.rs:31:5 [INFO] [stderr] | [INFO] [stderr] 31 | / let mut last_token = None; [INFO] [stderr] 32 | | if !tokens.is_empty() { [INFO] [stderr] 33 | | last_token = Some(tokens.last().unwrap().clone()); [INFO] [stderr] 34 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let last_token = if !tokens.is_empty() { Some(tokens.last().unwrap().clone()) } else { None };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/parse/mod.rs:75:30 [INFO] [stderr] | [INFO] [stderr] 75 | fn read_input_file(filename: &String) -> io::Result { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/parse/mod.rs:86:29 [INFO] [stderr] | [INFO] [stderr] 86 | pub fn parse_file(filename: &String) -> Result, Error> { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/syntax.rs:34:9 [INFO] [stderr] | [INFO] [stderr] 34 | / match self { [INFO] [stderr] 35 | | SExpression::Atom { ref mut type_id, .. } => *type_id = tid, [INFO] [stderr] 36 | | _ => () [INFO] [stderr] 37 | | } [INFO] [stderr] | |_________^ help: try this: `if let SExpression::Atom { ref mut type_id, .. } = self { *type_id = tid }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/syntax.rs:55:9 [INFO] [stderr] | [INFO] [stderr] 55 | / match self { [INFO] [stderr] 56 | | SExpression::SExprList(list) => list.push(Box::new(sexpr)), [INFO] [stderr] 57 | | _ => () [INFO] [stderr] 58 | | } [INFO] [stderr] | |_________^ help: try this: `if let SExpression::SExprList(list) = self { list.push(Box::new(sexpr)) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/types/error.rs:60:33 [INFO] [stderr] | [INFO] [stderr] 60 | pub fn file_error(filename: &String, msg: String) -> Error { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Int` [INFO] [stderr] --> src/eval.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 21 | Int(i32), [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Float` [INFO] [stderr] --> src/eval.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | Float(f64), [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/parse/dfa.rs:39:32 [INFO] [stderr] | [INFO] [stderr] 39 | pub fn contains(&self, ch: &char) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `char` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `parse::dfa::State` [INFO] [stderr] --> src/parse/dfa.rs:71:5 [INFO] [stderr] | [INFO] [stderr] 71 | / pub fn new() -> State { [INFO] [stderr] 72 | | State { [INFO] [stderr] 73 | | input_groups: vec![], [INFO] [stderr] 74 | | } [INFO] [stderr] 75 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 65 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/parse/dfa.rs:141:31 [INFO] [stderr] | [INFO] [stderr] 141 | pub fn eval(&self, input: &String) -> bool { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/parse/dfa.rs:151:9 [INFO] [stderr] | [INFO] [stderr] 151 | / if self.acc_states.contains(&(curr_state as usize)) { [INFO] [stderr] 152 | | true [INFO] [stderr] 153 | | } else { [INFO] [stderr] 154 | | false [INFO] [stderr] 155 | | } [INFO] [stderr] | |_________^ help: you can reduce it to: `self.acc_states.contains(&(curr_state as usize))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/parse/token.rs:85:24 [INFO] [stderr] | [INFO] [stderr] 85 | pub fn tokenize(input: &String) -> Vec { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/parse/token.rs:92:25 [INFO] [stderr] | [INFO] [stderr] 92 | let ch = &input[curr..curr+1]; [INFO] [stderr] | ^^^^^^^^^^^^ help: use: `curr..=curr` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/parse/type_parser.rs:43:32 [INFO] [stderr] | [INFO] [stderr] 43 | pub fn parse(&self, input: &String) -> TypeID { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/parse/mod.rs:31:5 [INFO] [stderr] | [INFO] [stderr] 31 | / let mut last_token = None; [INFO] [stderr] 32 | | if !tokens.is_empty() { [INFO] [stderr] 33 | | last_token = Some(tokens.last().unwrap().clone()); [INFO] [stderr] 34 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let last_token = if !tokens.is_empty() { Some(tokens.last().unwrap().clone()) } else { None };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/parse/mod.rs:75:30 [INFO] [stderr] | [INFO] [stderr] 75 | fn read_input_file(filename: &String) -> io::Result { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/parse/mod.rs:86:29 [INFO] [stderr] | [INFO] [stderr] 86 | pub fn parse_file(filename: &String) -> Result, Error> { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/syntax.rs:34:9 [INFO] [stderr] | [INFO] [stderr] 34 | / match self { [INFO] [stderr] 35 | | SExpression::Atom { ref mut type_id, .. } => *type_id = tid, [INFO] [stderr] 36 | | _ => () [INFO] [stderr] 37 | | } [INFO] [stderr] | |_________^ help: try this: `if let SExpression::Atom { ref mut type_id, .. } = self { *type_id = tid }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/syntax.rs:55:9 [INFO] [stderr] | [INFO] [stderr] 55 | / match self { [INFO] [stderr] 56 | | SExpression::SExprList(list) => list.push(Box::new(sexpr)), [INFO] [stderr] 57 | | _ => () [INFO] [stderr] 58 | | } [INFO] [stderr] | |_________^ help: try this: `if let SExpression::SExprList(list) = self { list.push(Box::new(sexpr)) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/types/error.rs:60:33 [INFO] [stderr] | [INFO] [stderr] 60 | pub fn file_error(filename: &String, msg: String) -> Error { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.11s [INFO] running `"docker" "inspect" "3a8d79f162914ec6b6a83d7078dc63ac4e5f1536091e84d669f7825bb7077ad0"` [INFO] running `"docker" "rm" "-f" "3a8d79f162914ec6b6a83d7078dc63ac4e5f1536091e84d669f7825bb7077ad0"` [INFO] [stdout] 3a8d79f162914ec6b6a83d7078dc63ac4e5f1536091e84d669f7825bb7077ad0