[INFO] updating cached repository iamwilhelm/ahayuta [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/iamwilhelm/ahayuta [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/iamwilhelm/ahayuta" "work/ex/clippy-test-run/sources/stable/gh/iamwilhelm/ahayuta"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/iamwilhelm/ahayuta'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/iamwilhelm/ahayuta" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/iamwilhelm/ahayuta"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/iamwilhelm/ahayuta'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 16b0a5547771e22e7e61d982ef81c5e402152f1d [INFO] sha for GitHub repo iamwilhelm/ahayuta: 16b0a5547771e22e7e61d982ef81c5e402152f1d [INFO] validating manifest of iamwilhelm/ahayuta on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of iamwilhelm/ahayuta on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing iamwilhelm/ahayuta [INFO] finished frobbing iamwilhelm/ahayuta [INFO] frobbed toml for iamwilhelm/ahayuta written to work/ex/clippy-test-run/sources/stable/gh/iamwilhelm/ahayuta/Cargo.toml [INFO] started frobbing iamwilhelm/ahayuta [INFO] finished frobbing iamwilhelm/ahayuta [INFO] frobbed toml for iamwilhelm/ahayuta written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/iamwilhelm/ahayuta/Cargo.toml [INFO] crate iamwilhelm/ahayuta has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting iamwilhelm/ahayuta against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/iamwilhelm/ahayuta:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 5d89889582989687d15423895b3d19dc5521507c4f59ce87997bb239eca5d010 [INFO] running `"docker" "start" "-a" "5d89889582989687d15423895b3d19dc5521507c4f59ce87997bb239eca5d010"` [INFO] [stderr] Checking ahayuta v0.0.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/libfab/tree/node.rs:560:9 [INFO] [stderr] | [INFO] [stderr] 560 | opcode: opcode, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `opcode` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/libfab/tree/node.rs:562:9 [INFO] [stderr] | [INFO] [stderr] 562 | results: results, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `results` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:19:5 [INFO] [stderr] | [INFO] [stderr] 19 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/libfab/tree/node.rs:560:9 [INFO] [stderr] | [INFO] [stderr] 560 | opcode: opcode, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `opcode` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/libfab/tree/node.rs:562:9 [INFO] [stderr] | [INFO] [stderr] 562 | results: results, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `results` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:19:5 [INFO] [stderr] | [INFO] [stderr] 19 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/libfab/tree/node.rs:446:16 [INFO] [stderr] | [INFO] [stderr] 446 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 447 | | if lhs.rank > rhs.rank { [INFO] [stderr] 448 | | 1 + lhs.rank [INFO] [stderr] 449 | | } else { [INFO] [stderr] 450 | | 1 + rhs.rank [INFO] [stderr] 451 | | } [INFO] [stderr] 452 | | }, [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 446 | } else if lhs.rank > rhs.rank { [INFO] [stderr] 447 | 1 + lhs.rank [INFO] [stderr] 448 | } else { [INFO] [stderr] 449 | 1 + rhs.rank [INFO] [stderr] 450 | }, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/libfab/tree/node.rs:446:16 [INFO] [stderr] | [INFO] [stderr] 446 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 447 | | if lhs.rank > rhs.rank { [INFO] [stderr] 448 | | 1 + lhs.rank [INFO] [stderr] 449 | | } else { [INFO] [stderr] 450 | | 1 + rhs.rank [INFO] [stderr] 451 | | } [INFO] [stderr] 452 | | }, [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 446 | } else if lhs.rank > rhs.rank { [INFO] [stderr] 447 | 1 + lhs.rank [INFO] [stderr] 448 | } else { [INFO] [stderr] 449 | 1 + rhs.rank [INFO] [stderr] 450 | }, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: defining a method called `clone` on this type; consider implementing the `std::clone::Clone` trait or choosing a less ambiguous name [INFO] [stderr] --> src/libfab/tree/node.rs:52:5 [INFO] [stderr] | [INFO] [stderr] 52 | / pub fn clone(&self) -> Opcode { [INFO] [stderr] 53 | | match *self { [INFO] [stderr] 54 | | Opcode::Add => Opcode::Add, [INFO] [stderr] 55 | | Opcode::Sub => Opcode::Sub, [INFO] [stderr] ... | [INFO] [stderr] 79 | | } [INFO] [stderr] 80 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/libfab/tree/node.rs:96:20 [INFO] [stderr] | [INFO] [stderr] 96 | lower: self.lower.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.lower` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/libfab/tree/node.rs:97:20 [INFO] [stderr] | [INFO] [stderr] 97 | upper: self.upper.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.upper` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/libfab/tree/node.rs:112:16 [INFO] [stderr] | [INFO] [stderr] 112 | f: self.f.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.f` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/libfab/tree/node.rs:118:18 [INFO] [stderr] | [INFO] [stderr] 118 | for i in 0..MIN_VOLUME { [INFO] [stderr] | ^^^^^^^^^^^^^ help: try replacing the loop by: `results.r[..MIN_VOLUME].clone_from_slice(&self.r[..MIN_VOLUME])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::manual_memcpy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/libfab/tree/node.rs:127:19 [INFO] [stderr] | [INFO] [stderr] 127 | n.results.f = value.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try removing the `clone` call: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/libfab/tree/node.rs:128:37 [INFO] [stderr] | [INFO] [stderr] 128 | n.results.i = Interval { lower: value.clone(), upper: value.clone() }; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try removing the `clone` call: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/libfab/tree/node.rs:128:59 [INFO] [stderr] | [INFO] [stderr] 128 | n.results.i = Interval { lower: value.clone(), upper: value.clone() }; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try removing the `clone` call: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/libfab/tree/node.rs:131:26 [INFO] [stderr] | [INFO] [stderr] 131 | n.results.r[q] = value.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try removing the `clone` call: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: defining a method called `clone` on this type; consider implementing the `std::clone::Clone` trait or choosing a less ambiguous name [INFO] [stderr] --> src/libfab/tree/node.rs:166:5 [INFO] [stderr] | [INFO] [stderr] 166 | / pub fn clone(&self) -> Node { [INFO] [stderr] 167 | | let mut clone = Node { [INFO] [stderr] 168 | | opcode: self.opcode.clone(), [INFO] [stderr] 169 | | results: self.results.clone(), [INFO] [stderr] ... | [INFO] [stderr] 194 | | clone [INFO] [stderr] 195 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/libfab/tree/node.rs:171:19 [INFO] [stderr] | [INFO] [stderr] 171 | rank: self.rank.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.rank` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/libfab/tree/node.rs:173:26 [INFO] [stderr] | [INFO] [stderr] 173 | is_constant: self.is_constant.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.is_constant` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/libfab/tree/node.rs:174:25 [INFO] [stderr] | [INFO] [stderr] 174 | is_ignored: self.is_ignored.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.is_ignored` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/libfab/tree/node.rs:175:25 [INFO] [stderr] | [INFO] [stderr] 175 | is_boolean: self.is_boolean.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.is_boolean` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/libfab/tree/node.rs:176:25 [INFO] [stderr] | [INFO] [stderr] 176 | is_in_tree: self.is_in_tree.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.is_in_tree` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/libfab/tree/node.rs:184:9 [INFO] [stderr] | [INFO] [stderr] 184 | / match self.lhs { [INFO] [stderr] 185 | | Some(ref left) => clone.lhs = Option::Some(Box::new((*left).clone())), [INFO] [stderr] 186 | | _ => {}, [INFO] [stderr] 187 | | }; [INFO] [stderr] | |_________^ help: try this: `if let Some(ref left) = self.lhs { clone.lhs = Option::Some(Box::new((*left).clone())) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/libfab/tree/node.rs:189:9 [INFO] [stderr] | [INFO] [stderr] 189 | / match self.rhs { [INFO] [stderr] 190 | | Some(ref right) => clone.rhs = Option::Some(Box::new((*right).clone())), [INFO] [stderr] 191 | | _ => {}, [INFO] [stderr] 192 | | }; [INFO] [stderr] | |_________^ help: try this: `if let Some(ref right) = self.rhs { clone.rhs = Option::Some(Box::new((*right).clone())) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 26 [INFO] [stderr] --> src/libfab/tree/node.rs:197:5 [INFO] [stderr] | [INFO] [stderr] 197 | / pub fn print(&self) { [INFO] [stderr] 198 | | match self.opcode { [INFO] [stderr] 199 | | Opcode::Add => { [INFO] [stderr] 200 | | print!("("); [INFO] [stderr] ... | [INFO] [stderr] 426 | | } [INFO] [stderr] 427 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/libfab/tree/node.rs:201:17 [INFO] [stderr] | [INFO] [stderr] 201 | / match self.lhs { [INFO] [stderr] 202 | | Some(ref node) => { [INFO] [stderr] 203 | | node.print(); [INFO] [stderr] 204 | | }, [INFO] [stderr] 205 | | _ => { }, [INFO] [stderr] 206 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 201 | if let Some(ref node) = self.lhs { [INFO] [stderr] 202 | node.print(); [INFO] [stderr] 203 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/libfab/tree/node.rs:208:17 [INFO] [stderr] | [INFO] [stderr] 208 | / match self.rhs { [INFO] [stderr] 209 | | Some(ref node) => { [INFO] [stderr] 210 | | node.print(); [INFO] [stderr] 211 | | }, [INFO] [stderr] 212 | | _ => { }, [INFO] [stderr] 213 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 208 | if let Some(ref node) = self.rhs { [INFO] [stderr] 209 | node.print(); [INFO] [stderr] 210 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/libfab/tree/node.rs:218:17 [INFO] [stderr] | [INFO] [stderr] 218 | / match self.lhs { [INFO] [stderr] 219 | | Some(ref node) => { [INFO] [stderr] 220 | | node.print(); [INFO] [stderr] 221 | | }, [INFO] [stderr] 222 | | _ => { }, [INFO] [stderr] 223 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 218 | if let Some(ref node) = self.lhs { [INFO] [stderr] 219 | node.print(); [INFO] [stderr] 220 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/libfab/tree/node.rs:225:17 [INFO] [stderr] | [INFO] [stderr] 225 | / match self.rhs { [INFO] [stderr] 226 | | Some(ref node) => { [INFO] [stderr] 227 | | node.print(); [INFO] [stderr] 228 | | }, [INFO] [stderr] 229 | | _ => { }, [INFO] [stderr] 230 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 225 | if let Some(ref node) = self.rhs { [INFO] [stderr] 226 | node.print(); [INFO] [stderr] 227 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/libfab/tree/node.rs:235:17 [INFO] [stderr] | [INFO] [stderr] 235 | / match self.lhs { [INFO] [stderr] 236 | | Some(ref node) => { [INFO] [stderr] 237 | | node.print(); [INFO] [stderr] 238 | | }, [INFO] [stderr] 239 | | _ => { }, [INFO] [stderr] 240 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 235 | if let Some(ref node) = self.lhs { [INFO] [stderr] 236 | node.print(); [INFO] [stderr] 237 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/libfab/tree/node.rs:242:17 [INFO] [stderr] | [INFO] [stderr] 242 | / match self.rhs { [INFO] [stderr] 243 | | Some(ref node) => { [INFO] [stderr] 244 | | node.print(); [INFO] [stderr] 245 | | }, [INFO] [stderr] 246 | | _ => { }, [INFO] [stderr] 247 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 242 | if let Some(ref node) = self.rhs { [INFO] [stderr] 243 | node.print(); [INFO] [stderr] 244 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/libfab/tree/node.rs:252:17 [INFO] [stderr] | [INFO] [stderr] 252 | / match self.lhs { [INFO] [stderr] 253 | | Some(ref node) => { [INFO] [stderr] 254 | | node.print(); [INFO] [stderr] 255 | | }, [INFO] [stderr] 256 | | _ => { }, [INFO] [stderr] 257 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 252 | if let Some(ref node) = self.lhs { [INFO] [stderr] 253 | node.print(); [INFO] [stderr] 254 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/libfab/tree/node.rs:259:17 [INFO] [stderr] | [INFO] [stderr] 259 | / match self.rhs { [INFO] [stderr] 260 | | Some(ref node) => { [INFO] [stderr] 261 | | node.print(); [INFO] [stderr] 262 | | }, [INFO] [stderr] 263 | | _ => { }, [INFO] [stderr] 264 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 259 | if let Some(ref node) = self.rhs { [INFO] [stderr] 260 | node.print(); [INFO] [stderr] 261 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/libfab/tree/node.rs:269:17 [INFO] [stderr] | [INFO] [stderr] 269 | / match self.lhs { [INFO] [stderr] 270 | | Some(ref node) => { [INFO] [stderr] 271 | | node.print(); [INFO] [stderr] 272 | | }, [INFO] [stderr] 273 | | _ => { }, [INFO] [stderr] 274 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 269 | if let Some(ref node) = self.lhs { [INFO] [stderr] 270 | node.print(); [INFO] [stderr] 271 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/libfab/tree/node.rs:276:17 [INFO] [stderr] | [INFO] [stderr] 276 | / match self.rhs { [INFO] [stderr] 277 | | Some(ref node) => { [INFO] [stderr] 278 | | node.print(); [INFO] [stderr] 279 | | }, [INFO] [stderr] 280 | | _ => { }, [INFO] [stderr] 281 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 276 | if let Some(ref node) = self.rhs { [INFO] [stderr] 277 | node.print(); [INFO] [stderr] 278 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/libfab/tree/node.rs:286:17 [INFO] [stderr] | [INFO] [stderr] 286 | / match self.lhs { [INFO] [stderr] 287 | | Some(ref node) => { [INFO] [stderr] 288 | | node.print(); [INFO] [stderr] 289 | | }, [INFO] [stderr] 290 | | _ => { }, [INFO] [stderr] 291 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 286 | if let Some(ref node) = self.lhs { [INFO] [stderr] 287 | node.print(); [INFO] [stderr] 288 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/libfab/tree/node.rs:293:17 [INFO] [stderr] | [INFO] [stderr] 293 | / match self.rhs { [INFO] [stderr] 294 | | Some(ref node) => { [INFO] [stderr] 295 | | node.print(); [INFO] [stderr] 296 | | }, [INFO] [stderr] 297 | | _ => { }, [INFO] [stderr] 298 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 293 | if let Some(ref node) = self.rhs { [INFO] [stderr] 294 | node.print(); [INFO] [stderr] 295 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/libfab/tree/node.rs:303:17 [INFO] [stderr] | [INFO] [stderr] 303 | / match self.lhs { [INFO] [stderr] 304 | | Some(ref node) => { [INFO] [stderr] 305 | | node.print(); [INFO] [stderr] 306 | | }, [INFO] [stderr] 307 | | _ => { }, [INFO] [stderr] 308 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 303 | if let Some(ref node) = self.lhs { [INFO] [stderr] 304 | node.print(); [INFO] [stderr] 305 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/libfab/tree/node.rs:310:17 [INFO] [stderr] | [INFO] [stderr] 310 | / match self.rhs { [INFO] [stderr] 311 | | Some(ref node) => { [INFO] [stderr] 312 | | node.print(); [INFO] [stderr] 313 | | }, [INFO] [stderr] 314 | | _ => { }, [INFO] [stderr] 315 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 310 | if let Some(ref node) = self.rhs { [INFO] [stderr] 311 | node.print(); [INFO] [stderr] 312 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/libfab/tree/node.rs:320:17 [INFO] [stderr] | [INFO] [stderr] 320 | / match self.lhs { [INFO] [stderr] 321 | | Some(ref node) => { [INFO] [stderr] 322 | | print!("abs("); [INFO] [stderr] 323 | | node.print(); [INFO] [stderr] ... | [INFO] [stderr] 326 | | _ => { }, [INFO] [stderr] 327 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 320 | if let Some(ref node) = self.lhs { [INFO] [stderr] 321 | print!("abs("); [INFO] [stderr] 322 | node.print(); [INFO] [stderr] 323 | print!(")"); [INFO] [stderr] 324 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/libfab/tree/node.rs:330:17 [INFO] [stderr] | [INFO] [stderr] 330 | / match self.lhs { [INFO] [stderr] 331 | | Some(ref node) => { [INFO] [stderr] 332 | | print!("square("); [INFO] [stderr] 333 | | node.print(); [INFO] [stderr] ... | [INFO] [stderr] 336 | | _ => { }, [INFO] [stderr] 337 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 330 | if let Some(ref node) = self.lhs { [INFO] [stderr] 331 | print!("square("); [INFO] [stderr] 332 | node.print(); [INFO] [stderr] 333 | print!(")"); [INFO] [stderr] 334 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/libfab/tree/node.rs:340:17 [INFO] [stderr] | [INFO] [stderr] 340 | / match self.lhs { [INFO] [stderr] 341 | | Some(ref node) => { [INFO] [stderr] 342 | | print!("sqrt("); [INFO] [stderr] 343 | | node.print(); [INFO] [stderr] ... | [INFO] [stderr] 346 | | _ => { }, [INFO] [stderr] 347 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 340 | if let Some(ref node) = self.lhs { [INFO] [stderr] 341 | print!("sqrt("); [INFO] [stderr] 342 | node.print(); [INFO] [stderr] 343 | print!(")"); [INFO] [stderr] 344 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/libfab/tree/node.rs:350:17 [INFO] [stderr] | [INFO] [stderr] 350 | / match self.lhs { [INFO] [stderr] 351 | | Some(ref node) => { [INFO] [stderr] 352 | | print!("sin("); [INFO] [stderr] 353 | | node.print(); [INFO] [stderr] ... | [INFO] [stderr] 356 | | _ => { }, [INFO] [stderr] 357 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 350 | if let Some(ref node) = self.lhs { [INFO] [stderr] 351 | print!("sin("); [INFO] [stderr] 352 | node.print(); [INFO] [stderr] 353 | print!(")"); [INFO] [stderr] 354 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/libfab/tree/node.rs:360:17 [INFO] [stderr] | [INFO] [stderr] 360 | / match self.lhs { [INFO] [stderr] 361 | | Some(ref node) => { [INFO] [stderr] 362 | | print!("cos("); [INFO] [stderr] 363 | | node.print(); [INFO] [stderr] ... | [INFO] [stderr] 366 | | _ => { }, [INFO] [stderr] 367 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 360 | if let Some(ref node) = self.lhs { [INFO] [stderr] 361 | print!("cos("); [INFO] [stderr] 362 | node.print(); [INFO] [stderr] 363 | print!(")"); [INFO] [stderr] 364 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/libfab/tree/node.rs:370:17 [INFO] [stderr] | [INFO] [stderr] 370 | / match self.lhs { [INFO] [stderr] 371 | | Some(ref node) => { [INFO] [stderr] 372 | | print!("tan("); [INFO] [stderr] 373 | | node.print(); [INFO] [stderr] ... | [INFO] [stderr] 376 | | _ => { }, [INFO] [stderr] 377 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 370 | if let Some(ref node) = self.lhs { [INFO] [stderr] 371 | print!("tan("); [INFO] [stderr] 372 | node.print(); [INFO] [stderr] 373 | print!(")"); [INFO] [stderr] 374 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/libfab/tree/node.rs:380:17 [INFO] [stderr] | [INFO] [stderr] 380 | / match self.lhs { [INFO] [stderr] 381 | | Some(ref node) => { [INFO] [stderr] 382 | | print!("arcsin("); [INFO] [stderr] 383 | | node.print(); [INFO] [stderr] ... | [INFO] [stderr] 386 | | _ => { }, [INFO] [stderr] 387 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 380 | if let Some(ref node) = self.lhs { [INFO] [stderr] 381 | print!("arcsin("); [INFO] [stderr] 382 | node.print(); [INFO] [stderr] 383 | print!(")"); [INFO] [stderr] 384 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/libfab/tree/node.rs:390:17 [INFO] [stderr] | [INFO] [stderr] 390 | / match self.lhs { [INFO] [stderr] 391 | | Some(ref node) => { [INFO] [stderr] 392 | | print!("arccos("); [INFO] [stderr] 393 | | node.print(); [INFO] [stderr] ... | [INFO] [stderr] 396 | | _ => { }, [INFO] [stderr] 397 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 390 | if let Some(ref node) = self.lhs { [INFO] [stderr] 391 | print!("arccos("); [INFO] [stderr] 392 | node.print(); [INFO] [stderr] 393 | print!(")"); [INFO] [stderr] 394 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/libfab/tree/node.rs:400:17 [INFO] [stderr] | [INFO] [stderr] 400 | / match self.lhs { [INFO] [stderr] 401 | | Some(ref node) => { [INFO] [stderr] 402 | | print!("arctan("); [INFO] [stderr] 403 | | node.print(); [INFO] [stderr] ... | [INFO] [stderr] 406 | | _ => { }, [INFO] [stderr] 407 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 400 | if let Some(ref node) = self.lhs { [INFO] [stderr] 401 | print!("arctan("); [INFO] [stderr] 402 | node.print(); [INFO] [stderr] 403 | print!(")"); [INFO] [stderr] 404 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/libfab/tree/node.rs:410:17 [INFO] [stderr] | [INFO] [stderr] 410 | / match self.lhs { [INFO] [stderr] 411 | | Some(ref node) => { [INFO] [stderr] 412 | | print!("-"); [INFO] [stderr] 413 | | node.print(); [INFO] [stderr] 414 | | }, [INFO] [stderr] 415 | | _ => { }, [INFO] [stderr] 416 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 410 | if let Some(ref node) = self.lhs { [INFO] [stderr] 411 | print!("-"); [INFO] [stderr] 412 | node.print(); [INFO] [stderr] 413 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/libfab/tree/node.rs:454:22 [INFO] [stderr] | [INFO] [stderr] 454 | is_constant: is_const.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `is_const` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/libfab/tree/node.rs:510:22 [INFO] [stderr] | [INFO] [stderr] 510 | is_constant: arg.is_constant.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `arg.is_constant` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: defining a method called `clone` on this type; consider implementing the `std::clone::Clone` trait or choosing a less ambiguous name [INFO] [stderr] --> src/libfab/tree/node.rs:52:5 [INFO] [stderr] | [INFO] [stderr] 52 | / pub fn clone(&self) -> Opcode { [INFO] [stderr] 53 | | match *self { [INFO] [stderr] 54 | | Opcode::Add => Opcode::Add, [INFO] [stderr] 55 | | Opcode::Sub => Opcode::Sub, [INFO] [stderr] ... | [INFO] [stderr] 79 | | } [INFO] [stderr] 80 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/libfab/tree/node.rs:96:20 [INFO] [stderr] | [INFO] [stderr] 96 | lower: self.lower.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.lower` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/libfab/tree/node.rs:97:20 [INFO] [stderr] | [INFO] [stderr] 97 | upper: self.upper.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.upper` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/libfab/tree/node.rs:112:16 [INFO] [stderr] | [INFO] [stderr] 112 | f: self.f.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.f` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/libfab/tree/node.rs:118:18 [INFO] [stderr] | [INFO] [stderr] 118 | for i in 0..MIN_VOLUME { [INFO] [stderr] | ^^^^^^^^^^^^^ help: try replacing the loop by: `results.r[..MIN_VOLUME].clone_from_slice(&self.r[..MIN_VOLUME])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::manual_memcpy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/libfab/tree/node.rs:127:19 [INFO] [stderr] | [INFO] [stderr] 127 | n.results.f = value.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try removing the `clone` call: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/libfab/tree/node.rs:128:37 [INFO] [stderr] | [INFO] [stderr] 128 | n.results.i = Interval { lower: value.clone(), upper: value.clone() }; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try removing the `clone` call: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/libfab/tree/node.rs:128:59 [INFO] [stderr] | [INFO] [stderr] 128 | n.results.i = Interval { lower: value.clone(), upper: value.clone() }; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try removing the `clone` call: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/libfab/tree/node.rs:131:26 [INFO] [stderr] | [INFO] [stderr] 131 | n.results.r[q] = value.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try removing the `clone` call: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: defining a method called `clone` on this type; consider implementing the `std::clone::Clone` trait or choosing a less ambiguous name [INFO] [stderr] --> src/libfab/tree/node.rs:166:5 [INFO] [stderr] | [INFO] [stderr] 166 | / pub fn clone(&self) -> Node { [INFO] [stderr] 167 | | let mut clone = Node { [INFO] [stderr] 168 | | opcode: self.opcode.clone(), [INFO] [stderr] 169 | | results: self.results.clone(), [INFO] [stderr] ... | [INFO] [stderr] 194 | | clone [INFO] [stderr] 195 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/libfab/tree/node.rs:171:19 [INFO] [stderr] | [INFO] [stderr] 171 | rank: self.rank.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.rank` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/libfab/tree/node.rs:173:26 [INFO] [stderr] | [INFO] [stderr] 173 | is_constant: self.is_constant.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.is_constant` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/libfab/tree/node.rs:174:25 [INFO] [stderr] | [INFO] [stderr] 174 | is_ignored: self.is_ignored.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.is_ignored` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/libfab/tree/node.rs:175:25 [INFO] [stderr] | [INFO] [stderr] 175 | is_boolean: self.is_boolean.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.is_boolean` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/libfab/tree/node.rs:176:25 [INFO] [stderr] | [INFO] [stderr] 176 | is_in_tree: self.is_in_tree.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.is_in_tree` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/libfab/tree/node.rs:184:9 [INFO] [stderr] | [INFO] [stderr] 184 | / match self.lhs { [INFO] [stderr] 185 | | Some(ref left) => clone.lhs = Option::Some(Box::new((*left).clone())), [INFO] [stderr] 186 | | _ => {}, [INFO] [stderr] 187 | | }; [INFO] [stderr] | |_________^ help: try this: `if let Some(ref left) = self.lhs { clone.lhs = Option::Some(Box::new((*left).clone())) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/libfab/tree/node.rs:189:9 [INFO] [stderr] | [INFO] [stderr] 189 | / match self.rhs { [INFO] [stderr] 190 | | Some(ref right) => clone.rhs = Option::Some(Box::new((*right).clone())), [INFO] [stderr] 191 | | _ => {}, [INFO] [stderr] 192 | | }; [INFO] [stderr] | |_________^ help: try this: `if let Some(ref right) = self.rhs { clone.rhs = Option::Some(Box::new((*right).clone())) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 26 [INFO] [stderr] --> src/libfab/tree/node.rs:197:5 [INFO] [stderr] | [INFO] [stderr] 197 | / pub fn print(&self) { [INFO] [stderr] 198 | | match self.opcode { [INFO] [stderr] 199 | | Opcode::Add => { [INFO] [stderr] 200 | | print!("("); [INFO] [stderr] ... | [INFO] [stderr] 426 | | } [INFO] [stderr] 427 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/libfab/tree/node.rs:201:17 [INFO] [stderr] | [INFO] [stderr] 201 | / match self.lhs { [INFO] [stderr] 202 | | Some(ref node) => { [INFO] [stderr] 203 | | node.print(); [INFO] [stderr] 204 | | }, [INFO] [stderr] 205 | | _ => { }, [INFO] [stderr] 206 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 201 | if let Some(ref node) = self.lhs { [INFO] [stderr] 202 | node.print(); [INFO] [stderr] 203 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/libfab/tree/node.rs:208:17 [INFO] [stderr] | [INFO] [stderr] 208 | / match self.rhs { [INFO] [stderr] 209 | | Some(ref node) => { [INFO] [stderr] 210 | | node.print(); [INFO] [stderr] 211 | | }, [INFO] [stderr] 212 | | _ => { }, [INFO] [stderr] 213 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 208 | if let Some(ref node) = self.rhs { [INFO] [stderr] 209 | node.print(); [INFO] [stderr] 210 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/libfab/tree/node.rs:218:17 [INFO] [stderr] | [INFO] [stderr] 218 | / match self.lhs { [INFO] [stderr] 219 | | Some(ref node) => { [INFO] [stderr] 220 | | node.print(); [INFO] [stderr] 221 | | }, [INFO] [stderr] 222 | | _ => { }, [INFO] [stderr] 223 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 218 | if let Some(ref node) = self.lhs { [INFO] [stderr] 219 | node.print(); [INFO] [stderr] 220 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/libfab/tree/node.rs:225:17 [INFO] [stderr] | [INFO] [stderr] 225 | / match self.rhs { [INFO] [stderr] 226 | | Some(ref node) => { [INFO] [stderr] 227 | | node.print(); [INFO] [stderr] 228 | | }, [INFO] [stderr] 229 | | _ => { }, [INFO] [stderr] 230 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 225 | if let Some(ref node) = self.rhs { [INFO] [stderr] 226 | node.print(); [INFO] [stderr] 227 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/libfab/tree/node.rs:235:17 [INFO] [stderr] | [INFO] [stderr] 235 | / match self.lhs { [INFO] [stderr] 236 | | Some(ref node) => { [INFO] [stderr] 237 | | node.print(); [INFO] [stderr] 238 | | }, [INFO] [stderr] 239 | | _ => { }, [INFO] [stderr] 240 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 235 | if let Some(ref node) = self.lhs { [INFO] [stderr] 236 | node.print(); [INFO] [stderr] 237 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/libfab/tree/node.rs:242:17 [INFO] [stderr] | [INFO] [stderr] 242 | / match self.rhs { [INFO] [stderr] 243 | | Some(ref node) => { [INFO] [stderr] 244 | | node.print(); [INFO] [stderr] 245 | | }, [INFO] [stderr] 246 | | _ => { }, [INFO] [stderr] 247 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 242 | if let Some(ref node) = self.rhs { [INFO] [stderr] 243 | node.print(); [INFO] [stderr] 244 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/libfab/tree/node.rs:252:17 [INFO] [stderr] | [INFO] [stderr] 252 | / match self.lhs { [INFO] [stderr] 253 | | Some(ref node) => { [INFO] [stderr] 254 | | node.print(); [INFO] [stderr] 255 | | }, [INFO] [stderr] 256 | | _ => { }, [INFO] [stderr] 257 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 252 | if let Some(ref node) = self.lhs { [INFO] [stderr] 253 | node.print(); [INFO] [stderr] 254 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/libfab/tree/node.rs:259:17 [INFO] [stderr] | [INFO] [stderr] 259 | / match self.rhs { [INFO] [stderr] 260 | | Some(ref node) => { [INFO] [stderr] 261 | | node.print(); [INFO] [stderr] 262 | | }, [INFO] [stderr] 263 | | _ => { }, [INFO] [stderr] 264 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 259 | if let Some(ref node) = self.rhs { [INFO] [stderr] 260 | node.print(); [INFO] [stderr] 261 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/libfab/tree/node.rs:269:17 [INFO] [stderr] | [INFO] [stderr] 269 | / match self.lhs { [INFO] [stderr] 270 | | Some(ref node) => { [INFO] [stderr] 271 | | node.print(); [INFO] [stderr] 272 | | }, [INFO] [stderr] 273 | | _ => { }, [INFO] [stderr] 274 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 269 | if let Some(ref node) = self.lhs { [INFO] [stderr] 270 | node.print(); [INFO] [stderr] 271 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/libfab/tree/node.rs:276:17 [INFO] [stderr] | [INFO] [stderr] 276 | / match self.rhs { [INFO] [stderr] 277 | | Some(ref node) => { [INFO] [stderr] 278 | | node.print(); [INFO] [stderr] 279 | | }, [INFO] [stderr] 280 | | _ => { }, [INFO] [stderr] 281 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 276 | if let Some(ref node) = self.rhs { [INFO] [stderr] 277 | node.print(); [INFO] [stderr] 278 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/libfab/tree/node.rs:286:17 [INFO] [stderr] | [INFO] [stderr] 286 | / match self.lhs { [INFO] [stderr] 287 | | Some(ref node) => { [INFO] [stderr] 288 | | node.print(); [INFO] [stderr] 289 | | }, [INFO] [stderr] 290 | | _ => { }, [INFO] [stderr] 291 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 286 | if let Some(ref node) = self.lhs { [INFO] [stderr] 287 | node.print(); [INFO] [stderr] 288 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/libfab/tree/node.rs:293:17 [INFO] [stderr] | [INFO] [stderr] 293 | / match self.rhs { [INFO] [stderr] 294 | | Some(ref node) => { [INFO] [stderr] 295 | | node.print(); [INFO] [stderr] 296 | | }, [INFO] [stderr] 297 | | _ => { }, [INFO] [stderr] 298 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 293 | if let Some(ref node) = self.rhs { [INFO] [stderr] 294 | node.print(); [INFO] [stderr] 295 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/libfab/tree/node.rs:303:17 [INFO] [stderr] | [INFO] [stderr] 303 | / match self.lhs { [INFO] [stderr] 304 | | Some(ref node) => { [INFO] [stderr] 305 | | node.print(); [INFO] [stderr] 306 | | }, [INFO] [stderr] 307 | | _ => { }, [INFO] [stderr] 308 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 303 | if let Some(ref node) = self.lhs { [INFO] [stderr] 304 | node.print(); [INFO] [stderr] 305 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/libfab/tree/node.rs:310:17 [INFO] [stderr] | [INFO] [stderr] 310 | / match self.rhs { [INFO] [stderr] 311 | | Some(ref node) => { [INFO] [stderr] 312 | | node.print(); [INFO] [stderr] 313 | | }, [INFO] [stderr] 314 | | _ => { }, [INFO] [stderr] 315 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 310 | if let Some(ref node) = self.rhs { [INFO] [stderr] 311 | node.print(); [INFO] [stderr] 312 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/libfab/tree/node.rs:320:17 [INFO] [stderr] | [INFO] [stderr] 320 | / match self.lhs { [INFO] [stderr] 321 | | Some(ref node) => { [INFO] [stderr] 322 | | print!("abs("); [INFO] [stderr] 323 | | node.print(); [INFO] [stderr] ... | [INFO] [stderr] 326 | | _ => { }, [INFO] [stderr] 327 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 320 | if let Some(ref node) = self.lhs { [INFO] [stderr] 321 | print!("abs("); [INFO] [stderr] 322 | node.print(); [INFO] [stderr] 323 | print!(")"); [INFO] [stderr] 324 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/libfab/tree/node.rs:330:17 [INFO] [stderr] | [INFO] [stderr] 330 | / match self.lhs { [INFO] [stderr] 331 | | Some(ref node) => { [INFO] [stderr] 332 | | print!("square("); [INFO] [stderr] 333 | | node.print(); [INFO] [stderr] ... | [INFO] [stderr] 336 | | _ => { }, [INFO] [stderr] 337 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 330 | if let Some(ref node) = self.lhs { [INFO] [stderr] 331 | print!("square("); [INFO] [stderr] 332 | node.print(); [INFO] [stderr] 333 | print!(")"); [INFO] [stderr] 334 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/libfab/tree/node.rs:340:17 [INFO] [stderr] | [INFO] [stderr] 340 | / match self.lhs { [INFO] [stderr] 341 | | Some(ref node) => { [INFO] [stderr] 342 | | print!("sqrt("); [INFO] [stderr] 343 | | node.print(); [INFO] [stderr] ... | [INFO] [stderr] 346 | | _ => { }, [INFO] [stderr] 347 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 340 | if let Some(ref node) = self.lhs { [INFO] [stderr] 341 | print!("sqrt("); [INFO] [stderr] 342 | node.print(); [INFO] [stderr] 343 | print!(")"); [INFO] [stderr] 344 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/libfab/tree/node.rs:350:17 [INFO] [stderr] | [INFO] [stderr] 350 | / match self.lhs { [INFO] [stderr] 351 | | Some(ref node) => { [INFO] [stderr] 352 | | print!("sin("); [INFO] [stderr] 353 | | node.print(); [INFO] [stderr] ... | [INFO] [stderr] 356 | | _ => { }, [INFO] [stderr] 357 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 350 | if let Some(ref node) = self.lhs { [INFO] [stderr] 351 | print!("sin("); [INFO] [stderr] 352 | node.print(); [INFO] [stderr] 353 | print!(")"); [INFO] [stderr] 354 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/libfab/tree/node.rs:360:17 [INFO] [stderr] | [INFO] [stderr] 360 | / match self.lhs { [INFO] [stderr] 361 | | Some(ref node) => { [INFO] [stderr] 362 | | print!("cos("); [INFO] [stderr] 363 | | node.print(); [INFO] [stderr] ... | [INFO] [stderr] 366 | | _ => { }, [INFO] [stderr] 367 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 360 | if let Some(ref node) = self.lhs { [INFO] [stderr] 361 | print!("cos("); [INFO] [stderr] 362 | node.print(); [INFO] [stderr] 363 | print!(")"); [INFO] [stderr] 364 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/libfab/tree/node.rs:370:17 [INFO] [stderr] | [INFO] [stderr] 370 | / match self.lhs { [INFO] [stderr] 371 | | Some(ref node) => { [INFO] [stderr] 372 | | print!("tan("); [INFO] [stderr] 373 | | node.print(); [INFO] [stderr] ... | [INFO] [stderr] 376 | | _ => { }, [INFO] [stderr] 377 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 370 | if let Some(ref node) = self.lhs { [INFO] [stderr] 371 | print!("tan("); [INFO] [stderr] 372 | node.print(); [INFO] [stderr] 373 | print!(")"); [INFO] [stderr] 374 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/libfab/tree/node.rs:380:17 [INFO] [stderr] | [INFO] [stderr] 380 | / match self.lhs { [INFO] [stderr] 381 | | Some(ref node) => { [INFO] [stderr] 382 | | print!("arcsin("); [INFO] [stderr] 383 | | node.print(); [INFO] [stderr] ... | [INFO] [stderr] 386 | | _ => { }, [INFO] [stderr] 387 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 380 | if let Some(ref node) = self.lhs { [INFO] [stderr] 381 | print!("arcsin("); [INFO] [stderr] 382 | node.print(); [INFO] [stderr] 383 | print!(")"); [INFO] [stderr] 384 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/libfab/tree/node.rs:390:17 [INFO] [stderr] | [INFO] [stderr] 390 | / match self.lhs { [INFO] [stderr] 391 | | Some(ref node) => { [INFO] [stderr] 392 | | print!("arccos("); [INFO] [stderr] 393 | | node.print(); [INFO] [stderr] ... | [INFO] [stderr] 396 | | _ => { }, [INFO] [stderr] 397 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 390 | if let Some(ref node) = self.lhs { [INFO] [stderr] 391 | print!("arccos("); [INFO] [stderr] 392 | node.print(); [INFO] [stderr] 393 | print!(")"); [INFO] [stderr] 394 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/libfab/tree/node.rs:400:17 [INFO] [stderr] | [INFO] [stderr] 400 | / match self.lhs { [INFO] [stderr] 401 | | Some(ref node) => { [INFO] [stderr] 402 | | print!("arctan("); [INFO] [stderr] 403 | | node.print(); [INFO] [stderr] ... | [INFO] [stderr] 406 | | _ => { }, [INFO] [stderr] 407 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 400 | if let Some(ref node) = self.lhs { [INFO] [stderr] 401 | print!("arctan("); [INFO] [stderr] 402 | node.print(); [INFO] [stderr] 403 | print!(")"); [INFO] [stderr] 404 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/libfab/tree/node.rs:410:17 [INFO] [stderr] | [INFO] [stderr] 410 | / match self.lhs { [INFO] [stderr] 411 | | Some(ref node) => { [INFO] [stderr] 412 | | print!("-"); [INFO] [stderr] 413 | | node.print(); [INFO] [stderr] 414 | | }, [INFO] [stderr] 415 | | _ => { }, [INFO] [stderr] 416 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 410 | if let Some(ref node) = self.lhs { [INFO] [stderr] 411 | print!("-"); [INFO] [stderr] 412 | node.print(); [INFO] [stderr] 413 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/libfab/tree/node.rs:454:22 [INFO] [stderr] | [INFO] [stderr] 454 | is_constant: is_const.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `is_const` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/libfab/tree/node.rs:510:22 [INFO] [stderr] | [INFO] [stderr] 510 | is_constant: arg.is_constant.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `arg.is_constant` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.69s [INFO] running `"docker" "inspect" "5d89889582989687d15423895b3d19dc5521507c4f59ce87997bb239eca5d010"` [INFO] running `"docker" "rm" "-f" "5d89889582989687d15423895b3d19dc5521507c4f59ce87997bb239eca5d010"` [INFO] [stdout] 5d89889582989687d15423895b3d19dc5521507c4f59ce87997bb239eca5d010