[INFO] updating cached repository iamlotus/jthreadpool [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/iamlotus/jthreadpool [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/iamlotus/jthreadpool" "work/ex/clippy-test-run/sources/stable/gh/iamlotus/jthreadpool"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/iamlotus/jthreadpool'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/iamlotus/jthreadpool" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/iamlotus/jthreadpool"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/iamlotus/jthreadpool'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 224fcdbafdadcf6168d93f217579cafa3558570c [INFO] sha for GitHub repo iamlotus/jthreadpool: 224fcdbafdadcf6168d93f217579cafa3558570c [INFO] validating manifest of iamlotus/jthreadpool on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of iamlotus/jthreadpool on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing iamlotus/jthreadpool [INFO] finished frobbing iamlotus/jthreadpool [INFO] frobbed toml for iamlotus/jthreadpool written to work/ex/clippy-test-run/sources/stable/gh/iamlotus/jthreadpool/Cargo.toml [INFO] started frobbing iamlotus/jthreadpool [INFO] finished frobbing iamlotus/jthreadpool [INFO] frobbed toml for iamlotus/jthreadpool written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/iamlotus/jthreadpool/Cargo.toml [INFO] crate iamlotus/jthreadpool has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting iamlotus/jthreadpool against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/iamlotus/jthreadpool:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a8d6c1863b599fd8dd4e14938902bdc2c238332458731182e02f0c7b30a89bff [INFO] running `"docker" "start" "-a" "a8d6c1863b599fd8dd4e14938902bdc2c238332458731182e02f0c7b30a89bff"` [INFO] [stderr] Checking jthreadpool v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `Builder` [INFO] [stderr] --> src/lib.rs:314:5 [INFO] [stderr] | [INFO] [stderr] 314 | / pub fn new()-> Builder { [INFO] [stderr] 315 | | Builder { [INFO] [stderr] 316 | | name_prefix:None, [INFO] [stderr] 317 | | num_threads:None, [INFO] [stderr] 318 | | stack_size:None [INFO] [stderr] 319 | | } [INFO] [stderr] 320 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 307 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: Consider using an AtomicUsize instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>. [INFO] [stderr] --> src/lib.rs:362:40 [INFO] [stderr] | [INFO] [stderr] 362 | shutdown_message_consumed:(Mutex::new(0),Condvar::new()), [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::mutex_atomic)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `Builder` [INFO] [stderr] --> src/lib.rs:314:5 [INFO] [stderr] | [INFO] [stderr] 314 | / pub fn new()-> Builder { [INFO] [stderr] 315 | | Builder { [INFO] [stderr] 316 | | name_prefix:None, [INFO] [stderr] 317 | | num_threads:None, [INFO] [stderr] 318 | | stack_size:None [INFO] [stderr] 319 | | } [INFO] [stderr] 320 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 307 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: Consider using an AtomicUsize instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>. [INFO] [stderr] --> src/lib.rs:362:40 [INFO] [stderr] | [INFO] [stderr] 362 | shutdown_message_consumed:(Mutex::new(0),Condvar::new()), [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::mutex_atomic)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.13s [INFO] running `"docker" "inspect" "a8d6c1863b599fd8dd4e14938902bdc2c238332458731182e02f0c7b30a89bff"` [INFO] running `"docker" "rm" "-f" "a8d6c1863b599fd8dd4e14938902bdc2c238332458731182e02f0c7b30a89bff"` [INFO] [stdout] a8d6c1863b599fd8dd4e14938902bdc2c238332458731182e02f0c7b30a89bff