[INFO] updating cached repository hwelzel/sudoku
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/hwelzel/sudoku
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/hwelzel/sudoku" "work/ex/clippy-test-run/sources/stable/gh/hwelzel/sudoku"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/hwelzel/sudoku'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/hwelzel/sudoku" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/hwelzel/sudoku"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/hwelzel/sudoku'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] a7188e36efcd369d4cc03b0ccc8ccadf3604e0cc
[INFO] sha for GitHub repo hwelzel/sudoku: a7188e36efcd369d4cc03b0ccc8ccadf3604e0cc
[INFO] validating manifest of hwelzel/sudoku on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of hwelzel/sudoku on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing hwelzel/sudoku
[INFO] finished frobbing hwelzel/sudoku
[INFO] frobbed toml for hwelzel/sudoku written to work/ex/clippy-test-run/sources/stable/gh/hwelzel/sudoku/Cargo.toml
[INFO] started frobbing hwelzel/sudoku
[INFO] finished frobbing hwelzel/sudoku
[INFO] frobbed toml for hwelzel/sudoku written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/hwelzel/sudoku/Cargo.toml
[INFO] crate hwelzel/sudoku has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting hwelzel/sudoku against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/hwelzel/sudoku:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 85169ad3142617452adc408159d5ab76f453d2308b1ccfb57321790a6901017d
[INFO] running `"docker" "start" "-a" "85169ad3142617452adc408159d5ab76f453d2308b1ccfb57321790a6901017d"`
[INFO] [stderr]     Checking sudoku v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/main.rs:57:19
[INFO] [stderr]    |
[INFO] [stderr] 57 | const SEP_NORTH: &'static str =   "┌───┬───┬───╥───┬───┬───╥───┬───┬───┐\n";
[INFO] [stderr]    |                  -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/main.rs:58:19
[INFO] [stderr]    |
[INFO] [stderr] 58 | const SEP_MINOR: &'static str = "\n├───┼───┼───╫───┼───┼───╫───┼───┼───┤\n";
[INFO] [stderr]    |                  -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/main.rs:59:19
[INFO] [stderr]    |
[INFO] [stderr] 59 | const SEP_MAJOR: &'static str = "\n╞═══╪═══╪═══╬═══╪═══╪═══╬═══╪═══╪═══╡\n";
[INFO] [stderr]    |                  -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/main.rs:60:19
[INFO] [stderr]    |
[INFO] [stderr] 60 | const SEP_SOUTH: &'static str = "\n└───┴───┴───╨───┴───┴───╨───┴───┴───┘";
[INFO] [stderr]    |                  -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/main.rs:57:19
[INFO] [stderr]    |
[INFO] [stderr] 57 | const SEP_NORTH: &'static str =   "┌───┬───┬───╥───┬───┬───╥───┬───┬───┐\n";
[INFO] [stderr]    |                  -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/main.rs:58:19
[INFO] [stderr]    |
[INFO] [stderr] 58 | const SEP_MINOR: &'static str = "\n├───┼───┼───╫───┼───┼───╫───┼───┼───┤\n";
[INFO] [stderr]    |                  -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/main.rs:59:19
[INFO] [stderr]    |
[INFO] [stderr] 59 | const SEP_MAJOR: &'static str = "\n╞═══╪═══╪═══╬═══╪═══╪═══╬═══╪═══╪═══╡\n";
[INFO] [stderr]    |                  -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/main.rs:60:19
[INFO] [stderr]    |
[INFO] [stderr] 60 | const SEP_SOUTH: &'static str = "\n└───┴───┴───╨───┴───┴───╨───┴───┴───┘";
[INFO] [stderr]    |                  -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]   --> src/main.rs:22:22
[INFO] [stderr]    |
[INFO] [stderr] 22 |     line.chars().map(|c| read_value(c)).collect()
[INFO] [stderr]    |                      ^^^^^^^^^^^^^^^^^ help: remove closure as shown: `read_value`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_closure)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/main.rs:31:42
[INFO] [stderr]    |
[INFO] [stderr] 31 |     let lines: Vec<&str> = content.split("\n").collect();
[INFO] [stderr]    |                                          ^^^^ help: try using a char instead: `'\n'`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/main.rs:41:27
[INFO] [stderr]    |
[INFO] [stderr] 41 | fn value_to_string(value: &Option<u8>) -> String {
[INFO] [stderr]    |                           ^^^^^^^^^^^ help: consider passing by value instead: `Option<u8>`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> src/main.rs:42:34
[INFO] [stderr]    |
[INFO] [stderr] 42 |     value.map(|v| v.to_string()).unwrap_or(' '.to_string())
[INFO] [stderr]    |                                  ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| ' '.to_string())`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/main.rs:45:25
[INFO] [stderr]    |
[INFO] [stderr] 45 | fn line_to_string(line: &Vec<Option<u8>>) -> String {
[INFO] [stderr]    |                         ^^^^^^^^^^^^^^^^ help: change this to: `&[Option<u8>]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]   --> src/main.rs:22:22
[INFO] [stderr]    |
[INFO] [stderr] 22 |     line.chars().map(|c| read_value(c)).collect()
[INFO] [stderr]    |                      ^^^^^^^^^^^^^^^^^ help: remove closure as shown: `read_value`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_closure)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/main.rs:31:42
[INFO] [stderr]    |
[INFO] [stderr] 31 |     let lines: Vec<&str> = content.split("\n").collect();
[INFO] [stderr]    |                                          ^^^^ help: try using a char instead: `'\n'`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/main.rs:41:27
[INFO] [stderr]    |
[INFO] [stderr] 41 | fn value_to_string(value: &Option<u8>) -> String {
[INFO] [stderr]    |                           ^^^^^^^^^^^ help: consider passing by value instead: `Option<u8>`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> src/main.rs:42:34
[INFO] [stderr]    |
[INFO] [stderr] 42 |     value.map(|v| v.to_string()).unwrap_or(' '.to_string())
[INFO] [stderr]    |                                  ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| ' '.to_string())`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/main.rs:45:25
[INFO] [stderr]    |
[INFO] [stderr] 45 | fn line_to_string(line: &Vec<Option<u8>>) -> String {
[INFO] [stderr]    |                         ^^^^^^^^^^^^^^^^ help: change this to: `&[Option<u8>]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 0.90s
[INFO] running `"docker" "inspect" "85169ad3142617452adc408159d5ab76f453d2308b1ccfb57321790a6901017d"`
[INFO] running `"docker" "rm" "-f" "85169ad3142617452adc408159d5ab76f453d2308b1ccfb57321790a6901017d"`
[INFO] [stdout] 85169ad3142617452adc408159d5ab76f453d2308b1ccfb57321790a6901017d