[INFO] updating cached repository huytd/sergaem [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/huytd/sergaem [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/huytd/sergaem" "work/ex/clippy-test-run/sources/stable/gh/huytd/sergaem"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/huytd/sergaem'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/huytd/sergaem" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/huytd/sergaem"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/huytd/sergaem'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 318afedb90b7f2607ab4c6850db3590ffadf6c7b [INFO] sha for GitHub repo huytd/sergaem: 318afedb90b7f2607ab4c6850db3590ffadf6c7b [INFO] validating manifest of huytd/sergaem on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of huytd/sergaem on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing huytd/sergaem [INFO] finished frobbing huytd/sergaem [INFO] frobbed toml for huytd/sergaem written to work/ex/clippy-test-run/sources/stable/gh/huytd/sergaem/Cargo.toml [INFO] started frobbing huytd/sergaem [INFO] finished frobbing huytd/sergaem [INFO] frobbed toml for huytd/sergaem written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/huytd/sergaem/Cargo.toml [INFO] crate huytd/sergaem has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting huytd/sergaem against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/huytd/sergaem:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] c7fd6054b2b1f0ad9f3dfd2b61a0556638fd4a6c7b4ca66a0c498e381675cd84 [INFO] running `"docker" "start" "-a" "c7fd6054b2b1f0ad9f3dfd2b61a0556638fd4a6c7b4ca66a0c498e381675cd84"` [INFO] [stderr] Checking crossbeam v0.3.0 [INFO] [stderr] Checking net2 v0.2.31 [INFO] [stderr] Checking bytes v0.4.5 [INFO] [stderr] Checking mio v0.6.11 [INFO] [stderr] Checking ws v0.7.3 [INFO] [stderr] Checking sergaem v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/logic/commands.rs:30:17 [INFO] [stderr] | [INFO] [stderr] 30 | return self.send_error(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.send_error()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::cell::RefCell` [INFO] [stderr] --> src/engine/network.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | use std::cell::RefCell; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/engine/network.rs:90:9 [INFO] [stderr] | [INFO] [stderr] 90 | result [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/engine/network.rs:80:22 [INFO] [stderr] | [INFO] [stderr] 80 | let result = match msg.is_text() { [INFO] [stderr] | ______________________^ [INFO] [stderr] 81 | | true => { [INFO] [stderr] 82 | | let msg_text = msg.as_text().unwrap(); [INFO] [stderr] 83 | | self.processing_commands(msg_text) [INFO] [stderr] ... | [INFO] [stderr] 88 | | } [INFO] [stderr] 89 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/main.rs:27:17 [INFO] [stderr] | [INFO] [stderr] 27 | server [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/main.rs:22:30 [INFO] [stderr] | [INFO] [stderr] 22 | let server = ServerHandler { [INFO] [stderr] | ______________________________^ [INFO] [stderr] 23 | | socket: client, [INFO] [stderr] 24 | | manager: network_manager.clone(), [INFO] [stderr] 25 | | game_manager: game_manager.clone() [INFO] [stderr] 26 | | }; [INFO] [stderr] | |_________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/logic/commands.rs:30:17 [INFO] [stderr] | [INFO] [stderr] 30 | return self.send_error(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.send_error()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::cell::RefCell` [INFO] [stderr] --> src/engine/network.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | use std::cell::RefCell; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/engine/network.rs:90:9 [INFO] [stderr] | [INFO] [stderr] 90 | result [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/engine/network.rs:80:22 [INFO] [stderr] | [INFO] [stderr] 80 | let result = match msg.is_text() { [INFO] [stderr] | ______________________^ [INFO] [stderr] 81 | | true => { [INFO] [stderr] 82 | | let msg_text = msg.as_text().unwrap(); [INFO] [stderr] 83 | | self.processing_commands(msg_text) [INFO] [stderr] ... | [INFO] [stderr] 88 | | } [INFO] [stderr] 89 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/main.rs:27:17 [INFO] [stderr] | [INFO] [stderr] 27 | server [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/main.rs:22:30 [INFO] [stderr] | [INFO] [stderr] 22 | let server = ServerHandler { [INFO] [stderr] | ______________________________^ [INFO] [stderr] 23 | | socket: client, [INFO] [stderr] 24 | | manager: network_manager.clone(), [INFO] [stderr] 25 | | game_manager: game_manager.clone() [INFO] [stderr] 26 | | }; [INFO] [stderr] | |_________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/engine/game.rs:30:21 [INFO] [stderr] | [INFO] [stderr] 30 | let mut game_logic = GameLogic::new(self.clone()); [INFO] [stderr] | ----^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/engine/game.rs:30:21 [INFO] [stderr] | [INFO] [stderr] 30 | let mut game_logic = GameLogic::new(self.clone()); [INFO] [stderr] | ----^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: the variable `index` is used as a loop counter. Consider using `for (index, item) in self.clients.iter().enumerate()` or similar iterators [INFO] [stderr] --> src/engine/network.rs:42:23 [INFO] [stderr] | [INFO] [stderr] 42 | for client in self.clients.iter() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/engine/network.rs:80:22 [INFO] [stderr] | [INFO] [stderr] 80 | let result = match msg.is_text() { [INFO] [stderr] | ______________________^ [INFO] [stderr] 81 | | true => { [INFO] [stderr] 82 | | let msg_text = msg.as_text().unwrap(); [INFO] [stderr] 83 | | self.processing_commands(msg_text) [INFO] [stderr] ... | [INFO] [stderr] 88 | | } [INFO] [stderr] 89 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 80 | let result = if msg.is_text() { [INFO] [stderr] 81 | let msg_text = msg.as_text().unwrap(); [INFO] [stderr] 82 | self.processing_commands(msg_text) [INFO] [stderr] 83 | } else { [INFO] [stderr] 84 | println!("Unknown message"); [INFO] [stderr] 85 | self.send_error() [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to want to iterate on a map's values [INFO] [stderr] --> src/engine/game_manager.rs:38:30 [INFO] [stderr] | [INFO] [stderr] 38 | for (_, mut game) in &mut self.games { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::for_kv_map)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stderr] help: use the corresponding method [INFO] [stderr] | [INFO] [stderr] 38 | for mut game in self.games.values_mut() { [INFO] [stderr] | ^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/engine/game.rs:30:21 [INFO] [stderr] | [INFO] [stderr] 30 | let mut game_logic = GameLogic::new(self.clone()); [INFO] [stderr] | ----^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/engine/game.rs:30:21 [INFO] [stderr] | [INFO] [stderr] 30 | let mut game_logic = GameLogic::new(self.clone()); [INFO] [stderr] | ----^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] error: Variable in the condition are not mutated in the loop body. This either leads to an infinite or to a never running loop. [INFO] [stderr] --> src/engine/game.rs:32:23 [INFO] [stderr] | [INFO] [stderr] 32 | while self.is_started { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::while_immutable_condition)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_immutable_condition [INFO] [stderr] [INFO] [stderr] warning: the variable `index` is used as a loop counter. Consider using `for (index, item) in self.players.iter().enumerate()` or similar iterators [INFO] [stderr] --> src/engine/game.rs:48:18 [INFO] [stderr] | [INFO] [stderr] 48 | for p in self.players.iter() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/engine/game.rs:72:13 [INFO] [stderr] | [INFO] [stderr] 72 | player.send(Message::from(msg)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `sergaem`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: the variable `index` is used as a loop counter. Consider using `for (index, item) in self.clients.iter().enumerate()` or similar iterators [INFO] [stderr] --> src/engine/network.rs:42:23 [INFO] [stderr] | [INFO] [stderr] 42 | for client in self.clients.iter() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/engine/network.rs:80:22 [INFO] [stderr] | [INFO] [stderr] 80 | let result = match msg.is_text() { [INFO] [stderr] | ______________________^ [INFO] [stderr] 81 | | true => { [INFO] [stderr] 82 | | let msg_text = msg.as_text().unwrap(); [INFO] [stderr] 83 | | self.processing_commands(msg_text) [INFO] [stderr] ... | [INFO] [stderr] 88 | | } [INFO] [stderr] 89 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 80 | let result = if msg.is_text() { [INFO] [stderr] 81 | let msg_text = msg.as_text().unwrap(); [INFO] [stderr] 82 | self.processing_commands(msg_text) [INFO] [stderr] 83 | } else { [INFO] [stderr] 84 | println!("Unknown message"); [INFO] [stderr] 85 | self.send_error() [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to want to iterate on a map's values [INFO] [stderr] --> src/engine/game_manager.rs:38:30 [INFO] [stderr] | [INFO] [stderr] 38 | for (_, mut game) in &mut self.games { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::for_kv_map)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stderr] help: use the corresponding method [INFO] [stderr] | [INFO] [stderr] 38 | for mut game in self.games.values_mut() { [INFO] [stderr] | ^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: Variable in the condition are not mutated in the loop body. This either leads to an infinite or to a never running loop. [INFO] [stderr] --> src/engine/game.rs:32:23 [INFO] [stderr] | [INFO] [stderr] 32 | while self.is_started { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::while_immutable_condition)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_immutable_condition [INFO] [stderr] [INFO] [stderr] warning: the variable `index` is used as a loop counter. Consider using `for (index, item) in self.players.iter().enumerate()` or similar iterators [INFO] [stderr] --> src/engine/game.rs:48:18 [INFO] [stderr] | [INFO] [stderr] 48 | for p in self.players.iter() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/engine/game.rs:72:13 [INFO] [stderr] | [INFO] [stderr] 72 | player.send(Message::from(msg)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `sergaem`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "c7fd6054b2b1f0ad9f3dfd2b61a0556638fd4a6c7b4ca66a0c498e381675cd84"` [INFO] running `"docker" "rm" "-f" "c7fd6054b2b1f0ad9f3dfd2b61a0556638fd4a6c7b4ca66a0c498e381675cd84"` [INFO] [stdout] c7fd6054b2b1f0ad9f3dfd2b61a0556638fd4a6c7b4ca66a0c498e381675cd84