[INFO] updating cached repository huwb/rust-rt
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/huwb/rust-rt
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/huwb/rust-rt" "work/ex/clippy-test-run/sources/stable/gh/huwb/rust-rt"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/huwb/rust-rt'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/huwb/rust-rt" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/huwb/rust-rt"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/huwb/rust-rt'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 34c4b6019d92713f1f3adcb6336a82acdbff1ee8
[INFO] sha for GitHub repo huwb/rust-rt: 34c4b6019d92713f1f3adcb6336a82acdbff1ee8
[INFO] validating manifest of huwb/rust-rt on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of huwb/rust-rt on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing huwb/rust-rt
[INFO] finished frobbing huwb/rust-rt
[INFO] frobbed toml for huwb/rust-rt written to work/ex/clippy-test-run/sources/stable/gh/huwb/rust-rt/Cargo.toml
[INFO] started frobbing huwb/rust-rt
[INFO] finished frobbing huwb/rust-rt
[INFO] frobbed toml for huwb/rust-rt written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/huwb/rust-rt/Cargo.toml
[INFO] crate huwb/rust-rt has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting huwb/rust-rt against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/huwb/rust-rt:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] d87bd501e119901bebab46b6d968fa9524f8597fc762a18bcdc03e7896f50ce8
[INFO] running `"docker" "start" "-a" "d87bd501e119901bebab46b6d968fa9524f8597fc762a18bcdc03e7896f50ce8"`
[INFO] [stderr]     Checking rand v0.3.22
[INFO] [stderr]     Checking simple-stopwatch v0.1.4
[INFO] [stderr]     Checking rust-rt v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: 5th binding whose name is just one char
[INFO] [stderr]   --> src/main.rs:65:17
[INFO] [stderr]    |
[INFO] [stderr] 65 |             let t = -b - h;
[INFO] [stderr]    |                 ^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::many_single_char_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: literal with an empty format string
[INFO] [stderr]    --> src/main.rs:295:31
[INFO] [stderr]     |
[INFO] [stderr] 295 |     writeln!(&mut file, "{}", 255).unwrap();
[INFO] [stderr]     |                               ^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::write_literal)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal
[INFO] [stderr] 
[INFO] [stderr] warning: 5th binding whose name is just one char
[INFO] [stderr]   --> src/main.rs:65:17
[INFO] [stderr]    |
[INFO] [stderr] 65 |             let t = -b - h;
[INFO] [stderr]    |                 ^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::many_single_char_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: literal with an empty format string
[INFO] [stderr]    --> src/main.rs:295:31
[INFO] [stderr]     |
[INFO] [stderr] 295 |     writeln!(&mut file, "{}", 255).unwrap();
[INFO] [stderr]     |                               ^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::write_literal)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal
[INFO] [stderr] 
[INFO] [stderr] warning: Consider using an AtomicBool instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>.
[INFO] [stderr]    --> src/threadpool.rs:106:36
[INFO] [stderr]     |
[INFO] [stderr] 106 |         let job_ran_ref = Arc::new(Mutex::new(false));
[INFO] [stderr]     |                                    ^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::mutex_atomic)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic
[INFO] [stderr] 
[INFO] [stderr] warning: equality checks against false can be replaced by a negation
[INFO] [stderr]    --> src/threadpool.rs:122:17
[INFO] [stderr]     |
[INFO] [stderr] 122 |         assert!(*job_ran_ref.lock().unwrap() == false);
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!(*job_ran_ref.lock().unwrap())`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::bool_comparison)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison
[INFO] [stderr] 
[INFO] [stderr] error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false
[INFO] [stderr]    --> src/main.rs:177:8
[INFO] [stderr]     |
[INFO] [stderr] 177 |     if bounces_rem <= 0 {
[INFO] [stderr]     |        ^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[deny(clippy::absurd_extreme_comparisons)] on by default
[INFO] [stderr]     = help: because 0 is the minimum value for this type, the case where the two sides are not equal never occurs, consider using bounces_rem == 0 instead
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#absurd_extreme_comparisons
[INFO] [stderr] 
[INFO] [stderr] error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false
[INFO] [stderr]    --> src/main.rs:177:8
[INFO] [stderr]     |
[INFO] [stderr] 177 |     if bounces_rem <= 0 {
[INFO] [stderr]     |        ^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[deny(clippy::absurd_extreme_comparisons)] on by default
[INFO] [stderr]     = help: because 0 is the minimum value for this type, the case where the two sides are not equal never occurs, consider using bounces_rem == 0 instead
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#absurd_extreme_comparisons
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `y` is used to index `image`
[INFO] [stderr]    --> src/main.rs:242:14
[INFO] [stderr]     |
[INFO] [stderr] 242 |     for y in 0..height {
[INFO] [stderr]     |              ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]     |
[INFO] [stderr] 242 |     for (y, <item>) in image.iter().enumerate().take(height) {
[INFO] [stderr]     |         ^^^^^^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `x` is used to index `row`
[INFO] [stderr]    --> src/main.rs:252:22
[INFO] [stderr]     |
[INFO] [stderr] 252 |             for x in 0..width {
[INFO] [stderr]     |                      ^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]     |
[INFO] [stderr] 252 |             for (x, <item>) in row.iter_mut().enumerate().take(width) {
[INFO] [stderr]     |                 ^^^^^^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `y` is used to index `image`
[INFO] [stderr]    --> src/main.rs:242:14
[INFO] [stderr]     |
[INFO] [stderr] 242 |     for y in 0..height {
[INFO] [stderr]     |              ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]     |
[INFO] [stderr] 242 |     for (y, <item>) in image.iter().enumerate().take(height) {
[INFO] [stderr]     |         ^^^^^^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `x` is used to index `row`
[INFO] [stderr]    --> src/main.rs:252:22
[INFO] [stderr]     |
[INFO] [stderr] 252 |             for x in 0..width {
[INFO] [stderr]     |                      ^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]     |
[INFO] [stderr] 252 |             for (x, <item>) in row.iter_mut().enumerate().take(width) {
[INFO] [stderr]     |                 ^^^^^^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: use of `expect` followed by a function call
[INFO] [stderr]    --> src/main.rs:284:43
[INFO] [stderr]     |
[INFO] [stderr] 284 |       let mut file = File::create(filename).expect(&format!(
[INFO] [stderr]     |  ___________________________________________^
[INFO] [stderr] 285 | |         "Could not open for writing: {}",
[INFO] [stderr] 286 | |         filename.display()
[INFO] [stderr] 287 | |     ));
[INFO] [stderr]     | |______^ help: try this: `unwrap_or_else(|_| panic!("Could not open for writing: {}", filename.display()))`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::expect_fun_call)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `y` is only used to index `image`.
[INFO] [stderr]    --> src/main.rs:297:14
[INFO] [stderr]     |
[INFO] [stderr] 297 |     for y in 0..height {
[INFO] [stderr]     |              ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]     |
[INFO] [stderr] 297 |     for <item> in image.iter().take(height) {
[INFO] [stderr]     |         ^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `x` is only used to index `row`.
[INFO] [stderr]    --> src/main.rs:299:18
[INFO] [stderr]     |
[INFO] [stderr] 299 |         for x in 0..width {
[INFO] [stderr]     |                  ^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]     |
[INFO] [stderr] 299 |         for <item> in row.iter().take(width) {
[INFO] [stderr]     |             ^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: use of `expect` followed by a function call
[INFO] [stderr]    --> src/main.rs:284:43
[INFO] [stderr]     |
[INFO] [stderr] 284 |       let mut file = File::create(filename).expect(&format!(
[INFO] [stderr]     |  ___________________________________________^
[INFO] [stderr] 285 | |         "Could not open for writing: {}",
[INFO] [stderr] 286 | |         filename.display()
[INFO] [stderr] 287 | |     ));
[INFO] [stderr]     | |______^ help: try this: `unwrap_or_else(|_| panic!("Could not open for writing: {}", filename.display()))`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::expect_fun_call)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `y` is only used to index `image`.
[INFO] [stderr]    --> src/main.rs:297:14
[INFO] [stderr]     |
[INFO] [stderr] 297 |     for y in 0..height {
[INFO] [stderr]     |              ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]     |
[INFO] [stderr] 297 |     for <item> in image.iter().take(height) {
[INFO] [stderr]     |         ^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `x` is only used to index `row`.
[INFO] [stderr]    --> src/main.rs:299:18
[INFO] [stderr]     |
[INFO] [stderr] 299 |         for x in 0..width {
[INFO] [stderr]     |                  ^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]     |
[INFO] [stderr] 299 |         for <item> in row.iter().take(width) {
[INFO] [stderr]     |             ^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to previous error
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to previous error
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `rust-rt`.
[INFO] [stderr] warning: build failed, waiting for other jobs to finish...
[INFO] [stderr] error: Could not compile `rust-rt`.
[INFO] [stderr] 
[INFO] [stderr] To learn more, run the command again with --verbose.
[INFO] running `"docker" "inspect" "d87bd501e119901bebab46b6d968fa9524f8597fc762a18bcdc03e7896f50ce8"`
[INFO] running `"docker" "rm" "-f" "d87bd501e119901bebab46b6d968fa9524f8597fc762a18bcdc03e7896f50ce8"`
[INFO] [stdout] d87bd501e119901bebab46b6d968fa9524f8597fc762a18bcdc03e7896f50ce8