[INFO] updating cached repository huwb/myrustminigrep
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/huwb/myrustminigrep
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/huwb/myrustminigrep" "work/ex/clippy-test-run/sources/stable/gh/huwb/myrustminigrep"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/huwb/myrustminigrep'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/huwb/myrustminigrep" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/huwb/myrustminigrep"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/huwb/myrustminigrep'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 2c1b61fc8042a85ae7272913279012e255137aa4
[INFO] sha for GitHub repo huwb/myrustminigrep: 2c1b61fc8042a85ae7272913279012e255137aa4
[INFO] validating manifest of huwb/myrustminigrep on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of huwb/myrustminigrep on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing huwb/myrustminigrep
[INFO] finished frobbing huwb/myrustminigrep
[INFO] frobbed toml for huwb/myrustminigrep written to work/ex/clippy-test-run/sources/stable/gh/huwb/myrustminigrep/Cargo.toml
[INFO] started frobbing huwb/myrustminigrep
[INFO] finished frobbing huwb/myrustminigrep
[INFO] frobbed toml for huwb/myrustminigrep written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/huwb/myrustminigrep/Cargo.toml
[INFO] crate huwb/myrustminigrep has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting huwb/myrustminigrep against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/huwb/myrustminigrep:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 182651582d1a602e647c145aedfc865e4cd726ce6a5821374ea2d9cb29bcb7a3
[INFO] running `"docker" "start" "-a" "182651582d1a602e647c145aedfc865e4cd726ce6a5821374ea2d9cb29bcb7a3"`
[INFO] [stderr]     Checking myrustminigrep v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/config.rs:36:27
[INFO] [stderr]    |
[INFO] [stderr] 36 |             i if i < 3 => return Err("not enough arguments"),
[INFO] [stderr]    |                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err("not enough arguments")`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/config.rs:37:18
[INFO] [stderr]    |
[INFO] [stderr] 37 |             _ => return Err("too many arguments"),
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err("too many arguments")`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/config.rs:36:27
[INFO] [stderr]    |
[INFO] [stderr] 36 |             i if i < 3 => return Err("not enough arguments"),
[INFO] [stderr]    |                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err("not enough arguments")`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/config.rs:37:18
[INFO] [stderr]    |
[INFO] [stderr] 37 |             _ => return Err("too many arguments"),
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err("too many arguments")`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/config.rs:30:22
[INFO] [stderr]    |
[INFO] [stderr] 30 |     pub fn new(args: &'a Vec<String>) -> Result<Config<'a>, &'static str> {
[INFO] [stderr]    |                      ^^^^^^^^^^^^^^^ help: change this to: `&[String]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: passing a unit value to a function
[INFO] [stderr]   --> src/lib.rs:20:8
[INFO] [stderr]    |
[INFO] [stderr] 20 |     Ok({})
[INFO] [stderr]    |        ^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unit_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg
[INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead
[INFO] [stderr]    |
[INFO] [stderr] 20 |     Ok(())
[INFO] [stderr]    |        ^^
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/lib.rs:24:8
[INFO] [stderr]    |
[INFO] [stderr] 24 |     if query.len() == 0 {
[INFO] [stderr]    |        ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `query.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/config.rs:30:22
[INFO] [stderr]    |
[INFO] [stderr] 30 |     pub fn new(args: &'a Vec<String>) -> Result<Config<'a>, &'static str> {
[INFO] [stderr]    |                      ^^^^^^^^^^^^^^^ help: change this to: `&[String]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: passing a unit value to a function
[INFO] [stderr]   --> src/lib.rs:20:8
[INFO] [stderr]    |
[INFO] [stderr] 20 |     Ok({})
[INFO] [stderr]    |        ^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unit_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg
[INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead
[INFO] [stderr]    |
[INFO] [stderr] 20 |     Ok(())
[INFO] [stderr]    |        ^^
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/lib.rs:24:8
[INFO] [stderr]    |
[INFO] [stderr] 24 |     if query.len() == 0 {
[INFO] [stderr]    |        ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `query.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 0.79s
[INFO] running `"docker" "inspect" "182651582d1a602e647c145aedfc865e4cd726ce6a5821374ea2d9cb29bcb7a3"`
[INFO] running `"docker" "rm" "-f" "182651582d1a602e647c145aedfc865e4cd726ce6a5821374ea2d9cb29bcb7a3"`
[INFO] [stdout] 182651582d1a602e647c145aedfc865e4cd726ce6a5821374ea2d9cb29bcb7a3