[INFO] updating cached repository hunterkepley/Smoke
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/hunterkepley/Smoke
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/hunterkepley/Smoke" "work/ex/clippy-test-run/sources/stable/gh/hunterkepley/Smoke"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/hunterkepley/Smoke'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/hunterkepley/Smoke" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/hunterkepley/Smoke"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/hunterkepley/Smoke'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 32a68e984b2f7ebeb326033fd81b03cab4736f18
[INFO] sha for GitHub repo hunterkepley/Smoke: 32a68e984b2f7ebeb326033fd81b03cab4736f18
[INFO] validating manifest of hunterkepley/Smoke on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of hunterkepley/Smoke on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing hunterkepley/Smoke
[INFO] finished frobbing hunterkepley/Smoke
[INFO] frobbed toml for hunterkepley/Smoke written to work/ex/clippy-test-run/sources/stable/gh/hunterkepley/Smoke/Cargo.toml
[INFO] started frobbing hunterkepley/Smoke
[INFO] finished frobbing hunterkepley/Smoke
[INFO] frobbed toml for hunterkepley/Smoke written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/hunterkepley/Smoke/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting hunterkepley/Smoke against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/hunterkepley/Smoke:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 58ecd86df42eae003daa4f6be8877f4d5498dbbaf172951dee869a96bde106a3
[INFO] running `"docker" "start" "-a" "58ecd86df42eae003daa4f6be8877f4d5498dbbaf172951dee869a96bde106a3"`
[INFO] [stderr]     Checking smoke v0.0.2 (/opt/crater/workdir)
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/parser.rs:60:5
[INFO] [stderr]    |
[INFO] [stderr] 60 |     return final_constructor;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `final_constructor`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: this if statement can be collapsed
[INFO] [stderr]   --> src/parser.rs:50:9
[INFO] [stderr]    |
[INFO] [stderr] 50 | /         if !empty_constructor {
[INFO] [stderr] 51 | |             if chars_collected[0] == '"' || chars_collected[0] == '\"' {
[INFO] [stderr] 52 | |                 // It's a string
[INFO] [stderr] 53 | |                 let chars_collected_length = chars_collected.len();
[INFO] [stderr] ...  |
[INFO] [stderr] 56 | |             }
[INFO] [stderr] 57 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 50 |         if !empty_constructor && (chars_collected[0] == '"' || chars_collected[0] == '\"') {
[INFO] [stderr] 51 |     // It's a string
[INFO] [stderr] 52 |     let chars_collected_length = chars_collected.len();
[INFO] [stderr] 53 |     chars_collected.remove(0);chars_collected.remove(chars_collected_length-2); // remove quotes
[INFO] [stderr] 54 |     constructor_part.string = chars_collected.into_iter().collect();
[INFO] [stderr] 55 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/parser.rs:84:13
[INFO] [stderr]    |
[INFO] [stderr] 84 |             return true;
[INFO] [stderr]    |             ^^^^^^^^^^^^ help: remove `return` as shown: `true`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/parser.rs:88:13
[INFO] [stderr]    |
[INFO] [stderr] 88 |             return true;
[INFO] [stderr]    |             ^^^^^^^^^^^^ help: remove `return` as shown: `true`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/lexer.rs:53:5
[INFO] [stderr]    |
[INFO] [stderr] 53 |     return tokens;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^ help: remove `return` as shown: `tokens`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `constructor`
[INFO] [stderr]   --> src/smoke_commands.rs:10:13
[INFO] [stderr]    |
[INFO] [stderr] 10 | pub fn quit(constructor: Vec<parser::ConstructorPart>) {
[INFO] [stderr]    |             ^^^^^^^^^^^ help: consider using `_constructor` instead
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_variables)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: variant is never constructed: `VChar`
[INFO] [stderr]  --> src/parser.rs:8:5
[INFO] [stderr]   |
[INFO] [stderr] 8 |     VChar,
[INFO] [stderr]   |     ^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: variant is never constructed: `VInt`
[INFO] [stderr]  --> src/parser.rs:9:5
[INFO] [stderr]   |
[INFO] [stderr] 9 |     VInt,
[INFO] [stderr]   |     ^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: variant is never constructed: `VFloat`
[INFO] [stderr]   --> src/parser.rs:10:5
[INFO] [stderr]    |
[INFO] [stderr] 10 |     VFloat
[INFO] [stderr]    |     ^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: this boolean expression can be simplified
[INFO] [stderr]   --> src/parser.rs:51:16
[INFO] [stderr]    |
[INFO] [stderr] 51 |             if chars_collected[0] == '"' || chars_collected[0] == '\"' {
[INFO] [stderr]    |                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `chars_collected[0] == '"'`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::nonminimal_bool)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is only used to index `tokens`.
[INFO] [stderr]   --> src/parser.rs:32:18
[INFO] [stderr]    |
[INFO] [stderr] 32 |         for i in start_index..tokens.len() {
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 32 |         for <item> in tokens.iter().skip(start_index) {
[INFO] [stderr]    |             ^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/parser.rs:35:24
[INFO] [stderr]    |
[INFO] [stderr] 35 |                     if chars_collected.len() == 0 {
[INFO] [stderr]    |                        ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `chars_collected.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] error: equal expressions as operands to `||`
[INFO] [stderr]   --> src/parser.rs:51:16
[INFO] [stderr]    |
[INFO] [stderr] 51 |             if chars_collected[0] == '"' || chars_collected[0] == '\"' {
[INFO] [stderr]    |                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[deny(clippy::eq_op)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eq_op
[INFO] [stderr] 
[INFO] [stderr] warning: the variable `iterator` is used as a loop counter. Consider using `for (iterator, item) in t.enumerate()` or similar iterators
[INFO] [stderr]   --> src/parser.rs:99:14
[INFO] [stderr]    |
[INFO] [stderr] 99 |     for i in t {
[INFO] [stderr]    |              ^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::explicit_counter_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to previous error
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `smoke`.
[INFO] [stderr] warning: build failed, waiting for other jobs to finish...
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/parser.rs:60:5
[INFO] [stderr]    |
[INFO] [stderr] 60 |     return final_constructor;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `final_constructor`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: this if statement can be collapsed
[INFO] [stderr]   --> src/parser.rs:50:9
[INFO] [stderr]    |
[INFO] [stderr] 50 | /         if !empty_constructor {
[INFO] [stderr] 51 | |             if chars_collected[0] == '"' || chars_collected[0] == '\"' {
[INFO] [stderr] 52 | |                 // It's a string
[INFO] [stderr] 53 | |                 let chars_collected_length = chars_collected.len();
[INFO] [stderr] ...  |
[INFO] [stderr] 56 | |             }
[INFO] [stderr] 57 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 50 |         if !empty_constructor && (chars_collected[0] == '"' || chars_collected[0] == '\"') {
[INFO] [stderr] 51 |     // It's a string
[INFO] [stderr] 52 |     let chars_collected_length = chars_collected.len();
[INFO] [stderr] 53 |     chars_collected.remove(0);chars_collected.remove(chars_collected_length-2); // remove quotes
[INFO] [stderr] 54 |     constructor_part.string = chars_collected.into_iter().collect();
[INFO] [stderr] 55 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/parser.rs:84:13
[INFO] [stderr]    |
[INFO] [stderr] 84 |             return true;
[INFO] [stderr]    |             ^^^^^^^^^^^^ help: remove `return` as shown: `true`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/parser.rs:88:13
[INFO] [stderr]    |
[INFO] [stderr] 88 |             return true;
[INFO] [stderr]    |             ^^^^^^^^^^^^ help: remove `return` as shown: `true`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/lexer.rs:53:5
[INFO] [stderr]    |
[INFO] [stderr] 53 |     return tokens;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^ help: remove `return` as shown: `tokens`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `constructor`
[INFO] [stderr]   --> src/smoke_commands.rs:10:13
[INFO] [stderr]    |
[INFO] [stderr] 10 | pub fn quit(constructor: Vec<parser::ConstructorPart>) {
[INFO] [stderr]    |             ^^^^^^^^^^^ help: consider using `_constructor` instead
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_variables)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: variant is never constructed: `VChar`
[INFO] [stderr]  --> src/parser.rs:8:5
[INFO] [stderr]   |
[INFO] [stderr] 8 |     VChar,
[INFO] [stderr]   |     ^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: variant is never constructed: `VInt`
[INFO] [stderr]  --> src/parser.rs:9:5
[INFO] [stderr]   |
[INFO] [stderr] 9 |     VInt,
[INFO] [stderr]   |     ^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: variant is never constructed: `VFloat`
[INFO] [stderr]   --> src/parser.rs:10:5
[INFO] [stderr]    |
[INFO] [stderr] 10 |     VFloat
[INFO] [stderr]    |     ^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: this boolean expression can be simplified
[INFO] [stderr]   --> src/parser.rs:51:16
[INFO] [stderr]    |
[INFO] [stderr] 51 |             if chars_collected[0] == '"' || chars_collected[0] == '\"' {
[INFO] [stderr]    |                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `chars_collected[0] == '"'`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::nonminimal_bool)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is only used to index `tokens`.
[INFO] [stderr]   --> src/parser.rs:32:18
[INFO] [stderr]    |
[INFO] [stderr] 32 |         for i in start_index..tokens.len() {
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 32 |         for <item> in tokens.iter().skip(start_index) {
[INFO] [stderr]    |             ^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/parser.rs:35:24
[INFO] [stderr]    |
[INFO] [stderr] 35 |                     if chars_collected.len() == 0 {
[INFO] [stderr]    |                        ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `chars_collected.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] error: equal expressions as operands to `||`
[INFO] [stderr]   --> src/parser.rs:51:16
[INFO] [stderr]    |
[INFO] [stderr] 51 |             if chars_collected[0] == '"' || chars_collected[0] == '\"' {
[INFO] [stderr]    |                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[deny(clippy::eq_op)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eq_op
[INFO] [stderr] 
[INFO] [stderr] warning: the variable `iterator` is used as a loop counter. Consider using `for (iterator, item) in t.enumerate()` or similar iterators
[INFO] [stderr]   --> src/parser.rs:99:14
[INFO] [stderr]    |
[INFO] [stderr] 99 |     for i in t {
[INFO] [stderr]    |              ^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::explicit_counter_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to previous error
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `smoke`.
[INFO] [stderr] 
[INFO] [stderr] To learn more, run the command again with --verbose.
[INFO] running `"docker" "inspect" "58ecd86df42eae003daa4f6be8877f4d5498dbbaf172951dee869a96bde106a3"`
[INFO] running `"docker" "rm" "-f" "58ecd86df42eae003daa4f6be8877f4d5498dbbaf172951dee869a96bde106a3"`
[INFO] [stdout] 58ecd86df42eae003daa4f6be8877f4d5498dbbaf172951dee869a96bde106a3