[INFO] updating cached repository huehodaniel/shortpath
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/huehodaniel/shortpath
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/huehodaniel/shortpath" "work/ex/clippy-test-run/sources/stable/gh/huehodaniel/shortpath"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/huehodaniel/shortpath'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/huehodaniel/shortpath" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/huehodaniel/shortpath"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/huehodaniel/shortpath'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] ff7ba5c1dfb3364c080029ad2a842923dfc42311
[INFO] sha for GitHub repo huehodaniel/shortpath: ff7ba5c1dfb3364c080029ad2a842923dfc42311
[INFO] validating manifest of huehodaniel/shortpath on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of huehodaniel/shortpath on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing huehodaniel/shortpath
[INFO] finished frobbing huehodaniel/shortpath
[INFO] frobbed toml for huehodaniel/shortpath written to work/ex/clippy-test-run/sources/stable/gh/huehodaniel/shortpath/Cargo.toml
[INFO] started frobbing huehodaniel/shortpath
[INFO] finished frobbing huehodaniel/shortpath
[INFO] frobbed toml for huehodaniel/shortpath written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/huehodaniel/shortpath/Cargo.toml
[INFO] crate huehodaniel/shortpath has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting huehodaniel/shortpath against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/huehodaniel/shortpath:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] a2bf5c5acd498a708c986674d572340594d43f2b6a5ea6ea23c03d0b52b8e03e
[INFO] running `"docker" "start" "-a" "a2bf5c5acd498a708c986674d572340594d43f2b6a5ea6ea23c03d0b52b8e03e"`
[INFO] [stderr]     Checking shortpath v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead.
[INFO] [stderr]   --> src/main.rs:38:16
[INFO] [stderr]    |
[INFO] [stderr] 38 |     let home = env::home_dir().unwrap();
[INFO] [stderr]    |                ^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(deprecated)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead.
[INFO] [stderr]   --> src/main.rs:38:16
[INFO] [stderr]    |
[INFO] [stderr] 38 |     let home = env::home_dir().unwrap();
[INFO] [stderr]    |                ^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(deprecated)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/main.rs:14:5
[INFO] [stderr]    |
[INFO] [stderr] 14 | /     match components.split_last() {
[INFO] [stderr] 15 | |         Some((last, elems)) => {
[INFO] [stderr] 16 | |             for elem in elems {
[INFO] [stderr] 17 | |                 match elem {
[INFO] [stderr] ...  |
[INFO] [stderr] 31 | |         None => ()
[INFO] [stderr] 32 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 14 |     if let Some((last, elems)) = components.split_last() {
[INFO] [stderr] 15 |     for elem in elems {
[INFO] [stderr] 16 |         match elem {
[INFO] [stderr] 17 |             &Component::Normal(os_str) => {
[INFO] [stderr] 18 |                 let letter = os_str.to_str()
[INFO] [stderr] 19 |                     .and_then(|s| s.chars().next())
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/main.rs:17:17
[INFO] [stderr]    |
[INFO] [stderr] 17 | /                 match elem {
[INFO] [stderr] 18 | |                     &Component::Normal(os_str) => {
[INFO] [stderr] 19 | |                         let letter = os_str.to_str()
[INFO] [stderr] 20 | |                             .and_then(|s| s.chars().next())
[INFO] [stderr] ...  |
[INFO] [stderr] 25 | |                     _ => to_return.push(elem.as_os_str())
[INFO] [stderr] 26 | |                 }
[INFO] [stderr]    | |_________________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 17 |                 match *elem {
[INFO] [stderr] 18 |                     Component::Normal(os_str) => {
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> src/main.rs:22:30
[INFO] [stderr]    |
[INFO] [stderr] 22 |                             .unwrap_or("?".to_owned());
[INFO] [stderr]    |                              ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "?".to_owned())`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]   --> src/main.rs:21:34
[INFO] [stderr]    |
[INFO] [stderr] 21 |                             .map(|ch| from_char(ch))
[INFO] [stderr]    |                                  ^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `from_char`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_closure)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/main.rs:14:5
[INFO] [stderr]    |
[INFO] [stderr] 14 | /     match components.split_last() {
[INFO] [stderr] 15 | |         Some((last, elems)) => {
[INFO] [stderr] 16 | |             for elem in elems {
[INFO] [stderr] 17 | |                 match elem {
[INFO] [stderr] ...  |
[INFO] [stderr] 31 | |         None => ()
[INFO] [stderr] 32 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 14 |     if let Some((last, elems)) = components.split_last() {
[INFO] [stderr] 15 |     for elem in elems {
[INFO] [stderr] 16 |         match elem {
[INFO] [stderr] 17 |             &Component::Normal(os_str) => {
[INFO] [stderr] 18 |                 let letter = os_str.to_str()
[INFO] [stderr] 19 |                     .and_then(|s| s.chars().next())
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/main.rs:17:17
[INFO] [stderr]    |
[INFO] [stderr] 17 | /                 match elem {
[INFO] [stderr] 18 | |                     &Component::Normal(os_str) => {
[INFO] [stderr] 19 | |                         let letter = os_str.to_str()
[INFO] [stderr] 20 | |                             .and_then(|s| s.chars().next())
[INFO] [stderr] ...  |
[INFO] [stderr] 25 | |                     _ => to_return.push(elem.as_os_str())
[INFO] [stderr] 26 | |                 }
[INFO] [stderr]    | |_________________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 17 |                 match *elem {
[INFO] [stderr] 18 |                     Component::Normal(os_str) => {
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> src/main.rs:22:30
[INFO] [stderr]    |
[INFO] [stderr] 22 |                             .unwrap_or("?".to_owned());
[INFO] [stderr]    |                              ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "?".to_owned())`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]   --> src/main.rs:21:34
[INFO] [stderr]    |
[INFO] [stderr] 21 |                             .map(|ch| from_char(ch))
[INFO] [stderr]    |                                  ^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `from_char`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_closure)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 0.76s
[INFO] running `"docker" "inspect" "a2bf5c5acd498a708c986674d572340594d43f2b6a5ea6ea23c03d0b52b8e03e"`
[INFO] running `"docker" "rm" "-f" "a2bf5c5acd498a708c986674d572340594d43f2b6a5ea6ea23c03d0b52b8e03e"`
[INFO] [stdout] a2bf5c5acd498a708c986674d572340594d43f2b6a5ea6ea23c03d0b52b8e03e