[INFO] updating cached repository hsolatges/Rust--Miller-Rabin-primality-test [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/hsolatges/Rust--Miller-Rabin-primality-test [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/hsolatges/Rust--Miller-Rabin-primality-test" "work/ex/clippy-test-run/sources/stable/gh/hsolatges/Rust--Miller-Rabin-primality-test"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/hsolatges/Rust--Miller-Rabin-primality-test'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/hsolatges/Rust--Miller-Rabin-primality-test" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/hsolatges/Rust--Miller-Rabin-primality-test"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/hsolatges/Rust--Miller-Rabin-primality-test'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 161c21a7eee9b68894dc35a60c31152dc82b3e60 [INFO] sha for GitHub repo hsolatges/Rust--Miller-Rabin-primality-test: 161c21a7eee9b68894dc35a60c31152dc82b3e60 [INFO] validating manifest of hsolatges/Rust--Miller-Rabin-primality-test on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of hsolatges/Rust--Miller-Rabin-primality-test on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing hsolatges/Rust--Miller-Rabin-primality-test [INFO] finished frobbing hsolatges/Rust--Miller-Rabin-primality-test [INFO] frobbed toml for hsolatges/Rust--Miller-Rabin-primality-test written to work/ex/clippy-test-run/sources/stable/gh/hsolatges/Rust--Miller-Rabin-primality-test/Cargo.toml [INFO] started frobbing hsolatges/Rust--Miller-Rabin-primality-test [INFO] finished frobbing hsolatges/Rust--Miller-Rabin-primality-test [INFO] frobbed toml for hsolatges/Rust--Miller-Rabin-primality-test written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/hsolatges/Rust--Miller-Rabin-primality-test/Cargo.toml [INFO] crate hsolatges/Rust--Miller-Rabin-primality-test has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting hsolatges/Rust--Miller-Rabin-primality-test against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/hsolatges/Rust--Miller-Rabin-primality-test:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 45c6f7d4c2787f7cb8d77cdbaca0c054f2e4f5cc7d4c354f490bcac4687be096 [INFO] running `"docker" "start" "-a" "45c6f7d4c2787f7cb8d77cdbaca0c054f2e4f5cc7d4c354f490bcac4687be096"` [INFO] [stderr] Checking miller_rabin_primality_test v0.0.1 (/opt/crater/workdir) [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:17:9 [INFO] [stderr] | [INFO] [stderr] 17 | sup = sup+1; [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `sup += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:18:9 [INFO] [stderr] | [INFO] [stderr] 18 | odd = odd/2; [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `odd /= 2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:28:5 [INFO] [stderr] | [INFO] [stderr] 28 | / let mut resp: bool = true; [INFO] [stderr] 29 | | [INFO] [stderr] 30 | | if rem == 1 || rem == n-1 { [INFO] [stderr] 31 | | resp = false; [INFO] [stderr] 32 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let resp = if rem == 1 || rem == n-1 { false } else { true };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:40:9 [INFO] [stderr] | [INFO] [stderr] 40 | sup = sup-1; [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `sup -= 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:17:9 [INFO] [stderr] | [INFO] [stderr] 17 | sup = sup+1; [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `sup += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:18:9 [INFO] [stderr] | [INFO] [stderr] 18 | odd = odd/2; [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `odd /= 2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:28:5 [INFO] [stderr] | [INFO] [stderr] 28 | / let mut resp: bool = true; [INFO] [stderr] 29 | | [INFO] [stderr] 30 | | if rem == 1 || rem == n-1 { [INFO] [stderr] 31 | | resp = false; [INFO] [stderr] 32 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let resp = if rem == 1 || rem == n-1 { false } else { true };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:40:9 [INFO] [stderr] | [INFO] [stderr] 40 | sup = sup-1; [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `sup -= 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.43s [INFO] running `"docker" "inspect" "45c6f7d4c2787f7cb8d77cdbaca0c054f2e4f5cc7d4c354f490bcac4687be096"` [INFO] running `"docker" "rm" "-f" "45c6f7d4c2787f7cb8d77cdbaca0c054f2e4f5cc7d4c354f490bcac4687be096"` [INFO] [stdout] 45c6f7d4c2787f7cb8d77cdbaca0c054f2e4f5cc7d4c354f490bcac4687be096