[INFO] updating cached repository howeih/Day-6-Postfix-notation [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/howeih/Day-6-Postfix-notation [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/howeih/Day-6-Postfix-notation" "work/ex/clippy-test-run/sources/stable/gh/howeih/Day-6-Postfix-notation"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/howeih/Day-6-Postfix-notation'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/howeih/Day-6-Postfix-notation" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/howeih/Day-6-Postfix-notation"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/howeih/Day-6-Postfix-notation'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 31b590a37cd4f2f1b12b611fd885e0a69cc42107 [INFO] sha for GitHub repo howeih/Day-6-Postfix-notation: 31b590a37cd4f2f1b12b611fd885e0a69cc42107 [INFO] validating manifest of howeih/Day-6-Postfix-notation on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of howeih/Day-6-Postfix-notation on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing howeih/Day-6-Postfix-notation [INFO] finished frobbing howeih/Day-6-Postfix-notation [INFO] frobbed toml for howeih/Day-6-Postfix-notation written to work/ex/clippy-test-run/sources/stable/gh/howeih/Day-6-Postfix-notation/Cargo.toml [INFO] started frobbing howeih/Day-6-Postfix-notation [INFO] finished frobbing howeih/Day-6-Postfix-notation [INFO] frobbed toml for howeih/Day-6-Postfix-notation written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/howeih/Day-6-Postfix-notation/Cargo.toml [INFO] crate howeih/Day-6-Postfix-notation has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting howeih/Day-6-Postfix-notation against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/howeih/Day-6-Postfix-notation:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] bf91b556ab7f799d999a329fe46040b04c72bd0e3a28244a8054da442ce47cdd [INFO] running `"docker" "start" "-a" "bf91b556ab7f799d999a329fe46040b04c72bd0e3a28244a8054da442ce47cdd"` [INFO] [stderr] Checking postfix v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:13:9 [INFO] [stderr] | [INFO] [stderr] 13 | / let mut x: f64; [INFO] [stderr] 14 | | if ops.contains_key(i){ [INFO] [stderr] 15 | | let op1 = stack.pop().unwrap(); [INFO] [stderr] 16 | | let op2 = stack.pop().unwrap(); [INFO] [stderr] ... | [INFO] [stderr] 20 | | x = i.parse::().unwrap(); [INFO] [stderr] 21 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let x = if ops.contains_key(i) { ..; op(op2,op1) } else { i.parse::().unwrap() };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:17:22 [INFO] [stderr] | [INFO] [stderr] 17 | let op = ops.get(i).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try this: `&ops[i]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:13:9 [INFO] [stderr] | [INFO] [stderr] 13 | / let mut x: f64; [INFO] [stderr] 14 | | if ops.contains_key(i){ [INFO] [stderr] 15 | | let op1 = stack.pop().unwrap(); [INFO] [stderr] 16 | | let op2 = stack.pop().unwrap(); [INFO] [stderr] ... | [INFO] [stderr] 20 | | x = i.parse::().unwrap(); [INFO] [stderr] 21 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let x = if ops.contains_key(i) { ..; op(op2,op1) } else { i.parse::().unwrap() };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:17:22 [INFO] [stderr] | [INFO] [stderr] 17 | let op = ops.get(i).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try this: `&ops[i]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.59s [INFO] running `"docker" "inspect" "bf91b556ab7f799d999a329fe46040b04c72bd0e3a28244a8054da442ce47cdd"` [INFO] running `"docker" "rm" "-f" "bf91b556ab7f799d999a329fe46040b04c72bd0e3a28244a8054da442ce47cdd"` [INFO] [stdout] bf91b556ab7f799d999a329fe46040b04c72bd0e3a28244a8054da442ce47cdd