[INFO] updating cached repository howeih/Day-29-String-searching
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/howeih/Day-29-String-searching
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/howeih/Day-29-String-searching" "work/ex/clippy-test-run/sources/stable/gh/howeih/Day-29-String-searching"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/howeih/Day-29-String-searching'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/howeih/Day-29-String-searching" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/howeih/Day-29-String-searching"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/howeih/Day-29-String-searching'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 994a5b7d42f10e5f0ff2f3d93a5e8775137fd3c0
[INFO] sha for GitHub repo howeih/Day-29-String-searching: 994a5b7d42f10e5f0ff2f3d93a5e8775137fd3c0
[INFO] validating manifest of howeih/Day-29-String-searching on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of howeih/Day-29-String-searching on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing howeih/Day-29-String-searching
[INFO] finished frobbing howeih/Day-29-String-searching
[INFO] frobbed toml for howeih/Day-29-String-searching written to work/ex/clippy-test-run/sources/stable/gh/howeih/Day-29-String-searching/Cargo.toml
[INFO] started frobbing howeih/Day-29-String-searching
[INFO] finished frobbing howeih/Day-29-String-searching
[INFO] frobbed toml for howeih/Day-29-String-searching written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/howeih/Day-29-String-searching/Cargo.toml
[INFO] crate howeih/Day-29-String-searching has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting howeih/Day-29-String-searching against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/howeih/Day-29-String-searching:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] a8089e7e317130ce34a733b4c0fa1b8e29029d37a4e9db42ec4ab71cd43d7251
[INFO] running `"docker" "start" "-a" "a8089e7e317130ce34a733b4c0fa1b8e29029d37a4e9db42ec4ab71cd43d7251"`
[INFO] [stderr]     Checking string_searching v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]   --> src/main.rs:12:16
[INFO] [stderr]    |
[INFO] [stderr] 12 |           } else {
[INFO] [stderr]    |  ________________^
[INFO] [stderr] 13 | |             if j == 0 {
[INFO] [stderr] 14 | |                 failure_function[i] = 0;
[INFO] [stderr] 15 | |                 i = i + 1;
[INFO] [stderr] ...  |
[INFO] [stderr] 18 | |             }
[INFO] [stderr] 19 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 12 |         } else if j == 0 {
[INFO] [stderr] 13 |     failure_function[i] = 0;
[INFO] [stderr] 14 |     i = i + 1;
[INFO] [stderr] 15 | } else {
[INFO] [stderr] 16 |     j = failure_function[j - 1];
[INFO] [stderr] 17 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: Unnecessary `>= y + 1` or `x - 1 >=`
[INFO] [stderr]   --> src/main.rs:36:12
[INFO] [stderr]    |
[INFO] [stderr] 36 |     while (t_i <= text_len - 1) && (p_i <= pattern_len - 1) {
[INFO] [stderr]    |            ^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::int_plus_one)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#int_plus_one
[INFO] [stderr] help: change `>= y + 1` to `> y` as shown
[INFO] [stderr]    |
[INFO] [stderr] 36 |     while (t_i < text_len) && (p_i <= pattern_len - 1) {
[INFO] [stderr]    |            ^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: Unnecessary `>= y + 1` or `x - 1 >=`
[INFO] [stderr]   --> src/main.rs:36:37
[INFO] [stderr]    |
[INFO] [stderr] 36 |     while (t_i <= text_len - 1) && (p_i <= pattern_len - 1) {
[INFO] [stderr]    |                                     ^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#int_plus_one
[INFO] [stderr] help: change `>= y + 1` to `> y` as shown
[INFO] [stderr]    |
[INFO] [stderr] 36 |     while (t_i <= text_len - 1) && (p_i < pattern_len) {
[INFO] [stderr]    |                                     ^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]   --> src/main.rs:12:16
[INFO] [stderr]    |
[INFO] [stderr] 12 |           } else {
[INFO] [stderr]    |  ________________^
[INFO] [stderr] 13 | |             if j == 0 {
[INFO] [stderr] 14 | |                 failure_function[i] = 0;
[INFO] [stderr] 15 | |                 i = i + 1;
[INFO] [stderr] ...  |
[INFO] [stderr] 18 | |             }
[INFO] [stderr] 19 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 12 |         } else if j == 0 {
[INFO] [stderr] 13 |     failure_function[i] = 0;
[INFO] [stderr] 14 |     i = i + 1;
[INFO] [stderr] 15 | } else {
[INFO] [stderr] 16 |     j = failure_function[j - 1];
[INFO] [stderr] 17 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: Unnecessary `>= y + 1` or `x - 1 >=`
[INFO] [stderr]   --> src/main.rs:36:12
[INFO] [stderr]    |
[INFO] [stderr] 36 |     while (t_i <= text_len - 1) && (p_i <= pattern_len - 1) {
[INFO] [stderr]    |            ^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::int_plus_one)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#int_plus_one
[INFO] [stderr] help: change `>= y + 1` to `> y` as shown
[INFO] [stderr]    |
[INFO] [stderr] 36 |     while (t_i < text_len) && (p_i <= pattern_len - 1) {
[INFO] [stderr]    |            ^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: Unnecessary `>= y + 1` or `x - 1 >=`
[INFO] [stderr]   --> src/main.rs:36:37
[INFO] [stderr]    |
[INFO] [stderr] 36 |     while (t_i <= text_len - 1) && (p_i <= pattern_len - 1) {
[INFO] [stderr]    |                                     ^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#int_plus_one
[INFO] [stderr] help: change `>= y + 1` to `> y` as shown
[INFO] [stderr]    |
[INFO] [stderr] 36 |     while (t_i <= text_len - 1) && (p_i < pattern_len) {
[INFO] [stderr]    |                                     ^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]  --> src/main.rs:1:35
[INFO] [stderr]   |
[INFO] [stderr] 1 | fn find_failure_function(pattern: &Vec<char>) -> Vec<usize> {
[INFO] [stderr]   |                                   ^^^^^^^^^^ help: change this to: `&[char]`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/main.rs:10:13
[INFO] [stderr]    |
[INFO] [stderr] 10 |             i = i + 1;
[INFO] [stderr]    |             ^^^^^^^^^ help: replace it with: `i += 1`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::assign_op_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/main.rs:11:13
[INFO] [stderr]    |
[INFO] [stderr] 11 |             j = j + 1;
[INFO] [stderr]    |             ^^^^^^^^^ help: replace it with: `j += 1`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/main.rs:15:17
[INFO] [stderr]    |
[INFO] [stderr] 15 |                 i = i + 1;
[INFO] [stderr]    |                 ^^^^^^^^^ help: replace it with: `i += 1`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/main.rs:26:14
[INFO] [stderr]    |
[INFO] [stderr] 26 |     pattern: &Vec<char>,
[INFO] [stderr]    |              ^^^^^^^^^^ help: change this to: `&[char]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/main.rs:41:13
[INFO] [stderr]    |
[INFO] [stderr] 41 |             t_i = t_i + 1;
[INFO] [stderr]    |             ^^^^^^^^^^^^^ help: replace it with: `t_i += 1`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/main.rs:42:13
[INFO] [stderr]    |
[INFO] [stderr] 42 |             p_i = p_i + 1;
[INFO] [stderr]    |             ^^^^^^^^^^^^^ help: replace it with: `p_i += 1`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/main.rs:52:13
[INFO] [stderr]    |
[INFO] [stderr] 52 |             t_i = t_i + 1;
[INFO] [stderr]    |             ^^^^^^^^^^^^^ help: replace it with: `t_i += 1`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]  --> src/main.rs:1:35
[INFO] [stderr]   |
[INFO] [stderr] 1 | fn find_failure_function(pattern: &Vec<char>) -> Vec<usize> {
[INFO] [stderr]   |                                   ^^^^^^^^^^ help: change this to: `&[char]`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/main.rs:10:13
[INFO] [stderr]    |
[INFO] [stderr] 10 |             i = i + 1;
[INFO] [stderr]    |             ^^^^^^^^^ help: replace it with: `i += 1`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::assign_op_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/main.rs:11:13
[INFO] [stderr]    |
[INFO] [stderr] 11 |             j = j + 1;
[INFO] [stderr]    |             ^^^^^^^^^ help: replace it with: `j += 1`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/main.rs:15:17
[INFO] [stderr]    |
[INFO] [stderr] 15 |                 i = i + 1;
[INFO] [stderr]    |                 ^^^^^^^^^ help: replace it with: `i += 1`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/main.rs:26:14
[INFO] [stderr]    |
[INFO] [stderr] 26 |     pattern: &Vec<char>,
[INFO] [stderr]    |              ^^^^^^^^^^ help: change this to: `&[char]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/main.rs:41:13
[INFO] [stderr]    |
[INFO] [stderr] 41 |             t_i = t_i + 1;
[INFO] [stderr]    |             ^^^^^^^^^^^^^ help: replace it with: `t_i += 1`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/main.rs:42:13
[INFO] [stderr]    |
[INFO] [stderr] 42 |             p_i = p_i + 1;
[INFO] [stderr]    |             ^^^^^^^^^^^^^ help: replace it with: `p_i += 1`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/main.rs:52:13
[INFO] [stderr]    |
[INFO] [stderr] 52 |             t_i = t_i + 1;
[INFO] [stderr]    |             ^^^^^^^^^^^^^ help: replace it with: `t_i += 1`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 0.33s
[INFO] running `"docker" "inspect" "a8089e7e317130ce34a733b4c0fa1b8e29029d37a4e9db42ec4ab71cd43d7251"`
[INFO] running `"docker" "rm" "-f" "a8089e7e317130ce34a733b4c0fa1b8e29029d37a4e9db42ec4ab71cd43d7251"`
[INFO] [stdout] a8089e7e317130ce34a733b4c0fa1b8e29029d37a4e9db42ec4ab71cd43d7251