[INFO] updating cached repository howeih/Day-28-Convex-hull [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/howeih/Day-28-Convex-hull [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/howeih/Day-28-Convex-hull" "work/ex/clippy-test-run/sources/stable/gh/howeih/Day-28-Convex-hull"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/howeih/Day-28-Convex-hull'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/howeih/Day-28-Convex-hull" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/howeih/Day-28-Convex-hull"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/howeih/Day-28-Convex-hull'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 572030e345dd76f75d070e986a9d08aa20d2b5a7 [INFO] sha for GitHub repo howeih/Day-28-Convex-hull: 572030e345dd76f75d070e986a9d08aa20d2b5a7 [INFO] validating manifest of howeih/Day-28-Convex-hull on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of howeih/Day-28-Convex-hull on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing howeih/Day-28-Convex-hull [INFO] finished frobbing howeih/Day-28-Convex-hull [INFO] frobbed toml for howeih/Day-28-Convex-hull written to work/ex/clippy-test-run/sources/stable/gh/howeih/Day-28-Convex-hull/Cargo.toml [INFO] started frobbing howeih/Day-28-Convex-hull [INFO] finished frobbing howeih/Day-28-Convex-hull [INFO] frobbed toml for howeih/Day-28-Convex-hull written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/howeih/Day-28-Convex-hull/Cargo.toml [INFO] crate howeih/Day-28-Convex-hull has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting howeih/Day-28-Convex-hull against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/howeih/Day-28-Convex-hull:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 739d9990565533e2048549a7fb3f0a3c5a47089ad93d91899b77c5601a946204 [INFO] running `"docker" "start" "-a" "739d9990565533e2048549a7fb3f0a3c5a47089ad93d91899b77c5601a946204"` [INFO] [stderr] Checking convex_hull v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:59:22 [INFO] [stderr] | [INFO] [stderr] 59 | ConvexHull { points: points } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `points` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:59:22 [INFO] [stderr] | [INFO] [stderr] 59 | ConvexHull { points: points } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `points` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:40:12 [INFO] [stderr] | [INFO] [stderr] 40 | } else { [INFO] [stderr] | ____________^ [INFO] [stderr] 41 | | if p1.x < p2.x { [INFO] [stderr] 42 | | Ordering::Less [INFO] [stderr] 43 | | } else { [INFO] [stderr] 44 | | Ordering::Greater [INFO] [stderr] 45 | | } [INFO] [stderr] 46 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 40 | } else if p1.x < p2.x { [INFO] [stderr] 41 | Ordering::Less [INFO] [stderr] 42 | } else { [INFO] [stderr] 43 | Ordering::Greater [INFO] [stderr] 44 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:40:12 [INFO] [stderr] | [INFO] [stderr] 40 | } else { [INFO] [stderr] | ____________^ [INFO] [stderr] 41 | | if p1.x < p2.x { [INFO] [stderr] 42 | | Ordering::Less [INFO] [stderr] 43 | | } else { [INFO] [stderr] 44 | | Ordering::Greater [INFO] [stderr] 45 | | } [INFO] [stderr] 46 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 40 | } else if p1.x < p2.x { [INFO] [stderr] 41 | Ordering::Less [INFO] [stderr] 42 | } else { [INFO] [stderr] 43 | Ordering::Greater [INFO] [stderr] 44 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.29s [INFO] running `"docker" "inspect" "739d9990565533e2048549a7fb3f0a3c5a47089ad93d91899b77c5601a946204"` [INFO] running `"docker" "rm" "-f" "739d9990565533e2048549a7fb3f0a3c5a47089ad93d91899b77c5601a946204"` [INFO] [stdout] 739d9990565533e2048549a7fb3f0a3c5a47089ad93d91899b77c5601a946204