[INFO] updating cached repository howeih/Day-26-Karger-mincut [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/howeih/Day-26-Karger-mincut [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/howeih/Day-26-Karger-mincut" "work/ex/clippy-test-run/sources/stable/gh/howeih/Day-26-Karger-mincut"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/howeih/Day-26-Karger-mincut'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/howeih/Day-26-Karger-mincut" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/howeih/Day-26-Karger-mincut"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/howeih/Day-26-Karger-mincut'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 7a5bd900f6ad0add235e517b49b438d20d44708e [INFO] sha for GitHub repo howeih/Day-26-Karger-mincut: 7a5bd900f6ad0add235e517b49b438d20d44708e [INFO] validating manifest of howeih/Day-26-Karger-mincut on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of howeih/Day-26-Karger-mincut on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing howeih/Day-26-Karger-mincut [INFO] finished frobbing howeih/Day-26-Karger-mincut [INFO] frobbed toml for howeih/Day-26-Karger-mincut written to work/ex/clippy-test-run/sources/stable/gh/howeih/Day-26-Karger-mincut/Cargo.toml [INFO] started frobbing howeih/Day-26-Karger-mincut [INFO] finished frobbing howeih/Day-26-Karger-mincut [INFO] frobbed toml for howeih/Day-26-Karger-mincut written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/howeih/Day-26-Karger-mincut/Cargo.toml [INFO] crate howeih/Day-26-Karger-mincut has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting howeih/Day-26-Karger-mincut against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/howeih/Day-26-Karger-mincut:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 1a2d2e9948184365961e860fdf38c07ab63230529551e48ef75dea0a92da2592 [INFO] running `"docker" "start" "-a" "1a2d2e9948184365961e860fdf38c07ab63230529551e48ef75dea0a92da2592"` [INFO] [stderr] Checking Kargers_mincut v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: crate `Kargers_mincut` should have a snake case name such as `kargers_mincut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:34:5 [INFO] [stderr] | [INFO] [stderr] 34 | / let mut edge_idx = 0; [INFO] [stderr] 35 | | if graph_len > 0 { [INFO] [stderr] 36 | | edge_idx = rng.gen_range(0, graph.len()); [INFO] [stderr] 37 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let edge_idx = if graph_len > 0 { rng.gen_range(0, graph.len()) } else { 0 };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: called `.iter().nth()` on a slice. Calling `.get()` is both faster and more readable [INFO] [stderr] --> src/main.rs:38:5 [INFO] [stderr] | [INFO] [stderr] 38 | graph.iter().nth(edge_idx).unwrap().clone() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::iter_nth)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_nth [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:41:18 [INFO] [stderr] | [INFO] [stderr] 41 | fn mincut(graph: &Vec<(String, String)>, n: i32) -> ((String,String), usize){ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 41 | fn mincut(graph: &[(String, String)], n: i32) -> ((String,String), usize){ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] help: change `graph.clone()` to [INFO] [stderr] | [INFO] [stderr] 45 | let mut aux = graph.to_owned(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: crate `Kargers_mincut` should have a snake case name such as `kargers_mincut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:34:5 [INFO] [stderr] | [INFO] [stderr] 34 | / let mut edge_idx = 0; [INFO] [stderr] 35 | | if graph_len > 0 { [INFO] [stderr] 36 | | edge_idx = rng.gen_range(0, graph.len()); [INFO] [stderr] 37 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let edge_idx = if graph_len > 0 { rng.gen_range(0, graph.len()) } else { 0 };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: called `.iter().nth()` on a slice. Calling `.get()` is both faster and more readable [INFO] [stderr] --> src/main.rs:38:5 [INFO] [stderr] | [INFO] [stderr] 38 | graph.iter().nth(edge_idx).unwrap().clone() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::iter_nth)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_nth [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:41:18 [INFO] [stderr] | [INFO] [stderr] 41 | fn mincut(graph: &Vec<(String, String)>, n: i32) -> ((String,String), usize){ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 41 | fn mincut(graph: &[(String, String)], n: i32) -> ((String,String), usize){ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] help: change `graph.clone()` to [INFO] [stderr] | [INFO] [stderr] 45 | let mut aux = graph.to_owned(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.52s [INFO] running `"docker" "inspect" "1a2d2e9948184365961e860fdf38c07ab63230529551e48ef75dea0a92da2592"` [INFO] running `"docker" "rm" "-f" "1a2d2e9948184365961e860fdf38c07ab63230529551e48ef75dea0a92da2592"` [INFO] [stdout] 1a2d2e9948184365961e860fdf38c07ab63230529551e48ef75dea0a92da2592