[INFO] updating cached repository howeih/Day-19-Counting-inversions [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/howeih/Day-19-Counting-inversions [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/howeih/Day-19-Counting-inversions" "work/ex/clippy-test-run/sources/stable/gh/howeih/Day-19-Counting-inversions"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/howeih/Day-19-Counting-inversions'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/howeih/Day-19-Counting-inversions" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/howeih/Day-19-Counting-inversions"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/howeih/Day-19-Counting-inversions'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] eb628a7dd3f3ee712dd784f2ff40cf122ffb4c11 [INFO] sha for GitHub repo howeih/Day-19-Counting-inversions: eb628a7dd3f3ee712dd784f2ff40cf122ffb4c11 [INFO] validating manifest of howeih/Day-19-Counting-inversions on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of howeih/Day-19-Counting-inversions on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing howeih/Day-19-Counting-inversions [INFO] finished frobbing howeih/Day-19-Counting-inversions [INFO] frobbed toml for howeih/Day-19-Counting-inversions written to work/ex/clippy-test-run/sources/stable/gh/howeih/Day-19-Counting-inversions/Cargo.toml [INFO] started frobbing howeih/Day-19-Counting-inversions [INFO] finished frobbing howeih/Day-19-Counting-inversions [INFO] frobbed toml for howeih/Day-19-Counting-inversions written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/howeih/Day-19-Counting-inversions/Cargo.toml [INFO] crate howeih/Day-19-Counting-inversions has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting howeih/Day-19-Counting-inversions against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/howeih/Day-19-Counting-inversions:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 67106d18d3e305d8877788253c3043d75915d395735100e4b073a74c8aa2c87d [INFO] running `"docker" "start" "-a" "67106d18d3e305d8877788253c3043d75915d395735100e4b073a74c8aa2c87d"` [INFO] [stderr] Checking counting_inversions v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: the loop variable `l` is only used to index `items`. [INFO] [stderr] --> src/main.rs:26:14 [INFO] [stderr] | [INFO] [stderr] 26 | for l in i..mid { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 26 | for in items.iter().take(mid).skip(i) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `r` is only used to index `items`. [INFO] [stderr] --> src/main.rs:29:14 [INFO] [stderr] | [INFO] [stderr] 29 | for r in j..end { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 29 | for in items.iter().take(end).skip(j) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `items`. [INFO] [stderr] --> src/main.rs:33:14 [INFO] [stderr] | [INFO] [stderr] 33 | for i in left..end { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 33 | for in items.iter_mut().take(end).skip(left) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the variable `merge_i` is used as a loop counter. Consider using `for (merge_i, item) in left..end.enumerate()` or similar iterators [INFO] [stderr] --> src/main.rs:33:14 [INFO] [stderr] | [INFO] [stderr] 33 | for i in left..end { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: the loop variable `l` is only used to index `items`. [INFO] [stderr] --> src/main.rs:26:14 [INFO] [stderr] | [INFO] [stderr] 26 | for l in i..mid { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 26 | for in items.iter().take(mid).skip(i) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `r` is only used to index `items`. [INFO] [stderr] --> src/main.rs:29:14 [INFO] [stderr] | [INFO] [stderr] 29 | for r in j..end { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 29 | for in items.iter().take(end).skip(j) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `items`. [INFO] [stderr] --> src/main.rs:33:14 [INFO] [stderr] | [INFO] [stderr] 33 | for i in left..end { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 33 | for in items.iter_mut().take(end).skip(left) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the variable `merge_i` is used as a loop counter. Consider using `for (merge_i, item) in left..end.enumerate()` or similar iterators [INFO] [stderr] --> src/main.rs:33:14 [INFO] [stderr] | [INFO] [stderr] 33 | for i in left..end { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.51s [INFO] running `"docker" "inspect" "67106d18d3e305d8877788253c3043d75915d395735100e4b073a74c8aa2c87d"` [INFO] running `"docker" "rm" "-f" "67106d18d3e305d8877788253c3043d75915d395735100e4b073a74c8aa2c87d"` [INFO] [stdout] 67106d18d3e305d8877788253c3043d75915d395735100e4b073a74c8aa2c87d