[INFO] updating cached repository homsterius/rust-craftinginterpreters [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/homsterius/rust-craftinginterpreters [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/homsterius/rust-craftinginterpreters" "work/ex/clippy-test-run/sources/stable/gh/homsterius/rust-craftinginterpreters"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/homsterius/rust-craftinginterpreters'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/homsterius/rust-craftinginterpreters" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/homsterius/rust-craftinginterpreters"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/homsterius/rust-craftinginterpreters'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] db4dd8d31f5bbaa8e900c9ed6317bd3c59abaf84 [INFO] sha for GitHub repo homsterius/rust-craftinginterpreters: db4dd8d31f5bbaa8e900c9ed6317bd3c59abaf84 [INFO] validating manifest of homsterius/rust-craftinginterpreters on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of homsterius/rust-craftinginterpreters on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing homsterius/rust-craftinginterpreters [INFO] finished frobbing homsterius/rust-craftinginterpreters [INFO] frobbed toml for homsterius/rust-craftinginterpreters written to work/ex/clippy-test-run/sources/stable/gh/homsterius/rust-craftinginterpreters/Cargo.toml [INFO] started frobbing homsterius/rust-craftinginterpreters [INFO] finished frobbing homsterius/rust-craftinginterpreters [INFO] frobbed toml for homsterius/rust-craftinginterpreters written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/homsterius/rust-craftinginterpreters/Cargo.toml [INFO] crate homsterius/rust-craftinginterpreters has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting homsterius/rust-craftinginterpreters against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/homsterius/rust-craftinginterpreters:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 5401034b562c1b7306729a367d6cfd9ae3a97398c5c1a4c037ecd44cb11e6430 [INFO] running `"docker" "start" "-a" "5401034b562c1b7306729a367d6cfd9ae3a97398c5c1a4c037ecd44cb11e6430"` [INFO] [stderr] Checking lox v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lox/ast_printer.rs:8:9 [INFO] [stderr] | [INFO] [stderr] 8 | return expr.accept(self); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `expr.accept(self)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lox/ast_printer.rs:8:9 [INFO] [stderr] | [INFO] [stderr] 8 | return expr.accept(self); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `expr.accept(self)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lox/scanner.rs:139:35 [INFO] [stderr] | [INFO] [stderr] 139 | let lexeme = &self.source[self.current..self.current + 1]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `self.current..=self.current` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lox/scanner.rs:153:23 [INFO] [stderr] | [INFO] [stderr] 153 | (&self.source[self.current..self.current + 1]).parse().unwrap() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `self.current..=self.current` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/lox/expr.rs:26:5 [INFO] [stderr] | [INFO] [stderr] 26 | / pub fn new(left: ExprRef<'a>, operator: Rc>, right: ExprRef<'a>) -> ExprRef<'a> { [INFO] [stderr] 27 | | Rc::new(Binary { [INFO] [stderr] 28 | | left, [INFO] [stderr] 29 | | operator, [INFO] [stderr] 30 | | right, [INFO] [stderr] 31 | | }) [INFO] [stderr] 32 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_ret_no_self)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/lox/expr.rs:47:5 [INFO] [stderr] | [INFO] [stderr] 47 | / pub fn new(expression: ExprRef<'a>) -> ExprRef<'a> { [INFO] [stderr] 48 | | Rc::new(Grouping { expression }) [INFO] [stderr] 49 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/lox/expr.rs:64:5 [INFO] [stderr] | [INFO] [stderr] 64 | / pub fn new(value: TokenLiteral<'a>) -> ExprRef<'a> { [INFO] [stderr] 65 | | Rc::new(Literal { value }) [INFO] [stderr] 66 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/lox/expr.rs:82:5 [INFO] [stderr] | [INFO] [stderr] 82 | / pub fn new(operator: Rc>, right: ExprRef<'a>) -> ExprRef<'a> { [INFO] [stderr] 83 | | Rc::new(Unary { [INFO] [stderr] 84 | | operator, [INFO] [stderr] 85 | | right, [INFO] [stderr] 86 | | }) [INFO] [stderr] 87 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lox/parser.rs:11:24 [INFO] [stderr] | [INFO] [stderr] 11 | pub fn new(tokens: &'a Vec>>) -> Parser<'a> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[Rc>]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `lox::Lox` [INFO] [stderr] --> src/lox/mod.rs:23:5 [INFO] [stderr] | [INFO] [stderr] 23 | / pub fn new() -> Lox { [INFO] [stderr] 24 | | Lox { [INFO] [stderr] 25 | | had_error: false, [INFO] [stderr] 26 | | } [INFO] [stderr] 27 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 18 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/lox/mod.rs:31:13 [INFO] [stderr] | [INFO] [stderr] 31 | io::stdout().write("> ".as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/lox/mod.rs:31:32 [INFO] [stderr] | [INFO] [stderr] 31 | io::stdout().write("> ".as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"> "` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::string_lit_as_bytes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lox/mod.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | / match expression { [INFO] [stderr] 64 | | Some(expr) => { [INFO] [stderr] 65 | | let ast_printer = AstPrinter {}; [INFO] [stderr] 66 | | println!("{}", ast_printer.print(expr.as_ref())); [INFO] [stderr] 67 | | }, [INFO] [stderr] 68 | | _ => {}, [INFO] [stderr] 69 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 63 | if let Some(expr) = expression { [INFO] [stderr] 64 | let ast_printer = AstPrinter {}; [INFO] [stderr] 65 | println!("{}", ast_printer.print(expr.as_ref())); [INFO] [stderr] 66 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/lox/mod.rs:86:9 [INFO] [stderr] | [INFO] [stderr] 86 | io::stderr().write(s.as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `lox`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lox/scanner.rs:139:35 [INFO] [stderr] | [INFO] [stderr] 139 | let lexeme = &self.source[self.current..self.current + 1]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `self.current..=self.current` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lox/scanner.rs:153:23 [INFO] [stderr] | [INFO] [stderr] 153 | (&self.source[self.current..self.current + 1]).parse().unwrap() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `self.current..=self.current` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/lox/expr.rs:26:5 [INFO] [stderr] | [INFO] [stderr] 26 | / pub fn new(left: ExprRef<'a>, operator: Rc>, right: ExprRef<'a>) -> ExprRef<'a> { [INFO] [stderr] 27 | | Rc::new(Binary { [INFO] [stderr] 28 | | left, [INFO] [stderr] 29 | | operator, [INFO] [stderr] 30 | | right, [INFO] [stderr] 31 | | }) [INFO] [stderr] 32 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_ret_no_self)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/lox/expr.rs:47:5 [INFO] [stderr] | [INFO] [stderr] 47 | / pub fn new(expression: ExprRef<'a>) -> ExprRef<'a> { [INFO] [stderr] 48 | | Rc::new(Grouping { expression }) [INFO] [stderr] 49 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/lox/expr.rs:64:5 [INFO] [stderr] | [INFO] [stderr] 64 | / pub fn new(value: TokenLiteral<'a>) -> ExprRef<'a> { [INFO] [stderr] 65 | | Rc::new(Literal { value }) [INFO] [stderr] 66 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/lox/expr.rs:82:5 [INFO] [stderr] | [INFO] [stderr] 82 | / pub fn new(operator: Rc>, right: ExprRef<'a>) -> ExprRef<'a> { [INFO] [stderr] 83 | | Rc::new(Unary { [INFO] [stderr] 84 | | operator, [INFO] [stderr] 85 | | right, [INFO] [stderr] 86 | | }) [INFO] [stderr] 87 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lox/parser.rs:11:24 [INFO] [stderr] | [INFO] [stderr] 11 | pub fn new(tokens: &'a Vec>>) -> Parser<'a> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[Rc>]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `lox::Lox` [INFO] [stderr] --> src/lox/mod.rs:23:5 [INFO] [stderr] | [INFO] [stderr] 23 | / pub fn new() -> Lox { [INFO] [stderr] 24 | | Lox { [INFO] [stderr] 25 | | had_error: false, [INFO] [stderr] 26 | | } [INFO] [stderr] 27 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 18 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/lox/mod.rs:31:13 [INFO] [stderr] | [INFO] [stderr] 31 | io::stdout().write("> ".as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/lox/mod.rs:31:32 [INFO] [stderr] | [INFO] [stderr] 31 | io::stdout().write("> ".as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"> "` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::string_lit_as_bytes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lox/mod.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | / match expression { [INFO] [stderr] 64 | | Some(expr) => { [INFO] [stderr] 65 | | let ast_printer = AstPrinter {}; [INFO] [stderr] 66 | | println!("{}", ast_printer.print(expr.as_ref())); [INFO] [stderr] 67 | | }, [INFO] [stderr] 68 | | _ => {}, [INFO] [stderr] 69 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 63 | if let Some(expr) = expression { [INFO] [stderr] 64 | let ast_printer = AstPrinter {}; [INFO] [stderr] 65 | println!("{}", ast_printer.print(expr.as_ref())); [INFO] [stderr] 66 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/lox/mod.rs:86:9 [INFO] [stderr] | [INFO] [stderr] 86 | io::stderr().write(s.as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `lox`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "5401034b562c1b7306729a367d6cfd9ae3a97398c5c1a4c037ecd44cb11e6430"` [INFO] running `"docker" "rm" "-f" "5401034b562c1b7306729a367d6cfd9ae3a97398c5c1a4c037ecd44cb11e6430"` [INFO] [stdout] 5401034b562c1b7306729a367d6cfd9ae3a97398c5c1a4c037ecd44cb11e6430