[INFO] updating cached repository holsee/bloom_spell [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/holsee/bloom_spell [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/holsee/bloom_spell" "work/ex/clippy-test-run/sources/stable/gh/holsee/bloom_spell"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/holsee/bloom_spell'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/holsee/bloom_spell" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/holsee/bloom_spell"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/holsee/bloom_spell'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] d0c9ae7b86f3feb423a6b1847d904c1eb9807cd4 [INFO] sha for GitHub repo holsee/bloom_spell: d0c9ae7b86f3feb423a6b1847d904c1eb9807cd4 [INFO] validating manifest of holsee/bloom_spell on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of holsee/bloom_spell on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing holsee/bloom_spell [INFO] finished frobbing holsee/bloom_spell [INFO] frobbed toml for holsee/bloom_spell written to work/ex/clippy-test-run/sources/stable/gh/holsee/bloom_spell/Cargo.toml [INFO] started frobbing holsee/bloom_spell [INFO] finished frobbing holsee/bloom_spell [INFO] frobbed toml for holsee/bloom_spell written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/holsee/bloom_spell/Cargo.toml [INFO] crate holsee/bloom_spell has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting holsee/bloom_spell against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/holsee/bloom_spell:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 4d2287f3cd4904e757002ca8571a0fa684597265ad3eda0915dfae840d8484a7 [INFO] running `"docker" "start" "-a" "4d2287f3cd4904e757002ca8571a0fa684597265ad3eda0915dfae840d8484a7"` [INFO] [stderr] Checking bitvec-rs v0.1.0 [INFO] [stderr] Checking bloom_spell v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/util/bloom_filter.rs:28:13 [INFO] [stderr] | [INFO] [stderr] 28 | hash_count: hash_count [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `hash_count` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/util/bloom_filter.rs:28:13 [INFO] [stderr] | [INFO] [stderr] 28 | hash_count: hash_count [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `hash_count` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/util/bloom_filter.rs:60:35 [INFO] [stderr] | [INFO] [stderr] 60 | let indices: Vec = hash_range.into_iter() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `hash_range` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/util/bloom_filter.rs:63:74 [INFO] [stderr] | [INFO] [stderr] 63 | let hash: f64 = hash_a + (i as f64) * hash_b; [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(i)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/util/bloom_filter.rs:60:35 [INFO] [stderr] | [INFO] [stderr] 60 | let indices: Vec = hash_range.into_iter() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `hash_range` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/util/bloom_filter.rs:63:74 [INFO] [stderr] | [INFO] [stderr] 63 | let hash: f64 = hash_a + (i as f64) * hash_b; [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(i)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `foo` [INFO] [stderr] --> src/main.rs:15:9 [INFO] [stderr] | [INFO] [stderr] 15 | let foo = bf.maybe_contains("foo"); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::blacklisted_name)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `foo` [INFO] [stderr] --> src/main.rs:15:9 [INFO] [stderr] | [INFO] [stderr] 15 | let foo = bf.maybe_contains("foo"); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::blacklisted_name)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.33s [INFO] running `"docker" "inspect" "4d2287f3cd4904e757002ca8571a0fa684597265ad3eda0915dfae840d8484a7"` [INFO] running `"docker" "rm" "-f" "4d2287f3cd4904e757002ca8571a0fa684597265ad3eda0915dfae840d8484a7"` [INFO] [stdout] 4d2287f3cd4904e757002ca8571a0fa684597265ad3eda0915dfae840d8484a7