[INFO] updating cached repository hindenbug/rtstc
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/hindenbug/rtstc
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/hindenbug/rtstc" "work/ex/clippy-test-run/sources/stable/gh/hindenbug/rtstc"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/hindenbug/rtstc'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/hindenbug/rtstc" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/hindenbug/rtstc"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/hindenbug/rtstc'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 25f582d234f2b087ba11dce1444a7ca4290386bc
[INFO] sha for GitHub repo hindenbug/rtstc: 25f582d234f2b087ba11dce1444a7ca4290386bc
[INFO] validating manifest of hindenbug/rtstc on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of hindenbug/rtstc on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing hindenbug/rtstc
[INFO] finished frobbing hindenbug/rtstc
[INFO] frobbed toml for hindenbug/rtstc written to work/ex/clippy-test-run/sources/stable/gh/hindenbug/rtstc/Cargo.toml
[INFO] started frobbing hindenbug/rtstc
[INFO] finished frobbing hindenbug/rtstc
[INFO] frobbed toml for hindenbug/rtstc written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/hindenbug/rtstc/Cargo.toml
[INFO] crate hindenbug/rtstc has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting hindenbug/rtstc against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/hindenbug/rtstc:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 10130a8243d35c754631248034d4c97bfab11b48d18e8d2c1ebfa7cba097a345
[INFO] running `"docker" "start" "-a" "10130a8243d35c754631248034d4c97bfab11b48d18e8d2c1ebfa7cba097a345"`
[INFO] [stderr]     Checking rtstc v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/parser.rs:43:29
[INFO] [stderr]    |
[INFO] [stderr] 43 |                             params: params,
[INFO] [stderr]    |                             ^^^^^^^^^^^^^^ help: replace it with: `params`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/parser.rs:43:29
[INFO] [stderr]    |
[INFO] [stderr] 43 |                             params: params,
[INFO] [stderr]    |                             ^^^^^^^^^^^^^^ help: replace it with: `params`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/parser.rs:52:14
[INFO] [stderr]    |
[INFO] [stderr] 52 |         _ => return Err("Error".to_string()),
[INFO] [stderr]    |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err("Error".to_string())`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/parser.rs:52:14
[INFO] [stderr]    |
[INFO] [stderr] 52 |         _ => return Err("Error".to_string()),
[INFO] [stderr]    |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err("Error".to_string())`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `ast`
[INFO] [stderr]  --> src/traverser.rs:8:17
[INFO] [stderr]   |
[INFO] [stderr] 8 | pub fn traverse(ast: ::parser::Node) {
[INFO] [stderr]   |                 ^^^ help: consider using `_ast` instead
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(unused_variables)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: struct is never constructed: `Visitor`
[INFO] [stderr]  --> src/traverser.rs:1:1
[INFO] [stderr]   |
[INFO] [stderr] 1 | struct Visitor {
[INFO] [stderr]   | ^^^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: function is never used: `traverse`
[INFO] [stderr]  --> src/traverser.rs:8:1
[INFO] [stderr]   |
[INFO] [stderr] 8 | pub fn traverse(ast: ::parser::Node) {
[INFO] [stderr]   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/parser.rs:56:22
[INFO] [stderr]    |
[INFO] [stderr] 56 | pub fn parse(tokens: &Vec<::tokenizer::Token>) -> Result<Node, String> {
[INFO] [stderr]    |                      ^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[::tokenizer::Token]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec
[INFO] [stderr]   --> src/parser.rs:58:34
[INFO] [stderr]    |
[INFO] [stderr] 58 |     let mut tokens_iter = tokens.into_iter();
[INFO] [stderr]    |                                  ^^^^^^^^^ help: call directly: `iter`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::into_iter_on_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/tokenizer.rs:62:21
[INFO] [stderr]    |
[INFO] [stderr] 62 | /                     match c {
[INFO] [stderr] 63 | |                         &'"' => {
[INFO] [stderr] 64 | |                             chars_.next().unwrap();
[INFO] [stderr] 65 | |                             break;
[INFO] [stderr] 66 | |                         }
[INFO] [stderr] 67 | |                         _ => str_.push(chars_.next().unwrap()),
[INFO] [stderr] 68 | |                     }
[INFO] [stderr]    | |_____________________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 62 |                     match *c {
[INFO] [stderr] 63 |                         '"' => {
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `ast`
[INFO] [stderr]  --> src/traverser.rs:8:17
[INFO] [stderr]   |
[INFO] [stderr] 8 | pub fn traverse(ast: ::parser::Node) {
[INFO] [stderr]   |                 ^^^ help: consider using `_ast` instead
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(unused_variables)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: struct is never constructed: `Visitor`
[INFO] [stderr]  --> src/traverser.rs:1:1
[INFO] [stderr]   |
[INFO] [stderr] 1 | struct Visitor {
[INFO] [stderr]   | ^^^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/parser.rs:56:22
[INFO] [stderr]    |
[INFO] [stderr] 56 | pub fn parse(tokens: &Vec<::tokenizer::Token>) -> Result<Node, String> {
[INFO] [stderr]    |                      ^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[::tokenizer::Token]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec
[INFO] [stderr]   --> src/parser.rs:58:34
[INFO] [stderr]    |
[INFO] [stderr] 58 |     let mut tokens_iter = tokens.into_iter();
[INFO] [stderr]    |                                  ^^^^^^^^^ help: call directly: `iter`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::into_iter_on_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/tokenizer.rs:62:21
[INFO] [stderr]    |
[INFO] [stderr] 62 | /                     match c {
[INFO] [stderr] 63 | |                         &'"' => {
[INFO] [stderr] 64 | |                             chars_.next().unwrap();
[INFO] [stderr] 65 | |                             break;
[INFO] [stderr] 66 | |                         }
[INFO] [stderr] 67 | |                         _ => str_.push(chars_.next().unwrap()),
[INFO] [stderr] 68 | |                     }
[INFO] [stderr]    | |_____________________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 62 |                     match *c {
[INFO] [stderr] 63 |                         '"' => {
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 0.53s
[INFO] running `"docker" "inspect" "10130a8243d35c754631248034d4c97bfab11b48d18e8d2c1ebfa7cba097a345"`
[INFO] running `"docker" "rm" "-f" "10130a8243d35c754631248034d4c97bfab11b48d18e8d2c1ebfa7cba097a345"`
[INFO] [stdout] 10130a8243d35c754631248034d4c97bfab11b48d18e8d2c1ebfa7cba097a345