[INFO] updating cached repository hgoldstein95/impterpreter [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/hgoldstein95/impterpreter [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/hgoldstein95/impterpreter" "work/ex/clippy-test-run/sources/stable/gh/hgoldstein95/impterpreter"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/hgoldstein95/impterpreter'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/hgoldstein95/impterpreter" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/hgoldstein95/impterpreter"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/hgoldstein95/impterpreter'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] b131c79d803d1027487f7f252f997d47ee66f38a [INFO] sha for GitHub repo hgoldstein95/impterpreter: b131c79d803d1027487f7f252f997d47ee66f38a [INFO] validating manifest of hgoldstein95/impterpreter on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of hgoldstein95/impterpreter on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing hgoldstein95/impterpreter [INFO] finished frobbing hgoldstein95/impterpreter [INFO] frobbed toml for hgoldstein95/impterpreter written to work/ex/clippy-test-run/sources/stable/gh/hgoldstein95/impterpreter/Cargo.toml [INFO] started frobbing hgoldstein95/impterpreter [INFO] finished frobbing hgoldstein95/impterpreter [INFO] frobbed toml for hgoldstein95/impterpreter written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/hgoldstein95/impterpreter/Cargo.toml [INFO] crate hgoldstein95/impterpreter has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting hgoldstein95/impterpreter against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/hgoldstein95/impterpreter:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 656af7eedae52ebfc2888ff5c417cca433e8089f07f0ee89ad5e77897ceee5fd [INFO] running `"docker" "start" "-a" "656af7eedae52ebfc2888ff5c417cca433e8089f07f0ee89ad5e77897ceee5fd"` [INFO] [stderr] Checking impterpreter v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/interpreter/mod.rs:24:9 [INFO] [stderr] | [INFO] [stderr] 24 | / match a { [INFO] [stderr] 25 | | &Num(n) => Ok(n), [INFO] [stderr] 26 | | &Var(ref s) => { [INFO] [stderr] 27 | | if let Some(&n) = self.store.get(s) { [INFO] [stderr] ... | [INFO] [stderr] 42 | | } [INFO] [stderr] 43 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 24 | match *a { [INFO] [stderr] 25 | Num(n) => Ok(n), [INFO] [stderr] 26 | Var(ref s) => { [INFO] [stderr] 27 | if let Some(&n) = self.store.get(s) { [INFO] [stderr] 28 | Ok(n) [INFO] [stderr] 29 | } else { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/interpreter/mod.rs:50:9 [INFO] [stderr] | [INFO] [stderr] 50 | / match b { [INFO] [stderr] 51 | | &True => Ok(true), [INFO] [stderr] 52 | | &False => Ok(false), [INFO] [stderr] 53 | | &Less(ref a1, ref a2) => { [INFO] [stderr] ... | [INFO] [stderr] 57 | | } [INFO] [stderr] 58 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 50 | match *b { [INFO] [stderr] 51 | True => Ok(true), [INFO] [stderr] 52 | False => Ok(false), [INFO] [stderr] 53 | Less(ref a1, ref a2) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/interpreter/mod.rs:65:9 [INFO] [stderr] | [INFO] [stderr] 65 | / match c { [INFO] [stderr] 66 | | &Skip => Ok(()), [INFO] [stderr] 67 | | &Seq(ref c1, ref c2) => { [INFO] [stderr] 68 | | self.eval(c1).and(self.eval(c2).and(Ok(()))) [INFO] [stderr] ... | [INFO] [stderr] 93 | | } [INFO] [stderr] 94 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 65 | match *c { [INFO] [stderr] 66 | Skip => Ok(()), [INFO] [stderr] 67 | Seq(ref c1, ref c2) => { [INFO] [stderr] 68 | self.eval(c1).and(self.eval(c2).and(Ok(()))) [INFO] [stderr] 69 | } [INFO] [stderr] 70 | Assgn(ref s, ref a) => { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/interpreter/mod.rs:24:9 [INFO] [stderr] | [INFO] [stderr] 24 | / match a { [INFO] [stderr] 25 | | &Num(n) => Ok(n), [INFO] [stderr] 26 | | &Var(ref s) => { [INFO] [stderr] 27 | | if let Some(&n) = self.store.get(s) { [INFO] [stderr] ... | [INFO] [stderr] 42 | | } [INFO] [stderr] 43 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 24 | match *a { [INFO] [stderr] 25 | Num(n) => Ok(n), [INFO] [stderr] 26 | Var(ref s) => { [INFO] [stderr] 27 | if let Some(&n) = self.store.get(s) { [INFO] [stderr] 28 | Ok(n) [INFO] [stderr] 29 | } else { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/interpreter/mod.rs:50:9 [INFO] [stderr] | [INFO] [stderr] 50 | / match b { [INFO] [stderr] 51 | | &True => Ok(true), [INFO] [stderr] 52 | | &False => Ok(false), [INFO] [stderr] 53 | | &Less(ref a1, ref a2) => { [INFO] [stderr] ... | [INFO] [stderr] 57 | | } [INFO] [stderr] 58 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 50 | match *b { [INFO] [stderr] 51 | True => Ok(true), [INFO] [stderr] 52 | False => Ok(false), [INFO] [stderr] 53 | Less(ref a1, ref a2) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/interpreter/mod.rs:65:9 [INFO] [stderr] | [INFO] [stderr] 65 | / match c { [INFO] [stderr] 66 | | &Skip => Ok(()), [INFO] [stderr] 67 | | &Seq(ref c1, ref c2) => { [INFO] [stderr] 68 | | self.eval(c1).and(self.eval(c2).and(Ok(()))) [INFO] [stderr] ... | [INFO] [stderr] 93 | | } [INFO] [stderr] 94 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 65 | match *c { [INFO] [stderr] 66 | Skip => Ok(()), [INFO] [stderr] 67 | Seq(ref c1, ref c2) => { [INFO] [stderr] 68 | self.eval(c1).and(self.eval(c2).and(Ok(()))) [INFO] [stderr] 69 | } [INFO] [stderr] 70 | Assgn(ref s, ref a) => { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.40s [INFO] running `"docker" "inspect" "656af7eedae52ebfc2888ff5c417cca433e8089f07f0ee89ad5e77897ceee5fd"` [INFO] running `"docker" "rm" "-f" "656af7eedae52ebfc2888ff5c417cca433e8089f07f0ee89ad5e77897ceee5fd"` [INFO] [stdout] 656af7eedae52ebfc2888ff5c417cca433e8089f07f0ee89ad5e77897ceee5fd