[INFO] updating cached repository heychenbin/nes [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/heychenbin/nes [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/heychenbin/nes" "work/ex/clippy-test-run/sources/stable/gh/heychenbin/nes"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/heychenbin/nes'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/heychenbin/nes" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/heychenbin/nes"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/heychenbin/nes'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 7f0c53df4e2a645383cc1308d67ddf96b4c17818 [INFO] sha for GitHub repo heychenbin/nes: 7f0c53df4e2a645383cc1308d67ddf96b4c17818 [INFO] validating manifest of heychenbin/nes on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of heychenbin/nes on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing heychenbin/nes [INFO] finished frobbing heychenbin/nes [INFO] frobbed toml for heychenbin/nes written to work/ex/clippy-test-run/sources/stable/gh/heychenbin/nes/Cargo.toml [INFO] started frobbing heychenbin/nes [INFO] finished frobbing heychenbin/nes [INFO] frobbed toml for heychenbin/nes written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/heychenbin/nes/Cargo.toml [INFO] crate heychenbin/nes has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting heychenbin/nes against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/heychenbin/nes:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a7f5a3fd42bdbe5f30fe89d686461566a7e20e759322d66439c094138e8ca409 [INFO] running `"docker" "start" "-a" "a7f5a3fd42bdbe5f30fe89d686461566a7e20e759322d66439c094138e8ca409"` [INFO] [stderr] Checking nes v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `status` [INFO] [stderr] --> src/cpu.rs:171:18 [INFO] [stderr] | [INFO] [stderr] 171 | self.c = (status >> 0) & 0x1; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `self.c` [INFO] [stderr] --> src/cpu.rs:204:19 [INFO] [stderr] | [INFO] [stderr] 204 | status |= (self.c << 0) & (0x1 << 0); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `0x1` [INFO] [stderr] --> src/cpu.rs:204:35 [INFO] [stderr] | [INFO] [stderr] 204 | status |= (self.c << 0) & (0x1 << 0); [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `cpu::CPU` [INFO] [stderr] --> src/cpu.rs:305:5 [INFO] [stderr] | [INFO] [stderr] 305 | / pub fn new() -> CPU { [INFO] [stderr] 306 | | CPU { [INFO] [stderr] 307 | | memory: Ram { val: [0; 0x800] }, [INFO] [stderr] 308 | | cycles: 0, [INFO] [stderr] ... | [INFO] [stderr] 311 | | } [INFO] [stderr] 312 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 304 | impl Default for cpu::CPU { [INFO] [stderr] 305 | fn default() -> Self { [INFO] [stderr] 306 | Self::new() [INFO] [stderr] 307 | } [INFO] [stderr] 308 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:351:27 [INFO] [stderr] | [INFO] [stderr] 351 | self.storeb(0x100+sp as u16, val); [INFO] [stderr] | ^^^^^^^^^ help: try: `u16::from(sp)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:357:29 [INFO] [stderr] | [INFO] [stderr] 357 | self.storew(0x100 + sp as u16 - 1, val); [INFO] [stderr] | ^^^^^^^^^ help: try: `u16::from(sp)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:364:28 [INFO] [stderr] | [INFO] [stderr] 364 | self.loadb(0x100 + sp as u16 + 1) [INFO] [stderr] | ^^^^^^^^^ help: try: `u16::from(sp)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:370:28 [INFO] [stderr] | [INFO] [stderr] 370 | self.loadw(0x100 + sp as u16 + 1) [INFO] [stderr] | ^^^^^^^^^ help: try: `u16::from(sp)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:382:9 [INFO] [stderr] | [INFO] [stderr] 382 | low as u16 | (high as u16) << 8 [INFO] [stderr] | ^^^^^^^^^^ help: try: `u16::from(low)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:382:22 [INFO] [stderr] | [INFO] [stderr] 382 | low as u16 | (high as u16) << 8 [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u16::from(high)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:393:17 [INFO] [stderr] | [INFO] [stderr] 393 | let t = a as u16 + b as u16 + c as u16; [INFO] [stderr] | ^^^^^^^^ help: try: `u16::from(a)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:393:28 [INFO] [stderr] | [INFO] [stderr] 393 | let t = a as u16 + b as u16 + c as u16; [INFO] [stderr] | ^^^^^^^^ help: try: `u16::from(b)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:393:39 [INFO] [stderr] | [INFO] [stderr] 393 | let t = a as u16 + b as u16 + c as u16; [INFO] [stderr] | ^^^^^^^^ help: try: `u16::from(c)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:424:22 [INFO] [stderr] | [INFO] [stderr] 424 | let branch = self.loadb_from_pc() as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(self.loadb_from_pc())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:426:33 [INFO] [stderr] | [INFO] [stderr] 426 | self.register.pc = (self.register.pc as i32 + branch) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(self.register.pc)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:503:19 [INFO] [stderr] | [INFO] [stderr] 503 | let rhs = am.load(self) as i16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `i16::from(am.load(self))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:504:19 [INFO] [stderr] | [INFO] [stderr] 504 | let lhs = x as i16; [INFO] [stderr] | ^^^^^^^^ help: try: `i16::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:529:20 [INFO] [stderr] | [INFO] [stderr] 529 | let val = (am.load(self) as i16 - 1) as u8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `i16::from(am.load(self))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:535:18 [INFO] [stderr] | [INFO] [stderr] 535 | let x = (self.register.x as i16 - 1) as u8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `i16::from(self.register.x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:541:18 [INFO] [stderr] | [INFO] [stderr] 541 | let y = (self.register.y as i16 - 1) as u8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `i16::from(self.register.y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:553:20 [INFO] [stderr] | [INFO] [stderr] 553 | let val = (am.load(self) as i16 + 1) as u8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `i16::from(am.load(self))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:559:18 [INFO] [stderr] | [INFO] [stderr] 559 | let x = (self.register.x as i16 + 1) as u8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `i16::from(self.register.x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:565:18 [INFO] [stderr] | [INFO] [stderr] 565 | let y = (self.register.y as i16 + 1) as u8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `i16::from(self.register.y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:674:19 [INFO] [stderr] | [INFO] [stderr] 674 | let ret = a as i16 - b as i16 - (1 - c as i16); [INFO] [stderr] | ^^^^^^^^ help: try: `i16::from(a)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:674:30 [INFO] [stderr] | [INFO] [stderr] 674 | let ret = a as i16 - b as i16 - (1 - c as i16); [INFO] [stderr] | ^^^^^^^^ help: try: `i16::from(b)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:674:46 [INFO] [stderr] | [INFO] [stderr] 674 | let ret = a as i16 - b as i16 - (1 - c as i16); [INFO] [stderr] | ^^^^^^^^ help: try: `i16::from(c)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/mem.rs:29:9 [INFO] [stderr] | [INFO] [stderr] 29 | (high as u16) << 8 | low as u16 [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u16::from(high)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/mem.rs:29:30 [INFO] [stderr] | [INFO] [stderr] 29 | (high as u16) << 8 | low as u16 [INFO] [stderr] | ^^^^^^^^^^ help: try: `u16::from(low)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `status` [INFO] [stderr] --> src/cpu.rs:171:18 [INFO] [stderr] | [INFO] [stderr] 171 | self.c = (status >> 0) & 0x1; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `self.c` [INFO] [stderr] --> src/cpu.rs:204:19 [INFO] [stderr] | [INFO] [stderr] 204 | status |= (self.c << 0) & (0x1 << 0); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `0x1` [INFO] [stderr] --> src/cpu.rs:204:35 [INFO] [stderr] | [INFO] [stderr] 204 | status |= (self.c << 0) & (0x1 << 0); [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `cpu::CPU` [INFO] [stderr] --> src/cpu.rs:305:5 [INFO] [stderr] | [INFO] [stderr] 305 | / pub fn new() -> CPU { [INFO] [stderr] 306 | | CPU { [INFO] [stderr] 307 | | memory: Ram { val: [0; 0x800] }, [INFO] [stderr] 308 | | cycles: 0, [INFO] [stderr] ... | [INFO] [stderr] 311 | | } [INFO] [stderr] 312 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 304 | impl Default for cpu::CPU { [INFO] [stderr] 305 | fn default() -> Self { [INFO] [stderr] 306 | Self::new() [INFO] [stderr] 307 | } [INFO] [stderr] 308 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:351:27 [INFO] [stderr] | [INFO] [stderr] 351 | self.storeb(0x100+sp as u16, val); [INFO] [stderr] | ^^^^^^^^^ help: try: `u16::from(sp)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:357:29 [INFO] [stderr] | [INFO] [stderr] 357 | self.storew(0x100 + sp as u16 - 1, val); [INFO] [stderr] | ^^^^^^^^^ help: try: `u16::from(sp)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:364:28 [INFO] [stderr] | [INFO] [stderr] 364 | self.loadb(0x100 + sp as u16 + 1) [INFO] [stderr] | ^^^^^^^^^ help: try: `u16::from(sp)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:370:28 [INFO] [stderr] | [INFO] [stderr] 370 | self.loadw(0x100 + sp as u16 + 1) [INFO] [stderr] | ^^^^^^^^^ help: try: `u16::from(sp)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:382:9 [INFO] [stderr] | [INFO] [stderr] 382 | low as u16 | (high as u16) << 8 [INFO] [stderr] | ^^^^^^^^^^ help: try: `u16::from(low)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:382:22 [INFO] [stderr] | [INFO] [stderr] 382 | low as u16 | (high as u16) << 8 [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u16::from(high)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:393:17 [INFO] [stderr] | [INFO] [stderr] 393 | let t = a as u16 + b as u16 + c as u16; [INFO] [stderr] | ^^^^^^^^ help: try: `u16::from(a)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:393:28 [INFO] [stderr] | [INFO] [stderr] 393 | let t = a as u16 + b as u16 + c as u16; [INFO] [stderr] | ^^^^^^^^ help: try: `u16::from(b)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:393:39 [INFO] [stderr] | [INFO] [stderr] 393 | let t = a as u16 + b as u16 + c as u16; [INFO] [stderr] | ^^^^^^^^ help: try: `u16::from(c)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:424:22 [INFO] [stderr] | [INFO] [stderr] 424 | let branch = self.loadb_from_pc() as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(self.loadb_from_pc())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:426:33 [INFO] [stderr] | [INFO] [stderr] 426 | self.register.pc = (self.register.pc as i32 + branch) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(self.register.pc)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:503:19 [INFO] [stderr] | [INFO] [stderr] 503 | let rhs = am.load(self) as i16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `i16::from(am.load(self))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:504:19 [INFO] [stderr] | [INFO] [stderr] 504 | let lhs = x as i16; [INFO] [stderr] | ^^^^^^^^ help: try: `i16::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:529:20 [INFO] [stderr] | [INFO] [stderr] 529 | let val = (am.load(self) as i16 - 1) as u8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `i16::from(am.load(self))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:535:18 [INFO] [stderr] | [INFO] [stderr] 535 | let x = (self.register.x as i16 - 1) as u8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `i16::from(self.register.x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:541:18 [INFO] [stderr] | [INFO] [stderr] 541 | let y = (self.register.y as i16 - 1) as u8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `i16::from(self.register.y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:553:20 [INFO] [stderr] | [INFO] [stderr] 553 | let val = (am.load(self) as i16 + 1) as u8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `i16::from(am.load(self))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:559:18 [INFO] [stderr] | [INFO] [stderr] 559 | let x = (self.register.x as i16 + 1) as u8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `i16::from(self.register.x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:565:18 [INFO] [stderr] | [INFO] [stderr] 565 | let y = (self.register.y as i16 + 1) as u8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `i16::from(self.register.y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:674:19 [INFO] [stderr] | [INFO] [stderr] 674 | let ret = a as i16 - b as i16 - (1 - c as i16); [INFO] [stderr] | ^^^^^^^^ help: try: `i16::from(a)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:674:30 [INFO] [stderr] | [INFO] [stderr] 674 | let ret = a as i16 - b as i16 - (1 - c as i16); [INFO] [stderr] | ^^^^^^^^ help: try: `i16::from(b)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:674:46 [INFO] [stderr] | [INFO] [stderr] 674 | let ret = a as i16 - b as i16 - (1 - c as i16); [INFO] [stderr] | ^^^^^^^^ help: try: `i16::from(c)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/mem.rs:29:9 [INFO] [stderr] | [INFO] [stderr] 29 | (high as u16) << 8 | low as u16 [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u16::from(high)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/mem.rs:29:30 [INFO] [stderr] | [INFO] [stderr] 29 | (high as u16) << 8 | low as u16 [INFO] [stderr] | ^^^^^^^^^^ help: try: `u16::from(low)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.46s [INFO] running `"docker" "inspect" "a7f5a3fd42bdbe5f30fe89d686461566a7e20e759322d66439c094138e8ca409"` [INFO] running `"docker" "rm" "-f" "a7f5a3fd42bdbe5f30fe89d686461566a7e20e759322d66439c094138e8ca409"` [INFO] [stdout] a7f5a3fd42bdbe5f30fe89d686461566a7e20e759322d66439c094138e8ca409