[INFO] updating cached repository henryroyal/cli-fractional-knapsack
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/henryroyal/cli-fractional-knapsack
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/henryroyal/cli-fractional-knapsack" "work/ex/clippy-test-run/sources/stable/gh/henryroyal/cli-fractional-knapsack"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/henryroyal/cli-fractional-knapsack'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/henryroyal/cli-fractional-knapsack" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/henryroyal/cli-fractional-knapsack"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/henryroyal/cli-fractional-knapsack'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] aad60f6e27baaad53767c4245a6d82b33105d7fd
[INFO] sha for GitHub repo henryroyal/cli-fractional-knapsack: aad60f6e27baaad53767c4245a6d82b33105d7fd
[INFO] validating manifest of henryroyal/cli-fractional-knapsack on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of henryroyal/cli-fractional-knapsack on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing henryroyal/cli-fractional-knapsack
[INFO] finished frobbing henryroyal/cli-fractional-knapsack
[INFO] frobbed toml for henryroyal/cli-fractional-knapsack written to work/ex/clippy-test-run/sources/stable/gh/henryroyal/cli-fractional-knapsack/Cargo.toml
[INFO] started frobbing henryroyal/cli-fractional-knapsack
[INFO] finished frobbing henryroyal/cli-fractional-knapsack
[INFO] frobbed toml for henryroyal/cli-fractional-knapsack written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/henryroyal/cli-fractional-knapsack/Cargo.toml
[INFO] crate henryroyal/cli-fractional-knapsack has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting henryroyal/cli-fractional-knapsack against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/henryroyal/cli-fractional-knapsack:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] cf30dd0586a125ddc8bd27fb204293ca32e142c7cb30a04019bc2beb5674eec4
[INFO] running `"docker" "start" "-a" "cf30dd0586a125ddc8bd27fb204293ca32e142c7cb30a04019bc2beb5674eec4"`
[INFO] [stderr]     Checking fractional_knapsack v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]  --> src/main.rs:9:9
[INFO] [stderr]   |
[INFO] [stderr] 9 |         return self.value / self.weight;
[INFO] [stderr]   |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.value / self.weight`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:18:9
[INFO] [stderr]    |
[INFO] [stderr] 18 |         return compared.unwrap();
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `compared.unwrap()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:24:9
[INFO] [stderr]    |
[INFO] [stderr] 24 |         return Some(self.cmp(other));
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(self.cmp(other))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:30:9
[INFO] [stderr]    |
[INFO] [stderr] 30 |         return self.value_density() == self.value_density();
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.value_density() == self.value_density()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:115:5
[INFO] [stderr]     |
[INFO] [stderr] 115 |     return value;
[INFO] [stderr]     |     ^^^^^^^^^^^^^ help: remove `return` as shown: `value`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:140:5
[INFO] [stderr]     |
[INFO] [stderr] 140 |     return vector;
[INFO] [stderr]     |     ^^^^^^^^^^^^^^ help: remove `return` as shown: `vector`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]  --> src/main.rs:9:9
[INFO] [stderr]   |
[INFO] [stderr] 9 |         return self.value / self.weight;
[INFO] [stderr]   |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.value / self.weight`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:18:9
[INFO] [stderr]    |
[INFO] [stderr] 18 |         return compared.unwrap();
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `compared.unwrap()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:24:9
[INFO] [stderr]    |
[INFO] [stderr] 24 |         return Some(self.cmp(other));
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(self.cmp(other))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:30:9
[INFO] [stderr]    |
[INFO] [stderr] 30 |         return self.value_density() == self.value_density();
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.value_density() == self.value_density()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:115:5
[INFO] [stderr]     |
[INFO] [stderr] 115 |     return value;
[INFO] [stderr]     |     ^^^^^^^^^^^^^ help: remove `return` as shown: `value`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:140:5
[INFO] [stderr]     |
[INFO] [stderr] 140 |     return vector;
[INFO] [stderr]     |     ^^^^^^^^^^^^^^ help: remove `return` as shown: `vector`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `ix`
[INFO] [stderr]   --> src/main.rs:67:13
[INFO] [stderr]    |
[INFO] [stderr] 67 |     let mut ix: usize = 0;
[INFO] [stderr]    |             ^^ help: consider using `_ix` instead
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_variables)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `remaining_weight`
[INFO] [stderr]   --> src/main.rs:86:13
[INFO] [stderr]    |
[INFO] [stderr] 86 |         let remaining_weight = max_weight - weight;
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^ help: consider using `_remaining_weight` instead
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `remaining_count`
[INFO] [stderr]   --> src/main.rs:87:13
[INFO] [stderr]    |
[INFO] [stderr] 87 |         let remaining_count = max_count - count;
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^ help: consider using `_remaining_count` instead
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `other`
[INFO] [stderr]   --> src/main.rs:29:18
[INFO] [stderr]    |
[INFO] [stderr] 29 |     fn eq(&self, other: &Item) -> bool {
[INFO] [stderr]    |                  ^^^^^ help: consider using `_other` instead
[INFO] [stderr] 
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr]   --> src/main.rs:67:9
[INFO] [stderr]    |
[INFO] [stderr] 67 |     let mut ix: usize = 0;
[INFO] [stderr]    |         ----^^
[INFO] [stderr]    |         |
[INFO] [stderr]    |         help: remove this `mut`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_mut)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `ix`
[INFO] [stderr]   --> src/main.rs:67:13
[INFO] [stderr]    |
[INFO] [stderr] 67 |     let mut ix: usize = 0;
[INFO] [stderr]    |             ^^ help: consider using `_ix` instead
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_variables)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `remaining_weight`
[INFO] [stderr]   --> src/main.rs:86:13
[INFO] [stderr]    |
[INFO] [stderr] 86 |         let remaining_weight = max_weight - weight;
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^ help: consider using `_remaining_weight` instead
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `remaining_count`
[INFO] [stderr]   --> src/main.rs:87:13
[INFO] [stderr]    |
[INFO] [stderr] 87 |         let remaining_count = max_count - count;
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^ help: consider using `_remaining_count` instead
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `other`
[INFO] [stderr]   --> src/main.rs:29:18
[INFO] [stderr]    |
[INFO] [stderr] 29 |     fn eq(&self, other: &Item) -> bool {
[INFO] [stderr]    |                  ^^^^^ help: consider using `_other` instead
[INFO] [stderr] 
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr]   --> src/main.rs:67:9
[INFO] [stderr]    |
[INFO] [stderr] 67 |     let mut ix: usize = 0;
[INFO] [stderr]    |         ----^^
[INFO] [stderr]    |         |
[INFO] [stderr]    |         help: remove this `mut`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_mut)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/main.rs:43:12
[INFO] [stderr]    |
[INFO] [stderr] 43 |         if input.len() == 0 {
[INFO] [stderr]    |            ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `input.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/main.rs:65:59
[INFO] [stderr]    |
[INFO] [stderr] 65 | fn maximize_value(max_count: i32, max_weight: f64, items: &Vec<Item>) -> f64 {
[INFO] [stderr]    |                                                           ^^^^^^^^^^ help: change this to: `&[Item]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: variable `DEBUG` should have a snake case name such as `debug`
[INFO] [stderr]   --> src/main.rs:66:9
[INFO] [stderr]    |
[INFO] [stderr] 66 |     let DEBUG = false;
[INFO] [stderr]    |         ^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(non_snake_case)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused `std::result::Result` that must be used
[INFO] [stderr]    --> src/main.rs:123:5
[INFO] [stderr]     |
[INFO] [stderr] 123 |     std::io::stdin().read_line(&mut stdin);
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_must_use)] on by default
[INFO] [stderr]     = note: this `Result` may be an `Err` variant, which should be handled
[INFO] [stderr] 
[INFO] [stderr] warning: unused return value of `std::str::<impl str>::replace` that must be used
[INFO] [stderr]    --> src/main.rs:124:5
[INFO] [stderr]     |
[INFO] [stderr] 124 |     stdin.replace("\n", "");
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: this returns the replaced string as a new allocation, without modifying the original
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/main.rs:43:12
[INFO] [stderr]    |
[INFO] [stderr] 43 |         if input.len() == 0 {
[INFO] [stderr]    |            ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `input.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/main.rs:65:59
[INFO] [stderr]    |
[INFO] [stderr] 65 | fn maximize_value(max_count: i32, max_weight: f64, items: &Vec<Item>) -> f64 {
[INFO] [stderr]    |                                                           ^^^^^^^^^^ help: change this to: `&[Item]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: variable `DEBUG` should have a snake case name such as `debug`
[INFO] [stderr]   --> src/main.rs:66:9
[INFO] [stderr]    |
[INFO] [stderr] 66 |     let DEBUG = false;
[INFO] [stderr]    |         ^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(non_snake_case)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused `std::result::Result` that must be used
[INFO] [stderr]    --> src/main.rs:123:5
[INFO] [stderr]     |
[INFO] [stderr] 123 |     std::io::stdin().read_line(&mut stdin);
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_must_use)] on by default
[INFO] [stderr]     = note: this `Result` may be an `Err` variant, which should be handled
[INFO] [stderr] 
[INFO] [stderr] warning: unused return value of `std::str::<impl str>::replace` that must be used
[INFO] [stderr]    --> src/main.rs:124:5
[INFO] [stderr]     |
[INFO] [stderr] 124 |     stdin.replace("\n", "");
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: this returns the replaced string as a new allocation, without modifying the original
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 0.32s
[INFO] running `"docker" "inspect" "cf30dd0586a125ddc8bd27fb204293ca32e142c7cb30a04019bc2beb5674eec4"`
[INFO] running `"docker" "rm" "-f" "cf30dd0586a125ddc8bd27fb204293ca32e142c7cb30a04019bc2beb5674eec4"`
[INFO] [stdout] cf30dd0586a125ddc8bd27fb204293ca32e142c7cb30a04019bc2beb5674eec4