[INFO] updating cached repository hellopatrick/rays.rs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/hellopatrick/rays.rs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/hellopatrick/rays.rs" "work/ex/clippy-test-run/sources/stable/gh/hellopatrick/rays.rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/hellopatrick/rays.rs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/hellopatrick/rays.rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/hellopatrick/rays.rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/hellopatrick/rays.rs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 3da4de4fb9e83a80f5dfc68339615671e8722b7f [INFO] sha for GitHub repo hellopatrick/rays.rs: 3da4de4fb9e83a80f5dfc68339615671e8722b7f [INFO] validating manifest of hellopatrick/rays.rs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of hellopatrick/rays.rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing hellopatrick/rays.rs [INFO] finished frobbing hellopatrick/rays.rs [INFO] frobbed toml for hellopatrick/rays.rs written to work/ex/clippy-test-run/sources/stable/gh/hellopatrick/rays.rs/Cargo.toml [INFO] started frobbing hellopatrick/rays.rs [INFO] finished frobbing hellopatrick/rays.rs [INFO] frobbed toml for hellopatrick/rays.rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/hellopatrick/rays.rs/Cargo.toml [INFO] crate hellopatrick/rays.rs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting hellopatrick/rays.rs against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/hellopatrick/rays.rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 060916bb6cbdac3380e2acdb7eb01e3eb8be6b8d424bcfa69ea4dd076c1690b6 [INFO] running `"docker" "start" "-a" "060916bb6cbdac3380e2acdb7eb01e3eb8be6b8d424bcfa69ea4dd076c1690b6"` [INFO] [stderr] Checking rays v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/matrix.rs:263:5 [INFO] [stderr] | [INFO] [stderr] 263 | return Some(Matrix4x4 { elements }); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(Matrix4x4 { elements })` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/matrix.rs:342:5 [INFO] [stderr] | [INFO] [stderr] 342 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/matrix.rs:263:5 [INFO] [stderr] | [INFO] [stderr] 263 | return Some(Matrix4x4 { elements }); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(Matrix4x4 { elements })` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/matrix.rs:342:5 [INFO] [stderr] | [INFO] [stderr] 342 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (9/7) [INFO] [stderr] --> src/matrix.rs:50:3 [INFO] [stderr] | [INFO] [stderr] 50 | / pub fn new( [INFO] [stderr] 51 | | a11: f32, [INFO] [stderr] 52 | | a12: f32, [INFO] [stderr] 53 | | a13: f32, [INFO] [stderr] ... | [INFO] [stderr] 63 | | } [INFO] [stderr] 64 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (16/7) [INFO] [stderr] --> src/matrix.rs:132:3 [INFO] [stderr] | [INFO] [stderr] 132 | / pub fn new( [INFO] [stderr] 133 | | a11: f32, [INFO] [stderr] 134 | | a12: f32, [INFO] [stderr] 135 | | a13: f32, [INFO] [stderr] ... | [INFO] [stderr] 157 | | } [INFO] [stderr] 158 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: the loop variable `row` is used to index `elements` [INFO] [stderr] --> src/matrix.rs:185:16 [INFO] [stderr] | [INFO] [stderr] 185 | for row in 0..4 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 185 | for (row, ) in elements.iter_mut().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `col` is used to index `elements` [INFO] [stderr] --> src/matrix.rs:258:18 [INFO] [stderr] | [INFO] [stderr] 258 | for col in 0..4 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 258 | for (col, ) in elements.iter_mut().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `x` is used to index `cols` [INFO] [stderr] --> src/matrix.rs:276:14 [INFO] [stderr] | [INFO] [stderr] 276 | for x in 0..4 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 276 | for (x, ) in cols.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/tuple.rs:33:5 [INFO] [stderr] | [INFO] [stderr] 33 | self.w == 1.0 [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider comparing them within some error: `(self.w - 1.0).abs() < error` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/tuple.rs:33:5 [INFO] [stderr] | [INFO] [stderr] 33 | self.w == 1.0 [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `rays`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: this function has too many arguments (9/7) [INFO] [stderr] --> src/matrix.rs:50:3 [INFO] [stderr] | [INFO] [stderr] 50 | / pub fn new( [INFO] [stderr] 51 | | a11: f32, [INFO] [stderr] 52 | | a12: f32, [INFO] [stderr] 53 | | a13: f32, [INFO] [stderr] ... | [INFO] [stderr] 63 | | } [INFO] [stderr] 64 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (16/7) [INFO] [stderr] --> src/matrix.rs:132:3 [INFO] [stderr] | [INFO] [stderr] 132 | / pub fn new( [INFO] [stderr] 133 | | a11: f32, [INFO] [stderr] 134 | | a12: f32, [INFO] [stderr] 135 | | a13: f32, [INFO] [stderr] ... | [INFO] [stderr] 157 | | } [INFO] [stderr] 158 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: the loop variable `row` is used to index `elements` [INFO] [stderr] --> src/matrix.rs:185:16 [INFO] [stderr] | [INFO] [stderr] 185 | for row in 0..4 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 185 | for (row, ) in elements.iter_mut().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `col` is used to index `elements` [INFO] [stderr] --> src/matrix.rs:258:18 [INFO] [stderr] | [INFO] [stderr] 258 | for col in 0..4 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 258 | for (col, ) in elements.iter_mut().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `x` is used to index `cols` [INFO] [stderr] --> src/matrix.rs:276:14 [INFO] [stderr] | [INFO] [stderr] 276 | for x in 0..4 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 276 | for (x, ) in cols.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/tuple.rs:33:5 [INFO] [stderr] | [INFO] [stderr] 33 | self.w == 1.0 [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider comparing them within some error: `(self.w - 1.0).abs() < error` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/tuple.rs:33:5 [INFO] [stderr] | [INFO] [stderr] 33 | self.w == 1.0 [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `rays`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "060916bb6cbdac3380e2acdb7eb01e3eb8be6b8d424bcfa69ea4dd076c1690b6"` [INFO] running `"docker" "rm" "-f" "060916bb6cbdac3380e2acdb7eb01e3eb8be6b8d424bcfa69ea4dd076c1690b6"` [INFO] [stdout] 060916bb6cbdac3380e2acdb7eb01e3eb8be6b8d424bcfa69ea4dd076c1690b6