[INFO] updating cached repository hejile/tcpspeedtest [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/hejile/tcpspeedtest [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/hejile/tcpspeedtest" "work/ex/clippy-test-run/sources/stable/gh/hejile/tcpspeedtest"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/hejile/tcpspeedtest'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/hejile/tcpspeedtest" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/hejile/tcpspeedtest"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/hejile/tcpspeedtest'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] a84fa28592a6f45a842e296e4c1a64fad0af01d6 [INFO] sha for GitHub repo hejile/tcpspeedtest: a84fa28592a6f45a842e296e4c1a64fad0af01d6 [INFO] validating manifest of hejile/tcpspeedtest on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of hejile/tcpspeedtest on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing hejile/tcpspeedtest [INFO] finished frobbing hejile/tcpspeedtest [INFO] frobbed toml for hejile/tcpspeedtest written to work/ex/clippy-test-run/sources/stable/gh/hejile/tcpspeedtest/Cargo.toml [INFO] started frobbing hejile/tcpspeedtest [INFO] finished frobbing hejile/tcpspeedtest [INFO] frobbed toml for hejile/tcpspeedtest written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/hejile/tcpspeedtest/Cargo.toml [INFO] crate hejile/tcpspeedtest has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting hejile/tcpspeedtest against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/hejile/tcpspeedtest:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 8cf9eb819d3e8109335b45d1214846355e7c3fc54b7b5e664a07b1384d7970df [INFO] running `"docker" "start" "-a" "8cf9eb819d3e8109335b45d1214846355e7c3fc54b7b5e664a07b1384d7970df"` [INFO] [stderr] Checking tcpspeedtest v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:9:20 [INFO] [stderr] | [INFO] [stderr] 9 | buf.push(((n & 0xff000000) >> 24) as u8); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xff00_0000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:10:20 [INFO] [stderr] | [INFO] [stderr] 10 | buf.push(((n & 0x00ff0000) >> 16) as u8); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x00ff_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:11:20 [INFO] [stderr] | [INFO] [stderr] 11 | buf.push(((n & 0x0000ff00) >> 8) as u8); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_ff00` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:12:20 [INFO] [stderr] | [INFO] [stderr] 12 | buf.push(((n & 0x000000ff) >> 0) as u8); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_00ff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:9:20 [INFO] [stderr] | [INFO] [stderr] 9 | buf.push(((n & 0xff000000) >> 24) as u8); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xff00_0000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:10:20 [INFO] [stderr] | [INFO] [stderr] 10 | buf.push(((n & 0x00ff0000) >> 16) as u8); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x00ff_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:11:20 [INFO] [stderr] | [INFO] [stderr] 11 | buf.push(((n & 0x0000ff00) >> 8) as u8); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_ff00` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:12:20 [INFO] [stderr] | [INFO] [stderr] 12 | buf.push(((n & 0x000000ff) >> 0) as u8); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_00ff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: value assigned to `total_bytes` is never read [INFO] [stderr] --> src/main.rs:36:13 [INFO] [stderr] | [INFO] [stderr] 36 | let mut total_bytes = 0; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_assignments)] on by default [INFO] [stderr] [INFO] [stderr] warning: value assigned to `upload_dur` is never read [INFO] [stderr] --> src/main.rs:58:13 [INFO] [stderr] | [INFO] [stderr] 58 | let mut upload_dur = 0usize; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `(n & 0x000000ff)` [INFO] [stderr] --> src/main.rs:12:14 [INFO] [stderr] | [INFO] [stderr] 12 | buf.push(((n & 0x000000ff) >> 0) as u8); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:19:10 [INFO] [stderr] | [INFO] [stderr] 19 | n += (buf[0] as u32) << 24; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u32::from(buf[0])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:20:10 [INFO] [stderr] | [INFO] [stderr] 20 | n += (buf[1] as u32) << 16; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u32::from(buf[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:21:10 [INFO] [stderr] | [INFO] [stderr] 21 | n += (buf[2] as u32) << 8; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u32::from(buf[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `(buf[3] as u32)` [INFO] [stderr] --> src/main.rs:22:10 [INFO] [stderr] | [INFO] [stderr] 22 | n += (buf[3] as u32) << 0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:22:10 [INFO] [stderr] | [INFO] [stderr] 22 | n += (buf[3] as u32) << 0; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u32::from(buf[3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `buf`. [INFO] [stderr] --> src/main.rs:28:14 [INFO] [stderr] | [INFO] [stderr] 28 | for i in 0..buf.len() { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 28 | for in &mut buf { [INFO] [stderr] | ^^^^^^ ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: slow zero-filling initialization [INFO] [stderr] --> src/main.rs:49:5 [INFO] [stderr] | [INFO] [stderr] 48 | let mut upload_buf: Vec = Vec::with_capacity(total_bytes); [INFO] [stderr] | ------------------------------- help: consider replace allocation with: `vec![0; total_bytes]` [INFO] [stderr] 49 | upload_buf.resize(total_bytes, 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::slow_vector_initialization)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#slow_vector_initialization [INFO] [stderr] [INFO] [stderr] warning: slow zero-filling initialization [INFO] [stderr] --> src/main.rs:70:5 [INFO] [stderr] | [INFO] [stderr] 69 | let mut buf: Vec = Vec::with_capacity(data_size); [INFO] [stderr] | ----------------------------- help: consider replace allocation with: `vec![0; data_size]` [INFO] [stderr] 70 | buf.resize(data_size, 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#slow_vector_initialization [INFO] [stderr] [INFO] [stderr] warning: value assigned to `total_bytes` is never read [INFO] [stderr] --> src/main.rs:36:13 [INFO] [stderr] | [INFO] [stderr] 36 | let mut total_bytes = 0; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_assignments)] on by default [INFO] [stderr] [INFO] [stderr] warning: value assigned to `upload_dur` is never read [INFO] [stderr] --> src/main.rs:58:13 [INFO] [stderr] | [INFO] [stderr] 58 | let mut upload_dur = 0usize; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `(n & 0x000000ff)` [INFO] [stderr] --> src/main.rs:12:14 [INFO] [stderr] | [INFO] [stderr] 12 | buf.push(((n & 0x000000ff) >> 0) as u8); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:19:10 [INFO] [stderr] | [INFO] [stderr] 19 | n += (buf[0] as u32) << 24; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u32::from(buf[0])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:20:10 [INFO] [stderr] | [INFO] [stderr] 20 | n += (buf[1] as u32) << 16; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u32::from(buf[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:21:10 [INFO] [stderr] | [INFO] [stderr] 21 | n += (buf[2] as u32) << 8; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u32::from(buf[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `(buf[3] as u32)` [INFO] [stderr] --> src/main.rs:22:10 [INFO] [stderr] | [INFO] [stderr] 22 | n += (buf[3] as u32) << 0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:22:10 [INFO] [stderr] | [INFO] [stderr] 22 | n += (buf[3] as u32) << 0; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u32::from(buf[3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `buf`. [INFO] [stderr] --> src/main.rs:28:14 [INFO] [stderr] | [INFO] [stderr] 28 | for i in 0..buf.len() { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 28 | for in &mut buf { [INFO] [stderr] | ^^^^^^ ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: slow zero-filling initialization [INFO] [stderr] --> src/main.rs:49:5 [INFO] [stderr] | [INFO] [stderr] 48 | let mut upload_buf: Vec = Vec::with_capacity(total_bytes); [INFO] [stderr] | ------------------------------- help: consider replace allocation with: `vec![0; total_bytes]` [INFO] [stderr] 49 | upload_buf.resize(total_bytes, 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::slow_vector_initialization)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#slow_vector_initialization [INFO] [stderr] [INFO] [stderr] warning: slow zero-filling initialization [INFO] [stderr] --> src/main.rs:70:5 [INFO] [stderr] | [INFO] [stderr] 69 | let mut buf: Vec = Vec::with_capacity(data_size); [INFO] [stderr] | ----------------------------- help: consider replace allocation with: `vec![0; data_size]` [INFO] [stderr] 70 | buf.resize(data_size, 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#slow_vector_initialization [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.86s [INFO] running `"docker" "inspect" "8cf9eb819d3e8109335b45d1214846355e7c3fc54b7b5e664a07b1384d7970df"` [INFO] running `"docker" "rm" "-f" "8cf9eb819d3e8109335b45d1214846355e7c3fc54b7b5e664a07b1384d7970df"` [INFO] [stdout] 8cf9eb819d3e8109335b45d1214846355e7c3fc54b7b5e664a07b1384d7970df