[INFO] updating cached repository heejongahn/daily-BOJ [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/heejongahn/daily-BOJ [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/heejongahn/daily-BOJ" "work/ex/clippy-test-run/sources/stable/gh/heejongahn/daily-BOJ"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/heejongahn/daily-BOJ'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/heejongahn/daily-BOJ" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/heejongahn/daily-BOJ"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/heejongahn/daily-BOJ'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] f1ec181a66b7745ef46992da012315cf2be06358 [INFO] sha for GitHub repo heejongahn/daily-BOJ: f1ec181a66b7745ef46992da012315cf2be06358 [INFO] validating manifest of heejongahn/daily-BOJ on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of heejongahn/daily-BOJ on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing heejongahn/daily-BOJ [INFO] finished frobbing heejongahn/daily-BOJ [INFO] frobbed toml for heejongahn/daily-BOJ written to work/ex/clippy-test-run/sources/stable/gh/heejongahn/daily-BOJ/Cargo.toml [INFO] started frobbing heejongahn/daily-BOJ [INFO] finished frobbing heejongahn/daily-BOJ [INFO] frobbed toml for heejongahn/daily-BOJ written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/heejongahn/daily-BOJ/Cargo.toml [INFO] crate heejongahn/daily-BOJ has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting heejongahn/daily-BOJ against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/heejongahn/daily-BOJ:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 1c11639464632402116eaa67f44293e8cc5a1072cb1e8d1566801e2b6e34d8ab [INFO] running `"docker" "start" "-a" "1c11639464632402116eaa67f44293e8cc5a1072cb1e8d1566801e2b6e34d8ab"` [INFO] [stderr] Checking daily-boj v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/2751.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | return merge(&left, &right); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `merge(&left, &right)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/2751.rs:43:5 [INFO] [stderr] | [INFO] [stderr] 43 | return sorted; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `sorted` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/2751.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | return merge(&left, &right); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `merge(&left, &right)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/2751.rs:43:5 [INFO] [stderr] | [INFO] [stderr] 43 | return sorted; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `sorted` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::f32` [INFO] [stderr] --> src/bin/1978.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | use std::f32; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/1978.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/bin/1978.rs:6:12 [INFO] [stderr] | [INFO] [stderr] 6 | if ((n % i) == 0) { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `match` head expression [INFO] [stderr] --> src/bin/1978.rs:26:15 [INFO] [stderr] | [INFO] [stderr] 26 | match (str::parse::(string)) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::f32` [INFO] [stderr] --> src/bin/1978.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | use std::f32; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/1978.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/bin/1978.rs:6:12 [INFO] [stderr] | [INFO] [stderr] 6 | if ((n % i) == 0) { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `match` head expression [INFO] [stderr] --> src/bin/1978.rs:26:15 [INFO] [stderr] | [INFO] [stderr] 26 | match (str::parse::(string)) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/bin/7785.rs:21:12 [INFO] [stderr] | [INFO] [stderr] 21 | if line.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `line.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: unused variable: `numbers` [INFO] [stderr] --> src/bin/1978.rs:22:9 [INFO] [stderr] | [INFO] [stderr] 22 | let numbers: Vec = Vec::new(); [INFO] [stderr] | ^^^^^^^ help: consider using `_numbers` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/bin/1978.rs:21:44 [INFO] [stderr] | [INFO] [stderr] 21 | let strings = numbers_str.trim().split(" "); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: unused variable: `numbers` [INFO] [stderr] --> src/bin/1978.rs:22:9 [INFO] [stderr] | [INFO] [stderr] 22 | let numbers: Vec = Vec::new(); [INFO] [stderr] | ^^^^^^^ help: consider using `_numbers` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/bin/1978.rs:21:44 [INFO] [stderr] | [INFO] [stderr] 21 | let strings = numbers_str.trim().split(" "); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/bin/9375.rs:24:78 [INFO] [stderr] | [INFO] [stderr] 24 | let line: Vec<&str> = lines.next().expect("get next line").split(" ").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/bin/9375.rs:28:13 [INFO] [stderr] | [INFO] [stderr] 28 | *count = *count + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `*count += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/bin/7785.rs:21:12 [INFO] [stderr] | [INFO] [stderr] 21 | if line.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `line.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/bin/9375.rs:24:78 [INFO] [stderr] | [INFO] [stderr] 24 | let line: Vec<&str> = lines.next().expect("get next line").split(" ").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/bin/9375.rs:28:13 [INFO] [stderr] | [INFO] [stderr] 28 | *count = *count + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `*count += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/2750.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | return buf.trim_right().parse().expect("Failed to expect i_32"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `buf.trim_right().parse().expect("Failed to expect i_32")` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/bin/2750.rs:31:12 [INFO] [stderr] | [INFO] [stderr] 31 | if (&v[i] < &v[len - 1]) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/2750.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | return buf.trim_right().parse().expect("Failed to expect i_32"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `buf.trim_right().parse().expect("Failed to expect i_32")` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/bin/2750.rs:31:12 [INFO] [stderr] | [INFO] [stderr] 31 | if (&v[i] < &v[len - 1]) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/bin/2750.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | handle.read_line(&mut buf); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/bin/2750.rs:31:12 [INFO] [stderr] | [INFO] [stderr] 31 | if (&v[i] < &v[len - 1]) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 31 | if (v[i] < v[len - 1]) { [INFO] [stderr] | ^^^^ ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/bin/2750.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | handle.read_line(&mut buf); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/bin/2750.rs:31:12 [INFO] [stderr] | [INFO] [stderr] 31 | if (&v[i] < &v[len - 1]) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 31 | if (v[i] < v[len - 1]) { [INFO] [stderr] | ^^^^ ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.76s [INFO] running `"docker" "inspect" "1c11639464632402116eaa67f44293e8cc5a1072cb1e8d1566801e2b6e34d8ab"` [INFO] running `"docker" "rm" "-f" "1c11639464632402116eaa67f44293e8cc5a1072cb1e8d1566801e2b6e34d8ab"` [INFO] [stdout] 1c11639464632402116eaa67f44293e8cc5a1072cb1e8d1566801e2b6e34d8ab