[INFO] updating cached repository hcpl/jq-tools [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/hcpl/jq-tools [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/hcpl/jq-tools" "work/ex/clippy-test-run/sources/stable/gh/hcpl/jq-tools"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/hcpl/jq-tools'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/hcpl/jq-tools" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/hcpl/jq-tools"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/hcpl/jq-tools'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 4729fe6fd8079fa3d20b7bc618c68c3aebcd2399 [INFO] sha for GitHub repo hcpl/jq-tools: 4729fe6fd8079fa3d20b7bc618c68c3aebcd2399 [INFO] validating manifest of hcpl/jq-tools on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of hcpl/jq-tools on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing hcpl/jq-tools [INFO] finished frobbing hcpl/jq-tools [INFO] frobbed toml for hcpl/jq-tools written to work/ex/clippy-test-run/sources/stable/gh/hcpl/jq-tools/Cargo.toml [INFO] started frobbing hcpl/jq-tools [INFO] finished frobbing hcpl/jq-tools [INFO] frobbed toml for hcpl/jq-tools written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/hcpl/jq-tools/Cargo.toml [INFO] crate hcpl/jq-tools has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting hcpl/jq-tools against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/hcpl/jq-tools:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 64bace1fa17fb70bff9eb80aa56df6969d350773ec995ab8ea7f2a9e256e33b5 [INFO] running `"docker" "start" "-a" "64bace1fa17fb70bff9eb80aa56df6969d350773ec995ab8ea7f2a9e256e33b5"` [INFO] [stderr] Checking semver v0.6.0 [INFO] [stderr] Checking jq-tools v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused macro definition [INFO] [stderr] --> src/nom_helpers.rs:7:1 [INFO] [stderr] | [INFO] [stderr] 7 | / macro_rules! ret_const( [INFO] [stderr] 8 | | ($i:expr, $value:expr) => ( [INFO] [stderr] 9 | | $crate::nom::IResult::Done($i, $value) as $crate::nom::IResult<_, _, u32> [INFO] [stderr] 10 | | ); [INFO] [stderr] 11 | | ); [INFO] [stderr] | |__^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_macros)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused macro definition [INFO] [stderr] --> src/nom_helpers.rs:13:1 [INFO] [stderr] | [INFO] [stderr] 13 | / macro_rules! peek_cond ( [INFO] [stderr] 14 | | ($input:expr, $submac:ident!( $($args:tt)* ), $submac2:ident!( $($args2:tt)* )) => ( [INFO] [stderr] 15 | | { [INFO] [stderr] 16 | | use $crate::nom::{IResult, ErrorKind}; [INFO] [stderr] ... | [INFO] [stderr] 39 | | ); [INFO] [stderr] 40 | | ); [INFO] [stderr] | |__^ [INFO] [stderr] [INFO] [stderr] warning: unused macro definition [INFO] [stderr] --> src/nom_helpers.rs:61:1 [INFO] [stderr] | [INFO] [stderr] 61 | / macro_rules! take_while_m_n ( [INFO] [stderr] 62 | | ($input:expr, $m:expr, $n:expr, $submac:ident!( $($args:tt)* )) => ( [INFO] [stderr] 63 | | { [INFO] [stderr] 64 | | use std::cmp; [INFO] [stderr] ... | [INFO] [stderr] 90 | | ); [INFO] [stderr] 91 | | ); [INFO] [stderr] | |__^ [INFO] [stderr] [INFO] [stderr] warning: unused macro definition [INFO] [stderr] --> src/nom_helpers.rs:7:1 [INFO] [stderr] | [INFO] [stderr] 7 | / macro_rules! ret_const( [INFO] [stderr] 8 | | ($i:expr, $value:expr) => ( [INFO] [stderr] 9 | | $crate::nom::IResult::Done($i, $value) as $crate::nom::IResult<_, _, u32> [INFO] [stderr] 10 | | ); [INFO] [stderr] 11 | | ); [INFO] [stderr] | |__^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_macros)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused macro definition [INFO] [stderr] --> src/nom_helpers.rs:13:1 [INFO] [stderr] | [INFO] [stderr] 13 | / macro_rules! peek_cond ( [INFO] [stderr] 14 | | ($input:expr, $submac:ident!( $($args:tt)* ), $submac2:ident!( $($args2:tt)* )) => ( [INFO] [stderr] 15 | | { [INFO] [stderr] 16 | | use $crate::nom::{IResult, ErrorKind}; [INFO] [stderr] ... | [INFO] [stderr] 39 | | ); [INFO] [stderr] 40 | | ); [INFO] [stderr] | |__^ [INFO] [stderr] [INFO] [stderr] warning: unused macro definition [INFO] [stderr] --> src/nom_helpers.rs:61:1 [INFO] [stderr] | [INFO] [stderr] 61 | / macro_rules! take_while_m_n ( [INFO] [stderr] 62 | | ($input:expr, $m:expr, $n:expr, $submac:ident!( $($args:tt)* )) => ( [INFO] [stderr] 63 | | { [INFO] [stderr] 64 | | use std::cmp; [INFO] [stderr] ... | [INFO] [stderr] 90 | | ); [INFO] [stderr] 91 | | ); [INFO] [stderr] | |__^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Update` [INFO] [stderr] --> src/ast.rs:96:54 [INFO] [stderr] | [INFO] [stderr] 96 | Assign, Or, And, Alternative, UpdateAlternative, Update, [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/nom_helpers.rs:47:55 [INFO] [stderr] | [INFO] [stderr] 47 | match ($input).iter_elements().next().map(|c| $submac!(c, $($args)*)) { [INFO] [stderr] | _______________________________________________________^ [INFO] [stderr] 48 | | None => IResult::Incomplete::<_, _>(Needed::Size(1)), [INFO] [stderr] 49 | | Some(false) => IResult::Error(error_position!(ErrorKind::Char, $input)), [INFO] [stderr] 50 | | Some(true) => IResult::Done( [INFO] [stderr] ... | [INFO] [stderr] 56 | | ($input:expr, $f:expr) => ( [INFO] [stderr] 57 | | char_pred!($input, call!($f)); [INFO] [stderr] | |_______________________________^ help: remove closure as shown: `is_alphaunderscore` [INFO] [stderr] | [INFO] [stderr] ::: src/lexer.rs:33:5 [INFO] [stderr] | [INFO] [stderr] 33 | / do_parse!(input, [INFO] [stderr] 34 | | prefix: many0!(complete!(do_parse!( [INFO] [stderr] 35 | | char_pred!(is_alphaunderscore) >> [INFO] [stderr] 36 | | next_chars: take_while!(is_alphanumeric_) >> [INFO] [stderr] ... | [INFO] [stderr] 45 | | }) [INFO] [stderr] 46 | | ) [INFO] [stderr] | |_____- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/nom_helpers.rs:47:55 [INFO] [stderr] | [INFO] [stderr] 47 | match ($input).iter_elements().next().map(|c| $submac!(c, $($args)*)) { [INFO] [stderr] | _______________________________________________________^ [INFO] [stderr] 48 | | None => IResult::Incomplete::<_, _>(Needed::Size(1)), [INFO] [stderr] 49 | | Some(false) => IResult::Error(error_position!(ErrorKind::Char, $input)), [INFO] [stderr] 50 | | Some(true) => IResult::Done( [INFO] [stderr] ... | [INFO] [stderr] 56 | | ($input:expr, $f:expr) => ( [INFO] [stderr] 57 | | char_pred!($input, call!($f)); [INFO] [stderr] | |_______________________________^ help: remove closure as shown: `is_alphaunderscore` [INFO] [stderr] | [INFO] [stderr] ::: src/lexer.rs:33:5 [INFO] [stderr] | [INFO] [stderr] 33 | / do_parse!(input, [INFO] [stderr] 34 | | prefix: many0!(complete!(do_parse!( [INFO] [stderr] 35 | | char_pred!(is_alphaunderscore) >> [INFO] [stderr] 36 | | next_chars: take_while!(is_alphanumeric_) >> [INFO] [stderr] ... | [INFO] [stderr] 45 | | }) [INFO] [stderr] 46 | | ) [INFO] [stderr] | |_____- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/nom_helpers.rs:47:55 [INFO] [stderr] | [INFO] [stderr] 47 | match ($input).iter_elements().next().map(|c| $submac!(c, $($args)*)) { [INFO] [stderr] | _______________________________________________________^ [INFO] [stderr] 48 | | None => IResult::Incomplete::<_, _>(Needed::Size(1)), [INFO] [stderr] 49 | | Some(false) => IResult::Error(error_position!(ErrorKind::Char, $input)), [INFO] [stderr] 50 | | Some(true) => IResult::Done( [INFO] [stderr] ... | [INFO] [stderr] 56 | | ($input:expr, $f:expr) => ( [INFO] [stderr] 57 | | char_pred!($input, call!($f)); [INFO] [stderr] | |_______________________________^ help: remove closure as shown: `is_alphaunderscore` [INFO] [stderr] | [INFO] [stderr] ::: src/lexer.rs:50:5 [INFO] [stderr] | [INFO] [stderr] 50 | / do_parse!(input, [INFO] [stderr] 51 | | char!('.') >> [INFO] [stderr] 52 | | char_pred!(is_alphaunderscore) >> [INFO] [stderr] 53 | | next_chars: take_while!(is_alphanumeric_) >> [INFO] [stderr] ... | [INFO] [stderr] 57 | | }) [INFO] [stderr] 58 | | ) [INFO] [stderr] | |______- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Update` [INFO] [stderr] --> src/ast.rs:96:54 [INFO] [stderr] | [INFO] [stderr] 96 | Assign, Or, And, Alternative, UpdateAlternative, Update, [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/nom_helpers.rs:47:55 [INFO] [stderr] | [INFO] [stderr] 47 | match ($input).iter_elements().next().map(|c| $submac!(c, $($args)*)) { [INFO] [stderr] | _______________________________________________________^ [INFO] [stderr] 48 | | None => IResult::Incomplete::<_, _>(Needed::Size(1)), [INFO] [stderr] 49 | | Some(false) => IResult::Error(error_position!(ErrorKind::Char, $input)), [INFO] [stderr] 50 | | Some(true) => IResult::Done( [INFO] [stderr] ... | [INFO] [stderr] 56 | | ($input:expr, $f:expr) => ( [INFO] [stderr] 57 | | char_pred!($input, call!($f)); [INFO] [stderr] | |_______________________________^ help: remove closure as shown: `is_alphaunderscore` [INFO] [stderr] | [INFO] [stderr] ::: src/lexer.rs:33:5 [INFO] [stderr] | [INFO] [stderr] 33 | / do_parse!(input, [INFO] [stderr] 34 | | prefix: many0!(complete!(do_parse!( [INFO] [stderr] 35 | | char_pred!(is_alphaunderscore) >> [INFO] [stderr] 36 | | next_chars: take_while!(is_alphanumeric_) >> [INFO] [stderr] ... | [INFO] [stderr] 45 | | }) [INFO] [stderr] 46 | | ) [INFO] [stderr] | |_____- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/nom_helpers.rs:47:55 [INFO] [stderr] | [INFO] [stderr] 47 | match ($input).iter_elements().next().map(|c| $submac!(c, $($args)*)) { [INFO] [stderr] | _______________________________________________________^ [INFO] [stderr] 48 | | None => IResult::Incomplete::<_, _>(Needed::Size(1)), [INFO] [stderr] 49 | | Some(false) => IResult::Error(error_position!(ErrorKind::Char, $input)), [INFO] [stderr] 50 | | Some(true) => IResult::Done( [INFO] [stderr] ... | [INFO] [stderr] 56 | | ($input:expr, $f:expr) => ( [INFO] [stderr] 57 | | char_pred!($input, call!($f)); [INFO] [stderr] | |_______________________________^ help: remove closure as shown: `is_alphaunderscore` [INFO] [stderr] | [INFO] [stderr] ::: src/lexer.rs:33:5 [INFO] [stderr] | [INFO] [stderr] 33 | / do_parse!(input, [INFO] [stderr] 34 | | prefix: many0!(complete!(do_parse!( [INFO] [stderr] 35 | | char_pred!(is_alphaunderscore) >> [INFO] [stderr] 36 | | next_chars: take_while!(is_alphanumeric_) >> [INFO] [stderr] ... | [INFO] [stderr] 45 | | }) [INFO] [stderr] 46 | | ) [INFO] [stderr] | |_____- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/nom_helpers.rs:47:55 [INFO] [stderr] | [INFO] [stderr] 47 | match ($input).iter_elements().next().map(|c| $submac!(c, $($args)*)) { [INFO] [stderr] | _______________________________________________________^ [INFO] [stderr] 48 | | None => IResult::Incomplete::<_, _>(Needed::Size(1)), [INFO] [stderr] 49 | | Some(false) => IResult::Error(error_position!(ErrorKind::Char, $input)), [INFO] [stderr] 50 | | Some(true) => IResult::Done( [INFO] [stderr] ... | [INFO] [stderr] 56 | | ($input:expr, $f:expr) => ( [INFO] [stderr] 57 | | char_pred!($input, call!($f)); [INFO] [stderr] | |_______________________________^ help: remove closure as shown: `is_alphaunderscore` [INFO] [stderr] | [INFO] [stderr] ::: src/lexer.rs:50:5 [INFO] [stderr] | [INFO] [stderr] 50 | / do_parse!(input, [INFO] [stderr] 51 | | char!('.') >> [INFO] [stderr] 52 | | char_pred!(is_alphaunderscore) >> [INFO] [stderr] 53 | | next_chars: take_while!(is_alphanumeric_) >> [INFO] [stderr] ... | [INFO] [stderr] 57 | | }) [INFO] [stderr] 58 | | ) [INFO] [stderr] | |______- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 56 [INFO] [stderr] --> src/parser.rs:282:1 [INFO] [stderr] | [INFO] [stderr] 282 | / pub fn qq_string_part(input: &str) -> IResult<&str, QQStringPart> { [INFO] [stderr] 283 | | alt_complete!(input, [INFO] [stderr] 284 | | do_parse!( [INFO] [stderr] 285 | | text: alt_complete!( [INFO] [stderr] ... | [INFO] [stderr] 314 | | ) [INFO] [stderr] 315 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 56 [INFO] [stderr] --> src/parser.rs:282:1 [INFO] [stderr] | [INFO] [stderr] 282 | / pub fn qq_string_part(input: &str) -> IResult<&str, QQStringPart> { [INFO] [stderr] 283 | | alt_complete!(input, [INFO] [stderr] 284 | | do_parse!( [INFO] [stderr] 285 | | text: alt_complete!( [INFO] [stderr] ... | [INFO] [stderr] 314 | | ) [INFO] [stderr] 315 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 11.59s [INFO] running `"docker" "inspect" "64bace1fa17fb70bff9eb80aa56df6969d350773ec995ab8ea7f2a9e256e33b5"` [INFO] running `"docker" "rm" "-f" "64bace1fa17fb70bff9eb80aa56df6969d350773ec995ab8ea7f2a9e256e33b5"` [INFO] [stdout] 64bace1fa17fb70bff9eb80aa56df6969d350773ec995ab8ea7f2a9e256e33b5