[INFO] updating cached repository hazeycode/lee [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/hazeycode/lee [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/hazeycode/lee" "work/ex/clippy-test-run/sources/stable/gh/hazeycode/lee"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/hazeycode/lee'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/hazeycode/lee" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/hazeycode/lee"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/hazeycode/lee'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 1b2bf7035933df0d7a18ddc5594478dfb3f0e91e [INFO] sha for GitHub repo hazeycode/lee: 1b2bf7035933df0d7a18ddc5594478dfb3f0e91e [INFO] validating manifest of hazeycode/lee on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of hazeycode/lee on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing hazeycode/lee [INFO] finished frobbing hazeycode/lee [INFO] frobbed toml for hazeycode/lee written to work/ex/clippy-test-run/sources/stable/gh/hazeycode/lee/Cargo.toml [INFO] started frobbing hazeycode/lee [INFO] finished frobbing hazeycode/lee [INFO] frobbed toml for hazeycode/lee written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/hazeycode/lee/Cargo.toml [INFO] crate hazeycode/lee has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting hazeycode/lee against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/hazeycode/lee:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 110e608fa294a6e81b80a93bc7f5b2f01613f851b09658f8beee7d5ff3bc796f [INFO] running `"docker" "start" "-a" "110e608fa294a6e81b80a93bc7f5b2f01613f851b09658f8beee7d5ff3bc796f"` [INFO] [stderr] Checking nix v0.5.1 [INFO] [stderr] Checking rustyline v1.0.0 [INFO] [stderr] Checking lee v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: this loop could be written as a `for` loop [INFO] [stderr] --> src/expr.rs:50:40 [INFO] [stderr] | [INFO] [stderr] 50 | while let Some(next) = iter.next() { [INFO] [stderr] | ^^^^^^^^^^^ help: try: `for next in iter { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_on_iterator)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/env.rs:23:32 [INFO] [stderr] | [INFO] [stderr] 23 | if x.len() == 0 && y.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `x.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/env.rs:23:48 [INFO] [stderr] | [INFO] [stderr] 23 | if x.len() == 0 && y.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `y.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `for` loop [INFO] [stderr] --> src/lex.rs:62:25 [INFO] [stderr] | [INFO] [stderr] 62 | while let Some(c) = chars.next() { [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `for c in chars { .. }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/lex.rs:115:25 [INFO] [stderr] | [INFO] [stderr] 115 | fn tokenise(string: &String) -> Option { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 115 | fn tokenise(string: &str) -> Option { [INFO] [stderr] | ^^^^ [INFO] [stderr] help: change `string.as_str()` to [INFO] [stderr] | [INFO] [stderr] 118 | match string { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] help: change `string.clone()` to [INFO] [stderr] | [INFO] [stderr] 121 | _ => Some(Token::Symbol(string.to_string())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] help: change `string.clone()` to [INFO] [stderr] | [INFO] [stderr] 130 | Some(_) => Some(Token::Symbol(string.to_string())), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `for` loop [INFO] [stderr] --> src/expr.rs:50:40 [INFO] [stderr] | [INFO] [stderr] 50 | while let Some(next) = iter.next() { [INFO] [stderr] | ^^^^^^^^^^^ help: try: `for next in iter { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_on_iterator)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/env.rs:23:32 [INFO] [stderr] | [INFO] [stderr] 23 | if x.len() == 0 && y.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `x.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/env.rs:23:48 [INFO] [stderr] | [INFO] [stderr] 23 | if x.len() == 0 && y.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `y.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `for` loop [INFO] [stderr] --> src/lex.rs:62:25 [INFO] [stderr] | [INFO] [stderr] 62 | while let Some(c) = chars.next() { [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `for c in chars { .. }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/lex.rs:115:25 [INFO] [stderr] | [INFO] [stderr] 115 | fn tokenise(string: &String) -> Option { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 115 | fn tokenise(string: &str) -> Option { [INFO] [stderr] | ^^^^ [INFO] [stderr] help: change `string.as_str()` to [INFO] [stderr] | [INFO] [stderr] 118 | match string { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] help: change `string.clone()` to [INFO] [stderr] | [INFO] [stderr] 121 | _ => Some(Token::Symbol(string.to_string())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] help: change `string.clone()` to [INFO] [stderr] | [INFO] [stderr] 130 | Some(_) => Some(Token::Symbol(string.to_string())), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:6:26 [INFO] [stderr] | [INFO] [stderr] 6 | const HISTORY_PATH: &'static str = "./repl-input.txt"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:6:26 [INFO] [stderr] | [INFO] [stderr] 6 | const HISTORY_PATH: &'static str = "./repl-input.txt"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 5.70s [INFO] running `"docker" "inspect" "110e608fa294a6e81b80a93bc7f5b2f01613f851b09658f8beee7d5ff3bc796f"` [INFO] running `"docker" "rm" "-f" "110e608fa294a6e81b80a93bc7f5b2f01613f851b09658f8beee7d5ff3bc796f"` [INFO] [stdout] 110e608fa294a6e81b80a93bc7f5b2f01613f851b09658f8beee7d5ff3bc796f