[INFO] updating cached repository hardvain/dsa [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/hardvain/dsa [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/hardvain/dsa" "work/ex/clippy-test-run/sources/stable/gh/hardvain/dsa"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/hardvain/dsa'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/hardvain/dsa" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/hardvain/dsa"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/hardvain/dsa'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 61b98346e489768a04e8c5b7e032959961e404d4 [INFO] sha for GitHub repo hardvain/dsa: 61b98346e489768a04e8c5b7e032959961e404d4 [INFO] validating manifest of hardvain/dsa on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of hardvain/dsa on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing hardvain/dsa [INFO] removed 0 missing tests [INFO] finished frobbing hardvain/dsa [INFO] frobbed toml for hardvain/dsa written to work/ex/clippy-test-run/sources/stable/gh/hardvain/dsa/Cargo.toml [INFO] started frobbing hardvain/dsa [INFO] removed 0 missing tests [INFO] finished frobbing hardvain/dsa [INFO] frobbed toml for hardvain/dsa written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/hardvain/dsa/Cargo.toml [INFO] crate hardvain/dsa has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting hardvain/dsa against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/hardvain/dsa:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 9ded005ce4f8df0e89678304c414ccb5e8c0d2dd11279df40b30101e5bd221a9 [INFO] running `"docker" "start" "-a" "9ded005ce4f8df0e89678304c414ccb5e8c0d2dd11279df40b30101e5bd221a9"` [INFO] [stderr] Checking dsa v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/singly_linked_list.rs:191:36 [INFO] [stderr] | [INFO] [stderr] 191 | SinglyLinkedListIterator { next: next } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `next` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/singly_linked_list.rs:200:39 [INFO] [stderr] | [INFO] [stderr] 200 | SinglyLinkedListIteratorMut { next: next } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `next` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/singly_linked_list.rs:191:36 [INFO] [stderr] | [INFO] [stderr] 191 | SinglyLinkedListIterator { next: next } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `next` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/singly_linked_list.rs:200:39 [INFO] [stderr] | [INFO] [stderr] 200 | SinglyLinkedListIteratorMut { next: next } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `next` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `singly_linked_list::SinglyLinkedList` [INFO] [stderr] --> src/singly_linked_list.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | / pub fn new() -> Self { [INFO] [stderr] 15 | | SinglyLinkedList { head: None } [INFO] [stderr] 16 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 9 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/singly_linked_list.rs:20:13 [INFO] [stderr] | [INFO] [stderr] 20 | length = length + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `length += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/singly_linked_list.rs:46:9 [INFO] [stderr] | [INFO] [stderr] 46 | optional_node.map(|node| { [INFO] [stderr] | _________^ [INFO] [stderr] | |_________| [INFO] [stderr] | || [INFO] [stderr] 47 | || let current_next = &mut node.next; [INFO] [stderr] 48 | || new_node.next = current_next.take(); [INFO] [stderr] 49 | || node.next = Some(Box::new(new_node)); [INFO] [stderr] 50 | || }); [INFO] [stderr] | ||__________^- help: try this: `if let Some(node) = optional_node { ... }` [INFO] [stderr] | |___________| [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/singly_linked_list.rs:56:13 [INFO] [stderr] | [INFO] [stderr] 56 | self.head.as_mut().map(|node| { [INFO] [stderr] | _____________^ [INFO] [stderr] | |_____________| [INFO] [stderr] | || [INFO] [stderr] 57 | || node.value = t; [INFO] [stderr] 58 | || }); [INFO] [stderr] | ||______________^- help: try this: `if let Some(node) = self.head.as_mut() { node.value = t; }` [INFO] [stderr] | |_______________| [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/singly_linked_list.rs:61:13 [INFO] [stderr] | [INFO] [stderr] 61 | optional_node.map(|node| { [INFO] [stderr] | _____________^ [INFO] [stderr] | |_____________| [INFO] [stderr] | || [INFO] [stderr] 62 | || node.value = t; [INFO] [stderr] 63 | || }); [INFO] [stderr] | ||______________^- help: try this: `if let Some(node) = optional_node { node.value = t; }` [INFO] [stderr] | |_______________| [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/singly_linked_list.rs:106:13 [INFO] [stderr] | [INFO] [stderr] 106 | counter = counter - 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `counter -= 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/singly_linked_list.rs:120:13 [INFO] [stderr] | [INFO] [stderr] 120 | counter = counter - 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `counter -= 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/singly_linked_list.rs:146:13 [INFO] [stderr] | [INFO] [stderr] 146 | index = index + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `index += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/singly_linked_list.rs:158:13 [INFO] [stderr] | [INFO] [stderr] 158 | index = index + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `index += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `singly_linked_list::SinglyLinkedList` [INFO] [stderr] --> src/singly_linked_list.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | / pub fn new() -> Self { [INFO] [stderr] 15 | | SinglyLinkedList { head: None } [INFO] [stderr] 16 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 9 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/singly_linked_list.rs:20:13 [INFO] [stderr] | [INFO] [stderr] 20 | length = length + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `length += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/singly_linked_list.rs:46:9 [INFO] [stderr] | [INFO] [stderr] 46 | optional_node.map(|node| { [INFO] [stderr] | _________^ [INFO] [stderr] | |_________| [INFO] [stderr] | || [INFO] [stderr] 47 | || let current_next = &mut node.next; [INFO] [stderr] 48 | || new_node.next = current_next.take(); [INFO] [stderr] 49 | || node.next = Some(Box::new(new_node)); [INFO] [stderr] 50 | || }); [INFO] [stderr] | ||__________^- help: try this: `if let Some(node) = optional_node { ... }` [INFO] [stderr] | |___________| [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/singly_linked_list.rs:56:13 [INFO] [stderr] | [INFO] [stderr] 56 | self.head.as_mut().map(|node| { [INFO] [stderr] | _____________^ [INFO] [stderr] | |_____________| [INFO] [stderr] | || [INFO] [stderr] 57 | || node.value = t; [INFO] [stderr] 58 | || }); [INFO] [stderr] | ||______________^- help: try this: `if let Some(node) = self.head.as_mut() { node.value = t; }` [INFO] [stderr] | |_______________| [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/singly_linked_list.rs:61:13 [INFO] [stderr] | [INFO] [stderr] 61 | optional_node.map(|node| { [INFO] [stderr] | _____________^ [INFO] [stderr] | |_____________| [INFO] [stderr] | || [INFO] [stderr] 62 | || node.value = t; [INFO] [stderr] 63 | || }); [INFO] [stderr] | ||______________^- help: try this: `if let Some(node) = optional_node { node.value = t; }` [INFO] [stderr] | |_______________| [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/singly_linked_list.rs:106:13 [INFO] [stderr] | [INFO] [stderr] 106 | counter = counter - 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `counter -= 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/singly_linked_list.rs:120:13 [INFO] [stderr] | [INFO] [stderr] 120 | counter = counter - 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `counter -= 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/singly_linked_list.rs:146:13 [INFO] [stderr] | [INFO] [stderr] 146 | index = index + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `index += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/singly_linked_list.rs:158:13 [INFO] [stderr] | [INFO] [stderr] 158 | index = index + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `index += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.99s [INFO] running `"docker" "inspect" "9ded005ce4f8df0e89678304c414ccb5e8c0d2dd11279df40b30101e5bd221a9"` [INFO] running `"docker" "rm" "-f" "9ded005ce4f8df0e89678304c414ccb5e8c0d2dd11279df40b30101e5bd221a9"` [INFO] [stdout] 9ded005ce4f8df0e89678304c414ccb5e8c0d2dd11279df40b30101e5bd221a9