[INFO] updating cached repository hansihe/beam_code
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/hansihe/beam_code
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/hansihe/beam_code" "work/ex/clippy-test-run/sources/stable/gh/hansihe/beam_code"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/hansihe/beam_code'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/hansihe/beam_code" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/hansihe/beam_code"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/hansihe/beam_code'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 64f05a3f331e5ca9fc19c2501739c248995b9587
[INFO] sha for GitHub repo hansihe/beam_code: 64f05a3f331e5ca9fc19c2501739c248995b9587
[INFO] validating manifest of hansihe/beam_code on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of hansihe/beam_code on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing hansihe/beam_code
[INFO] finished frobbing hansihe/beam_code
[INFO] frobbed toml for hansihe/beam_code written to work/ex/clippy-test-run/sources/stable/gh/hansihe/beam_code/Cargo.toml
[INFO] started frobbing hansihe/beam_code
[INFO] finished frobbing hansihe/beam_code
[INFO] frobbed toml for hansihe/beam_code written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/hansihe/beam_code/Cargo.toml
[INFO] crate hansihe/beam_code has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting hansihe/beam_code against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/hansihe/beam_code:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 7dd6d57fcd8f0ba24f99d2066ee5b5ca3a36e77922f6677729e051a1311e262b
[INFO] running `"docker" "start" "-a" "7dd6d57fcd8f0ba24f99d2066ee5b5ca3a36e77922f6677729e051a1311e262b"`
[INFO] [stderr]     Checking num-integer v0.1.34
[INFO] [stderr]     Checking num-complex v0.1.38
[INFO] [stderr]     Checking libflate v0.1.9
[INFO] [stderr]     Checking string-intern v0.1.6
[INFO] [stderr]     Checking itertools v0.6.0
[INFO] [stderr]     Checking aho-corasick v0.6.3
[INFO] [stderr]     Checking regex v0.2.2
[INFO] [stderr]     Checking num-bigint v0.1.39
[INFO] [stderr]     Checking num-iter v0.1.33
[INFO] [stderr]     Checking beam_file v0.2.2
[INFO] [stderr]     Checking num-rational v0.1.38
[INFO] [stderr]     Checking num v0.1.39
[INFO] [stderr]     Checking eetf v0.3.6
[INFO] [stderr]     Checking beam_code v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/gen_op.rs:59:21
[INFO] [stderr]    |
[INFO] [stderr] 59 |                     arity: arity,
[INFO] [stderr]    |                     ^^^^^^^^^^^^ help: replace it with: `arity`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/gen_op.rs:67:13
[INFO] [stderr]    |
[INFO] [stderr] 67 |             ops: ops,
[INFO] [stderr]    |             ^^^^^^^^ help: replace it with: `ops`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/op.rs:21:13
[INFO] [stderr]    |
[INFO] [stderr] 21 |             kind: kind,
[INFO] [stderr]    |             ^^^^^^^^^^ help: replace it with: `kind`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/op.rs:26:13
[INFO] [stderr]    |
[INFO] [stderr] 26 |             reads: reads,
[INFO] [stderr]    |             ^^^^^^^^^^^^ help: replace it with: `reads`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/op.rs:29:13
[INFO] [stderr]    |
[INFO] [stderr] 29 |             kind: kind,
[INFO] [stderr]    |             ^^^^^^^^^^ help: replace it with: `kind`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/op.rs:34:13
[INFO] [stderr]    |
[INFO] [stderr] 34 |             reads: reads,
[INFO] [stderr]    |             ^^^^^^^^^^^^ help: replace it with: `reads`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/op.rs:36:13
[INFO] [stderr]    |
[INFO] [stderr] 36 |             labels: labels,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^ help: replace it with: `labels`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/op.rs:37:13
[INFO] [stderr]    |
[INFO] [stderr] 37 |             kind: kind,
[INFO] [stderr]    |             ^^^^^^^^^^ help: replace it with: `kind`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/op.rs:42:13
[INFO] [stderr]    |
[INFO] [stderr] 42 |             reads: reads,
[INFO] [stderr]    |             ^^^^^^^^^^^^ help: replace it with: `reads`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/op.rs:43:13
[INFO] [stderr]    |
[INFO] [stderr] 43 |             writes: writes,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^ help: replace it with: `writes`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/op.rs:45:13
[INFO] [stderr]    |
[INFO] [stderr] 45 |             kind: kind,
[INFO] [stderr]    |             ^^^^^^^^^^ help: replace it with: `kind`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/op.rs:522:45
[INFO] [stderr]     |
[INFO] [stderr] 522 |                     kind: OpKind::CallFun { arity: arity },
[INFO] [stderr]     |                                             ^^^^^^^^^^^^ help: replace it with: `arity`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/op.rs:550:25
[INFO] [stderr]     |
[INFO] [stderr] 550 |                         arity: arity,
[INFO] [stderr]     |                         ^^^^^^^^^^^^ help: replace it with: `arity`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/op.rs:560:25
[INFO] [stderr]     |
[INFO] [stderr] 560 |                         arity: arity,
[INFO] [stderr]     |                         ^^^^^^^^^^^^ help: replace it with: `arity`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/op.rs:571:25
[INFO] [stderr]     |
[INFO] [stderr] 571 |                         arity: arity,
[INFO] [stderr]     |                         ^^^^^^^^^^^^ help: replace it with: `arity`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/op.rs:582:25
[INFO] [stderr]     |
[INFO] [stderr] 582 |                         arity: arity,
[INFO] [stderr]     |                         ^^^^^^^^^^^^ help: replace it with: `arity`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/op.rs:592:25
[INFO] [stderr]     |
[INFO] [stderr] 592 |                         arity: arity,
[INFO] [stderr]     |                         ^^^^^^^^^^^^ help: replace it with: `arity`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/beam_module.rs:183:13
[INFO] [stderr]     |
[INFO] [stderr] 183 |             arity: arity,
[INFO] [stderr]     |             ^^^^^^^^^^^^ help: replace it with: `arity`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/beam_module.rs:204:13
[INFO] [stderr]     |
[INFO] [stderr] 204 |             arity: arity,
[INFO] [stderr]     |             ^^^^^^^^^^^^ help: replace it with: `arity`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/beam_module.rs:205:13
[INFO] [stderr]     |
[INFO] [stderr] 205 |             label: label,
[INFO] [stderr]     |             ^^^^^^^^^^^^ help: replace it with: `label`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/ssa/mod.rs:98:17
[INFO] [stderr]    |
[INFO] [stderr] 98 |                 arity: arity,
[INFO] [stderr]    |                 ^^^^^^^^^^^^ help: replace it with: `arity`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/ssa/mod.rs:99:17
[INFO] [stderr]    |
[INFO] [stderr] 99 |                 label: label,
[INFO] [stderr]    |                 ^^^^^^^^^^^^ help: replace it with: `label`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead
[INFO] [stderr]    --> src/ssa/mod.rs:494:5
[INFO] [stderr]     |
[INFO] [stderr] 494 |     write!(w, "digraph g {{\n")?;
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::write_with_newline)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead
[INFO] [stderr]    --> src/ssa/mod.rs:495:5
[INFO] [stderr]     |
[INFO] [stderr] 495 |     write!(w, "node [labeljust=\"l\", shape=record, fontname=\"Courier New\"]\n")?;
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead
[INFO] [stderr]    --> src/ssa/mod.rs:499:5
[INFO] [stderr]     |
[INFO] [stderr] 499 | /     write!(w, "entry [ label=<entry|fun: {} free: {:?} write[{:?}]> ];\n",
[INFO] [stderr] 500 | |            fun_name, function.fun_type, function.args)?;
[INFO] [stderr]     | |______________________________________________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead
[INFO] [stderr]    --> src/ssa/mod.rs:552:9
[INFO] [stderr]     |
[INFO] [stderr] 552 |         write!(w, "> ];\n")?;
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead
[INFO] [stderr]    --> src/ssa/mod.rs:555:13
[INFO] [stderr]     |
[INFO] [stderr] 555 |             write!(w, "blk_{} -> blk_{} [ label=cont ];\n", block_name, label.name())?;
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead
[INFO] [stderr]    --> src/ssa/mod.rs:558:13
[INFO] [stderr]     |
[INFO] [stderr] 558 |             write!(w, "blk_{} -> blk_{} [ label={} ];\n", block_name, arg.name(), idx)?;
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead
[INFO] [stderr]    --> src/ssa/mod.rs:560:9
[INFO] [stderr]     |
[INFO] [stderr] 560 |         write!(w, "\n")?;
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead
[INFO] [stderr]    --> src/ssa/mod.rs:563:5
[INFO] [stderr]     |
[INFO] [stderr] 563 |     write!(w, "}}\n")?;
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/gen_op.rs:59:21
[INFO] [stderr]    |
[INFO] [stderr] 59 |                     arity: arity,
[INFO] [stderr]    |                     ^^^^^^^^^^^^ help: replace it with: `arity`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/gen_op.rs:67:13
[INFO] [stderr]    |
[INFO] [stderr] 67 |             ops: ops,
[INFO] [stderr]    |             ^^^^^^^^ help: replace it with: `ops`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/op.rs:21:13
[INFO] [stderr]    |
[INFO] [stderr] 21 |             kind: kind,
[INFO] [stderr]    |             ^^^^^^^^^^ help: replace it with: `kind`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/op.rs:26:13
[INFO] [stderr]    |
[INFO] [stderr] 26 |             reads: reads,
[INFO] [stderr]    |             ^^^^^^^^^^^^ help: replace it with: `reads`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/op.rs:29:13
[INFO] [stderr]    |
[INFO] [stderr] 29 |             kind: kind,
[INFO] [stderr]    |             ^^^^^^^^^^ help: replace it with: `kind`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/op.rs:34:13
[INFO] [stderr]    |
[INFO] [stderr] 34 |             reads: reads,
[INFO] [stderr]    |             ^^^^^^^^^^^^ help: replace it with: `reads`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/op.rs:36:13
[INFO] [stderr]    |
[INFO] [stderr] 36 |             labels: labels,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^ help: replace it with: `labels`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/op.rs:37:13
[INFO] [stderr]    |
[INFO] [stderr] 37 |             kind: kind,
[INFO] [stderr]    |             ^^^^^^^^^^ help: replace it with: `kind`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/op.rs:42:13
[INFO] [stderr]    |
[INFO] [stderr] 42 |             reads: reads,
[INFO] [stderr]    |             ^^^^^^^^^^^^ help: replace it with: `reads`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/op.rs:43:13
[INFO] [stderr]    |
[INFO] [stderr] 43 |             writes: writes,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^ help: replace it with: `writes`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/op.rs:45:13
[INFO] [stderr]    |
[INFO] [stderr] 45 |             kind: kind,
[INFO] [stderr]    |             ^^^^^^^^^^ help: replace it with: `kind`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/op.rs:522:45
[INFO] [stderr]     |
[INFO] [stderr] 522 |                     kind: OpKind::CallFun { arity: arity },
[INFO] [stderr]     |                                             ^^^^^^^^^^^^ help: replace it with: `arity`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/op.rs:550:25
[INFO] [stderr]     |
[INFO] [stderr] 550 |                         arity: arity,
[INFO] [stderr]     |                         ^^^^^^^^^^^^ help: replace it with: `arity`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/op.rs:560:25
[INFO] [stderr]     |
[INFO] [stderr] 560 |                         arity: arity,
[INFO] [stderr]     |                         ^^^^^^^^^^^^ help: replace it with: `arity`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/op.rs:571:25
[INFO] [stderr]     |
[INFO] [stderr] 571 |                         arity: arity,
[INFO] [stderr]     |                         ^^^^^^^^^^^^ help: replace it with: `arity`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/op.rs:582:25
[INFO] [stderr]     |
[INFO] [stderr] 582 |                         arity: arity,
[INFO] [stderr]     |                         ^^^^^^^^^^^^ help: replace it with: `arity`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/op.rs:592:25
[INFO] [stderr]     |
[INFO] [stderr] 592 |                         arity: arity,
[INFO] [stderr]     |                         ^^^^^^^^^^^^ help: replace it with: `arity`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/beam_module.rs:183:13
[INFO] [stderr]     |
[INFO] [stderr] 183 |             arity: arity,
[INFO] [stderr]     |             ^^^^^^^^^^^^ help: replace it with: `arity`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/beam_module.rs:204:13
[INFO] [stderr]     |
[INFO] [stderr] 204 |             arity: arity,
[INFO] [stderr]     |             ^^^^^^^^^^^^ help: replace it with: `arity`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/beam_module.rs:205:13
[INFO] [stderr]     |
[INFO] [stderr] 205 |             label: label,
[INFO] [stderr]     |             ^^^^^^^^^^^^ help: replace it with: `label`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/ssa/mod.rs:98:17
[INFO] [stderr]    |
[INFO] [stderr] 98 |                 arity: arity,
[INFO] [stderr]    |                 ^^^^^^^^^^^^ help: replace it with: `arity`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/ssa/mod.rs:99:17
[INFO] [stderr]    |
[INFO] [stderr] 99 |                 label: label,
[INFO] [stderr]    |                 ^^^^^^^^^^^^ help: replace it with: `label`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead
[INFO] [stderr]    --> src/ssa/mod.rs:494:5
[INFO] [stderr]     |
[INFO] [stderr] 494 |     write!(w, "digraph g {{\n")?;
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::write_with_newline)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead
[INFO] [stderr]    --> src/ssa/mod.rs:495:5
[INFO] [stderr]     |
[INFO] [stderr] 495 |     write!(w, "node [labeljust=\"l\", shape=record, fontname=\"Courier New\"]\n")?;
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead
[INFO] [stderr]    --> src/ssa/mod.rs:499:5
[INFO] [stderr]     |
[INFO] [stderr] 499 | /     write!(w, "entry [ label=<entry|fun: {} free: {:?} write[{:?}]> ];\n",
[INFO] [stderr] 500 | |            fun_name, function.fun_type, function.args)?;
[INFO] [stderr]     | |______________________________________________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead
[INFO] [stderr]    --> src/ssa/mod.rs:552:9
[INFO] [stderr]     |
[INFO] [stderr] 552 |         write!(w, "> ];\n")?;
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead
[INFO] [stderr]    --> src/ssa/mod.rs:555:13
[INFO] [stderr]     |
[INFO] [stderr] 555 |             write!(w, "blk_{} -> blk_{} [ label=cont ];\n", block_name, label.name())?;
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead
[INFO] [stderr]    --> src/ssa/mod.rs:558:13
[INFO] [stderr]     |
[INFO] [stderr] 558 |             write!(w, "blk_{} -> blk_{} [ label={} ];\n", block_name, arg.name(), idx)?;
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead
[INFO] [stderr]    --> src/ssa/mod.rs:560:9
[INFO] [stderr]     |
[INFO] [stderr] 560 |         write!(w, "\n")?;
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead
[INFO] [stderr]    --> src/ssa/mod.rs:563:5
[INFO] [stderr]     |
[INFO] [stderr] 563 |     write!(w, "}}\n")?;
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `::std::rc::Rc`
[INFO] [stderr]  --> src/op.rs:6:5
[INFO] [stderr]   |
[INFO] [stderr] 6 | use ::std::rc::Rc;
[INFO] [stderr]   |     ^^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `::std::rc::Rc`
[INFO] [stderr]  --> src/op.rs:6:5
[INFO] [stderr]   |
[INFO] [stderr] 6 | use ::std::rc::Rc;
[INFO] [stderr]   |     ^^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/raw_op.rs:72:31
[INFO] [stderr]    |
[INFO] [stderr] 72 |     let arg_type = arg_base & 0b00000111;
[INFO] [stderr]    |                               ^^^^^^^^^^ help: consider: `0b0000_0111`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/raw_op.rs:73:35
[INFO] [stderr]    |
[INFO] [stderr] 73 |     let arg_expanded = arg_base & 0b00001000;
[INFO] [stderr]    |                                   ^^^^^^^^^^ help: consider: `0b0000_1000`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/raw_op.rs:74:39
[INFO] [stderr]    |
[INFO] [stderr] 74 |     let arg_adv_expanded = arg_base & 0b00010000;
[INFO] [stderr]    |                                       ^^^^^^^^^^ help: consider: `0b0001_0000`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `Literal`
[INFO] [stderr]  --> src/ssa/mod.rs:5:52
[INFO] [stderr]   |
[INFO] [stderr] 5 | use ::op::{ Op, LabelId, Register, OpKind, Source, Literal };
[INFO] [stderr]   |                                                    ^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `::std::hash::Hash`
[INFO] [stderr]  --> src/ssa/representation.rs:5:5
[INFO] [stderr]   |
[INFO] [stderr] 5 | use ::std::hash::Hash;
[INFO] [stderr]   |     ^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]    --> src/ssa/mod.rs:316:5
[INFO] [stderr]     |
[INFO] [stderr] 316 |     cleaned
[INFO] [stderr]     |     ^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]    --> src/ssa/mod.rs:279:19
[INFO] [stderr]     |
[INFO] [stderr] 279 |       let cleaned = functions.iter().map(|f| {
[INFO] [stderr]     |  ___________________^
[INFO] [stderr] 280 | |         let mut ssa_fun = SSAFunction {
[INFO] [stderr] 281 | |             name: f.name.clone(),
[INFO] [stderr] 282 | |             arity: f.arity,
[INFO] [stderr] ...   |
[INFO] [stderr] 313 | |         ssa_fun
[INFO] [stderr] 314 | |     }).collect();
[INFO] [stderr]     | |________________^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]    --> src/ssa/mod.rs:343:5
[INFO] [stderr]     |
[INFO] [stderr] 343 |     frontiers
[INFO] [stderr]     |     ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]    --> src/ssa/mod.rs:341:21
[INFO] [stderr]     |
[INFO] [stderr] 341 |     let frontiers = ::graph::dominance_frontiers(&i_dominators, &predecessors);
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `::std::fmt::Debug`
[INFO] [stderr]  --> src/graph/dfs.rs:2:5
[INFO] [stderr]   |
[INFO] [stderr] 2 | use ::std::fmt::Debug;
[INFO] [stderr]   |     ^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `GraphAccessor`
[INFO] [stderr]  --> src/graph/dfs.rs:5:14
[INFO] [stderr]   |
[INFO] [stderr] 5 | use super::{ GraphAccessor, GraphDfs };
[INFO] [stderr]   |              ^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/lib.rs:33:16
[INFO] [stderr]    |
[INFO] [stderr] 33 | const OP_TAB: &'static str = include_str!("../test_data/genop.tab");
[INFO] [stderr]    |               -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]   --> src/lib.rs:40:5
[INFO] [stderr]    |
[INFO] [stderr] 40 |     module
[INFO] [stderr]    |     ^^^^^^
[INFO] [stderr]    |
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]   --> src/lib.rs:39:18
[INFO] [stderr]    |
[INFO] [stderr] 39 |     let module = Module::from_beam_file(&file, &op_table);
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]   --> src/lib.rs:50:5
[INFO] [stderr]    |
[INFO] [stderr] 50 |     functions
[INFO] [stderr]    |     ^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]   --> src/lib.rs:48:21
[INFO] [stderr]    |
[INFO] [stderr] 48 |     let functions = ssa::code_to_functions(&code, module);
[INFO] [stderr]    |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/raw_op.rs:72:31
[INFO] [stderr]    |
[INFO] [stderr] 72 |     let arg_type = arg_base & 0b00000111;
[INFO] [stderr]    |                               ^^^^^^^^^^ help: consider: `0b0000_0111`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/raw_op.rs:73:35
[INFO] [stderr]    |
[INFO] [stderr] 73 |     let arg_expanded = arg_base & 0b00001000;
[INFO] [stderr]    |                                   ^^^^^^^^^^ help: consider: `0b0000_1000`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/raw_op.rs:74:39
[INFO] [stderr]    |
[INFO] [stderr] 74 |     let arg_adv_expanded = arg_base & 0b00010000;
[INFO] [stderr]    |                                       ^^^^^^^^^^ help: consider: `0b0001_0000`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `Literal`
[INFO] [stderr]  --> src/ssa/mod.rs:5:52
[INFO] [stderr]   |
[INFO] [stderr] 5 | use ::op::{ Op, LabelId, Register, OpKind, Source, Literal };
[INFO] [stderr]   |                                                    ^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `::std::hash::Hash`
[INFO] [stderr]  --> src/ssa/representation.rs:5:5
[INFO] [stderr]   |
[INFO] [stderr] 5 | use ::std::hash::Hash;
[INFO] [stderr]   |     ^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]    --> src/ssa/mod.rs:316:5
[INFO] [stderr]     |
[INFO] [stderr] 316 |     cleaned
[INFO] [stderr]     |     ^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]    --> src/ssa/mod.rs:279:19
[INFO] [stderr]     |
[INFO] [stderr] 279 |       let cleaned = functions.iter().map(|f| {
[INFO] [stderr]     |  ___________________^
[INFO] [stderr] 280 | |         let mut ssa_fun = SSAFunction {
[INFO] [stderr] 281 | |             name: f.name.clone(),
[INFO] [stderr] 282 | |             arity: f.arity,
[INFO] [stderr] ...   |
[INFO] [stderr] 313 | |         ssa_fun
[INFO] [stderr] 314 | |     }).collect();
[INFO] [stderr]     | |________________^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]    --> src/ssa/mod.rs:343:5
[INFO] [stderr]     |
[INFO] [stderr] 343 |     frontiers
[INFO] [stderr]     |     ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]    --> src/ssa/mod.rs:341:21
[INFO] [stderr]     |
[INFO] [stderr] 341 |     let frontiers = ::graph::dominance_frontiers(&i_dominators, &predecessors);
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `::std::fmt::Debug`
[INFO] [stderr]  --> src/graph/dfs.rs:2:5
[INFO] [stderr]   |
[INFO] [stderr] 2 | use ::std::fmt::Debug;
[INFO] [stderr]   |     ^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `GraphAccessor`
[INFO] [stderr]  --> src/graph/dfs.rs:5:14
[INFO] [stderr]   |
[INFO] [stderr] 5 | use super::{ GraphAccessor, GraphDfs };
[INFO] [stderr]   |              ^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/lib.rs:33:16
[INFO] [stderr]    |
[INFO] [stderr] 33 | const OP_TAB: &'static str = include_str!("../test_data/genop.tab");
[INFO] [stderr]    |               -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]   --> src/lib.rs:40:5
[INFO] [stderr]    |
[INFO] [stderr] 40 |     module
[INFO] [stderr]    |     ^^^^^^
[INFO] [stderr]    |
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]   --> src/lib.rs:39:18
[INFO] [stderr]    |
[INFO] [stderr] 39 |     let module = Module::from_beam_file(&file, &op_table);
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]   --> src/lib.rs:50:5
[INFO] [stderr]    |
[INFO] [stderr] 50 |     functions
[INFO] [stderr]    |     ^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]   --> src/lib.rs:48:21
[INFO] [stderr]    |
[INFO] [stderr] 48 |     let functions = ssa::code_to_functions(&code, module);
[INFO] [stderr]    |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `atom_num`
[INFO] [stderr]    --> src/beam_module.rs:218:9
[INFO] [stderr]     |
[INFO] [stderr] 218 |     for atom_num in 0..len {
[INFO] [stderr]     |         ^^^^^^^^ help: consider using `_atom_num` instead
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_variables)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `atom_num`
[INFO] [stderr]    --> src/beam_module.rs:218:9
[INFO] [stderr]     |
[INFO] [stderr] 218 |     for atom_num in 0..len {
[INFO] [stderr]     |         ^^^^^^^^ help: consider using `_atom_num` instead
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_variables)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `x_reg`
[INFO] [stderr]    --> src/op.rs:687:5
[INFO] [stderr]     |
[INFO] [stderr] 687 |     fn x_reg(num: u32) -> Source {
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: type alias is never used: `GraphAccessor`
[INFO] [stderr]   --> src/graph/mod.rs:14:1
[INFO] [stderr]    |
[INFO] [stderr] 14 | pub type GraphAccessor<NodeId> = Fn(NodeId, usize) -> Option<NodeId>;
[INFO] [stderr]    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/op.rs:332:39
[INFO] [stderr]     |
[INFO] [stderr] 332 |             OpKind::CallBif { .. } if self.labels.len() != 0 => true,
[INFO] [stderr]     |                                       ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.labels.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: the function has a cyclomatic complexity of 90
[INFO] [stderr]    --> src/op.rs:378:5
[INFO] [stderr]     |
[INFO] [stderr] 378 | /     pub fn from_raw(raw_op: &RawOp, module: &Module) -> Op {
[INFO] [stderr] 379 | |         let atoms = &module.atoms;
[INFO] [stderr] 380 | |         let imports = &module.imports;
[INFO] [stderr] 381 | |         let lambdas = &module.lambdas;
[INFO] [stderr] ...   |
[INFO] [stderr] 662 | |         }
[INFO] [stderr] 663 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cyclomatic_complexity)] on by default
[INFO] [stderr]     = help: you could split it up into multiple smaller functions
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]    --> src/op.rs:525:28
[INFO] [stderr]     |
[INFO] [stderr] 525 |                     reads: (0..(arity+1)).map(|n| Source::Register(Register::X(n))).collect(),
[INFO] [stderr]     |                            ^^^^^^^^^^^^^^ help: use: `(0..=arity)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::range_plus_one)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]    --> src/op.rs:683:37
[INFO] [stderr]     |
[INFO] [stderr] 683 |         Register::from_raw(raw).map(|r| Source::Register(r))
[INFO] [stderr]     |                                     ^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Source::Register`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_closure)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]    --> src/op.rs:684:60
[INFO] [stderr]     |
[INFO] [stderr] 684 |             .or_else(|| Literal::from_raw(raw, module).map(|r| Source::Literal(r)))
[INFO] [stderr]     |                                                            ^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Source::Literal`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]   --> src/raw_op.rs:70:20
[INFO] [stderr]    |
[INFO] [stderr] 70 |     let arg_base = reader.read_u8().unwrap() as u32;
[INFO] [stderr]    |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(reader.read_u8().unwrap())`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]   --> src/raw_op.rs:83:16
[INFO] [stderr]    |
[INFO] [stderr] 83 |         val |= expand_val as u32;
[INFO] [stderr]    |                ^^^^^^^^^^^^^^^^^ help: try: `u32::from(expand_val)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to want to iterate on a map's values
[INFO] [stderr]    --> src/ssa/representation.rs:123:27
[INFO] [stderr]     |
[INFO] [stderr] 123 |         for (_, block) in &mut self.blocks {
[INFO] [stderr]     |                           ^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::for_kv_map)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map
[INFO] [stderr] help: use the corresponding method
[INFO] [stderr]     |
[INFO] [stderr] 123 |         for block in self.blocks.values_mut() {
[INFO] [stderr]     |             ^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `x_reg`
[INFO] [stderr]    --> src/op.rs:687:5
[INFO] [stderr]     |
[INFO] [stderr] 687 |     fn x_reg(num: u32) -> Source {
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: type alias is never used: `GraphAccessor`
[INFO] [stderr]   --> src/graph/mod.rs:14:1
[INFO] [stderr]    |
[INFO] [stderr] 14 | pub type GraphAccessor<NodeId> = Fn(NodeId, usize) -> Option<NodeId>;
[INFO] [stderr]    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/ssa/mod.rs:132:14
[INFO] [stderr]     |
[INFO] [stderr] 132 |              ops.into_iter()
[INFO] [stderr]     |              ^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `ops`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::identity_conversion)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/ssa/mod.rs:172:17
[INFO] [stderr]     |
[INFO] [stderr] 172 |         assert!(block.ops.len() > 0, "Basic block containing only label found!!");
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!block.ops.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get_mut().unwrap()` on a Vec. Using `[]` is more clear and more concise
[INFO] [stderr]    --> src/ssa/mod.rs:224:27
[INFO] [stderr]     |
[INFO] [stderr] 224 |         let mut removed = basic_blocks.get_mut(first_idx+1).unwrap().ops.drain(0..num).collect_vec();
[INFO] [stderr]     |                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `basic_blocks[first_idx+1]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::get_unwrap)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get_mut().unwrap()` on a Vec. Using `[]` is more clear and more concise
[INFO] [stderr]    --> src/ssa/mod.rs:227:18
[INFO] [stderr]     |
[INFO] [stderr] 227 |         let bb = basic_blocks.get_mut(first_idx).unwrap();
[INFO] [stderr]     |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `basic_blocks[first_idx]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/ssa/mod.rs:240:15
[INFO] [stderr]     |
[INFO] [stderr] 240 |         while to_add.len() != 0 {
[INFO] [stderr]     |               ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!to_add.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/ssa/mod.rs:296:37
[INFO] [stderr]     |
[INFO] [stderr] 296 |                             assert!(op.op.labels.len() == 0);
[INFO] [stderr]     |                                     ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `op.op.labels.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise
[INFO] [stderr]    --> src/ssa/mod.rs:323:37
[INFO] [stderr]     |
[INFO] [stderr] 323 |         let block: &IntBasicBlock = fun.blocks.get(&node).unwrap();
[INFO] [stderr]     |                                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&fun.blocks[&node]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/ssa/mod.rs:434:21
[INFO] [stderr]     |
[INFO] [stderr] 434 | /                     if let &Source::Register(reg) = source {
[INFO] [stderr] 435 | |                         //println!("{:?}, {:?}, {:?}, {:?}, {:?}", reg, op.op.kind, op.op.reads, op.op.writes, state.assignments);
[INFO] [stderr] 436 | |                         //println!("read: {:?}", reg);
[INFO] [stderr] 437 | |                         op.reads[idx] = SSASource::Register(state.assignments[&reg]);
[INFO] [stderr] 438 | |                     }
[INFO] [stderr]     | |_____________________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 434 |                     if let Source::Register(reg) = *source {
[INFO] [stderr]     |                            ^^^^^^^^^^^^^^^^^^^^^   ^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/op.rs:332:39
[INFO] [stderr]     |
[INFO] [stderr] 332 |             OpKind::CallBif { .. } if self.labels.len() != 0 => true,
[INFO] [stderr]     |                                       ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.labels.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to want to iterate on a map's values
[INFO] [stderr]    --> src/ssa/mod.rs:503:23
[INFO] [stderr]     |
[INFO] [stderr] 503 |     for (_, block) in &function.blocks {
[INFO] [stderr]     |                       ^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map
[INFO] [stderr] help: use the corresponding method
[INFO] [stderr]     |
[INFO] [stderr] 503 |     for block in function.blocks.values() {
[INFO] [stderr]     |         ^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/ssa/mod.rs:518:16
[INFO] [stderr]     |
[INFO] [stderr] 518 |             if op.writes.len() > 0 {
[INFO] [stderr]     |                ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!op.writes.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: the function has a cyclomatic complexity of 90
[INFO] [stderr]    --> src/op.rs:378:5
[INFO] [stderr]     |
[INFO] [stderr] 378 | /     pub fn from_raw(raw_op: &RawOp, module: &Module) -> Op {
[INFO] [stderr] 379 | |         let atoms = &module.atoms;
[INFO] [stderr] 380 | |         let imports = &module.imports;
[INFO] [stderr] 381 | |         let lambdas = &module.lambdas;
[INFO] [stderr] ...   |
[INFO] [stderr] 662 | |         }
[INFO] [stderr] 663 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cyclomatic_complexity)] on by default
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/ssa/mod.rs:528:16
[INFO] [stderr]     |
[INFO] [stderr] 528 |             if op.reads.len() > 0 {
[INFO] [stderr]     |                ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!op.reads.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr]     = help: you could split it up into multiple smaller functions
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]  --> src/graph/dominance.rs:8:55
[INFO] [stderr]   |
[INFO] [stderr] 8 |                                     index_to_node_id: &GraphDfs<NodeId>,
[INFO] [stderr]   |                                                       ^^^^^^^^^^^^^^^^^ help: change this to: `&[NodeId]`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]    --> src/op.rs:525:28
[INFO] [stderr]     |
[INFO] [stderr] 525 |                     reads: (0..(arity+1)).map(|n| Source::Register(Register::X(n))).collect(),
[INFO] [stderr]     |                            ^^^^^^^^^^^^^^ help: use: `(0..=arity)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::range_plus_one)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]    --> src/op.rs:683:37
[INFO] [stderr]     |
[INFO] [stderr] 683 |         Register::from_raw(raw).map(|r| Source::Register(r))
[INFO] [stderr]     |                                     ^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Source::Register`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_closure)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]    --> src/op.rs:684:60
[INFO] [stderr]     |
[INFO] [stderr] 684 |             .or_else(|| Literal::from_raw(raw, module).map(|r| Source::Literal(r)))
[INFO] [stderr]     |                                                            ^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Source::Literal`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]   --> src/raw_op.rs:70:20
[INFO] [stderr]    |
[INFO] [stderr] 70 |     let arg_base = reader.read_u8().unwrap() as u32;
[INFO] [stderr]    |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(reader.read_u8().unwrap())`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]   --> src/raw_op.rs:83:16
[INFO] [stderr]    |
[INFO] [stderr] 83 |         val |= expand_val as u32;
[INFO] [stderr]    |                ^^^^^^^^^^^^^^^^^ help: try: `u32::from(expand_val)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to want to iterate on a map's values
[INFO] [stderr]    --> src/ssa/representation.rs:123:27
[INFO] [stderr]     |
[INFO] [stderr] 123 |         for (_, block) in &mut self.blocks {
[INFO] [stderr]     |                           ^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::for_kv_map)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map
[INFO] [stderr] help: use the corresponding method
[INFO] [stderr]     |
[INFO] [stderr] 123 |         for block in self.blocks.values_mut() {
[INFO] [stderr]     |             ^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/ssa/mod.rs:132:14
[INFO] [stderr]     |
[INFO] [stderr] 132 |              ops.into_iter()
[INFO] [stderr]     |              ^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `ops`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::identity_conversion)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/ssa/mod.rs:172:17
[INFO] [stderr]     |
[INFO] [stderr] 172 |         assert!(block.ops.len() > 0, "Basic block containing only label found!!");
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!block.ops.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get_mut().unwrap()` on a Vec. Using `[]` is more clear and more concise
[INFO] [stderr]    --> src/ssa/mod.rs:224:27
[INFO] [stderr]     |
[INFO] [stderr] 224 |         let mut removed = basic_blocks.get_mut(first_idx+1).unwrap().ops.drain(0..num).collect_vec();
[INFO] [stderr]     |                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `basic_blocks[first_idx+1]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::get_unwrap)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get_mut().unwrap()` on a Vec. Using `[]` is more clear and more concise
[INFO] [stderr]    --> src/ssa/mod.rs:227:18
[INFO] [stderr]     |
[INFO] [stderr] 227 |         let bb = basic_blocks.get_mut(first_idx).unwrap();
[INFO] [stderr]     |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `basic_blocks[first_idx]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/ssa/mod.rs:240:15
[INFO] [stderr]     |
[INFO] [stderr] 240 |         while to_add.len() != 0 {
[INFO] [stderr]     |               ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!to_add.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/ssa/mod.rs:296:37
[INFO] [stderr]     |
[INFO] [stderr] 296 |                             assert!(op.op.labels.len() == 0);
[INFO] [stderr]     |                                     ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `op.op.labels.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise
[INFO] [stderr]    --> src/ssa/mod.rs:323:37
[INFO] [stderr]     |
[INFO] [stderr] 323 |         let block: &IntBasicBlock = fun.blocks.get(&node).unwrap();
[INFO] [stderr]     |                                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&fun.blocks[&node]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/ssa/mod.rs:434:21
[INFO] [stderr]     |
[INFO] [stderr] 434 | /                     if let &Source::Register(reg) = source {
[INFO] [stderr] 435 | |                         //println!("{:?}, {:?}, {:?}, {:?}, {:?}", reg, op.op.kind, op.op.reads, op.op.writes, state.assignments);
[INFO] [stderr] 436 | |                         //println!("read: {:?}", reg);
[INFO] [stderr] 437 | |                         op.reads[idx] = SSASource::Register(state.assignments[&reg]);
[INFO] [stderr] 438 | |                     }
[INFO] [stderr]     | |_____________________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 434 |                     if let Source::Register(reg) = *source {
[INFO] [stderr]     |                            ^^^^^^^^^^^^^^^^^^^^^   ^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to want to iterate on a map's values
[INFO] [stderr]    --> src/ssa/mod.rs:503:23
[INFO] [stderr]     |
[INFO] [stderr] 503 |     for (_, block) in &function.blocks {
[INFO] [stderr]     |                       ^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map
[INFO] [stderr] help: use the corresponding method
[INFO] [stderr]     |
[INFO] [stderr] 503 |     for block in function.blocks.values() {
[INFO] [stderr]     |         ^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/ssa/mod.rs:518:16
[INFO] [stderr]     |
[INFO] [stderr] 518 |             if op.writes.len() > 0 {
[INFO] [stderr]     |                ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!op.writes.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/ssa/mod.rs:528:16
[INFO] [stderr]     |
[INFO] [stderr] 528 |             if op.reads.len() > 0 {
[INFO] [stderr]     |                ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!op.reads.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]  --> src/graph/dominance.rs:8:55
[INFO] [stderr]   |
[INFO] [stderr] 8 |                                     index_to_node_id: &GraphDfs<NodeId>,
[INFO] [stderr]   |                                                       ^^^^^^^^^^^^^^^^^ help: change this to: `&[NodeId]`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/gen_op.rs:59:21
[INFO] [stderr]    |
[INFO] [stderr] 59 |                     arity: arity,
[INFO] [stderr]    |                     ^^^^^^^^^^^^ help: replace it with: `arity`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/gen_op.rs:67:13
[INFO] [stderr]    |
[INFO] [stderr] 67 |             ops: ops,
[INFO] [stderr]    |             ^^^^^^^^ help: replace it with: `ops`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/op.rs:21:13
[INFO] [stderr]    |
[INFO] [stderr] 21 |             kind: kind,
[INFO] [stderr]    |             ^^^^^^^^^^ help: replace it with: `kind`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/op.rs:26:13
[INFO] [stderr]    |
[INFO] [stderr] 26 |             reads: reads,
[INFO] [stderr]    |             ^^^^^^^^^^^^ help: replace it with: `reads`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/op.rs:29:13
[INFO] [stderr]    |
[INFO] [stderr] 29 |             kind: kind,
[INFO] [stderr]    |             ^^^^^^^^^^ help: replace it with: `kind`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/op.rs:34:13
[INFO] [stderr]    |
[INFO] [stderr] 34 |             reads: reads,
[INFO] [stderr]    |             ^^^^^^^^^^^^ help: replace it with: `reads`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/op.rs:36:13
[INFO] [stderr]    |
[INFO] [stderr] 36 |             labels: labels,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^ help: replace it with: `labels`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/op.rs:37:13
[INFO] [stderr]    |
[INFO] [stderr] 37 |             kind: kind,
[INFO] [stderr]    |             ^^^^^^^^^^ help: replace it with: `kind`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/op.rs:42:13
[INFO] [stderr]    |
[INFO] [stderr] 42 |             reads: reads,
[INFO] [stderr]    |             ^^^^^^^^^^^^ help: replace it with: `reads`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/op.rs:43:13
[INFO] [stderr]    |
[INFO] [stderr] 43 |             writes: writes,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^ help: replace it with: `writes`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/op.rs:45:13
[INFO] [stderr]    |
[INFO] [stderr] 45 |             kind: kind,
[INFO] [stderr]    |             ^^^^^^^^^^ help: replace it with: `kind`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/op.rs:522:45
[INFO] [stderr]     |
[INFO] [stderr] 522 |                     kind: OpKind::CallFun { arity: arity },
[INFO] [stderr]     |                                             ^^^^^^^^^^^^ help: replace it with: `arity`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/op.rs:550:25
[INFO] [stderr]     |
[INFO] [stderr] 550 |                         arity: arity,
[INFO] [stderr]     |                         ^^^^^^^^^^^^ help: replace it with: `arity`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/op.rs:560:25
[INFO] [stderr]     |
[INFO] [stderr] 560 |                         arity: arity,
[INFO] [stderr]     |                         ^^^^^^^^^^^^ help: replace it with: `arity`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/op.rs:571:25
[INFO] [stderr]     |
[INFO] [stderr] 571 |                         arity: arity,
[INFO] [stderr]     |                         ^^^^^^^^^^^^ help: replace it with: `arity`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/op.rs:582:25
[INFO] [stderr]     |
[INFO] [stderr] 582 |                         arity: arity,
[INFO] [stderr]     |                         ^^^^^^^^^^^^ help: replace it with: `arity`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/op.rs:592:25
[INFO] [stderr]     |
[INFO] [stderr] 592 |                         arity: arity,
[INFO] [stderr]     |                         ^^^^^^^^^^^^ help: replace it with: `arity`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/beam_module.rs:183:13
[INFO] [stderr]     |
[INFO] [stderr] 183 |             arity: arity,
[INFO] [stderr]     |             ^^^^^^^^^^^^ help: replace it with: `arity`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/beam_module.rs:204:13
[INFO] [stderr]     |
[INFO] [stderr] 204 |             arity: arity,
[INFO] [stderr]     |             ^^^^^^^^^^^^ help: replace it with: `arity`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/beam_module.rs:205:13
[INFO] [stderr]     |
[INFO] [stderr] 205 |             label: label,
[INFO] [stderr]     |             ^^^^^^^^^^^^ help: replace it with: `label`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/ssa/mod.rs:98:17
[INFO] [stderr]    |
[INFO] [stderr] 98 |                 arity: arity,
[INFO] [stderr]    |                 ^^^^^^^^^^^^ help: replace it with: `arity`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/ssa/mod.rs:99:17
[INFO] [stderr]    |
[INFO] [stderr] 99 |                 label: label,
[INFO] [stderr]    |                 ^^^^^^^^^^^^ help: replace it with: `label`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead
[INFO] [stderr]    --> src/ssa/mod.rs:494:5
[INFO] [stderr]     |
[INFO] [stderr] 494 |     write!(w, "digraph g {{\n")?;
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::write_with_newline)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead
[INFO] [stderr]    --> src/ssa/mod.rs:495:5
[INFO] [stderr]     |
[INFO] [stderr] 495 |     write!(w, "node [labeljust=\"l\", shape=record, fontname=\"Courier New\"]\n")?;
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead
[INFO] [stderr]    --> src/ssa/mod.rs:499:5
[INFO] [stderr]     |
[INFO] [stderr] 499 | /     write!(w, "entry [ label=<entry|fun: {} free: {:?} write[{:?}]> ];\n",
[INFO] [stderr] 500 | |            fun_name, function.fun_type, function.args)?;
[INFO] [stderr]     | |______________________________________________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead
[INFO] [stderr]    --> src/ssa/mod.rs:552:9
[INFO] [stderr]     |
[INFO] [stderr] 552 |         write!(w, "> ];\n")?;
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead
[INFO] [stderr]    --> src/ssa/mod.rs:555:13
[INFO] [stderr]     |
[INFO] [stderr] 555 |             write!(w, "blk_{} -> blk_{} [ label=cont ];\n", block_name, label.name())?;
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead
[INFO] [stderr]    --> src/ssa/mod.rs:558:13
[INFO] [stderr]     |
[INFO] [stderr] 558 |             write!(w, "blk_{} -> blk_{} [ label={} ];\n", block_name, arg.name(), idx)?;
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead
[INFO] [stderr]    --> src/ssa/mod.rs:560:9
[INFO] [stderr]     |
[INFO] [stderr] 560 |         write!(w, "\n")?;
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead
[INFO] [stderr]    --> src/ssa/mod.rs:563:5
[INFO] [stderr]     |
[INFO] [stderr] 563 |     write!(w, "}}\n")?;
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/gen_op.rs:59:21
[INFO] [stderr]    |
[INFO] [stderr] 59 |                     arity: arity,
[INFO] [stderr]    |                     ^^^^^^^^^^^^ help: replace it with: `arity`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/gen_op.rs:67:13
[INFO] [stderr]    |
[INFO] [stderr] 67 |             ops: ops,
[INFO] [stderr]    |             ^^^^^^^^ help: replace it with: `ops`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/op.rs:21:13
[INFO] [stderr]    |
[INFO] [stderr] 21 |             kind: kind,
[INFO] [stderr]    |             ^^^^^^^^^^ help: replace it with: `kind`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/op.rs:26:13
[INFO] [stderr]    |
[INFO] [stderr] 26 |             reads: reads,
[INFO] [stderr]    |             ^^^^^^^^^^^^ help: replace it with: `reads`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/op.rs:29:13
[INFO] [stderr]    |
[INFO] [stderr] 29 |             kind: kind,
[INFO] [stderr]    |             ^^^^^^^^^^ help: replace it with: `kind`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/op.rs:34:13
[INFO] [stderr]    |
[INFO] [stderr] 34 |             reads: reads,
[INFO] [stderr]    |             ^^^^^^^^^^^^ help: replace it with: `reads`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/op.rs:36:13
[INFO] [stderr]    |
[INFO] [stderr] 36 |             labels: labels,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^ help: replace it with: `labels`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/op.rs:37:13
[INFO] [stderr]    |
[INFO] [stderr] 37 |             kind: kind,
[INFO] [stderr]    |             ^^^^^^^^^^ help: replace it with: `kind`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/op.rs:42:13
[INFO] [stderr]    |
[INFO] [stderr] 42 |             reads: reads,
[INFO] [stderr]    |             ^^^^^^^^^^^^ help: replace it with: `reads`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/op.rs:43:13
[INFO] [stderr]    |
[INFO] [stderr] 43 |             writes: writes,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^ help: replace it with: `writes`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/op.rs:45:13
[INFO] [stderr]    |
[INFO] [stderr] 45 |             kind: kind,
[INFO] [stderr]    |             ^^^^^^^^^^ help: replace it with: `kind`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/op.rs:522:45
[INFO] [stderr]     |
[INFO] [stderr] 522 |                     kind: OpKind::CallFun { arity: arity },
[INFO] [stderr]     |                                             ^^^^^^^^^^^^ help: replace it with: `arity`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/op.rs:550:25
[INFO] [stderr]     |
[INFO] [stderr] 550 |                         arity: arity,
[INFO] [stderr]     |                         ^^^^^^^^^^^^ help: replace it with: `arity`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/op.rs:560:25
[INFO] [stderr]     |
[INFO] [stderr] 560 |                         arity: arity,
[INFO] [stderr]     |                         ^^^^^^^^^^^^ help: replace it with: `arity`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/op.rs:571:25
[INFO] [stderr]     |
[INFO] [stderr] 571 |                         arity: arity,
[INFO] [stderr]     |                         ^^^^^^^^^^^^ help: replace it with: `arity`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/op.rs:582:25
[INFO] [stderr]     |
[INFO] [stderr] 582 |                         arity: arity,
[INFO] [stderr]     |                         ^^^^^^^^^^^^ help: replace it with: `arity`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/op.rs:592:25
[INFO] [stderr]     |
[INFO] [stderr] 592 |                         arity: arity,
[INFO] [stderr]     |                         ^^^^^^^^^^^^ help: replace it with: `arity`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/beam_module.rs:183:13
[INFO] [stderr]     |
[INFO] [stderr] 183 |             arity: arity,
[INFO] [stderr]     |             ^^^^^^^^^^^^ help: replace it with: `arity`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/beam_module.rs:204:13
[INFO] [stderr]     |
[INFO] [stderr] 204 |             arity: arity,
[INFO] [stderr]     |             ^^^^^^^^^^^^ help: replace it with: `arity`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/beam_module.rs:205:13
[INFO] [stderr]     |
[INFO] [stderr] 205 |             label: label,
[INFO] [stderr]     |             ^^^^^^^^^^^^ help: replace it with: `label`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/ssa/mod.rs:98:17
[INFO] [stderr]    |
[INFO] [stderr] 98 |                 arity: arity,
[INFO] [stderr]    |                 ^^^^^^^^^^^^ help: replace it with: `arity`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/ssa/mod.rs:99:17
[INFO] [stderr]    |
[INFO] [stderr] 99 |                 label: label,
[INFO] [stderr]    |                 ^^^^^^^^^^^^ help: replace it with: `label`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead
[INFO] [stderr]    --> src/ssa/mod.rs:494:5
[INFO] [stderr]     |
[INFO] [stderr] 494 |     write!(w, "digraph g {{\n")?;
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::write_with_newline)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead
[INFO] [stderr]    --> src/ssa/mod.rs:495:5
[INFO] [stderr]     |
[INFO] [stderr] 495 |     write!(w, "node [labeljust=\"l\", shape=record, fontname=\"Courier New\"]\n")?;
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead
[INFO] [stderr]    --> src/ssa/mod.rs:499:5
[INFO] [stderr]     |
[INFO] [stderr] 499 | /     write!(w, "entry [ label=<entry|fun: {} free: {:?} write[{:?}]> ];\n",
[INFO] [stderr] 500 | |            fun_name, function.fun_type, function.args)?;
[INFO] [stderr]     | |______________________________________________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead
[INFO] [stderr]    --> src/ssa/mod.rs:552:9
[INFO] [stderr]     |
[INFO] [stderr] 552 |         write!(w, "> ];\n")?;
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead
[INFO] [stderr]    --> src/ssa/mod.rs:555:13
[INFO] [stderr]     |
[INFO] [stderr] 555 |             write!(w, "blk_{} -> blk_{} [ label=cont ];\n", block_name, label.name())?;
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead
[INFO] [stderr]    --> src/ssa/mod.rs:558:13
[INFO] [stderr]     |
[INFO] [stderr] 558 |             write!(w, "blk_{} -> blk_{} [ label={} ];\n", block_name, arg.name(), idx)?;
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead
[INFO] [stderr]    --> src/ssa/mod.rs:560:9
[INFO] [stderr]     |
[INFO] [stderr] 560 |         write!(w, "\n")?;
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead
[INFO] [stderr]    --> src/ssa/mod.rs:563:5
[INFO] [stderr]     |
[INFO] [stderr] 563 |     write!(w, "}}\n")?;
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `::std::rc::Rc`
[INFO] [stderr]  --> src/op.rs:6:5
[INFO] [stderr]   |
[INFO] [stderr] 6 | use ::std::rc::Rc;
[INFO] [stderr]   |     ^^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/raw_op.rs:72:31
[INFO] [stderr]    |
[INFO] [stderr] 72 |     let arg_type = arg_base & 0b00000111;
[INFO] [stderr]    |                               ^^^^^^^^^^ help: consider: `0b0000_0111`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/raw_op.rs:73:35
[INFO] [stderr]    |
[INFO] [stderr] 73 |     let arg_expanded = arg_base & 0b00001000;
[INFO] [stderr]    |                                   ^^^^^^^^^^ help: consider: `0b0000_1000`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/raw_op.rs:74:39
[INFO] [stderr]    |
[INFO] [stderr] 74 |     let arg_adv_expanded = arg_base & 0b00010000;
[INFO] [stderr]    |                                       ^^^^^^^^^^ help: consider: `0b0001_0000`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `Literal`
[INFO] [stderr]  --> src/ssa/mod.rs:5:52
[INFO] [stderr]   |
[INFO] [stderr] 5 | use ::op::{ Op, LabelId, Register, OpKind, Source, Literal };
[INFO] [stderr]   |                                                    ^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `::std::hash::Hash`
[INFO] [stderr]  --> src/ssa/representation.rs:5:5
[INFO] [stderr]   |
[INFO] [stderr] 5 | use ::std::hash::Hash;
[INFO] [stderr]   |     ^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]    --> src/ssa/mod.rs:316:5
[INFO] [stderr]     |
[INFO] [stderr] 316 |     cleaned
[INFO] [stderr]     |     ^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]    --> src/ssa/mod.rs:279:19
[INFO] [stderr]     |
[INFO] [stderr] 279 |       let cleaned = functions.iter().map(|f| {
[INFO] [stderr]     |  ___________________^
[INFO] [stderr] 280 | |         let mut ssa_fun = SSAFunction {
[INFO] [stderr] 281 | |             name: f.name.clone(),
[INFO] [stderr] 282 | |             arity: f.arity,
[INFO] [stderr] ...   |
[INFO] [stderr] 313 | |         ssa_fun
[INFO] [stderr] 314 | |     }).collect();
[INFO] [stderr]     | |________________^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]    --> src/ssa/mod.rs:343:5
[INFO] [stderr]     |
[INFO] [stderr] 343 |     frontiers
[INFO] [stderr]     |     ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]    --> src/ssa/mod.rs:341:21
[INFO] [stderr]     |
[INFO] [stderr] 341 |     let frontiers = ::graph::dominance_frontiers(&i_dominators, &predecessors);
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `::std::fmt::Debug`
[INFO] [stderr]  --> src/graph/dfs.rs:2:5
[INFO] [stderr]   |
[INFO] [stderr] 2 | use ::std::fmt::Debug;
[INFO] [stderr]   |     ^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `GraphAccessor`
[INFO] [stderr]  --> src/graph/dfs.rs:5:14
[INFO] [stderr]   |
[INFO] [stderr] 5 | use super::{ GraphAccessor, GraphDfs };
[INFO] [stderr]   |              ^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `::std::rc::Rc`
[INFO] [stderr]  --> src/op.rs:6:5
[INFO] [stderr]   |
[INFO] [stderr] 6 | use ::std::rc::Rc;
[INFO] [stderr]   |     ^^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/raw_op.rs:72:31
[INFO] [stderr]    |
[INFO] [stderr] 72 |     let arg_type = arg_base & 0b00000111;
[INFO] [stderr]    |                               ^^^^^^^^^^ help: consider: `0b0000_0111`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/raw_op.rs:73:35
[INFO] [stderr]    |
[INFO] [stderr] 73 |     let arg_expanded = arg_base & 0b00001000;
[INFO] [stderr]    |                                   ^^^^^^^^^^ help: consider: `0b0000_1000`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/raw_op.rs:74:39
[INFO] [stderr]    |
[INFO] [stderr] 74 |     let arg_adv_expanded = arg_base & 0b00010000;
[INFO] [stderr]    |                                       ^^^^^^^^^^ help: consider: `0b0001_0000`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `Literal`
[INFO] [stderr]  --> src/ssa/mod.rs:5:52
[INFO] [stderr]   |
[INFO] [stderr] 5 | use ::op::{ Op, LabelId, Register, OpKind, Source, Literal };
[INFO] [stderr]   |                                                    ^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `::std::hash::Hash`
[INFO] [stderr]  --> src/ssa/representation.rs:5:5
[INFO] [stderr]   |
[INFO] [stderr] 5 | use ::std::hash::Hash;
[INFO] [stderr]   |     ^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]    --> src/ssa/mod.rs:316:5
[INFO] [stderr]     |
[INFO] [stderr] 316 |     cleaned
[INFO] [stderr]     |     ^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]    --> src/ssa/mod.rs:279:19
[INFO] [stderr]     |
[INFO] [stderr] 279 |       let cleaned = functions.iter().map(|f| {
[INFO] [stderr]     |  ___________________^
[INFO] [stderr] 280 | |         let mut ssa_fun = SSAFunction {
[INFO] [stderr] 281 | |             name: f.name.clone(),
[INFO] [stderr] 282 | |             arity: f.arity,
[INFO] [stderr] ...   |
[INFO] [stderr] 313 | |         ssa_fun
[INFO] [stderr] 314 | |     }).collect();
[INFO] [stderr]     | |________________^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]    --> src/ssa/mod.rs:343:5
[INFO] [stderr]     |
[INFO] [stderr] 343 |     frontiers
[INFO] [stderr]     |     ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]    --> src/ssa/mod.rs:341:21
[INFO] [stderr]     |
[INFO] [stderr] 341 |     let frontiers = ::graph::dominance_frontiers(&i_dominators, &predecessors);
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `::std::fmt::Debug`
[INFO] [stderr]  --> src/graph/dfs.rs:2:5
[INFO] [stderr]   |
[INFO] [stderr] 2 | use ::std::fmt::Debug;
[INFO] [stderr]   |     ^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `GraphAccessor`
[INFO] [stderr]  --> src/graph/dfs.rs:5:14
[INFO] [stderr]   |
[INFO] [stderr] 5 | use super::{ GraphAccessor, GraphDfs };
[INFO] [stderr]   |              ^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `atom_num`
[INFO] [stderr]    --> src/beam_module.rs:218:9
[INFO] [stderr]     |
[INFO] [stderr] 218 |     for atom_num in 0..len {
[INFO] [stderr]     |         ^^^^^^^^ help: consider using `_atom_num` instead
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_variables)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `atom_num`
[INFO] [stderr]    --> src/beam_module.rs:218:9
[INFO] [stderr]     |
[INFO] [stderr] 218 |     for atom_num in 0..len {
[INFO] [stderr]     |         ^^^^^^^^ help: consider using `_atom_num` instead
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_variables)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `with_reads_labels`
[INFO] [stderr]   --> src/op.rs:32:5
[INFO] [stderr]    |
[INFO] [stderr] 32 |     pub fn with_reads_labels(kind: OpKind, reads: Vec<Source>, labels: Vec<LabelId>) -> Self {
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: variant is never constructed: `CaseEnd`
[INFO] [stderr]    --> src/op.rs:156:5
[INFO] [stderr]     |
[INFO] [stderr] 156 |     CaseEnd,
[INFO] [stderr]     |     ^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `x_reg`
[INFO] [stderr]    --> src/op.rs:687:5
[INFO] [stderr]     |
[INFO] [stderr] 687 |     fn x_reg(num: u32) -> Source {
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `get_register`
[INFO] [stderr]    --> src/op.rs:691:5
[INFO] [stderr]     |
[INFO] [stderr] 691 |     pub fn get_register(&self) -> Register {
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `get_register`
[INFO] [stderr]   --> src/ssa/representation.rs:63:5
[INFO] [stderr]    |
[INFO] [stderr] 63 |     pub fn get_register(&self) -> SSARegister {
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: type alias is never used: `GraphAccessor`
[INFO] [stderr]   --> src/graph/mod.rs:14:1
[INFO] [stderr]    |
[INFO] [stderr] 14 | pub type GraphAccessor<NodeId> = Fn(NodeId, usize) -> Option<NodeId>;
[INFO] [stderr]    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `with_reads_labels`
[INFO] [stderr]   --> src/op.rs:32:5
[INFO] [stderr]    |
[INFO] [stderr] 32 |     pub fn with_reads_labels(kind: OpKind, reads: Vec<Source>, labels: Vec<LabelId>) -> Self {
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: variant is never constructed: `CaseEnd`
[INFO] [stderr]    --> src/op.rs:156:5
[INFO] [stderr]     |
[INFO] [stderr] 156 |     CaseEnd,
[INFO] [stderr]     |     ^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `x_reg`
[INFO] [stderr]    --> src/op.rs:687:5
[INFO] [stderr]     |
[INFO] [stderr] 687 |     fn x_reg(num: u32) -> Source {
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `get_register`
[INFO] [stderr]    --> src/op.rs:691:5
[INFO] [stderr]     |
[INFO] [stderr] 691 |     pub fn get_register(&self) -> Register {
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `get_register`
[INFO] [stderr]   --> src/ssa/representation.rs:63:5
[INFO] [stderr]    |
[INFO] [stderr] 63 |     pub fn get_register(&self) -> SSARegister {
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: type alias is never used: `GraphAccessor`
[INFO] [stderr]   --> src/graph/mod.rs:14:1
[INFO] [stderr]    |
[INFO] [stderr] 14 | pub type GraphAccessor<NodeId> = Fn(NodeId, usize) -> Option<NodeId>;
[INFO] [stderr]    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/op.rs:332:39
[INFO] [stderr]     |
[INFO] [stderr] 332 |             OpKind::CallBif { .. } if self.labels.len() != 0 => true,
[INFO] [stderr]     |                                       ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.labels.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: the function has a cyclomatic complexity of 90
[INFO] [stderr]    --> src/op.rs:378:5
[INFO] [stderr]     |
[INFO] [stderr] 378 | /     pub fn from_raw(raw_op: &RawOp, module: &Module) -> Op {
[INFO] [stderr] 379 | |         let atoms = &module.atoms;
[INFO] [stderr] 380 | |         let imports = &module.imports;
[INFO] [stderr] 381 | |         let lambdas = &module.lambdas;
[INFO] [stderr] ...   |
[INFO] [stderr] 662 | |         }
[INFO] [stderr] 663 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cyclomatic_complexity)] on by default
[INFO] [stderr]     = help: you could split it up into multiple smaller functions
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/op.rs:332:39
[INFO] [stderr]     |
[INFO] [stderr] 332 |             OpKind::CallBif { .. } if self.labels.len() != 0 => true,
[INFO] [stderr]     |                                       ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.labels.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: the function has a cyclomatic complexity of 90
[INFO] [stderr]    --> src/op.rs:378:5
[INFO] [stderr]     |
[INFO] [stderr] 378 | /     pub fn from_raw(raw_op: &RawOp, module: &Module) -> Op {
[INFO] [stderr] 379 | |         let atoms = &module.atoms;
[INFO] [stderr] 380 | |         let imports = &module.imports;
[INFO] [stderr] 381 | |         let lambdas = &module.lambdas;
[INFO] [stderr] ...   |
[INFO] [stderr] 662 | |         }
[INFO] [stderr] 663 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cyclomatic_complexity)] on by default
[INFO] [stderr]     = help: you could split it up into multiple smaller functions
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]    --> src/op.rs:525:28
[INFO] [stderr]     |
[INFO] [stderr] 525 |                     reads: (0..(arity+1)).map(|n| Source::Register(Register::X(n))).collect(),
[INFO] [stderr]     |                            ^^^^^^^^^^^^^^ help: use: `(0..=arity)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::range_plus_one)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]    --> src/op.rs:525:28
[INFO] [stderr]     |
[INFO] [stderr] 525 |                     reads: (0..(arity+1)).map(|n| Source::Register(Register::X(n))).collect(),
[INFO] [stderr]     |                            ^^^^^^^^^^^^^^ help: use: `(0..=arity)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::range_plus_one)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]    --> src/op.rs:683:37
[INFO] [stderr]     |
[INFO] [stderr] 683 |         Register::from_raw(raw).map(|r| Source::Register(r))
[INFO] [stderr]     |                                     ^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Source::Register`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_closure)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]    --> src/op.rs:684:60
[INFO] [stderr]     |
[INFO] [stderr] 684 |             .or_else(|| Literal::from_raw(raw, module).map(|r| Source::Literal(r)))
[INFO] [stderr]     |                                                            ^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Source::Literal`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]    --> src/op.rs:683:37
[INFO] [stderr]     |
[INFO] [stderr] 683 |         Register::from_raw(raw).map(|r| Source::Register(r))
[INFO] [stderr]     |                                     ^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Source::Register`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_closure)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]    --> src/op.rs:684:60
[INFO] [stderr]     |
[INFO] [stderr] 684 |             .or_else(|| Literal::from_raw(raw, module).map(|r| Source::Literal(r)))
[INFO] [stderr]     |                                                            ^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Source::Literal`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]   --> src/raw_op.rs:70:20
[INFO] [stderr]    |
[INFO] [stderr] 70 |     let arg_base = reader.read_u8().unwrap() as u32;
[INFO] [stderr]    |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(reader.read_u8().unwrap())`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]   --> src/raw_op.rs:83:16
[INFO] [stderr]    |
[INFO] [stderr] 83 |         val |= expand_val as u32;
[INFO] [stderr]    |                ^^^^^^^^^^^^^^^^^ help: try: `u32::from(expand_val)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]   --> src/raw_op.rs:70:20
[INFO] [stderr]    |
[INFO] [stderr] 70 |     let arg_base = reader.read_u8().unwrap() as u32;
[INFO] [stderr]    |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(reader.read_u8().unwrap())`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]   --> src/raw_op.rs:83:16
[INFO] [stderr]    |
[INFO] [stderr] 83 |         val |= expand_val as u32;
[INFO] [stderr]    |                ^^^^^^^^^^^^^^^^^ help: try: `u32::from(expand_val)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to want to iterate on a map's values
[INFO] [stderr]    --> src/ssa/representation.rs:123:27
[INFO] [stderr]     |
[INFO] [stderr] 123 |         for (_, block) in &mut self.blocks {
[INFO] [stderr]     |                           ^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::for_kv_map)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map
[INFO] [stderr] help: use the corresponding method
[INFO] [stderr]     |
[INFO] [stderr] 123 |         for block in self.blocks.values_mut() {
[INFO] [stderr]     |             ^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to want to iterate on a map's values
[INFO] [stderr]    --> src/ssa/representation.rs:123:27
[INFO] [stderr]     |
[INFO] [stderr] 123 |         for (_, block) in &mut self.blocks {
[INFO] [stderr]     |                           ^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::for_kv_map)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map
[INFO] [stderr] help: use the corresponding method
[INFO] [stderr]     |
[INFO] [stderr] 123 |         for block in self.blocks.values_mut() {
[INFO] [stderr]     |             ^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/ssa/mod.rs:132:14
[INFO] [stderr]     |
[INFO] [stderr] 132 |              ops.into_iter()
[INFO] [stderr]     |              ^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `ops`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::identity_conversion)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/ssa/mod.rs:132:14
[INFO] [stderr]     |
[INFO] [stderr] 132 |              ops.into_iter()
[INFO] [stderr]     |              ^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `ops`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::identity_conversion)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/ssa/mod.rs:172:17
[INFO] [stderr]     |
[INFO] [stderr] 172 |         assert!(block.ops.len() > 0, "Basic block containing only label found!!");
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!block.ops.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/ssa/mod.rs:172:17
[INFO] [stderr]     |
[INFO] [stderr] 172 |         assert!(block.ops.len() > 0, "Basic block containing only label found!!");
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!block.ops.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get_mut().unwrap()` on a Vec. Using `[]` is more clear and more concise
[INFO] [stderr]    --> src/ssa/mod.rs:224:27
[INFO] [stderr]     |
[INFO] [stderr] 224 |         let mut removed = basic_blocks.get_mut(first_idx+1).unwrap().ops.drain(0..num).collect_vec();
[INFO] [stderr]     |                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `basic_blocks[first_idx+1]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::get_unwrap)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get_mut().unwrap()` on a Vec. Using `[]` is more clear and more concise
[INFO] [stderr]    --> src/ssa/mod.rs:227:18
[INFO] [stderr]     |
[INFO] [stderr] 227 |         let bb = basic_blocks.get_mut(first_idx).unwrap();
[INFO] [stderr]     |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `basic_blocks[first_idx]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/ssa/mod.rs:240:15
[INFO] [stderr]     |
[INFO] [stderr] 240 |         while to_add.len() != 0 {
[INFO] [stderr]     |               ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!to_add.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get_mut().unwrap()` on a Vec. Using `[]` is more clear and more concise
[INFO] [stderr]    --> src/ssa/mod.rs:224:27
[INFO] [stderr]     |
[INFO] [stderr] 224 |         let mut removed = basic_blocks.get_mut(first_idx+1).unwrap().ops.drain(0..num).collect_vec();
[INFO] [stderr]     |                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `basic_blocks[first_idx+1]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::get_unwrap)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get_mut().unwrap()` on a Vec. Using `[]` is more clear and more concise
[INFO] [stderr]    --> src/ssa/mod.rs:227:18
[INFO] [stderr]     |
[INFO] [stderr] 227 |         let bb = basic_blocks.get_mut(first_idx).unwrap();
[INFO] [stderr]     |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `basic_blocks[first_idx]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/ssa/mod.rs:240:15
[INFO] [stderr]     |
[INFO] [stderr] 240 |         while to_add.len() != 0 {
[INFO] [stderr]     |               ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!to_add.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/ssa/mod.rs:296:37
[INFO] [stderr]     |
[INFO] [stderr] 296 |                             assert!(op.op.labels.len() == 0);
[INFO] [stderr]     |                                     ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `op.op.labels.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise
[INFO] [stderr]    --> src/ssa/mod.rs:323:37
[INFO] [stderr]     |
[INFO] [stderr] 323 |         let block: &IntBasicBlock = fun.blocks.get(&node).unwrap();
[INFO] [stderr]     |                                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&fun.blocks[&node]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/ssa/mod.rs:296:37
[INFO] [stderr]     |
[INFO] [stderr] 296 |                             assert!(op.op.labels.len() == 0);
[INFO] [stderr]     |                                     ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `op.op.labels.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise
[INFO] [stderr]    --> src/ssa/mod.rs:323:37
[INFO] [stderr]     |
[INFO] [stderr] 323 |         let block: &IntBasicBlock = fun.blocks.get(&node).unwrap();
[INFO] [stderr]     |                                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&fun.blocks[&node]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/ssa/mod.rs:434:21
[INFO] [stderr]     |
[INFO] [stderr] 434 | /                     if let &Source::Register(reg) = source {
[INFO] [stderr] 435 | |                         //println!("{:?}, {:?}, {:?}, {:?}, {:?}", reg, op.op.kind, op.op.reads, op.op.writes, state.assignments);
[INFO] [stderr] 436 | |                         //println!("read: {:?}", reg);
[INFO] [stderr] 437 | |                         op.reads[idx] = SSASource::Register(state.assignments[&reg]);
[INFO] [stderr] 438 | |                     }
[INFO] [stderr]     | |_____________________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 434 |                     if let Source::Register(reg) = *source {
[INFO] [stderr]     |                            ^^^^^^^^^^^^^^^^^^^^^   ^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/ssa/mod.rs:434:21
[INFO] [stderr]     |
[INFO] [stderr] 434 | /                     if let &Source::Register(reg) = source {
[INFO] [stderr] 435 | |                         //println!("{:?}, {:?}, {:?}, {:?}, {:?}", reg, op.op.kind, op.op.reads, op.op.writes, state.assignments);
[INFO] [stderr] 436 | |                         //println!("read: {:?}", reg);
[INFO] [stderr] 437 | |                         op.reads[idx] = SSASource::Register(state.assignments[&reg]);
[INFO] [stderr] 438 | |                     }
[INFO] [stderr]     | |_____________________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 434 |                     if let Source::Register(reg) = *source {
[INFO] [stderr]     |                            ^^^^^^^^^^^^^^^^^^^^^   ^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to want to iterate on a map's values
[INFO] [stderr]    --> src/ssa/mod.rs:503:23
[INFO] [stderr]     |
[INFO] [stderr] 503 |     for (_, block) in &function.blocks {
[INFO] [stderr]     |                       ^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map
[INFO] [stderr] help: use the corresponding method
[INFO] [stderr]     |
[INFO] [stderr] 503 |     for block in function.blocks.values() {
[INFO] [stderr]     |         ^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/ssa/mod.rs:518:16
[INFO] [stderr]     |
[INFO] [stderr] 518 |             if op.writes.len() > 0 {
[INFO] [stderr]     |                ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!op.writes.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/ssa/mod.rs:528:16
[INFO] [stderr]     |
[INFO] [stderr] 528 |             if op.reads.len() > 0 {
[INFO] [stderr]     |                ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!op.reads.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to want to iterate on a map's values
[INFO] [stderr]    --> src/ssa/mod.rs:503:23
[INFO] [stderr]     |
[INFO] [stderr] 503 |     for (_, block) in &function.blocks {
[INFO] [stderr]     |                       ^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map
[INFO] [stderr] help: use the corresponding method
[INFO] [stderr]     |
[INFO] [stderr] 503 |     for block in function.blocks.values() {
[INFO] [stderr]     |         ^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/ssa/mod.rs:518:16
[INFO] [stderr]     |
[INFO] [stderr] 518 |             if op.writes.len() > 0 {
[INFO] [stderr]     |                ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!op.writes.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]  --> src/graph/dominance.rs:8:55
[INFO] [stderr]   |
[INFO] [stderr] 8 |                                     index_to_node_id: &GraphDfs<NodeId>,
[INFO] [stderr]   |                                                       ^^^^^^^^^^^^^^^^^ help: change this to: `&[NodeId]`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/ssa/mod.rs:528:16
[INFO] [stderr]     |
[INFO] [stderr] 528 |             if op.reads.len() > 0 {
[INFO] [stderr]     |                ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!op.reads.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]  --> src/graph/dominance.rs:8:55
[INFO] [stderr]   |
[INFO] [stderr] 8 |                                     index_to_node_id: &GraphDfs<NodeId>,
[INFO] [stderr]   |                                                       ^^^^^^^^^^^^^^^^^ help: change this to: `&[NodeId]`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 13.70s
[INFO] running `"docker" "inspect" "7dd6d57fcd8f0ba24f99d2066ee5b5ca3a36e77922f6677729e051a1311e262b"`
[INFO] running `"docker" "rm" "-f" "7dd6d57fcd8f0ba24f99d2066ee5b5ca3a36e77922f6677729e051a1311e262b"`
[INFO] [stdout] 7dd6d57fcd8f0ba24f99d2066ee5b5ca3a36e77922f6677729e051a1311e262b