[INFO] updating cached repository haltode/gitrs
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/haltode/gitrs
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/haltode/gitrs" "work/ex/clippy-test-run/sources/stable/gh/haltode/gitrs"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/haltode/gitrs'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/haltode/gitrs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/haltode/gitrs"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/haltode/gitrs'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 4871b0b59a1a4ac0787d7c771b39f6b794dcb040
[INFO] sha for GitHub repo haltode/gitrs: 4871b0b59a1a4ac0787d7c771b39f6b794dcb040
[INFO] validating manifest of haltode/gitrs on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of haltode/gitrs on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing haltode/gitrs
[INFO] finished frobbing haltode/gitrs
[INFO] frobbed toml for haltode/gitrs written to work/ex/clippy-test-run/sources/stable/gh/haltode/gitrs/Cargo.toml
[INFO] started frobbing haltode/gitrs
[INFO] finished frobbing haltode/gitrs
[INFO] frobbed toml for haltode/gitrs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/haltode/gitrs/Cargo.toml
[INFO] crate haltode/gitrs has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting haltode/gitrs against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/haltode/gitrs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 814f40e3a90664a26e91356bad7eb069ccc70c21af6609199ae4d7ac5b0bbe1e
[INFO] running `"docker" "start" "-a" "814f40e3a90664a26e91356bad7eb069ccc70c21af6609199ae4d7ac5b0bbe1e"`
[INFO] [stderr]     Checking gitrs v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/builtin/config.rs:54:13
[INFO] [stderr]    |
[INFO] [stderr] 54 |             name: name,
[INFO] [stderr]    |             ^^^^^^^^^^ help: replace it with: `name`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/builtin/config.rs:55:13
[INFO] [stderr]    |
[INFO] [stderr] 55 |             email: email,
[INFO] [stderr]    |             ^^^^^^^^^^^^ help: replace it with: `email`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/builtin/config.rs:56:13
[INFO] [stderr]    |
[INFO] [stderr] 56 |             remotes: remotes,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^ help: replace it with: `remotes`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/builtin/read_tree.rs:78:13
[INFO] [stderr]    |
[INFO] [stderr] 78 |             mode: mode,
[INFO] [stderr]    |             ^^^^^^^^^^ help: replace it with: `mode`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/index.rs:63:13
[INFO] [stderr]    |
[INFO] [stderr] 63 |             hash: hash,
[INFO] [stderr]    |             ^^^^^^^^^^ help: replace it with: `hash`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/index.rs:127:13
[INFO] [stderr]     |
[INFO] [stderr] 127 |             hash: hash,
[INFO] [stderr]     |             ^^^^^^^^^^ help: replace it with: `hash`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/index.rs:128:13
[INFO] [stderr]     |
[INFO] [stderr] 128 |             flags: flags,
[INFO] [stderr]     |             ^^^^^^^^^^^^ help: replace it with: `flags`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/index.rs:129:13
[INFO] [stderr]     |
[INFO] [stderr] 129 |             path: path,
[INFO] [stderr]     |             ^^^^^^^^^^ help: replace it with: `path`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: 5th binding whose name is just one char
[INFO] [stderr]   --> src/sha1.rs:48:17
[INFO] [stderr]    |
[INFO] [stderr] 48 |         let mut d = states[3];
[INFO] [stderr]    |                 ^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::many_single_char_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 6th binding whose name is just one char
[INFO] [stderr]   --> src/sha1.rs:49:17
[INFO] [stderr]    |
[INFO] [stderr] 49 |         let mut e = states[4];
[INFO] [stderr]    |                 ^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 7th binding whose name is just one char
[INFO] [stderr]   --> src/sha1.rs:52:18
[INFO] [stderr]    |
[INFO] [stderr] 52 |             let (k, f) = match i {
[INFO] [stderr]    |                  ^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 8th binding whose name is just one char
[INFO] [stderr]   --> src/sha1.rs:52:21
[INFO] [stderr]    |
[INFO] [stderr] 52 |             let (k, f) = match i {
[INFO] [stderr]    |                     ^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/work_dir.rs:87:21
[INFO] [stderr]    |
[INFO] [stderr] 87 |                     state: state,
[INFO] [stderr]    |                     ^^^^^^^^^^^^ help: replace it with: `state`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/zlib.rs:35:13
[INFO] [stderr]    |
[INFO] [stderr] 35 |             input: input,
[INFO] [stderr]    |             ^^^^^^^^^^^^ help: replace it with: `input`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/zlib.rs:215:13
[INFO] [stderr]     |
[INFO] [stderr] 215 |             input: input,
[INFO] [stderr]     |             ^^^^^^^^^^^^ help: replace it with: `input`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/builtin/config.rs:54:13
[INFO] [stderr]    |
[INFO] [stderr] 54 |             name: name,
[INFO] [stderr]    |             ^^^^^^^^^^ help: replace it with: `name`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/builtin/config.rs:55:13
[INFO] [stderr]    |
[INFO] [stderr] 55 |             email: email,
[INFO] [stderr]    |             ^^^^^^^^^^^^ help: replace it with: `email`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/builtin/config.rs:56:13
[INFO] [stderr]    |
[INFO] [stderr] 56 |             remotes: remotes,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^ help: replace it with: `remotes`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/builtin/read_tree.rs:78:13
[INFO] [stderr]    |
[INFO] [stderr] 78 |             mode: mode,
[INFO] [stderr]    |             ^^^^^^^^^^ help: replace it with: `mode`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/index.rs:63:13
[INFO] [stderr]    |
[INFO] [stderr] 63 |             hash: hash,
[INFO] [stderr]    |             ^^^^^^^^^^ help: replace it with: `hash`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/index.rs:127:13
[INFO] [stderr]     |
[INFO] [stderr] 127 |             hash: hash,
[INFO] [stderr]     |             ^^^^^^^^^^ help: replace it with: `hash`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/index.rs:128:13
[INFO] [stderr]     |
[INFO] [stderr] 128 |             flags: flags,
[INFO] [stderr]     |             ^^^^^^^^^^^^ help: replace it with: `flags`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/index.rs:129:13
[INFO] [stderr]     |
[INFO] [stderr] 129 |             path: path,
[INFO] [stderr]     |             ^^^^^^^^^^ help: replace it with: `path`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: 5th binding whose name is just one char
[INFO] [stderr]   --> src/sha1.rs:48:17
[INFO] [stderr]    |
[INFO] [stderr] 48 |         let mut d = states[3];
[INFO] [stderr]    |                 ^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::many_single_char_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 6th binding whose name is just one char
[INFO] [stderr]   --> src/sha1.rs:49:17
[INFO] [stderr]    |
[INFO] [stderr] 49 |         let mut e = states[4];
[INFO] [stderr]    |                 ^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 7th binding whose name is just one char
[INFO] [stderr]   --> src/sha1.rs:52:18
[INFO] [stderr]    |
[INFO] [stderr] 52 |             let (k, f) = match i {
[INFO] [stderr]    |                  ^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 8th binding whose name is just one char
[INFO] [stderr]   --> src/sha1.rs:52:21
[INFO] [stderr]    |
[INFO] [stderr] 52 |             let (k, f) = match i {
[INFO] [stderr]    |                     ^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/work_dir.rs:87:21
[INFO] [stderr]    |
[INFO] [stderr] 87 |                     state: state,
[INFO] [stderr]    |                     ^^^^^^^^^^^^ help: replace it with: `state`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/zlib.rs:35:13
[INFO] [stderr]    |
[INFO] [stderr] 35 |             input: input,
[INFO] [stderr]    |             ^^^^^^^^^^^^ help: replace it with: `input`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/zlib.rs:215:13
[INFO] [stderr]     |
[INFO] [stderr] 215 |             input: input,
[INFO] [stderr]     |             ^^^^^^^^^^^^ help: replace it with: `input`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/bits.rs:50:9
[INFO] [stderr]    |
[INFO] [stderr] 50 |         return res;
[INFO] [stderr]    |         ^^^^^^^^^^^ help: remove `return` as shown: `res`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/builtin/config.rs:185:13
[INFO] [stderr]     |
[INFO] [stderr] 185 |             return (section.to_string(), subsection.to_string());
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(section.to_string(), subsection.to_string())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/builtin/config.rs:200:13
[INFO] [stderr]     |
[INFO] [stderr] 200 |             return (section.to_string(), subsection.to_string());
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(section.to_string(), subsection.to_string())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/builtin/diff.rs:86:5
[INFO] [stderr]    |
[INFO] [stderr] 86 |     return res;
[INFO] [stderr]    |     ^^^^^^^^^^^ help: remove `return` as shown: `res`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/builtin/diff.rs:102:5
[INFO] [stderr]     |
[INFO] [stderr] 102 |     return lcs;
[INFO] [stderr]     |     ^^^^^^^^^^^ help: remove `return` as shown: `lcs`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/cli.rs:13:5
[INFO] [stderr]    |
[INFO] [stderr] 13 |     return true;
[INFO] [stderr]    |     ^^^^^^^^^^^^ help: remove `return` as shown: `true`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/sha1.rs:23:9
[INFO] [stderr]    |
[INFO] [stderr] 23 |         0x67452301u32,
[INFO] [stderr]    |         ^^^^^^^^^^^^^ help: consider: `0x6745_2301u32`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/sha1.rs:24:9
[INFO] [stderr]    |
[INFO] [stderr] 24 |         0xefcdab89u32,
[INFO] [stderr]    |         ^^^^^^^^^^^^^ help: consider: `0xefcd_ab89u32`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/sha1.rs:25:9
[INFO] [stderr]    |
[INFO] [stderr] 25 |         0x98badcfeu32,
[INFO] [stderr]    |         ^^^^^^^^^^^^^ help: consider: `0x98ba_dcfeu32`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/sha1.rs:26:9
[INFO] [stderr]    |
[INFO] [stderr] 26 |         0x10325476u32,
[INFO] [stderr]    |         ^^^^^^^^^^^^^ help: consider: `0x1032_5476u32`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/sha1.rs:27:9
[INFO] [stderr]    |
[INFO] [stderr] 27 |         0xc3d2e1f0u32,
[INFO] [stderr]    |         ^^^^^^^^^^^^^ help: consider: `0xc3d2_e1f0u32`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/sha1.rs:53:28
[INFO] [stderr]    |
[INFO] [stderr] 53 |                 0...19 => (0x5a827999, (b & c) | (!b & d)),
[INFO] [stderr]    |                            ^^^^^^^^^^ help: consider: `0x5a82_7999`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/sha1.rs:54:29
[INFO] [stderr]    |
[INFO] [stderr] 54 |                 20...39 => (0x6ed9eba1, b ^ c ^ d),
[INFO] [stderr]    |                             ^^^^^^^^^^ help: consider: `0x6ed9_eba1`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/sha1.rs:55:29
[INFO] [stderr]    |
[INFO] [stderr] 55 |                 40...59 => (0x8f1bbcdc, (b & c) | (b & d) | (c & d)),
[INFO] [stderr]    |                             ^^^^^^^^^^ help: consider: `0x8f1b_bcdc`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/sha1.rs:56:29
[INFO] [stderr]    |
[INFO] [stderr] 56 |                 60...79 => (0xca62c1d6, b ^ c ^ d),
[INFO] [stderr]    |                             ^^^^^^^^^^ help: consider: `0xca62_c1d6`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/bits.rs:50:9
[INFO] [stderr]    |
[INFO] [stderr] 50 |         return res;
[INFO] [stderr]    |         ^^^^^^^^^^^ help: remove `return` as shown: `res`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/builtin/config.rs:185:13
[INFO] [stderr]     |
[INFO] [stderr] 185 |             return (section.to_string(), subsection.to_string());
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(section.to_string(), subsection.to_string())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/builtin/config.rs:200:13
[INFO] [stderr]     |
[INFO] [stderr] 200 |             return (section.to_string(), subsection.to_string());
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(section.to_string(), subsection.to_string())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/builtin/diff.rs:86:5
[INFO] [stderr]    |
[INFO] [stderr] 86 |     return res;
[INFO] [stderr]    |     ^^^^^^^^^^^ help: remove `return` as shown: `res`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/builtin/diff.rs:102:5
[INFO] [stderr]     |
[INFO] [stderr] 102 |     return lcs;
[INFO] [stderr]     |     ^^^^^^^^^^^ help: remove `return` as shown: `lcs`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/cli.rs:13:5
[INFO] [stderr]    |
[INFO] [stderr] 13 |     return true;
[INFO] [stderr]    |     ^^^^^^^^^^^^ help: remove `return` as shown: `true`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/sha1.rs:23:9
[INFO] [stderr]    |
[INFO] [stderr] 23 |         0x67452301u32,
[INFO] [stderr]    |         ^^^^^^^^^^^^^ help: consider: `0x6745_2301u32`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/sha1.rs:24:9
[INFO] [stderr]    |
[INFO] [stderr] 24 |         0xefcdab89u32,
[INFO] [stderr]    |         ^^^^^^^^^^^^^ help: consider: `0xefcd_ab89u32`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/sha1.rs:25:9
[INFO] [stderr]    |
[INFO] [stderr] 25 |         0x98badcfeu32,
[INFO] [stderr]    |         ^^^^^^^^^^^^^ help: consider: `0x98ba_dcfeu32`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/sha1.rs:26:9
[INFO] [stderr]    |
[INFO] [stderr] 26 |         0x10325476u32,
[INFO] [stderr]    |         ^^^^^^^^^^^^^ help: consider: `0x1032_5476u32`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/sha1.rs:27:9
[INFO] [stderr]    |
[INFO] [stderr] 27 |         0xc3d2e1f0u32,
[INFO] [stderr]    |         ^^^^^^^^^^^^^ help: consider: `0xc3d2_e1f0u32`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/sha1.rs:53:28
[INFO] [stderr]    |
[INFO] [stderr] 53 |                 0...19 => (0x5a827999, (b & c) | (!b & d)),
[INFO] [stderr]    |                            ^^^^^^^^^^ help: consider: `0x5a82_7999`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/sha1.rs:54:29
[INFO] [stderr]    |
[INFO] [stderr] 54 |                 20...39 => (0x6ed9eba1, b ^ c ^ d),
[INFO] [stderr]    |                             ^^^^^^^^^^ help: consider: `0x6ed9_eba1`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/sha1.rs:55:29
[INFO] [stderr]    |
[INFO] [stderr] 55 |                 40...59 => (0x8f1bbcdc, (b & c) | (b & d) | (c & d)),
[INFO] [stderr]    |                             ^^^^^^^^^^ help: consider: `0x8f1b_bcdc`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/sha1.rs:56:29
[INFO] [stderr]    |
[INFO] [stderr] 56 |                 60...79 => (0xca62c1d6, b ^ c ^ d),
[INFO] [stderr]    |                             ^^^^^^^^^^ help: consider: `0xca62_c1d6`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]   --> src/bits.rs:29:9
[INFO] [stderr]    |
[INFO] [stderr] 29 |         (x[0] as u32) << 24 | (x[1] as u32) << 16 | (x[2] as u32) << 8 | (x[3] as u32)
[INFO] [stderr]    |         ^^^^^^^^^^^^^ help: try: `u32::from(x[0])`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]   --> src/bits.rs:29:31
[INFO] [stderr]    |
[INFO] [stderr] 29 |         (x[0] as u32) << 24 | (x[1] as u32) << 16 | (x[2] as u32) << 8 | (x[3] as u32)
[INFO] [stderr]    |                               ^^^^^^^^^^^^^ help: try: `u32::from(x[1])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]   --> src/bits.rs:29:53
[INFO] [stderr]    |
[INFO] [stderr] 29 |         (x[0] as u32) << 24 | (x[1] as u32) << 16 | (x[2] as u32) << 8 | (x[3] as u32)
[INFO] [stderr]    |                                                     ^^^^^^^^^^^^^ help: try: `u32::from(x[2])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]   --> src/bits.rs:29:74
[INFO] [stderr]    |
[INFO] [stderr] 29 |         (x[0] as u32) << 24 | (x[1] as u32) << 16 | (x[2] as u32) << 8 | (x[3] as u32)
[INFO] [stderr]    |                                                                          ^^^^^^^^^^^^^ help: try: `u32::from(x[3])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]   --> src/bits.rs:37:9
[INFO] [stderr]    |
[INFO] [stderr] 37 |         (x[0] as u16) << 8 | (x[1] as u16)
[INFO] [stderr]    |         ^^^^^^^^^^^^^ help: try: `u16::from(x[0])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]   --> src/bits.rs:37:30
[INFO] [stderr]    |
[INFO] [stderr] 37 |         (x[0] as u16) << 8 | (x[1] as u16)
[INFO] [stderr]    |                              ^^^^^^^^^^^^^ help: try: `u16::from(x[1])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]   --> src/builtin/checkout.rs:43:18
[INFO] [stderr]    |
[INFO] [stderr] 43 |       let commit = match will_detach_head {
[INFO] [stderr]    |  __________________^
[INFO] [stderr] 44 | |         true => ref_name.to_string(),
[INFO] [stderr] 45 | |         false => refs::get_ref_hash(&ref_name)?,
[INFO] [stderr] 46 | |     };
[INFO] [stderr]    | |_____^ help: consider using an if/else expression: `if will_detach_head { ref_name.to_string() } else { refs::get_ref_hash(&ref_name)? }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_bool)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]    --> src/builtin/commit.rs:106:20
[INFO] [stderr]     |
[INFO] [stderr] 106 |       let ref_path = match refs::is_detached_head() {
[INFO] [stderr]     |  ____________________^
[INFO] [stderr] 107 | |         true => Path::new(".git").join("HEAD"),
[INFO] [stderr] 108 | |         false => Path::new(".git").join("refs").join("heads").join(&head),
[INFO] [stderr] 109 | |     };
[INFO] [stderr]     | |_____^ help: consider using an if/else expression: `if refs::is_detached_head() { Path::new(".git").join("HEAD") } else { Path::new(".git").join("refs").join("heads").join(&head) }`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/builtin/config.rs:26:37
[INFO] [stderr]    |
[INFO] [stderr] 26 |                 if line.starts_with("[") && line.ends_with("]") {
[INFO] [stderr]    |                                     ^^^ help: try using a char instead: `'['`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/builtin/config.rs:26:60
[INFO] [stderr]    |
[INFO] [stderr] 26 |                 if line.starts_with("[") && line.ends_with("]") {
[INFO] [stderr]    |                                                            ^^^ help: try using a char instead: `']'`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]    --> src/builtin/config.rs:175:5
[INFO] [stderr]     |
[INFO] [stderr] 175 | /     match section.starts_with("[") && section.ends_with("]") {
[INFO] [stderr] 176 | |         // [section "subsection"] or [section]
[INFO] [stderr] 177 | |         true => {
[INFO] [stderr] 178 | |             let section = &section[1..section.len() - 1];
[INFO] [stderr] ...   |
[INFO] [stderr] 201 | |         }
[INFO] [stderr] 202 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] help: consider using an if/else expression
[INFO] [stderr]     |
[INFO] [stderr] 175 |     if section.starts_with("[") && section.ends_with("]") {
[INFO] [stderr] 176 |     let section = &section[1..section.len() - 1];
[INFO] [stderr] 177 |     let space_idx = match section.find(' ') {
[INFO] [stderr] 178 |         Some(i) => i,
[INFO] [stderr] 179 |         None => return (section.to_string(), String::new()),
[INFO] [stderr] 180 |     };
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/builtin/config.rs:175:31
[INFO] [stderr]     |
[INFO] [stderr] 175 |     match section.starts_with("[") && section.ends_with("]") {
[INFO] [stderr]     |                               ^^^ help: try using a char instead: `'['`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/builtin/config.rs:175:57
[INFO] [stderr]     |
[INFO] [stderr] 175 |     match section.starts_with("[") && section.ends_with("]") {
[INFO] [stderr]     |                                                         ^^^ help: try using a char instead: `']'`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]   --> src/builtin/hash_object.rs:16:28
[INFO] [stderr]    |
[INFO] [stderr] 16 |               let obj_type = match cli::has_flag(flags, "--type", "-t") {
[INFO] [stderr]    |  ____________________________^
[INFO] [stderr] 17 | |                 true => match &args.get(1) {
[INFO] [stderr] 18 | |                     Some(t) => t,
[INFO] [stderr] 19 | |                     None => {
[INFO] [stderr] ...  |
[INFO] [stderr] 24 | |                 false => "blob",
[INFO] [stderr] 25 | |             };
[INFO] [stderr]    | |_____________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] help: consider using an if/else expression
[INFO] [stderr]    |
[INFO] [stderr] 16 |             let obj_type = if cli::has_flag(flags, "--type", "-t") { match &args.get(1) {
[INFO] [stderr] 17 |     Some(t) => t,
[INFO] [stderr] 18 |     None => {
[INFO] [stderr] 19 |         println!("hash-object: missing 'type' argument.");
[INFO] [stderr] 20 |         return;
[INFO] [stderr] 21 |     }
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]   --> src/bits.rs:29:9
[INFO] [stderr]    |
[INFO] [stderr] 29 |         (x[0] as u32) << 24 | (x[1] as u32) << 16 | (x[2] as u32) << 8 | (x[3] as u32)
[INFO] [stderr]    |         ^^^^^^^^^^^^^ help: try: `u32::from(x[0])`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]   --> src/bits.rs:29:31
[INFO] [stderr]    |
[INFO] [stderr] 29 |         (x[0] as u32) << 24 | (x[1] as u32) << 16 | (x[2] as u32) << 8 | (x[3] as u32)
[INFO] [stderr]    |                               ^^^^^^^^^^^^^ help: try: `u32::from(x[1])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]   --> src/bits.rs:29:53
[INFO] [stderr]    |
[INFO] [stderr] 29 |         (x[0] as u32) << 24 | (x[1] as u32) << 16 | (x[2] as u32) << 8 | (x[3] as u32)
[INFO] [stderr]    |                                                     ^^^^^^^^^^^^^ help: try: `u32::from(x[2])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]   --> src/bits.rs:29:74
[INFO] [stderr]    |
[INFO] [stderr] 29 |         (x[0] as u32) << 24 | (x[1] as u32) << 16 | (x[2] as u32) << 8 | (x[3] as u32)
[INFO] [stderr]    |                                                                          ^^^^^^^^^^^^^ help: try: `u32::from(x[3])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]   --> src/bits.rs:37:9
[INFO] [stderr]    |
[INFO] [stderr] 37 |         (x[0] as u16) << 8 | (x[1] as u16)
[INFO] [stderr]    |         ^^^^^^^^^^^^^ help: try: `u16::from(x[0])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]   --> src/bits.rs:37:30
[INFO] [stderr]    |
[INFO] [stderr] 37 |         (x[0] as u16) << 8 | (x[1] as u16)
[INFO] [stderr]    |                              ^^^^^^^^^^^^^ help: try: `u16::from(x[1])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]   --> src/builtin/checkout.rs:43:18
[INFO] [stderr]    |
[INFO] [stderr] 43 |       let commit = match will_detach_head {
[INFO] [stderr]    |  __________________^
[INFO] [stderr] 44 | |         true => ref_name.to_string(),
[INFO] [stderr] 45 | |         false => refs::get_ref_hash(&ref_name)?,
[INFO] [stderr] 46 | |     };
[INFO] [stderr]    | |_____^ help: consider using an if/else expression: `if will_detach_head { ref_name.to_string() } else { refs::get_ref_hash(&ref_name)? }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_bool)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]    --> src/builtin/commit.rs:106:20
[INFO] [stderr]     |
[INFO] [stderr] 106 |       let ref_path = match refs::is_detached_head() {
[INFO] [stderr]     |  ____________________^
[INFO] [stderr] 107 | |         true => Path::new(".git").join("HEAD"),
[INFO] [stderr] 108 | |         false => Path::new(".git").join("refs").join("heads").join(&head),
[INFO] [stderr] 109 | |     };
[INFO] [stderr]     | |_____^ help: consider using an if/else expression: `if refs::is_detached_head() { Path::new(".git").join("HEAD") } else { Path::new(".git").join("refs").join("heads").join(&head) }`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/cli.rs:20:28
[INFO] [stderr]    |
[INFO] [stderr] 20 |         if opt.starts_with("-") {
[INFO] [stderr]    |                            ^^^ help: try using a char instead: `'-'`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `e` is only used to index `fields`.
[INFO] [stderr]   --> src/index.rs:92:18
[INFO] [stderr]    |
[INFO] [stderr] 92 |         for e in 0..10 {
[INFO] [stderr]    |                  ^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 92 |         for <item> in &mut fields {
[INFO] [stderr]    |             ^^^^^^    ^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/builtin/config.rs:26:37
[INFO] [stderr]    |
[INFO] [stderr] 26 |                 if line.starts_with("[") && line.ends_with("]") {
[INFO] [stderr]    |                                     ^^^ help: try using a char instead: `'['`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/builtin/config.rs:26:60
[INFO] [stderr]    |
[INFO] [stderr] 26 |                 if line.starts_with("[") && line.ends_with("]") {
[INFO] [stderr]    |                                                            ^^^ help: try using a char instead: `']'`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]   --> src/refs.rs:45:26
[INFO] [stderr]    |
[INFO] [stderr] 45 |       let formated_value = match name == "HEAD" && is_branch(&value) {
[INFO] [stderr]    |  __________________________^
[INFO] [stderr] 46 | |         true => format!("ref: refs/heads/{}\n", value),
[INFO] [stderr] 47 | |         false => format!("{}\n", value),
[INFO] [stderr] 48 | |     };
[INFO] [stderr]    | |_____^ help: consider using an if/else expression: `if name == "HEAD" && is_branch(&value) { format!("ref: refs/heads/{}\n", value) } else { format!("{}\n", value) }`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]    --> src/builtin/config.rs:175:5
[INFO] [stderr]     |
[INFO] [stderr] 175 | /     match section.starts_with("[") && section.ends_with("]") {
[INFO] [stderr] 176 | |         // [section "subsection"] or [section]
[INFO] [stderr] 177 | |         true => {
[INFO] [stderr] 178 | |             let section = &section[1..section.len() - 1];
[INFO] [stderr] ...   |
[INFO] [stderr] 201 | |         }
[INFO] [stderr] 202 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] help: consider using an if/else expression
[INFO] [stderr]     |
[INFO] [stderr] 175 |     if section.starts_with("[") && section.ends_with("]") {
[INFO] [stderr] 176 |     let section = &section[1..section.len() - 1];
[INFO] [stderr] 177 |     let space_idx = match section.find(' ') {
[INFO] [stderr] 178 |         Some(i) => i,
[INFO] [stderr] 179 |         None => return (section.to_string(), String::new()),
[INFO] [stderr] 180 |     };
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/builtin/config.rs:175:31
[INFO] [stderr]     |
[INFO] [stderr] 175 |     match section.starts_with("[") && section.ends_with("]") {
[INFO] [stderr]     |                               ^^^ help: try using a char instead: `'['`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/builtin/config.rs:175:57
[INFO] [stderr]     |
[INFO] [stderr] 175 |     match section.starts_with("[") && section.ends_with("]") {
[INFO] [stderr]     |                                                         ^^^ help: try using a char instead: `']'`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is used to index `w`
[INFO] [stderr]   --> src/sha1.rs:51:18
[INFO] [stderr]    |
[INFO] [stderr] 51 |         for i in 0..80 {
[INFO] [stderr]    |                  ^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 51 |         for (i, <item>) in w.iter().enumerate() {
[INFO] [stderr]    |             ^^^^^^^^^^^    ^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]    --> src/sha1.rs:106:35
[INFO] [stderr]     |
[INFO] [stderr] 106 |         let n1 = char::from_digit(fst as u32, 16)?;
[INFO] [stderr]     |                                   ^^^^^^^^^^ help: try: `u32::from(fst)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]    --> src/sha1.rs:107:35
[INFO] [stderr]     |
[INFO] [stderr] 107 |         let n2 = char::from_digit(snd as u32, 16)?;
[INFO] [stderr]     |                                   ^^^^^^^^^^ help: try: `u32::from(snd)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `s` is only used to index `states`.
[INFO] [stderr]    --> src/sha1.rs:122:14
[INFO] [stderr]     |
[INFO] [stderr] 122 |     for s in 0..5 {
[INFO] [stderr]     |              ^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]     |
[INFO] [stderr] 122 |     for <item> in &mut states {
[INFO] [stderr]     |         ^^^^^^    ^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]   --> src/work_dir.rs:65:21
[INFO] [stderr]    |
[INFO] [stderr] 65 |       let tree_hash = match oldest.is_empty() {
[INFO] [stderr]    |  _____________________^
[INFO] [stderr] 66 | |         true => String::new(),
[INFO] [stderr] 67 | |         false => commit::get_tree_hash(&oldest)?,
[INFO] [stderr] 68 | |     };
[INFO] [stderr]    | |_____^ help: consider using an if/else expression: `if oldest.is_empty() { String::new() } else { commit::get_tree_hash(&oldest)? }`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]   --> src/work_dir.rs:69:23
[INFO] [stderr]    |
[INFO] [stderr] 69 |       let oldest_tree = match tree_hash.is_empty() {
[INFO] [stderr]    |  _______________________^
[INFO] [stderr] 70 | |         true => Vec::new(),
[INFO] [stderr] 71 | |         false => read_tree::read_tree(&tree_hash)?,
[INFO] [stderr] 72 | |     };
[INFO] [stderr]    | |_____^ help: consider using an if/else expression: `if tree_hash.is_empty() { Vec::new() } else { read_tree::read_tree(&tree_hash)? }`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]   --> src/work_dir.rs:82:29
[INFO] [stderr]    |
[INFO] [stderr] 82 |                   let state = match oldest_obj.data != latest_obj.data {
[INFO] [stderr]    |  _____________________________^
[INFO] [stderr] 83 | |                     true => State::Modified,
[INFO] [stderr] 84 | |                     false => State::Same,
[INFO] [stderr] 85 | |                 };
[INFO] [stderr]    | |_________________^ help: consider using an if/else expression: `if oldest_obj.data != latest_obj.data { State::Modified } else { State::Same }`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]   --> src/builtin/hash_object.rs:16:28
[INFO] [stderr]    |
[INFO] [stderr] 16 |               let obj_type = match cli::has_flag(flags, "--type", "-t") {
[INFO] [stderr]    |  ____________________________^
[INFO] [stderr] 17 | |                 true => match &args.get(1) {
[INFO] [stderr] 18 | |                     Some(t) => t,
[INFO] [stderr] 19 | |                     None => {
[INFO] [stderr] ...  |
[INFO] [stderr] 24 | |                 false => "blob",
[INFO] [stderr] 25 | |             };
[INFO] [stderr]    | |_____________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] help: consider using an if/else expression
[INFO] [stderr]    |
[INFO] [stderr] 16 |             let obj_type = if cli::has_flag(flags, "--type", "-t") { match &args.get(1) {
[INFO] [stderr] 17 |     Some(t) => t,
[INFO] [stderr] 18 |     None => {
[INFO] [stderr] 19 |         println!("hash-object: missing 'type' argument.");
[INFO] [stderr] 20 |         return;
[INFO] [stderr] 21 |     }
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]   --> src/zlib.rs:89:22
[INFO] [stderr]    |
[INFO] [stderr] 89 |             a = (a + self.input[byte] as u32) % 65521;
[INFO] [stderr]    |                      ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.input[byte])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: calling `as_bytes()` on a string literal
[INFO] [stderr]   --> src/builtin/hash_object.rs:65:31
[INFO] [stderr]    |
[INFO] [stderr] 65 |         let res = hash_object("this is a test!".as_bytes(), "blob", false).unwrap();
[INFO] [stderr]    |                               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"this is a test!"`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::string_lit_as_bytes)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `len` is only used to index `length`.
[INFO] [stderr]    --> src/zlib.rs:148:20
[INFO] [stderr]     |
[INFO] [stderr] 148 |         for len in 0..length.len() {
[INFO] [stderr]     |                    ^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]     |
[INFO] [stderr] 148 |         for <item> in &mut length {
[INFO] [stderr]     |             ^^^^^^    ^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]    --> src/zlib.rs:154:20
[INFO] [stderr]     |
[INFO] [stderr] 154 |         for len in 1..(MAX_BITS + 1) {
[INFO] [stderr]     |                    ^^^^^^^^^^^^^^^^^ help: use: `1..=MAX_BITS`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::range_plus_one)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change
[INFO] [stderr]    --> src/zlib.rs:156:27
[INFO] [stderr]     |
[INFO] [stderr] 156 |             codes_left -= table.count[len] as i32;
[INFO] [stderr]     |                           ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(table.count[len])`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `sym` is used to index `length`
[INFO] [stderr]    --> src/zlib.rs:170:20
[INFO] [stderr]     |
[INFO] [stderr] 170 |         for sym in 0..length.len() {
[INFO] [stderr]     |                    ^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]     |
[INFO] [stderr] 170 |         for (sym, <item>) in length.iter().enumerate() {
[INFO] [stderr]     |             ^^^^^^^^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]    --> src/zlib.rs:185:20
[INFO] [stderr]     |
[INFO] [stderr] 185 |         for bit in 1..(MAX_BITS + 1) {
[INFO] [stderr]     |                    ^^^^^^^^^^^^^^^^^ help: use: `1..=MAX_BITS`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]    --> src/zlib.rs:255:24
[INFO] [stderr]     |
[INFO] [stderr] 255 |             let byte = self.input[self.input_idx] as u32;
[INFO] [stderr]     |                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.input[self.input_idx])`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change
[INFO] [stderr]    --> src/zlib.rs:327:64
[INFO] [stderr]     |
[INFO] [stderr] 327 |                     EXTRA_LEN[symbol as usize] + self.get_bits(EXTRA_BITS[symbol as usize] as u32)?;
[INFO] [stderr]     |                                                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(EXTRA_BITS[symbol as usize])`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change
[INFO] [stderr]    --> src/zlib.rs:332:37
[INFO] [stderr]     |
[INFO] [stderr] 332 |                     + self.get_bits(EXTRA_DBITS[symbol as usize] as u32)?;
[INFO] [stderr]     |                                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(EXTRA_DBITS[symbol as usize])`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `sym` is used to index `length`
[INFO] [stderr]    --> src/zlib.rs:352:20
[INFO] [stderr]     |
[INFO] [stderr] 352 |         for sym in 0..FIX_L_CODES {
[INFO] [stderr]     |                    ^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]     |
[INFO] [stderr] 352 |         for (sym, <item>) in length.iter_mut().enumerate().take(FIX_L_CODES) {
[INFO] [stderr]     |             ^^^^^^^^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/cli.rs:20:28
[INFO] [stderr]    |
[INFO] [stderr] 20 |         if opt.starts_with("-") {
[INFO] [stderr]    |                            ^^^ help: try using a char instead: `'-'`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `e` is only used to index `fields`.
[INFO] [stderr]   --> src/index.rs:92:18
[INFO] [stderr]    |
[INFO] [stderr] 92 |         for e in 0..10 {
[INFO] [stderr]    |                  ^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 92 |         for <item> in &mut fields {
[INFO] [stderr]    |             ^^^^^^    ^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]   --> src/refs.rs:45:26
[INFO] [stderr]    |
[INFO] [stderr] 45 |       let formated_value = match name == "HEAD" && is_branch(&value) {
[INFO] [stderr]    |  __________________________^
[INFO] [stderr] 46 | |         true => format!("ref: refs/heads/{}\n", value),
[INFO] [stderr] 47 | |         false => format!("{}\n", value),
[INFO] [stderr] 48 | |     };
[INFO] [stderr]    | |_____^ help: consider using an if/else expression: `if name == "HEAD" && is_branch(&value) { format!("ref: refs/heads/{}\n", value) } else { format!("{}\n", value) }`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is used to index `w`
[INFO] [stderr]   --> src/sha1.rs:51:18
[INFO] [stderr]    |
[INFO] [stderr] 51 |         for i in 0..80 {
[INFO] [stderr]    |                  ^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 51 |         for (i, <item>) in w.iter().enumerate() {
[INFO] [stderr]    |             ^^^^^^^^^^^    ^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]    --> src/sha1.rs:106:35
[INFO] [stderr]     |
[INFO] [stderr] 106 |         let n1 = char::from_digit(fst as u32, 16)?;
[INFO] [stderr]     |                                   ^^^^^^^^^^ help: try: `u32::from(fst)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]    --> src/sha1.rs:107:35
[INFO] [stderr]     |
[INFO] [stderr] 107 |         let n2 = char::from_digit(snd as u32, 16)?;
[INFO] [stderr]     |                                   ^^^^^^^^^^ help: try: `u32::from(snd)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `s` is only used to index `states`.
[INFO] [stderr]    --> src/sha1.rs:122:14
[INFO] [stderr]     |
[INFO] [stderr] 122 |     for s in 0..5 {
[INFO] [stderr]     |              ^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]     |
[INFO] [stderr] 122 |     for <item> in &mut states {
[INFO] [stderr]     |         ^^^^^^    ^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: calling `as_bytes()` on a string literal
[INFO] [stderr]    --> src/sha1.rs:136:18
[INFO] [stderr]     |
[INFO] [stderr] 136 |             sha1("abc".as_bytes()),
[INFO] [stderr]     |                  ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"abc"`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes
[INFO] [stderr] 
[INFO] [stderr] warning: calling `as_bytes()` on a string literal
[INFO] [stderr]    --> src/sha1.rs:140:18
[INFO] [stderr]     |
[INFO] [stderr] 140 |             sha1("".as_bytes()),
[INFO] [stderr]     |                  ^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b""`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes
[INFO] [stderr] 
[INFO] [stderr] warning: calling `as_bytes()` on a string literal
[INFO] [stderr]    --> src/sha1.rs:144:18
[INFO] [stderr]     |
[INFO] [stderr] 144 |             sha1("The quick brown fox jumps over the lazy dog".as_bytes()),
[INFO] [stderr]     |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"The quick brown fox jumps over the lazy dog"`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes
[INFO] [stderr] 
[INFO] [stderr] warning: calling `as_bytes()` on a string literal
[INFO] [stderr]    --> src/sha1.rs:148:18
[INFO] [stderr]     |
[INFO] [stderr] 148 |             sha1("The quick brown fox jumps over the lazy cog".as_bytes()),
[INFO] [stderr]     |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"The quick brown fox jumps over the lazy cog"`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]   --> src/work_dir.rs:65:21
[INFO] [stderr]    |
[INFO] [stderr] 65 |       let tree_hash = match oldest.is_empty() {
[INFO] [stderr]    |  _____________________^
[INFO] [stderr] 66 | |         true => String::new(),
[INFO] [stderr] 67 | |         false => commit::get_tree_hash(&oldest)?,
[INFO] [stderr] 68 | |     };
[INFO] [stderr]    | |_____^ help: consider using an if/else expression: `if oldest.is_empty() { String::new() } else { commit::get_tree_hash(&oldest)? }`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]   --> src/work_dir.rs:69:23
[INFO] [stderr]    |
[INFO] [stderr] 69 |       let oldest_tree = match tree_hash.is_empty() {
[INFO] [stderr]    |  _______________________^
[INFO] [stderr] 70 | |         true => Vec::new(),
[INFO] [stderr] 71 | |         false => read_tree::read_tree(&tree_hash)?,
[INFO] [stderr] 72 | |     };
[INFO] [stderr]    | |_____^ help: consider using an if/else expression: `if tree_hash.is_empty() { Vec::new() } else { read_tree::read_tree(&tree_hash)? }`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]   --> src/work_dir.rs:82:29
[INFO] [stderr]    |
[INFO] [stderr] 82 |                   let state = match oldest_obj.data != latest_obj.data {
[INFO] [stderr]    |  _____________________________^
[INFO] [stderr] 83 | |                     true => State::Modified,
[INFO] [stderr] 84 | |                     false => State::Same,
[INFO] [stderr] 85 | |                 };
[INFO] [stderr]    | |_________________^ help: consider using an if/else expression: `if oldest_obj.data != latest_obj.data { State::Modified } else { State::Same }`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]   --> src/zlib.rs:89:22
[INFO] [stderr]    |
[INFO] [stderr] 89 |             a = (a + self.input[byte] as u32) % 65521;
[INFO] [stderr]    |                      ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.input[byte])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `len` is only used to index `length`.
[INFO] [stderr]    --> src/zlib.rs:148:20
[INFO] [stderr]     |
[INFO] [stderr] 148 |         for len in 0..length.len() {
[INFO] [stderr]     |                    ^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]     |
[INFO] [stderr] 148 |         for <item> in &mut length {
[INFO] [stderr]     |             ^^^^^^    ^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]    --> src/zlib.rs:154:20
[INFO] [stderr]     |
[INFO] [stderr] 154 |         for len in 1..(MAX_BITS + 1) {
[INFO] [stderr]     |                    ^^^^^^^^^^^^^^^^^ help: use: `1..=MAX_BITS`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::range_plus_one)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change
[INFO] [stderr]    --> src/zlib.rs:156:27
[INFO] [stderr]     |
[INFO] [stderr] 156 |             codes_left -= table.count[len] as i32;
[INFO] [stderr]     |                           ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(table.count[len])`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `sym` is used to index `length`
[INFO] [stderr]    --> src/zlib.rs:170:20
[INFO] [stderr]     |
[INFO] [stderr] 170 |         for sym in 0..length.len() {
[INFO] [stderr]     |                    ^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]     |
[INFO] [stderr] 170 |         for (sym, <item>) in length.iter().enumerate() {
[INFO] [stderr]     |             ^^^^^^^^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]    --> src/zlib.rs:185:20
[INFO] [stderr]     |
[INFO] [stderr] 185 |         for bit in 1..(MAX_BITS + 1) {
[INFO] [stderr]     |                    ^^^^^^^^^^^^^^^^^ help: use: `1..=MAX_BITS`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]    --> src/zlib.rs:255:24
[INFO] [stderr]     |
[INFO] [stderr] 255 |             let byte = self.input[self.input_idx] as u32;
[INFO] [stderr]     |                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.input[self.input_idx])`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change
[INFO] [stderr]    --> src/zlib.rs:327:64
[INFO] [stderr]     |
[INFO] [stderr] 327 |                     EXTRA_LEN[symbol as usize] + self.get_bits(EXTRA_BITS[symbol as usize] as u32)?;
[INFO] [stderr]     |                                                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(EXTRA_BITS[symbol as usize])`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change
[INFO] [stderr]    --> src/zlib.rs:332:37
[INFO] [stderr]     |
[INFO] [stderr] 332 |                     + self.get_bits(EXTRA_DBITS[symbol as usize] as u32)?;
[INFO] [stderr]     |                                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(EXTRA_DBITS[symbol as usize])`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `sym` is used to index `length`
[INFO] [stderr]    --> src/zlib.rs:352:20
[INFO] [stderr]     |
[INFO] [stderr] 352 |         for sym in 0..FIX_L_CODES {
[INFO] [stderr]     |                    ^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]     |
[INFO] [stderr] 352 |         for (sym, <item>) in length.iter_mut().enumerate().take(FIX_L_CODES) {
[INFO] [stderr]     |             ^^^^^^^^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 1.72s
[INFO] running `"docker" "inspect" "814f40e3a90664a26e91356bad7eb069ccc70c21af6609199ae4d7ac5b0bbe1e"`
[INFO] running `"docker" "rm" "-f" "814f40e3a90664a26e91356bad7eb069ccc70c21af6609199ae4d7ac5b0bbe1e"`
[INFO] [stdout] 814f40e3a90664a26e91356bad7eb069ccc70c21af6609199ae4d7ac5b0bbe1e