[INFO] updating cached repository halcyon/rust_tut [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/halcyon/rust_tut [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/halcyon/rust_tut" "work/ex/clippy-test-run/sources/stable/gh/halcyon/rust_tut"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/halcyon/rust_tut'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/halcyon/rust_tut" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/halcyon/rust_tut"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/halcyon/rust_tut'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 558bf4aae326605a6934155e7faf29e8747627d9 [INFO] sha for GitHub repo halcyon/rust_tut: 558bf4aae326605a6934155e7faf29e8747627d9 [INFO] validating manifest of halcyon/rust_tut on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of halcyon/rust_tut on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing halcyon/rust_tut [INFO] finished frobbing halcyon/rust_tut [INFO] frobbed toml for halcyon/rust_tut written to work/ex/clippy-test-run/sources/stable/gh/halcyon/rust_tut/Cargo.toml [INFO] started frobbing halcyon/rust_tut [INFO] finished frobbing halcyon/rust_tut [INFO] frobbed toml for halcyon/rust_tut written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/halcyon/rust_tut/Cargo.toml [INFO] crate halcyon/rust_tut has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting halcyon/rust_tut against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/halcyon/rust_tut:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 26517e6087840a95ca8c7bf6e5d4085b131dcec9fb368791601e2b79c036d438 [INFO] running `"docker" "start" "-a" "26517e6087840a95ca8c7bf6e5d4085b131dcec9fb368791601e2b79c036d438"` [INFO] [stderr] Checking rust_tut v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused imports: `u16`, `u32`, `u64`, `u8` [INFO] [stderr] --> src/main.rs:1:30 [INFO] [stderr] | [INFO] [stderr] 1 | use std::{i8, i16, i32, i64, u8, u16, u32, u64, isize, usize, f32, f64}; [INFO] [stderr] | ^^ ^^^ ^^^ ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:62:8 [INFO] [stderr] | [INFO] [stderr] 62 | if (age_old == 5) { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:78:23 [INFO] [stderr] | [INFO] [stderr] 78 | let can_vote = if (age_old >= 18) { true } else { false }; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:85:12 [INFO] [stderr] | [INFO] [stderr] 85 | if ((x % 2) == 0) { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:90:12 [INFO] [stderr] | [INFO] [stderr] 90 | if (x > 10) { [INFO] [stderr] | ^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unused imports: `u16`, `u32`, `u64`, `u8` [INFO] [stderr] --> src/main.rs:1:30 [INFO] [stderr] | [INFO] [stderr] 1 | use std::{i8, i16, i32, i64, u8, u16, u32, u64, isize, usize, f32, f64}; [INFO] [stderr] | ^^ ^^^ ^^^ ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:62:8 [INFO] [stderr] | [INFO] [stderr] 62 | if (age_old == 5) { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:78:23 [INFO] [stderr] | [INFO] [stderr] 78 | let can_vote = if (age_old >= 18) { true } else { false }; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:85:12 [INFO] [stderr] | [INFO] [stderr] 85 | if ((x % 2) == 0) { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:90:12 [INFO] [stderr] | [INFO] [stderr] 90 | if (x > 10) { [INFO] [stderr] | ^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unused variable: `num` [INFO] [stderr] --> src/main.rs:8:9 [INFO] [stderr] | [INFO] [stderr] 8 | let num = 10; [INFO] [stderr] | ^^^ help: consider using `_num` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `f_name` [INFO] [stderr] --> src/main.rs:34:10 [INFO] [stderr] | [INFO] [stderr] 34 | let (f_name, l_name) = ("Derek", "Banas"); [INFO] [stderr] | ^^^^^^ help: consider using `_f_name` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `l_name` [INFO] [stderr] --> src/main.rs:34:18 [INFO] [stderr] | [INFO] [stderr] 34 | let (f_name, l_name) = ("Derek", "Banas"); [INFO] [stderr] | ^^^^^^ help: consider using `_l_name` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `count` [INFO] [stderr] --> src/main.rs:116:9 [INFO] [stderr] | [INFO] [stderr] 116 | let count = rand_string.chars().count(); [INFO] [stderr] | ^^^^^ help: consider using `_count` instead [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:10:9 [INFO] [stderr] | [INFO] [stderr] 10 | let mut age: i32 = 40; [INFO] [stderr] | ----^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:52:9 [INFO] [stderr] | [INFO] [stderr] 52 | let mut neg_4 = -4i32; [INFO] [stderr] | ----^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `num` [INFO] [stderr] --> src/main.rs:8:9 [INFO] [stderr] | [INFO] [stderr] 8 | let num = 10; [INFO] [stderr] | ^^^ help: consider using `_num` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `f_name` [INFO] [stderr] --> src/main.rs:34:10 [INFO] [stderr] | [INFO] [stderr] 34 | let (f_name, l_name) = ("Derek", "Banas"); [INFO] [stderr] | ^^^^^^ help: consider using `_f_name` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `l_name` [INFO] [stderr] --> src/main.rs:34:18 [INFO] [stderr] | [INFO] [stderr] 34 | let (f_name, l_name) = ("Derek", "Banas"); [INFO] [stderr] | ^^^^^^ help: consider using `_l_name` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `count` [INFO] [stderr] --> src/main.rs:116:9 [INFO] [stderr] | [INFO] [stderr] 116 | let count = rand_string.chars().count(); [INFO] [stderr] | ^^^^^ help: consider using `_count` instead [INFO] [stderr] [INFO] [stderr] error: approximate value of `f64::consts::PI` found. Consider using it directly [INFO] [stderr] --> src/main.rs:58:31 [INFO] [stderr] | [INFO] [stderr] 58 | println!("Sin 3.14 = {}", 3.14f64.sin()); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::approx_constant)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#approx_constant [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/main.rs:78:20 [INFO] [stderr] | [INFO] [stderr] 78 | let can_vote = if (age_old >= 18) { true } else { false }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can reduce it to: `(age_old >= 18)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/main.rs:121:5 [INFO] [stderr] | [INFO] [stderr] 121 | / loop { [INFO] [stderr] 122 | | match indiv_char { [INFO] [stderr] 123 | | Some(x) => println!("{}", x), [INFO] [stderr] 124 | | None => break, [INFO] [stderr] 125 | | } [INFO] [stderr] 126 | | indiv_char = chars.next(); [INFO] [stderr] 127 | | } [INFO] [stderr] | |_____^ help: try: `while let Some(x) = indiv_char { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/main.rs:133:5 [INFO] [stderr] | [INFO] [stderr] 133 | / loop { [INFO] [stderr] 134 | | match indiv_word { [INFO] [stderr] 135 | | Some(x) => println!("{}", x), [INFO] [stderr] 136 | | None => break, [INFO] [stderr] 137 | | } [INFO] [stderr] 138 | | indiv_word = iter.next(); [INFO] [stderr] 139 | | } [INFO] [stderr] | |_____^ help: try: `while let Some(x) = indiv_word { .. }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/main.rs:146:5 [INFO] [stderr] | [INFO] [stderr] 146 | / loop { [INFO] [stderr] 147 | | match indiv_line { [INFO] [stderr] 148 | | Some(x) => println!("{}", x), [INFO] [stderr] 149 | | None => break, [INFO] [stderr] 150 | | } [INFO] [stderr] 151 | | indiv_line = lines.next(); [INFO] [stderr] 152 | | } [INFO] [stderr] | |_____^ help: try: `while let Some(x) = indiv_line { .. }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: called `map_or(None, f)` on an Option value. This can be done more directly by calling `and_then(f)` instead [INFO] [stderr] --> src/main.rs:164:38 [INFO] [stderr] | [INFO] [stderr] 164 | let guess: Option = input.ok().map_or(None, |_| line.trim().parse().ok()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try using and_then instead: `input.ok().and_then(|_| line.trim().parse().ok())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_or_none)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_or_none [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:10:9 [INFO] [stderr] | [INFO] [stderr] 10 | let mut age: i32 = 40; [INFO] [stderr] | ----^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:52:9 [INFO] [stderr] | [INFO] [stderr] 52 | let mut neg_4 = -4i32; [INFO] [stderr] | ----^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] error: Could not compile `rust_tut`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: approximate value of `f64::consts::PI` found. Consider using it directly [INFO] [stderr] --> src/main.rs:58:31 [INFO] [stderr] | [INFO] [stderr] 58 | println!("Sin 3.14 = {}", 3.14f64.sin()); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::approx_constant)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#approx_constant [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/main.rs:78:20 [INFO] [stderr] | [INFO] [stderr] 78 | let can_vote = if (age_old >= 18) { true } else { false }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can reduce it to: `(age_old >= 18)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/main.rs:121:5 [INFO] [stderr] | [INFO] [stderr] 121 | / loop { [INFO] [stderr] 122 | | match indiv_char { [INFO] [stderr] 123 | | Some(x) => println!("{}", x), [INFO] [stderr] 124 | | None => break, [INFO] [stderr] 125 | | } [INFO] [stderr] 126 | | indiv_char = chars.next(); [INFO] [stderr] 127 | | } [INFO] [stderr] | |_____^ help: try: `while let Some(x) = indiv_char { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/main.rs:133:5 [INFO] [stderr] | [INFO] [stderr] 133 | / loop { [INFO] [stderr] 134 | | match indiv_word { [INFO] [stderr] 135 | | Some(x) => println!("{}", x), [INFO] [stderr] 136 | | None => break, [INFO] [stderr] 137 | | } [INFO] [stderr] 138 | | indiv_word = iter.next(); [INFO] [stderr] 139 | | } [INFO] [stderr] | |_____^ help: try: `while let Some(x) = indiv_word { .. }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/main.rs:146:5 [INFO] [stderr] | [INFO] [stderr] 146 | / loop { [INFO] [stderr] 147 | | match indiv_line { [INFO] [stderr] 148 | | Some(x) => println!("{}", x), [INFO] [stderr] 149 | | None => break, [INFO] [stderr] 150 | | } [INFO] [stderr] 151 | | indiv_line = lines.next(); [INFO] [stderr] 152 | | } [INFO] [stderr] | |_____^ help: try: `while let Some(x) = indiv_line { .. }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: called `map_or(None, f)` on an Option value. This can be done more directly by calling `and_then(f)` instead [INFO] [stderr] --> src/main.rs:164:38 [INFO] [stderr] | [INFO] [stderr] 164 | let guess: Option = input.ok().map_or(None, |_| line.trim().parse().ok()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try using and_then instead: `input.ok().and_then(|_| line.trim().parse().ok())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_or_none)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_or_none [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `rust_tut`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "26517e6087840a95ca8c7bf6e5d4085b131dcec9fb368791601e2b79c036d438"` [INFO] running `"docker" "rm" "-f" "26517e6087840a95ca8c7bf6e5d4085b131dcec9fb368791601e2b79c036d438"` [INFO] [stdout] 26517e6087840a95ca8c7bf6e5d4085b131dcec9fb368791601e2b79c036d438