[INFO] updating cached repository h3nnn4n/spider-lenstra [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/h3nnn4n/spider-lenstra [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/h3nnn4n/spider-lenstra" "work/ex/clippy-test-run/sources/stable/gh/h3nnn4n/spider-lenstra"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/h3nnn4n/spider-lenstra'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/h3nnn4n/spider-lenstra" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/h3nnn4n/spider-lenstra"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/h3nnn4n/spider-lenstra'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 4d5f50fec7bfdae451d1f0d03bbc857d05025097 [INFO] sha for GitHub repo h3nnn4n/spider-lenstra: 4d5f50fec7bfdae451d1f0d03bbc857d05025097 [INFO] validating manifest of h3nnn4n/spider-lenstra on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of h3nnn4n/spider-lenstra on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing h3nnn4n/spider-lenstra [INFO] finished frobbing h3nnn4n/spider-lenstra [INFO] frobbed toml for h3nnn4n/spider-lenstra written to work/ex/clippy-test-run/sources/stable/gh/h3nnn4n/spider-lenstra/Cargo.toml [INFO] started frobbing h3nnn4n/spider-lenstra [INFO] finished frobbing h3nnn4n/spider-lenstra [INFO] frobbed toml for h3nnn4n/spider-lenstra written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/h3nnn4n/spider-lenstra/Cargo.toml [INFO] crate h3nnn4n/spider-lenstra has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting h3nnn4n/spider-lenstra against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/h3nnn4n/spider-lenstra:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] afc312572b19b40676a69f2d575b3cde32c6dfd6d44c26cb946affac621621d3 [INFO] running `"docker" "start" "-a" "afc312572b19b40676a69f2d575b3cde32c6dfd6d44c26cb946affac621621d3"` [INFO] [stderr] Checking lenstra v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/main.rs:25:10 [INFO] [stderr] | [INFO] [stderr] 25 | let (x, y, g) = modular_inv(b, r); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/main.rs:25:10 [INFO] [stderr] | [INFO] [stderr] 25 | let (x, y, g) = modular_inv(b, r); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/main.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | let (x, y, g) = modular_inv(b, r); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/main.rs:25:16 [INFO] [stderr] | [INFO] [stderr] 25 | let (x, y, g) = modular_inv(b, r); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/main.rs:30:73 [INFO] [stderr] | [INFO] [stderr] 30 | fn elliptic_add(p: (i64, i64, i64), q: (i64, i64, i64), a: i64, b: i64, m: i64) -> (i64, i64, i64) { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/main.rs:54:18 [INFO] [stderr] | [INFO] [stderr] 54 | let (inv, _, g) = modular_inv(denom, m); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/main.rs:60:9 [INFO] [stderr] | [INFO] [stderr] 60 | let z = (num * inv * num * inv - p.0 - q.0) % m; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/main.rs:65:69 [INFO] [stderr] | [INFO] [stderr] 65 | fn elliptic_mul(mut k: i64, mut p: (i64, i64, i64), a: i64, b: i64, m: i64) -> (i64, i64, i64) { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/main.rs:66:13 [INFO] [stderr] | [INFO] [stderr] 66 | let mut r = (0, 1, 0); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/main.rs:128:13 [INFO] [stderr] | [INFO] [stderr] 128 | let mut b = 0; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/main.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | let (x, y, g) = modular_inv(b, r); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/main.rs:25:16 [INFO] [stderr] | [INFO] [stderr] 25 | let (x, y, g) = modular_inv(b, r); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/main.rs:30:73 [INFO] [stderr] | [INFO] [stderr] 30 | fn elliptic_add(p: (i64, i64, i64), q: (i64, i64, i64), a: i64, b: i64, m: i64) -> (i64, i64, i64) { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/main.rs:54:18 [INFO] [stderr] | [INFO] [stderr] 54 | let (inv, _, g) = modular_inv(denom, m); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/main.rs:60:9 [INFO] [stderr] | [INFO] [stderr] 60 | let z = (num * inv * num * inv - p.0 - q.0) % m; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/main.rs:65:69 [INFO] [stderr] | [INFO] [stderr] 65 | fn elliptic_mul(mut k: i64, mut p: (i64, i64, i64), a: i64, b: i64, m: i64) -> (i64, i64, i64) { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/main.rs:66:13 [INFO] [stderr] | [INFO] [stderr] 66 | let mut r = (0, 1, 0); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/main.rs:128:13 [INFO] [stderr] | [INFO] [stderr] 128 | let mut b = 0; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: unused variable: `b` [INFO] [stderr] --> src/main.rs:30:65 [INFO] [stderr] | [INFO] [stderr] 30 | fn elliptic_add(p: (i64, i64, i64), q: (i64, i64, i64), a: i64, b: i64, m: i64) -> (i64, i64, i64) { [INFO] [stderr] | ^ help: consider using `_b` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `lenstra` [INFO] [stderr] --> src/main.rs:158:1 [INFO] [stderr] | [INFO] [stderr] 158 | fn lenstra(n: i64, limit: i64) -> i64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:40:5 [INFO] [stderr] | [INFO] [stderr] 40 | / let denom; [INFO] [stderr] 41 | | [INFO] [stderr] 42 | | if p.0 == q.0 { [INFO] [stderr] 43 | | if (p.1 + q.1) % m == 0 { [INFO] [stderr] ... | [INFO] [stderr] 51 | | denom = (q.0 - p.0) % m; [INFO] [stderr] 52 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let denom = if p.0 == q.0 { ..; (2 * p.1) % m } else { ..; (q.0 - p.0) % m };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:77:9 [INFO] [stderr] | [INFO] [stderr] 77 | k = k / 2; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `k /= 2` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:160:9 [INFO] [stderr] | [INFO] [stderr] 160 | / match lenstra_(n, limit) { [INFO] [stderr] 161 | | Some(m) => return m, [INFO] [stderr] 162 | | None => (), [INFO] [stderr] 163 | | } [INFO] [stderr] | |_________^ help: try this: `if let Some(m) = lenstra_(n, limit) { return m }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: unused variable: `b` [INFO] [stderr] --> src/main.rs:30:65 [INFO] [stderr] | [INFO] [stderr] 30 | fn elliptic_add(p: (i64, i64, i64), q: (i64, i64, i64), a: i64, b: i64, m: i64) -> (i64, i64, i64) { [INFO] [stderr] | ^ help: consider using `_b` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `lenstra` [INFO] [stderr] --> src/main.rs:158:1 [INFO] [stderr] | [INFO] [stderr] 158 | fn lenstra(n: i64, limit: i64) -> i64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:40:5 [INFO] [stderr] | [INFO] [stderr] 40 | / let denom; [INFO] [stderr] 41 | | [INFO] [stderr] 42 | | if p.0 == q.0 { [INFO] [stderr] 43 | | if (p.1 + q.1) % m == 0 { [INFO] [stderr] ... | [INFO] [stderr] 51 | | denom = (q.0 - p.0) % m; [INFO] [stderr] 52 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let denom = if p.0 == q.0 { ..; (2 * p.1) % m } else { ..; (q.0 - p.0) % m };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:77:9 [INFO] [stderr] | [INFO] [stderr] 77 | k = k / 2; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `k /= 2` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:160:9 [INFO] [stderr] | [INFO] [stderr] 160 | / match lenstra_(n, limit) { [INFO] [stderr] 161 | | Some(m) => return m, [INFO] [stderr] 162 | | None => (), [INFO] [stderr] 163 | | } [INFO] [stderr] | |_________^ help: try this: `if let Some(m) = lenstra_(n, limit) { return m }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.97s [INFO] running `"docker" "inspect" "afc312572b19b40676a69f2d575b3cde32c6dfd6d44c26cb946affac621621d3"` [INFO] running `"docker" "rm" "-f" "afc312572b19b40676a69f2d575b3cde32c6dfd6d44c26cb946affac621621d3"` [INFO] [stdout] afc312572b19b40676a69f2d575b3cde32c6dfd6d44c26cb946affac621621d3