[INFO] updating cached repository guydunigo/rust_recap
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/guydunigo/rust_recap
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/guydunigo/rust_recap" "work/ex/clippy-test-run/sources/stable/gh/guydunigo/rust_recap"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/guydunigo/rust_recap'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/guydunigo/rust_recap" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/guydunigo/rust_recap"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/guydunigo/rust_recap'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] e03003e49c1d081a9d90249d2df91c1c3c4144a3
[INFO] sha for GitHub repo guydunigo/rust_recap: e03003e49c1d081a9d90249d2df91c1c3c4144a3
[INFO] validating manifest of guydunigo/rust_recap on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of guydunigo/rust_recap on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing guydunigo/rust_recap
[INFO] finished frobbing guydunigo/rust_recap
[INFO] frobbed toml for guydunigo/rust_recap written to work/ex/clippy-test-run/sources/stable/gh/guydunigo/rust_recap/Cargo.toml
[INFO] started frobbing guydunigo/rust_recap
[INFO] finished frobbing guydunigo/rust_recap
[INFO] frobbed toml for guydunigo/rust_recap written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/guydunigo/rust_recap/Cargo.toml
[INFO] crate guydunigo/rust_recap has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting guydunigo/rust_recap against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/guydunigo/rust_recap:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 66a065c8e38743befd0a8cea9ff51a097e0e11ab16f380d5514063e32e12273e
[INFO] running `"docker" "start" "-a" "66a065c8e38743befd0a8cea9ff51a097e0e11ab16f380d5514063e32e12273e"`
[INFO] [stderr]     Checking rust_recap v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: lint `private_no_mangle_fns` has been removed: `no longer an warning, #[no_mangle] functions always exported`
[INFO] [stderr]  --> src/lib.rs:9:10
[INFO] [stderr]   |
[INFO] [stderr] 9 | #![allow(private_no_mangle_fns)]
[INFO] [stderr]   |          ^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(renamed_and_removed_lints)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: using `println!("")`
[INFO] [stderr]    --> src/smart_pointers.rs:220:9
[INFO] [stderr]     |
[INFO] [stderr] 220 |         println!("");
[INFO] [stderr]     |         ^^^^^^^^^^^^ help: replace it with: `println!()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::println_empty_string)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string
[INFO] [stderr] 
[INFO] [stderr] warning: using `println!("")`
[INFO] [stderr]    --> src/smart_pointers.rs:222:9
[INFO] [stderr]     |
[INFO] [stderr] 222 |         println!("");
[INFO] [stderr]     |         ^^^^^^^^^^^^ help: replace it with: `println!()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string
[INFO] [stderr] 
[INFO] [stderr] warning: using `println!("")`
[INFO] [stderr]    --> src/smart_pointers.rs:224:9
[INFO] [stderr]     |
[INFO] [stderr] 224 |         println!("");
[INFO] [stderr]     |         ^^^^^^^^^^^^ help: replace it with: `println!()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string
[INFO] [stderr] 
[INFO] [stderr] warning: 5th binding whose name is just one char
[INFO] [stderr]   --> src/pattern_matching.rs:81:24
[INFO] [stderr]    |
[INFO] [stderr] 81 |         let Point { x: a, y: b } = p;
[INFO] [stderr]    |                        ^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::many_single_char_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 6th binding whose name is just one char
[INFO] [stderr]   --> src/pattern_matching.rs:81:30
[INFO] [stderr]    |
[INFO] [stderr] 81 |         let Point { x: a, y: b } = p;
[INFO] [stderr]    |                              ^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 7th binding whose name is just one char
[INFO] [stderr]    --> src/pattern_matching.rs:109:34
[INFO] [stderr]     |
[INFO] [stderr] 109 |             Message::ChangeColor(r, g, b) => {
[INFO] [stderr]     |                                  ^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 8th binding whose name is just one char
[INFO] [stderr]    --> src/pattern_matching.rs:109:37
[INFO] [stderr]     |
[INFO] [stderr] 109 |             Message::ChangeColor(r, g, b) => {
[INFO] [stderr]     |                                     ^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: lint `private_no_mangle_fns` has been removed: `no longer an warning, #[no_mangle] functions always exported`
[INFO] [stderr]  --> src/lib.rs:9:10
[INFO] [stderr]   |
[INFO] [stderr] 9 | #![allow(private_no_mangle_fns)]
[INFO] [stderr]   |          ^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(renamed_and_removed_lints)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: using `println!("")`
[INFO] [stderr]    --> src/smart_pointers.rs:220:9
[INFO] [stderr]     |
[INFO] [stderr] 220 |         println!("");
[INFO] [stderr]     |         ^^^^^^^^^^^^ help: replace it with: `println!()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::println_empty_string)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string
[INFO] [stderr] 
[INFO] [stderr] warning: using `println!("")`
[INFO] [stderr]    --> src/smart_pointers.rs:222:9
[INFO] [stderr]     |
[INFO] [stderr] 222 |         println!("");
[INFO] [stderr]     |         ^^^^^^^^^^^^ help: replace it with: `println!()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string
[INFO] [stderr] 
[INFO] [stderr] warning: using `println!("")`
[INFO] [stderr]    --> src/smart_pointers.rs:224:9
[INFO] [stderr]     |
[INFO] [stderr] 224 |         println!("");
[INFO] [stderr]     |         ^^^^^^^^^^^^ help: replace it with: `println!()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string
[INFO] [stderr] 
[INFO] [stderr] warning: 5th binding whose name is just one char
[INFO] [stderr]   --> src/pattern_matching.rs:81:24
[INFO] [stderr]    |
[INFO] [stderr] 81 |         let Point { x: a, y: b } = p;
[INFO] [stderr]    |                        ^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::many_single_char_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 6th binding whose name is just one char
[INFO] [stderr]   --> src/pattern_matching.rs:81:30
[INFO] [stderr]    |
[INFO] [stderr] 81 |         let Point { x: a, y: b } = p;
[INFO] [stderr]    |                              ^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 7th binding whose name is just one char
[INFO] [stderr]    --> src/pattern_matching.rs:109:34
[INFO] [stderr]     |
[INFO] [stderr] 109 |             Message::ChangeColor(r, g, b) => {
[INFO] [stderr]     |                                  ^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 8th binding whose name is just one char
[INFO] [stderr]    --> src/pattern_matching.rs:109:37
[INFO] [stderr]     |
[INFO] [stderr] 109 |             Message::ChangeColor(r, g, b) => {
[INFO] [stderr]     |                                     ^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/generics_traits_lifetimes.rs:223:40
[INFO] [stderr]     |
[INFO] [stderr] 223 |             let pt = Point { x: 46, y: 164642 };
[INFO] [stderr]     |                                        ^^^^^^ help: consider: `164_642`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: module has the same name as its containing module
[INFO] [stderr]   --> src/tests.rs:24:1
[INFO] [stderr]    |
[INFO] [stderr] 24 | / mod tests {
[INFO] [stderr] 25 | |     use super::*;
[INFO] [stderr] 26 | |
[INFO] [stderr] 27 | |     #[test]
[INFO] [stderr] ...  |
[INFO] [stderr] 59 | |     }
[INFO] [stderr] 60 | | }
[INFO] [stderr]    | |_^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::module_inception)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception
[INFO] [stderr] 
[INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead
[INFO] [stderr]   --> src/pattern_matching.rs:86:21
[INFO] [stderr]    |
[INFO] [stderr] 86 |             Point { x: _, y } => println!("Something "),
[INFO] [stderr]    |                     ^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unneeded_field_pattern)] on by default
[INFO] [stderr]    = help: Try with `Point { y, .. }`
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/unsafe_rust.rs:14:23
[INFO] [stderr]    |
[INFO] [stderr] 14 |         let address = 0x012345usize;
[INFO] [stderr]    |                       ^^^^^^^^^^^^^ help: consider: `0x0001_2345usize`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/generics_traits_lifetimes.rs:223:40
[INFO] [stderr]     |
[INFO] [stderr] 223 |             let pt = Point { x: 46, y: 164642 };
[INFO] [stderr]     |                                        ^^^^^^ help: consider: `164_642`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead
[INFO] [stderr]   --> src/pattern_matching.rs:86:21
[INFO] [stderr]    |
[INFO] [stderr] 86 |             Point { x: _, y } => println!("Something "),
[INFO] [stderr]    |                     ^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unneeded_field_pattern)] on by default
[INFO] [stderr]    = help: Try with `Point { y, .. }`
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/unsafe_rust.rs:14:23
[INFO] [stderr]    |
[INFO] [stderr] 14 |         let address = 0x012345usize;
[INFO] [stderr]    |                       ^^^^^^^^^^^^^ help: consider: `0x0001_2345usize`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] error: this loop never actually loops
[INFO] [stderr]   --> src/basics.rs:74:9
[INFO] [stderr]    |
[INFO] [stderr] 74 | /         loop {
[INFO] [stderr] 75 | |             break;
[INFO] [stderr] 76 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[deny(clippy::never_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/basics.rs:80:13
[INFO] [stderr]    |
[INFO] [stderr] 80 |             i = i + 1;
[INFO] [stderr]    |             ^^^^^^^^^ help: replace it with: `i += 1`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::assign_op_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/ownership.rs:15:21
[INFO] [stderr]    |
[INFO] [stderr] 15 |     fn borrowing(s: &String) -> usize {
[INFO] [stderr]    |                     ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/structs.rs:89:9
[INFO] [stderr]    |
[INFO] [stderr] 89 | /         match self.state {
[INFO] [stderr] 90 | |             PostState::Draft => self.content.push_str(text),
[INFO] [stderr] 91 | |             _ => (),
[INFO] [stderr] 92 | |         };
[INFO] [stderr]    | |_________^ help: try this: `if let PostState::Draft = self.state { self.content.push_str(text) }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/collections.rs:41:13
[INFO] [stderr]    |
[INFO] [stderr] 41 | /             match i {
[INFO] [stderr] 42 | |                 &Types::Int(_) => println!("int"),
[INFO] [stderr] 43 | |                 &Types::Text(_) => println!("text"),
[INFO] [stderr] 44 | |                 &Types::Float(_) => println!("float"),
[INFO] [stderr] 45 | |             }
[INFO] [stderr]    | |_____________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 41 |             match *i {
[INFO] [stderr] 42 |                 Types::Int(_) => println!("int"),
[INFO] [stderr] 43 |                 Types::Text(_) => println!("text"),
[INFO] [stderr] 44 |                 Types::Float(_) => println!("float"),
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] error: this loop never actually loops
[INFO] [stderr]   --> src/basics.rs:74:9
[INFO] [stderr]    |
[INFO] [stderr] 74 | /         loop {
[INFO] [stderr] 75 | |             break;
[INFO] [stderr] 76 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[deny(clippy::never_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/basics.rs:80:13
[INFO] [stderr]    |
[INFO] [stderr] 80 |             i = i + 1;
[INFO] [stderr]    |             ^^^^^^^^^ help: replace it with: `i += 1`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::assign_op_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/ownership.rs:15:21
[INFO] [stderr]    |
[INFO] [stderr] 15 |     fn borrowing(s: &String) -> usize {
[INFO] [stderr]    |                     ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/structs.rs:89:9
[INFO] [stderr]    |
[INFO] [stderr] 89 | /         match self.state {
[INFO] [stderr] 90 | |             PostState::Draft => self.content.push_str(text),
[INFO] [stderr] 91 | |             _ => (),
[INFO] [stderr] 92 | |         };
[INFO] [stderr]    | |_________^ help: try this: `if let PostState::Draft = self.state { self.content.push_str(text) }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/generics_traits_lifetimes.rs:284:13
[INFO] [stderr]     |
[INFO] [stderr] 284 | /             fn parse_context<'s>(context: Context<'s>) -> Result<(), &'s str> {
[INFO] [stderr] 285 | |                 Parser { context: &context }.parse()
[INFO] [stderr] 286 | |             }
[INFO] [stderr]     | |_____________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_lifetimes)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]  --> src/tests.rs:9:14
[INFO] [stderr]   |
[INFO] [stderr] 9 |     for i in (1..min+1).rev() {
[INFO] [stderr]   |              ^^^^^^^^^^ help: use: `(1..=min)`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::range_plus_one)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]   --> src/functional.rs:45:53
[INFO] [stderr]    |
[INFO] [stderr] 45 |                               Entry::Occupied(v) => v.get().clone(),
[INFO] [stderr]    |                                                     ^^^^^^^^^^^^^^^ help: try dereferencing it: `*v.get()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::clone_on_copy)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/collections.rs:41:13
[INFO] [stderr]    |
[INFO] [stderr] 41 | /             match i {
[INFO] [stderr] 42 | |                 &Types::Int(_) => println!("int"),
[INFO] [stderr] 43 | |                 &Types::Text(_) => println!("text"),
[INFO] [stderr] 44 | |                 &Types::Float(_) => println!("float"),
[INFO] [stderr] 45 | |             }
[INFO] [stderr]    | |_____________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 41 |             match *i {
[INFO] [stderr] 42 |                 Types::Int(_) => println!("int"),
[INFO] [stderr] 43 |                 Types::Text(_) => println!("text"),
[INFO] [stderr] 44 |                 Types::Float(_) => println!("float"),
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]   --> src/smart_pointers.rs:49:30
[INFO] [stderr]    |
[INFO] [stderr] 49 |                         Some(v.clone())
[INFO] [stderr]    |                              ^^^^^^^^^ help: try dereferencing it: `*v`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]   --> src/smart_pointers.rs:66:72
[INFO] [stderr]    |
[INFO] [stderr] 66 |                 values.iter().rev().fold(List::Nil, |res, v| List::new(v.clone(), res))
[INFO] [stderr]    |                                                                        ^^^^^^^^^ help: try dereferencing it: `*v`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]   --> src/smart_pointers.rs:70:46
[INFO] [stderr]    |
[INFO] [stderr] 70 |                     List::Cons(v, _) => Some(v.clone()),
[INFO] [stderr]    |                                              ^^^^^^^^^ help: try dereferencing it: `*v`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/smart_pointers.rs:176:30
[INFO] [stderr]     |
[INFO] [stderr] 176 |                         Some(v.clone())
[INFO] [stderr]     |                              ^^^^^^^^^ help: try dereferencing it: `*v`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/smart_pointers.rs:197:57
[INFO] [stderr]     |
[INFO] [stderr] 197 |                     .fold(List::Nil, |res, v| List::new(v.clone(), Rc::new(res)))
[INFO] [stderr]     |                                                         ^^^^^^^^^ help: try dereferencing it: `*v`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/smart_pointers.rs:201:46
[INFO] [stderr]     |
[INFO] [stderr] 201 |                     List::Cons(v, _) => Some(v.clone()),
[INFO] [stderr]     |                                              ^^^^^^^^^ help: try dereferencing it: `*v`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `new` usually return `Self`
[INFO] [stderr]    --> src/oop.rs:161:5
[INFO] [stderr]     |
[INFO] [stderr] 161 | /     fn new() -> Draft2 {
[INFO] [stderr] 162 | |         Draft2 {
[INFO] [stderr] 163 | |             content: String::new(),
[INFO] [stderr] 164 | |         }
[INFO] [stderr] 165 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::new_ret_no_self)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_none()`
[INFO] [stderr]   --> src/pattern_matching.rs:16:23
[INFO] [stderr]    |
[INFO] [stderr] 16 |           } else if let None = var {
[INFO] [stderr]    |  ________________-      ^^^^
[INFO] [stderr] 17 | |             // ...
[INFO] [stderr] 18 | |         }
[INFO] [stderr]    | |_________- help: try this: `if var.is_none()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_pattern_matching)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/pattern_matching.rs:32:39
[INFO] [stderr]    |
[INFO] [stderr] 32 |         fn print_coordinates(&(x, y): &(i32, i32)) {
[INFO] [stderr]    |                                       ^^^^^^^^^^^ help: consider passing by value instead: `(i32, i32)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: some ranges overlap
[INFO] [stderr]   --> src/pattern_matching.rs:46:13
[INFO] [stderr]    |
[INFO] [stderr] 46 |             4 | 6 => println!("Four or six"),
[INFO] [stderr]    |             ^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_overlapping_arm)] on by default
[INFO] [stderr] note: overlaps with this
[INFO] [stderr]   --> src/pattern_matching.rs:48:13
[INFO] [stderr]    |
[INFO] [stderr] 48 |             4 ... 10 => println!("Small value"),
[INFO] [stderr]    |             ^^^^^^^^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_overlapping_arm
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/pattern_matching.rs:161:9
[INFO] [stderr]     |
[INFO] [stderr] 161 | /         match robot_name {
[INFO] [stderr] 162 | |             Some(ref name) => println!("Found a name {}", name),
[INFO] [stderr] 163 | |             None => (),
[INFO] [stderr] 164 | |         }
[INFO] [stderr]     | |_________^ help: try this: `if let Some(ref name) = robot_name { println!("Found a name {}", name) }`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/pattern_matching.rs:167:9
[INFO] [stderr]     |
[INFO] [stderr] 167 | /         match robot_name {
[INFO] [stderr] 168 | |             Some(ref mut name) => *name = String::from("Another name"),
[INFO] [stderr] 169 | |             None => (),
[INFO] [stderr] 170 | |         }
[INFO] [stderr]     | |_________^ help: try this: `if let Some(ref mut name) = robot_name { *name = String::from("Another name") }`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize`
[INFO] [stderr]   --> src/unsafe_rust.rs:45:43
[INFO] [stderr]    |
[INFO] [stderr] 45 |                 slice::from_raw_parts_mut(ptr.offset(mid as isize), len - mid))
[INFO] [stderr]    |                                           ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `ptr.add(mid)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_offset_with_cast)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/generics_traits_lifetimes.rs:284:13
[INFO] [stderr]     |
[INFO] [stderr] 284 | /             fn parse_context<'s>(context: Context<'s>) -> Result<(), &'s str> {
[INFO] [stderr] 285 | |                 Parser { context: &context }.parse()
[INFO] [stderr] 286 | |             }
[INFO] [stderr]     | |_____________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_lifetimes)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]  --> src/tests.rs:9:14
[INFO] [stderr]   |
[INFO] [stderr] 9 |     for i in (1..min+1).rev() {
[INFO] [stderr]   |              ^^^^^^^^^^ help: use: `(1..=min)`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::range_plus_one)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]   --> src/divers.rs:36:14
[INFO] [stderr]    |
[INFO] [stderr] 36 |     for n in 1..n + 1 {
[INFO] [stderr]    |              ^^^^^^^^ help: use: `1..=n`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to previous error
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]   --> src/functional.rs:45:53
[INFO] [stderr]    |
[INFO] [stderr] 45 |                               Entry::Occupied(v) => v.get().clone(),
[INFO] [stderr]    |                                                     ^^^^^^^^^^^^^^^ help: try dereferencing it: `*v.get()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::clone_on_copy)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `rust_recap`.
[INFO] [stderr] warning: build failed, waiting for other jobs to finish...
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]   --> src/smart_pointers.rs:49:30
[INFO] [stderr]    |
[INFO] [stderr] 49 |                         Some(v.clone())
[INFO] [stderr]    |                              ^^^^^^^^^ help: try dereferencing it: `*v`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]   --> src/smart_pointers.rs:66:72
[INFO] [stderr]    |
[INFO] [stderr] 66 |                 values.iter().rev().fold(List::Nil, |res, v| List::new(v.clone(), res))
[INFO] [stderr]    |                                                                        ^^^^^^^^^ help: try dereferencing it: `*v`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]   --> src/smart_pointers.rs:70:46
[INFO] [stderr]    |
[INFO] [stderr] 70 |                     List::Cons(v, _) => Some(v.clone()),
[INFO] [stderr]    |                                              ^^^^^^^^^ help: try dereferencing it: `*v`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/smart_pointers.rs:176:30
[INFO] [stderr]     |
[INFO] [stderr] 176 |                         Some(v.clone())
[INFO] [stderr]     |                              ^^^^^^^^^ help: try dereferencing it: `*v`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/smart_pointers.rs:197:57
[INFO] [stderr]     |
[INFO] [stderr] 197 |                     .fold(List::Nil, |res, v| List::new(v.clone(), Rc::new(res)))
[INFO] [stderr]     |                                                         ^^^^^^^^^ help: try dereferencing it: `*v`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/smart_pointers.rs:201:46
[INFO] [stderr]     |
[INFO] [stderr] 201 |                     List::Cons(v, _) => Some(v.clone()),
[INFO] [stderr]     |                                              ^^^^^^^^^ help: try dereferencing it: `*v`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `new` usually return `Self`
[INFO] [stderr]    --> src/oop.rs:161:5
[INFO] [stderr]     |
[INFO] [stderr] 161 | /     fn new() -> Draft2 {
[INFO] [stderr] 162 | |         Draft2 {
[INFO] [stderr] 163 | |             content: String::new(),
[INFO] [stderr] 164 | |         }
[INFO] [stderr] 165 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::new_ret_no_self)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_none()`
[INFO] [stderr]   --> src/pattern_matching.rs:16:23
[INFO] [stderr]    |
[INFO] [stderr] 16 |           } else if let None = var {
[INFO] [stderr]    |  ________________-      ^^^^
[INFO] [stderr] 17 | |             // ...
[INFO] [stderr] 18 | |         }
[INFO] [stderr]    | |_________- help: try this: `if var.is_none()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_pattern_matching)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/pattern_matching.rs:32:39
[INFO] [stderr]    |
[INFO] [stderr] 32 |         fn print_coordinates(&(x, y): &(i32, i32)) {
[INFO] [stderr]    |                                       ^^^^^^^^^^^ help: consider passing by value instead: `(i32, i32)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: some ranges overlap
[INFO] [stderr]   --> src/pattern_matching.rs:46:13
[INFO] [stderr]    |
[INFO] [stderr] 46 |             4 | 6 => println!("Four or six"),
[INFO] [stderr]    |             ^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_overlapping_arm)] on by default
[INFO] [stderr] note: overlaps with this
[INFO] [stderr]   --> src/pattern_matching.rs:48:13
[INFO] [stderr]    |
[INFO] [stderr] 48 |             4 ... 10 => println!("Small value"),
[INFO] [stderr]    |             ^^^^^^^^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_overlapping_arm
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/pattern_matching.rs:161:9
[INFO] [stderr]     |
[INFO] [stderr] 161 | /         match robot_name {
[INFO] [stderr] 162 | |             Some(ref name) => println!("Found a name {}", name),
[INFO] [stderr] 163 | |             None => (),
[INFO] [stderr] 164 | |         }
[INFO] [stderr]     | |_________^ help: try this: `if let Some(ref name) = robot_name { println!("Found a name {}", name) }`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/pattern_matching.rs:167:9
[INFO] [stderr]     |
[INFO] [stderr] 167 | /         match robot_name {
[INFO] [stderr] 168 | |             Some(ref mut name) => *name = String::from("Another name"),
[INFO] [stderr] 169 | |             None => (),
[INFO] [stderr] 170 | |         }
[INFO] [stderr]     | |_________^ help: try this: `if let Some(ref mut name) = robot_name { *name = String::from("Another name") }`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize`
[INFO] [stderr]   --> src/unsafe_rust.rs:45:43
[INFO] [stderr]    |
[INFO] [stderr] 45 |                 slice::from_raw_parts_mut(ptr.offset(mid as isize), len - mid))
[INFO] [stderr]    |                                           ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `ptr.add(mid)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_offset_with_cast)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]   --> src/divers.rs:36:14
[INFO] [stderr]    |
[INFO] [stderr] 36 |     for n in 1..n + 1 {
[INFO] [stderr]    |              ^^^^^^^^ help: use: `1..=n`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to previous error
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `rust_recap`.
[INFO] [stderr] 
[INFO] [stderr] To learn more, run the command again with --verbose.
[INFO] running `"docker" "inspect" "66a065c8e38743befd0a8cea9ff51a097e0e11ab16f380d5514063e32e12273e"`
[INFO] running `"docker" "rm" "-f" "66a065c8e38743befd0a8cea9ff51a097e0e11ab16f380d5514063e32e12273e"`
[INFO] [stdout] 66a065c8e38743befd0a8cea9ff51a097e0e11ab16f380d5514063e32e12273e