[INFO] updating cached repository guskovd/docker-habitat [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/guskovd/docker-habitat [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/guskovd/docker-habitat" "work/ex/clippy-test-run/sources/stable/gh/guskovd/docker-habitat"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/guskovd/docker-habitat'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/guskovd/docker-habitat" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/guskovd/docker-habitat"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/guskovd/docker-habitat'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] c904f9b1944b218ac4cf7413248e882ccddaea26 [INFO] sha for GitHub repo guskovd/docker-habitat: c904f9b1944b218ac4cf7413248e882ccddaea26 [INFO] validating manifest of guskovd/docker-habitat on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of guskovd/docker-habitat on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing guskovd/docker-habitat [INFO] finished frobbing guskovd/docker-habitat [INFO] frobbed toml for guskovd/docker-habitat written to work/ex/clippy-test-run/sources/stable/gh/guskovd/docker-habitat/Cargo.toml [INFO] started frobbing guskovd/docker-habitat [INFO] finished frobbing guskovd/docker-habitat [INFO] frobbed toml for guskovd/docker-habitat written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/guskovd/docker-habitat/Cargo.toml [INFO] crate guskovd/docker-habitat has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting guskovd/docker-habitat against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/guskovd/docker-habitat:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 5715926e3bae4172c19ec6026cf08a43cef52bf30526ef194fd35d99fe8ce3b5 [INFO] running `"docker" "start" "-a" "5715926e3bae4172c19ec6026cf08a43cef52bf30526ef194fd35d99fe8ce3b5"` [INFO] [stderr] Checking users v0.7.0 [INFO] [stderr] Checking clap v2.31.1 [INFO] [stderr] Checking docker-habitat v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/main.rs:33:34 [INFO] [stderr] | [INFO] [stderr] 33 | let home = format!("{}", env::home_dir().unwrap().display()); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/main.rs:31:12 [INFO] [stderr] | [INFO] [stderr] 31 | if let Some(_) = matches.subcommand_matches("shell") { [INFO] [stderr] | _____- ^^^^^^^ [INFO] [stderr] 32 | | let pwd = format!("{}", env::current_dir().unwrap().display()); [INFO] [stderr] 33 | | let home = format!("{}", env::home_dir().unwrap().display()); [INFO] [stderr] 34 | | format!("{}:{}", get_current_uid(), get_current_gid()); [INFO] [stderr] ... | [INFO] [stderr] 45 | | ]).exec(); [INFO] [stderr] 46 | | } [INFO] [stderr] | |_____- help: try this: `if matches.subcommand_matches("shell").is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/main.rs:48:12 [INFO] [stderr] | [INFO] [stderr] 48 | if let Some(_) = matches.subcommand_matches("binlink") { [INFO] [stderr] | _____- ^^^^^^^ [INFO] [stderr] 49 | | println!("Binlink ..."); [INFO] [stderr] 50 | | [INFO] [stderr] 51 | | } [INFO] [stderr] | |_____- help: try this: `if matches.subcommand_matches("binlink").is_some()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/main.rs:33:34 [INFO] [stderr] | [INFO] [stderr] 33 | let home = format!("{}", env::home_dir().unwrap().display()); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/main.rs:31:12 [INFO] [stderr] | [INFO] [stderr] 31 | if let Some(_) = matches.subcommand_matches("shell") { [INFO] [stderr] | _____- ^^^^^^^ [INFO] [stderr] 32 | | let pwd = format!("{}", env::current_dir().unwrap().display()); [INFO] [stderr] 33 | | let home = format!("{}", env::home_dir().unwrap().display()); [INFO] [stderr] 34 | | format!("{}:{}", get_current_uid(), get_current_gid()); [INFO] [stderr] ... | [INFO] [stderr] 45 | | ]).exec(); [INFO] [stderr] 46 | | } [INFO] [stderr] | |_____- help: try this: `if matches.subcommand_matches("shell").is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/main.rs:48:12 [INFO] [stderr] | [INFO] [stderr] 48 | if let Some(_) = matches.subcommand_matches("binlink") { [INFO] [stderr] | _____- ^^^^^^^ [INFO] [stderr] 49 | | println!("Binlink ..."); [INFO] [stderr] 50 | | [INFO] [stderr] 51 | | } [INFO] [stderr] | |_____- help: try this: `if matches.subcommand_matches("binlink").is_some()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 6.39s [INFO] running `"docker" "inspect" "5715926e3bae4172c19ec6026cf08a43cef52bf30526ef194fd35d99fe8ce3b5"` [INFO] running `"docker" "rm" "-f" "5715926e3bae4172c19ec6026cf08a43cef52bf30526ef194fd35d99fe8ce3b5"` [INFO] [stdout] 5715926e3bae4172c19ec6026cf08a43cef52bf30526ef194fd35d99fe8ce3b5