[INFO] updating cached repository guilherme/rust-bowling-kata [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/guilherme/rust-bowling-kata [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/guilherme/rust-bowling-kata" "work/ex/clippy-test-run/sources/stable/gh/guilherme/rust-bowling-kata"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/guilherme/rust-bowling-kata'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/guilherme/rust-bowling-kata" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/guilherme/rust-bowling-kata"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/guilherme/rust-bowling-kata'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] d11fcf865a5d1d16b8b085be372133ae4e8c1caf [INFO] sha for GitHub repo guilherme/rust-bowling-kata: d11fcf865a5d1d16b8b085be372133ae4e8c1caf [INFO] validating manifest of guilherme/rust-bowling-kata on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of guilherme/rust-bowling-kata on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing guilherme/rust-bowling-kata [INFO] finished frobbing guilherme/rust-bowling-kata [INFO] frobbed toml for guilherme/rust-bowling-kata written to work/ex/clippy-test-run/sources/stable/gh/guilherme/rust-bowling-kata/Cargo.toml [INFO] started frobbing guilherme/rust-bowling-kata [INFO] finished frobbing guilherme/rust-bowling-kata [INFO] frobbed toml for guilherme/rust-bowling-kata written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/guilherme/rust-bowling-kata/Cargo.toml [INFO] crate guilherme/rust-bowling-kata has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting guilherme/rust-bowling-kata against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/guilherme/rust-bowling-kata:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 780e10b0dfd99b16b305cd8a73728e22582e49c9824c603a21019006c028e78b [INFO] running `"docker" "start" "-a" "780e10b0dfd99b16b305cd8a73728e22582e49c9824c603a21019006c028e78b"` [INFO] [stderr] Checking bowling-kata v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:11:19 [INFO] [stderr] | [INFO] [stderr] 11 | return Game { rolls: rolls, current_roll: Cell::new(0) }; [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `rolls` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:11:19 [INFO] [stderr] | [INFO] [stderr] 11 | return Game { rolls: rolls, current_roll: Cell::new(0) }; [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `rolls` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | return Game { rolls: rolls, current_roll: Cell::new(0) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Game { rolls: rolls, current_roll: Cell::new(0) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:35:5 [INFO] [stderr] | [INFO] [stderr] 35 | return score; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `score` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | return Game { rolls: rolls, current_roll: Cell::new(0) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Game { rolls: rolls, current_roll: Cell::new(0) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:35:5 [INFO] [stderr] | [INFO] [stderr] 35 | return score; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `score` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `Game` [INFO] [stderr] --> src/main.rs:2:1 [INFO] [stderr] | [INFO] [stderr] 2 | struct Game { [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/main.rs:9:3 [INFO] [stderr] | [INFO] [stderr] 9 | pub fn new() -> Game { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `roll` [INFO] [stderr] --> src/main.rs:14:3 [INFO] [stderr] | [INFO] [stderr] 14 | fn roll(&mut self, pins: usize) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `score` [INFO] [stderr] --> src/main.rs:19:3 [INFO] [stderr] | [INFO] [stderr] 19 | fn score(&self) -> usize { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.69s [INFO] running `"docker" "inspect" "780e10b0dfd99b16b305cd8a73728e22582e49c9824c603a21019006c028e78b"` [INFO] running `"docker" "rm" "-f" "780e10b0dfd99b16b305cd8a73728e22582e49c9824c603a21019006c028e78b"` [INFO] [stdout] 780e10b0dfd99b16b305cd8a73728e22582e49c9824c603a21019006c028e78b